* [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers
@ 2019-11-18 18:02 Andy Shevchenko
2019-11-18 18:22 ` Andy Shevchenko
2019-11-21 14:02 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2019-11-18 18:02 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, linux-gpio; +Cc: Andy Shevchenko
When commit 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be
handle_bad_irq()") switched default handler to be handle_bad_irq() the
lp_irq_type() function remained untouched. It means that even request_irq()
can't change the handler and we are not able to handle IRQs properly anymore.
Fix it by setting correct handlers in the lp_irq_type() callback.
Fixes: 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be handle_bad_irq()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-lynxpoint.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
index e9e47c0d5be7..490ce7bae25e 100644
--- a/drivers/gpio/gpio-lynxpoint.c
+++ b/drivers/gpio/gpio-lynxpoint.c
@@ -164,6 +164,12 @@ static int lp_irq_type(struct irq_data *d, unsigned type)
value |= TRIG_SEL_BIT | INT_INV_BIT;
outl(value, reg);
+
+ if (type & IRQ_TYPE_EDGE_BOTH)
+ irq_set_handler_locked(d, handle_edge_irq);
+ else if (type & IRQ_TYPE_LEVEL_MASK)
+ irq_set_handler_locked(d, handle_level_irq);
+
spin_unlock_irqrestore(&lg->lock, flags);
return 0;
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers
2019-11-18 18:02 [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers Andy Shevchenko
@ 2019-11-18 18:22 ` Andy Shevchenko
2019-11-21 14:02 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2019-11-18 18:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, linux-gpio
On Mon, Nov 18, 2019 at 08:02:51PM +0200, Andy Shevchenko wrote:
> When commit 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be
> handle_bad_irq()") switched default handler to be handle_bad_irq() the
> lp_irq_type() function remained untouched. It means that even request_irq()
> can't change the handler and we are not able to handle IRQs properly anymore.
> Fix it by setting correct handlers in the lp_irq_type() callback.
Linus, I can send this one and MAINTAINERS update as a PR for v5.4 if it would
work better for you.
P.S. I eventually found the platform to test this with GPIO IRQs (another
platform I had wasn't providing GpioInt() resources and thus not possible to
test).
> Fixes: 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be handle_bad_irq()")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-lynxpoint.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
> index e9e47c0d5be7..490ce7bae25e 100644
> --- a/drivers/gpio/gpio-lynxpoint.c
> +++ b/drivers/gpio/gpio-lynxpoint.c
> @@ -164,6 +164,12 @@ static int lp_irq_type(struct irq_data *d, unsigned type)
> value |= TRIG_SEL_BIT | INT_INV_BIT;
>
> outl(value, reg);
> +
> + if (type & IRQ_TYPE_EDGE_BOTH)
> + irq_set_handler_locked(d, handle_edge_irq);
> + else if (type & IRQ_TYPE_LEVEL_MASK)
> + irq_set_handler_locked(d, handle_level_irq);
> +
> spin_unlock_irqrestore(&lg->lock, flags);
>
> return 0;
> --
> 2.24.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers
2019-11-18 18:02 [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers Andy Shevchenko
2019-11-18 18:22 ` Andy Shevchenko
@ 2019-11-21 14:02 ` Linus Walleij
2019-11-25 11:53 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2019-11-21 14:02 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Mon, Nov 18, 2019 at 7:02 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> When commit 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be
> handle_bad_irq()") switched default handler to be handle_bad_irq() the
> lp_irq_type() function remained untouched. It means that even request_irq()
> can't change the handler and we are not able to handle IRQs properly anymore.
> Fix it by setting correct handlers in the lp_irq_type() callback.
>
> Fixes: 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be handle_bad_irq()")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied!
This close to the merge window it is better if I just apply stuff
I think.
Thanks for your hard work on this!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers
2019-11-21 14:02 ` Linus Walleij
@ 2019-11-25 11:53 ` Andy Shevchenko
2019-11-25 11:54 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-11-25 11:53 UTC (permalink / raw)
To: Linus Walleij; +Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Thu, Nov 21, 2019 at 03:02:44PM +0100, Linus Walleij wrote:
> On Mon, Nov 18, 2019 at 7:02 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > When commit 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be
> > handle_bad_irq()") switched default handler to be handle_bad_irq() the
> > lp_irq_type() function remained untouched. It means that even request_irq()
> > can't change the handler and we are not able to handle IRQs properly anymore.
> > Fix it by setting correct handlers in the lp_irq_type() callback.
> >
> > Fixes: 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be handle_bad_irq()")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Patch applied!
> This close to the merge window it is better if I just apply stuff
> I think.
Thank you! Works for me.
>
> Thanks for your hard work on this!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers
2019-11-25 11:53 ` Andy Shevchenko
@ 2019-11-25 11:54 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2019-11-25 11:54 UTC (permalink / raw)
To: Linus Walleij; +Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Mon, Nov 25, 2019 at 01:53:27PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 21, 2019 at 03:02:44PM +0100, Linus Walleij wrote:
> > On Mon, Nov 18, 2019 at 7:02 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > This close to the merge window it is better if I just apply stuff
> > I think.
>
> Thank you! Works for me.
Ditto for the rest (to avoid repeating this).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-25 11:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 18:02 [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers Andy Shevchenko
2019-11-18 18:22 ` Andy Shevchenko
2019-11-21 14:02 ` Linus Walleij
2019-11-25 11:53 ` Andy Shevchenko
2019-11-25 11:54 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.