* [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 14:54 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2019-11-25 14:54 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, yuehaibing
Cc: amd-gfx, dri-devel, linux-kernel
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
It is never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
index 2dd5fee..468f5e6 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
@@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
struct mod_hdcp_display *display = get_first_added_display(hdcp);
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
@@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
uint8_t i;
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 14:54 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2019-11-25 14:54 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, yuehaibing
Cc: amd-gfx, dri-devel, linux-kernel
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
It is never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
index 2dd5fee..468f5e6 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
@@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
struct mod_hdcp_display *display = get_first_added_display(hdcp);
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
@@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
uint8_t i;
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 14:54 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2019-11-25 14:54 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, yuehaibing
Cc: dri-devel, amd-gfx, linux-kernel
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
It is never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
index 2dd5fee..468f5e6 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
@@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
struct mod_hdcp_display *display = get_first_added_display(hdcp);
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
@@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
uint8_t i;
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 14:54 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2019-11-25 14:54 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, yuehaibing
Cc: dri-devel, amd-gfx, linux-kernel
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
It is never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
index 2dd5fee..468f5e6 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
@@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
struct mod_hdcp_display *display = get_first_added_display(hdcp);
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
@@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
struct psp_context *psp = hdcp->config.psp.handle;
struct ta_hdcp_shared_memory *hdcp_cmd;
struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
- struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
uint8_t i;
hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
- msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
hdcp2_message_init(hdcp, msg_in);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 15:15 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2019-11-25 15:15 UTC (permalink / raw)
To: YueHaibing
Cc: Wentland, Harry, Leo (Sunpeng) Li, Deucher, Alexander,
Christian Koenig, Chunming Zhou, Dave Airlie, Daniel Vetter,
Bhawanpreet Lakha, Maling list - DRI developers, amd-gfx list,
LKML
On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> index 2dd5fee..468f5e6 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> @@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> struct mod_hdcp_display *display = get_first_added_display(hdcp);
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> @@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> uint8_t i;
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 15:15 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2019-11-25 15:15 UTC (permalink / raw)
To: YueHaibing
Cc: Chunming Zhou, Leo (Sunpeng) Li, Bhawanpreet Lakha, LKML,
Maling list - DRI developers, Dave Airlie, amd-gfx list,
Daniel Vetter, Deucher, Alexander, Wentland, Harry,
Christian Koenig
On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> index 2dd5fee..468f5e6 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> @@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> struct mod_hdcp_display *display = get_first_added_display(hdcp);
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> @@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> uint8_t i;
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 15:15 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2019-11-25 15:15 UTC (permalink / raw)
To: YueHaibing
Cc: Leo (Sunpeng) Li, Bhawanpreet Lakha, LKML,
Maling list - DRI developers, Dave Airlie, amd-gfx list, Deucher,
Alexander, Christian Koenig
On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> index 2dd5fee..468f5e6 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> @@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> struct mod_hdcp_display *display = get_first_added_display(hdcp);
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> @@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> uint8_t i;
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'
@ 2019-11-25 15:15 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2019-11-25 15:15 UTC (permalink / raw)
To: YueHaibing
Cc: Chunming Zhou, Leo (Sunpeng) Li, Bhawanpreet Lakha, LKML,
Maling list - DRI developers, Dave Airlie, amd-gfx list,
Daniel Vetter, Deucher, Alexander, Wentland, Harry,
Christian Koenig
On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> index 2dd5fee..468f5e6 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> @@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> struct mod_hdcp_display *display = get_first_added_display(hdcp);
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> @@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
> struct psp_context *psp = hdcp->config.psp.handle;
> struct ta_hdcp_shared_memory *hdcp_cmd;
> struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> - struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
> uint8_t i;
>
> hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
> memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
> msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> - msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
> hdcp2_message_init(hdcp, msg_in);
>
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-26 8:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 14:54 [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out' YueHaibing
2019-11-25 14:54 ` YueHaibing
2019-11-25 14:54 ` YueHaibing
2019-11-25 14:54 ` YueHaibing
2019-11-25 15:15 ` Alex Deucher
2019-11-25 15:15 ` Alex Deucher
2019-11-25 15:15 ` Alex Deucher
2019-11-25 15:15 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.