All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ] mesh: Ignore Composition features during attach
@ 2019-11-25 18:58 Brian Gix
  0 siblings, 0 replies; only message in thread
From: Brian Gix @ 2019-11-25 18:58 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: brian.gix, inga.stotland

Node Features are currently all under the control of the mesh daemon,
and should be ignored when attaching.  Eventually all Composition
feature bits will be controlled by a master mesh.conf file, overriding
any local node specific settings.
---
 mesh/node.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mesh/node.c b/mesh/node.c
index 59936861a..7b4ee0505 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -1526,6 +1526,10 @@ static bool check_req_node(struct managed_obj_request *req)
 		uint16_t attach_len = node_generate_comp(req->attach,
 					attach_comp, sizeof(attach_comp));
 
+		/* Ignore feature bits in Composition Compare */
+		node_comp[8] = 0;
+		attach_comp[8] = 0;
+
 		if (node_len != attach_len ||
 				memcmp(node_comp, attach_comp, node_len)) {
 			l_debug("Failed to verify app's composition data");
-- 
2.21.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-11-25 18:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 18:58 [PATCH BlueZ] mesh: Ignore Composition features during attach Brian Gix

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.