* [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16
@ 2019-11-26 9:14 Daniel Vetter
2019-11-26 9:14 ` [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210 Daniel Vetter
2019-11-26 18:19 ` [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16 Liviu Dudau
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-11-26 9:14 UTC (permalink / raw)
To: DRI Development
Cc: Neil Armstrong, Daniel Vetter, Randy Li, Daniel Vetter,
Ayan Kumar Halder
0 means 1 as the default, but it's mighty confusing if the block size
for the first plane is spelled out explicitly, but not for the 2nd
plane.
No cc: stable because this is just confusion, but 0 functional issue.
Fixes: 05f8bc82fc42 ("drm/fourcc: Add new P010, P016 video format")
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Randy Li <ayaka@soulik.info>
Cc: Clint Taylor <clinton.a.taylor@intel.com>
Cc: Ayan Kumar Halder <ayan.halder@arm.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_fourcc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index c630064ccf41..fe79ce857c8a 100644
--- a/drivers/gpu/drm/drm_fourcc.c
+++ b/drivers/gpu/drm/drm_fourcc.c
@@ -253,13 +253,13 @@ const struct drm_format_info *__drm_format_info(u32 format)
.char_per_block = { 8, 0, 0 }, .block_w = { 2, 0, 0 }, .block_h = { 2, 0, 0 },
.hsub = 2, .vsub = 2, .is_yuv = true },
{ .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2,
- .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },
+ .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 },
.hsub = 2, .vsub = 2, .is_yuv = true},
{ .format = DRM_FORMAT_P012, .depth = 0, .num_planes = 2,
- .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },
+ .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 },
.hsub = 2, .vsub = 2, .is_yuv = true},
{ .format = DRM_FORMAT_P016, .depth = 0, .num_planes = 2,
- .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },
+ .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 },
.hsub = 2, .vsub = 2, .is_yuv = true},
{ .format = DRM_FORMAT_P210, .depth = 0,
.num_planes = 2, .char_per_block = { 2, 4, 0 },
--
2.24.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210
2019-11-26 9:14 [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16 Daniel Vetter
@ 2019-11-26 9:14 ` Daniel Vetter
2019-11-26 11:46 ` Liviu Dudau
2019-11-26 18:19 ` [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16 Liviu Dudau
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2019-11-26 9:14 UTC (permalink / raw)
To: DRI Development
Cc: Daniel Vetter, Daniel Vetter, Liviu Dudau, Ayan Kumar Halder,
Alyssa Rosenzweig
0 means 1 as the default, but it's mighty confusing if the block size
for the first plane is spelled out explicitly, but not for the 2nd
plane.
No cc: stable because this is just confusion, but 0 functional issue.
Fixes: 7ba0fee247ee ("drm/fourcc: Add AFBC yuv fourccs for Mali")
Cc: Brian Starkey <brian.starkey@arm.com>
Cc: Ayan Kumar Halder <ayan.halder@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_fourcc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index fe79ce857c8a..b234bfaeda06 100644
--- a/drivers/gpu/drm/drm_fourcc.c
+++ b/drivers/gpu/drm/drm_fourcc.c
@@ -263,7 +263,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
.hsub = 2, .vsub = 2, .is_yuv = true},
{ .format = DRM_FORMAT_P210, .depth = 0,
.num_planes = 2, .char_per_block = { 2, 4, 0 },
- .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, .hsub = 2,
+ .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2,
.vsub = 1, .is_yuv = true },
{ .format = DRM_FORMAT_VUY101010, .depth = 0,
.num_planes = 1, .cpp = { 0, 0, 0 }, .hsub = 1, .vsub = 1,
--
2.24.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210
2019-11-26 9:14 ` [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210 Daniel Vetter
@ 2019-11-26 11:46 ` Liviu Dudau
2019-11-28 10:19 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Liviu Dudau @ 2019-11-26 11:46 UTC (permalink / raw)
To: Daniel Vetter
Cc: DRI Development, Daniel Vetter, Ayan Kumar Halder, Alyssa Rosenzweig
On Tue, Nov 26, 2019 at 10:14:14AM +0100, Daniel Vetter wrote:
> 0 means 1 as the default, but it's mighty confusing if the block size
> for the first plane is spelled out explicitly, but not for the 2nd
> plane.
>
> No cc: stable because this is just confusion, but 0 functional issue.
Agree!
>
> Fixes: 7ba0fee247ee ("drm/fourcc: Add AFBC yuv fourccs for Mali")
> Cc: Brian Starkey <brian.starkey@arm.com>
> Cc: Ayan Kumar Halder <ayan.halder@arm.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
> Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/drm_fourcc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
> index fe79ce857c8a..b234bfaeda06 100644
> --- a/drivers/gpu/drm/drm_fourcc.c
> +++ b/drivers/gpu/drm/drm_fourcc.c
> @@ -263,7 +263,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
> .hsub = 2, .vsub = 2, .is_yuv = true},
> { .format = DRM_FORMAT_P210, .depth = 0,
> .num_planes = 2, .char_per_block = { 2, 4, 0 },
> - .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, .hsub = 2,
> + .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2,
> .vsub = 1, .is_yuv = true },
> { .format = DRM_FORMAT_VUY101010, .depth = 0,
> .num_planes = 1, .cpp = { 0, 0, 0 }, .hsub = 1, .vsub = 1,
> --
> 2.24.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16
2019-11-26 9:14 [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16 Daniel Vetter
2019-11-26 9:14 ` [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210 Daniel Vetter
@ 2019-11-26 18:19 ` Liviu Dudau
1 sibling, 0 replies; 5+ messages in thread
From: Liviu Dudau @ 2019-11-26 18:19 UTC (permalink / raw)
To: Daniel Vetter
Cc: Daniel Vetter, Ayan Kumar Halder, Randy Li, DRI Development,
Neil Armstrong
On Tue, Nov 26, 2019 at 10:14:13AM +0100, Daniel Vetter wrote:
> 0 means 1 as the default, but it's mighty confusing if the block size
> for the first plane is spelled out explicitly, but not for the 2nd
> plane.
>
> No cc: stable because this is just confusion, but 0 functional issue.
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
>
> Fixes: 05f8bc82fc42 ("drm/fourcc: Add new P010, P016 video format")
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Randy Li <ayaka@soulik.info>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
> Cc: Ayan Kumar Halder <ayan.halder@arm.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/drm_fourcc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
> index c630064ccf41..fe79ce857c8a 100644
> --- a/drivers/gpu/drm/drm_fourcc.c
> +++ b/drivers/gpu/drm/drm_fourcc.c
> @@ -253,13 +253,13 @@ const struct drm_format_info *__drm_format_info(u32 format)
> .char_per_block = { 8, 0, 0 }, .block_w = { 2, 0, 0 }, .block_h = { 2, 0, 0 },
> .hsub = 2, .vsub = 2, .is_yuv = true },
> { .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2,
> - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },
> + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 },
> .hsub = 2, .vsub = 2, .is_yuv = true},
> { .format = DRM_FORMAT_P012, .depth = 0, .num_planes = 2,
> - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },
> + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 },
> .hsub = 2, .vsub = 2, .is_yuv = true},
> { .format = DRM_FORMAT_P016, .depth = 0, .num_planes = 2,
> - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },
> + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 },
> .hsub = 2, .vsub = 2, .is_yuv = true},
> { .format = DRM_FORMAT_P210, .depth = 0,
> .num_planes = 2, .char_per_block = { 2, 4, 0 },
> --
> 2.24.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210
2019-11-26 11:46 ` Liviu Dudau
@ 2019-11-28 10:19 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-11-28 10:19 UTC (permalink / raw)
To: Liviu Dudau
Cc: Daniel Vetter, DRI Development, Daniel Vetter, Ayan Kumar Halder,
Alyssa Rosenzweig
On Tue, Nov 26, 2019 at 11:46:54AM +0000, Liviu Dudau wrote:
> On Tue, Nov 26, 2019 at 10:14:14AM +0100, Daniel Vetter wrote:
> > 0 means 1 as the default, but it's mighty confusing if the block size
> > for the first plane is spelled out explicitly, but not for the 2nd
> > plane.
> >
> > No cc: stable because this is just confusion, but 0 functional issue.
>
> Agree!
>
> >
> > Fixes: 7ba0fee247ee ("drm/fourcc: Add AFBC yuv fourccs for Mali")
> > Cc: Brian Starkey <brian.starkey@arm.com>
> > Cc: Ayan Kumar Halder <ayan.halder@arm.com>
> > Cc: Liviu Dudau <liviu.dudau@arm.com>
>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Both patches applied, thanks for taking a look.
-Daniel
>
> Best regards,
>
> > Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/drm_fourcc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
> > index fe79ce857c8a..b234bfaeda06 100644
> > --- a/drivers/gpu/drm/drm_fourcc.c
> > +++ b/drivers/gpu/drm/drm_fourcc.c
> > @@ -263,7 +263,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
> > .hsub = 2, .vsub = 2, .is_yuv = true},
> > { .format = DRM_FORMAT_P210, .depth = 0,
> > .num_planes = 2, .char_per_block = { 2, 4, 0 },
> > - .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, .hsub = 2,
> > + .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2,
> > .vsub = 1, .is_yuv = true },
> > { .format = DRM_FORMAT_VUY101010, .depth = 0,
> > .num_planes = 1, .cpp = { 0, 0, 0 }, .hsub = 1, .vsub = 1,
> > --
> > 2.24.0
> >
>
> --
> ====================
> | I would like to |
> | fix the world, |
> | but they're not |
> | giving me the |
> \ source code! /
> ---------------
> ¯\_(ツ)_/¯
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-28 10:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 9:14 [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16 Daniel Vetter
2019-11-26 9:14 ` [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210 Daniel Vetter
2019-11-26 11:46 ` Liviu Dudau
2019-11-28 10:19 ` Daniel Vetter
2019-11-26 18:19 ` [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16 Liviu Dudau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.