All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] bios: dot not discard address space
@ 2019-11-26 22:51 ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

v4 of https://patchwork.freedesktop.org/series/69790/

Add missing unmap in patch 2 and update 3rd patch to the bare minimum.

Lucas De Marchi (3):
  drm/i915/bios: do not discard address space
  drm/i915/bios: fold pci rom map/unmap into copy function
  drm/i915/bios: assume vbt is 4-byte aligned into oprom

 drivers/gpu/drm/i915/display/intel_bios.c | 75 +++++++++++++++--------
 1 file changed, 51 insertions(+), 24 deletions(-)

-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH 0/3] bios: dot not discard address space
@ 2019-11-26 22:51 ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

v4 of https://patchwork.freedesktop.org/series/69790/

Add missing unmap in patch 2 and update 3rd patch to the bare minimum.

Lucas De Marchi (3):
  drm/i915/bios: do not discard address space
  drm/i915/bios: fold pci rom map/unmap into copy function
  drm/i915/bios: assume vbt is 4-byte aligned into oprom

 drivers/gpu/drm/i915/display/intel_bios.c | 75 +++++++++++++++--------
 1 file changed, 51 insertions(+), 24 deletions(-)

-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH 1/3] drm/i915/bios: do not discard address space
@ 2019-11-26 22:51   ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

When we map the VBT through pci_map_rom() we may not be allowed
to simply discard the address space and go on reading the memory.
That doesn't work on my test system, but by dumping the rom via
sysfs I can can get the correct vbt. So change our find_vbt() to do
the same as done by pci_read_rom(), i.e. use memcpy_fromio().

v2: the just the minimal changes by not bothering with the unaligned io
reads: this can be done on top (from Ville and Jani)

v3: drop const in function return since now we are copying the vbt,
rather than just finding it

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
 1 file changed, 39 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index f6a9a5ccb556..8bdfc1d55040 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1896,28 +1896,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
 	return vbt;
 }
 
-static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
+static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 {
+	void __iomem *p = NULL;
+	struct vbt_header *vbt;
+	u16 vbt_size;
 	size_t i;
 
 	/* Scour memory looking for the VBT signature. */
 	for (i = 0; i + 4 < size; i++) {
-		void *vbt;
-
 		if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
 			continue;
 
-		/*
-		 * This is the one place where we explicitly discard the address
-		 * space (__iomem) of the BIOS/VBT.
-		 */
-		vbt = (void __force *)oprom + i;
-		if (intel_bios_is_valid_vbt(vbt, size - i))
-			return vbt;
-
+		p = oprom + i;
+		size -= i;
 		break;
 	}
 
+	if (!p)
+		return NULL;
+
+	if (sizeof(struct vbt_header) > size) {
+		DRM_DEBUG_DRIVER("VBT header incomplete\n");
+		return NULL;
+	}
+
+	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
+	if (vbt_size > size) {
+		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
+		return NULL;
+	}
+
+	/* The rest will be validated by intel_bios_is_valid_vbt() */
+	vbt = kmalloc(vbt_size, GFP_KERNEL);
+	if (!vbt)
+		return NULL;
+
+	memcpy_fromio(vbt, p, vbt_size);
+
+	if (!intel_bios_is_valid_vbt(vbt, vbt_size))
+		goto err_free_vbt;
+
+	return vbt;
+
+err_free_vbt:
+	kfree(vbt);
+
 	return NULL;
 }
 
@@ -1953,7 +1977,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 		if (!oprom)
 			goto out;
 
-		vbt = find_vbt(oprom, size);
+		vbt = copy_vbt(oprom, size);
 		if (!vbt)
 			goto out;
 
@@ -1990,6 +2014,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 
 	if (oprom)
 		pci_unmap_rom(pdev, oprom);
+
+	if (vbt != dev_priv->opregion.vbt)
+		kfree(vbt);
 }
 
 /**
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915/bios: do not discard address space
@ 2019-11-26 22:51   ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

When we map the VBT through pci_map_rom() we may not be allowed
to simply discard the address space and go on reading the memory.
That doesn't work on my test system, but by dumping the rom via
sysfs I can can get the correct vbt. So change our find_vbt() to do
the same as done by pci_read_rom(), i.e. use memcpy_fromio().

v2: the just the minimal changes by not bothering with the unaligned io
reads: this can be done on top (from Ville and Jani)

v3: drop const in function return since now we are copying the vbt,
rather than just finding it

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
 1 file changed, 39 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index f6a9a5ccb556..8bdfc1d55040 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1896,28 +1896,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
 	return vbt;
 }
 
-static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
+static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 {
+	void __iomem *p = NULL;
+	struct vbt_header *vbt;
+	u16 vbt_size;
 	size_t i;
 
 	/* Scour memory looking for the VBT signature. */
 	for (i = 0; i + 4 < size; i++) {
-		void *vbt;
-
 		if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
 			continue;
 
-		/*
-		 * This is the one place where we explicitly discard the address
-		 * space (__iomem) of the BIOS/VBT.
-		 */
-		vbt = (void __force *)oprom + i;
-		if (intel_bios_is_valid_vbt(vbt, size - i))
-			return vbt;
-
+		p = oprom + i;
+		size -= i;
 		break;
 	}
 
+	if (!p)
+		return NULL;
+
+	if (sizeof(struct vbt_header) > size) {
+		DRM_DEBUG_DRIVER("VBT header incomplete\n");
+		return NULL;
+	}
+
+	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
+	if (vbt_size > size) {
+		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
+		return NULL;
+	}
+
+	/* The rest will be validated by intel_bios_is_valid_vbt() */
+	vbt = kmalloc(vbt_size, GFP_KERNEL);
+	if (!vbt)
+		return NULL;
+
+	memcpy_fromio(vbt, p, vbt_size);
+
+	if (!intel_bios_is_valid_vbt(vbt, vbt_size))
+		goto err_free_vbt;
+
+	return vbt;
+
+err_free_vbt:
+	kfree(vbt);
+
 	return NULL;
 }
 
@@ -1953,7 +1977,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 		if (!oprom)
 			goto out;
 
-		vbt = find_vbt(oprom, size);
+		vbt = copy_vbt(oprom, size);
 		if (!vbt)
 			goto out;
 
@@ -1990,6 +2014,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 
 	if (oprom)
 		pci_unmap_rom(pdev, oprom);
+
+	if (vbt != dev_priv->opregion.vbt)
+		kfree(vbt);
 }
 
 /**
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function
@ 2019-11-26 22:51   ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

We don't need to keep the pci rom mapped during the entire
intel_bios_init() anymore. Move it to the previous copy_vbt() function
and rename it to oprom_get_vbt() since now it's responsible to to all
operations related to get the vbt from the oprom.

v2: fix double __iomem attribute detected by sparse
v3: fix missing unmap on success (Ville)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 42 +++++++++++------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 8bdfc1d55040..56e566945e98 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1896,12 +1896,17 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
 	return vbt;
 }
 
-static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
+static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
 {
-	void __iomem *p = NULL;
+	struct pci_dev *pdev = dev_priv->drm.pdev;
+	void __iomem *p = NULL, *oprom;
 	struct vbt_header *vbt;
 	u16 vbt_size;
-	size_t i;
+	size_t i, size;
+
+	oprom = pci_map_rom(pdev, &size);
+	if (!oprom)
+		return NULL;
 
 	/* Scour memory looking for the VBT signature. */
 	for (i = 0; i + 4 < size; i++) {
@@ -1914,33 +1919,37 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 	}
 
 	if (!p)
-		return NULL;
+		goto err_unmap_oprom;
 
 	if (sizeof(struct vbt_header) > size) {
 		DRM_DEBUG_DRIVER("VBT header incomplete\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
 	if (vbt_size > size) {
 		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	/* The rest will be validated by intel_bios_is_valid_vbt() */
 	vbt = kmalloc(vbt_size, GFP_KERNEL);
 	if (!vbt)
-		return NULL;
+		goto err_unmap_oprom;
 
 	memcpy_fromio(vbt, p, vbt_size);
 
 	if (!intel_bios_is_valid_vbt(vbt, vbt_size))
 		goto err_free_vbt;
 
+	pci_unmap_rom(pdev, oprom);
+
 	return vbt;
 
 err_free_vbt:
 	kfree(vbt);
+err_unmap_oprom:
+	pci_unmap_rom(pdev, oprom);
 
 	return NULL;
 }
@@ -1955,10 +1964,9 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
  */
 void intel_bios_init(struct drm_i915_private *dev_priv)
 {
-	struct pci_dev *pdev = dev_priv->drm.pdev;
 	const struct vbt_header *vbt = dev_priv->opregion.vbt;
+	struct vbt_header *oprom_vbt = NULL;
 	const struct bdb_header *bdb;
-	u8 __iomem *oprom = NULL;
 
 	INIT_LIST_HEAD(&dev_priv->vbt.display_devices);
 
@@ -1971,15 +1979,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 
 	/* If the OpRegion does not have VBT, look in PCI ROM. */
 	if (!vbt) {
-		size_t size;
-
-		oprom = pci_map_rom(pdev, &size);
-		if (!oprom)
+		oprom_vbt = oprom_get_vbt(dev_priv);
+		if (!oprom_vbt)
 			goto out;
 
-		vbt = copy_vbt(oprom, size);
-		if (!vbt)
-			goto out;
+		vbt = oprom_vbt;
 
 		DRM_DEBUG_KMS("Found valid VBT in PCI ROM\n");
 	}
@@ -2012,11 +2016,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 		init_vbt_missing_defaults(dev_priv);
 	}
 
-	if (oprom)
-		pci_unmap_rom(pdev, oprom);
-
-	if (vbt != dev_priv->opregion.vbt)
-		kfree(vbt);
+	kfree(oprom_vbt);
 }
 
 /**
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function
@ 2019-11-26 22:51   ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

We don't need to keep the pci rom mapped during the entire
intel_bios_init() anymore. Move it to the previous copy_vbt() function
and rename it to oprom_get_vbt() since now it's responsible to to all
operations related to get the vbt from the oprom.

v2: fix double __iomem attribute detected by sparse
v3: fix missing unmap on success (Ville)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 42 +++++++++++------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 8bdfc1d55040..56e566945e98 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1896,12 +1896,17 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
 	return vbt;
 }
 
-static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
+static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
 {
-	void __iomem *p = NULL;
+	struct pci_dev *pdev = dev_priv->drm.pdev;
+	void __iomem *p = NULL, *oprom;
 	struct vbt_header *vbt;
 	u16 vbt_size;
-	size_t i;
+	size_t i, size;
+
+	oprom = pci_map_rom(pdev, &size);
+	if (!oprom)
+		return NULL;
 
 	/* Scour memory looking for the VBT signature. */
 	for (i = 0; i + 4 < size; i++) {
@@ -1914,33 +1919,37 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 	}
 
 	if (!p)
-		return NULL;
+		goto err_unmap_oprom;
 
 	if (sizeof(struct vbt_header) > size) {
 		DRM_DEBUG_DRIVER("VBT header incomplete\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
 	if (vbt_size > size) {
 		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	/* The rest will be validated by intel_bios_is_valid_vbt() */
 	vbt = kmalloc(vbt_size, GFP_KERNEL);
 	if (!vbt)
-		return NULL;
+		goto err_unmap_oprom;
 
 	memcpy_fromio(vbt, p, vbt_size);
 
 	if (!intel_bios_is_valid_vbt(vbt, vbt_size))
 		goto err_free_vbt;
 
+	pci_unmap_rom(pdev, oprom);
+
 	return vbt;
 
 err_free_vbt:
 	kfree(vbt);
+err_unmap_oprom:
+	pci_unmap_rom(pdev, oprom);
 
 	return NULL;
 }
@@ -1955,10 +1964,9 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
  */
 void intel_bios_init(struct drm_i915_private *dev_priv)
 {
-	struct pci_dev *pdev = dev_priv->drm.pdev;
 	const struct vbt_header *vbt = dev_priv->opregion.vbt;
+	struct vbt_header *oprom_vbt = NULL;
 	const struct bdb_header *bdb;
-	u8 __iomem *oprom = NULL;
 
 	INIT_LIST_HEAD(&dev_priv->vbt.display_devices);
 
@@ -1971,15 +1979,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 
 	/* If the OpRegion does not have VBT, look in PCI ROM. */
 	if (!vbt) {
-		size_t size;
-
-		oprom = pci_map_rom(pdev, &size);
-		if (!oprom)
+		oprom_vbt = oprom_get_vbt(dev_priv);
+		if (!oprom_vbt)
 			goto out;
 
-		vbt = copy_vbt(oprom, size);
-		if (!vbt)
-			goto out;
+		vbt = oprom_vbt;
 
 		DRM_DEBUG_KMS("Found valid VBT in PCI ROM\n");
 	}
@@ -2012,11 +2016,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 		init_vbt_missing_defaults(dev_priv);
 	}
 
-	if (oprom)
-		pci_unmap_rom(pdev, oprom);
-
-	if (vbt != dev_priv->opregion.vbt)
-		kfree(vbt);
+	kfree(oprom_vbt);
 }
 
 /**
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH 3/3] drm/i915/bios: assume vbt is 4-byte aligned into oprom
@ 2019-11-26 22:51   ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

The unaligned ioread32() will make us read byte by byte looking for the
vbt. We could just as well have done a ioread8() + a shift and avoid the
extra confusion on how we are looking for "$VBT".

However when using ACPI it's guaranteed the VBT is 4-byte aligned
per spec, so we can probably assume it here as well.

v2: do not try to simplify the loop by eliminating the auxiliary counter
(Jani and Ville)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 56e566945e98..fec6752b1f56 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1909,7 +1909,7 @@ static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
 		return NULL;
 
 	/* Scour memory looking for the VBT signature. */
-	for (i = 0; i + 4 < size; i++) {
+	for (i = 0; i + 4 < size; i += 4) {
 		if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
 			continue;
 
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/bios: assume vbt is 4-byte aligned into oprom
@ 2019-11-26 22:51   ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-26 22:51 UTC (permalink / raw)
  To: intel-gfx

The unaligned ioread32() will make us read byte by byte looking for the
vbt. We could just as well have done a ioread8() + a shift and avoid the
extra confusion on how we are looking for "$VBT".

However when using ACPI it's guaranteed the VBT is 4-byte aligned
per spec, so we can probably assume it here as well.

v2: do not try to simplify the loop by eliminating the auxiliary counter
(Jani and Ville)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 56e566945e98..fec6752b1f56 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1909,7 +1909,7 @@ static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
 		return NULL;
 
 	/* Scour memory looking for the VBT signature. */
-	for (i = 0; i + 4 < size; i++) {
+	for (i = 0; i + 4 < size; i += 4) {
 		if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
 			continue;
 
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* ✗ Fi.CI.BAT: failure for bios: dot not discard address space
@ 2019-11-27  0:14   ` Patchwork
  0 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2019-11-27  0:14 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: bios: dot not discard address space
URL   : https://patchwork.freedesktop.org/series/70075/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7426 -> Patchwork_15449
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15449 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15449, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15449:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-r:           [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-skl-6770hq:      [PASS][3] -> [DMESG-FAIL][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html

  
Known issues
------------

  Here are the changes found in Patchwork_15449 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_gt_heartbeat:
    - fi-kbl-guc:         [PASS][5] -> [DMESG-FAIL][6] ([fdo#112096])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-kbl-7560u}:     [INCOMPLETE][7] ([fdo#109964] / [fdo#112298]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-skl-lmem:        [DMESG-FAIL][9] -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html

  
#### Warnings ####

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +6 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][13] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +6 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298


Participating hosts (49 -> 43)
------------------------------

  Additional (2): fi-hsw-4770r fi-whl-u 
  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7426 -> Patchwork_15449

  CI-20190529: 20190529
  CI_DRM_7426: b204d72d3485a148456e2077683974739b675b21 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15449: 5f7d442c38ff29d6129f2480cf976b8a5cb5de48 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5f7d442c38ff drm/i915/bios: assume vbt is 4-byte aligned into oprom
8393a984bf15 drm/i915/bios: fold pci rom map/unmap into copy function
3a5e67efec79 drm/i915/bios: do not discard address space

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for bios: dot not discard address space
@ 2019-11-27  0:14   ` Patchwork
  0 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2019-11-27  0:14 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: bios: dot not discard address space
URL   : https://patchwork.freedesktop.org/series/70075/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7426 -> Patchwork_15449
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15449 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15449, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15449:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-r:           [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-skl-6770hq:      [PASS][3] -> [DMESG-FAIL][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html

  
Known issues
------------

  Here are the changes found in Patchwork_15449 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_gt_heartbeat:
    - fi-kbl-guc:         [PASS][5] -> [DMESG-FAIL][6] ([fdo#112096])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-kbl-7560u}:     [INCOMPLETE][7] ([fdo#109964] / [fdo#112298]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-skl-lmem:        [DMESG-FAIL][9] -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html

  
#### Warnings ####

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +6 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][13] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +6 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298


Participating hosts (49 -> 43)
------------------------------

  Additional (2): fi-hsw-4770r fi-whl-u 
  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7426 -> Patchwork_15449

  CI-20190529: 20190529
  CI_DRM_7426: b204d72d3485a148456e2077683974739b675b21 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15449: 5f7d442c38ff29d6129f2480cf976b8a5cb5de48 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5f7d442c38ff drm/i915/bios: assume vbt is 4-byte aligned into oprom
8393a984bf15 drm/i915/bios: fold pci rom map/unmap into copy function
3a5e67efec79 drm/i915/bios: do not discard address space

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for bios: dot not discard address space
@ 2019-11-27  0:53     ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-27  0:53 UTC (permalink / raw)
  To: Intel Graphics; +Cc: Lucas De Marchi

On Tue, Nov 26, 2019 at 4:14 PM Patchwork
<patchwork@emeril.freedesktop.org> wrote:
>
> == Series Details ==
>
> Series: bios: dot not discard address space
> URL   : https://patchwork.freedesktop.org/series/70075/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7426 -> Patchwork_15449
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_15449 absolutely need to be
>   verified manually.
>
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_15449, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_15449:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@gem_exec_suspend@basic-s0:
>     - fi-kbl-r:           [PASS][1] -> [INCOMPLETE][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html

<7>[    7.184681] [drm:intel_opregion_setup [i915]] Found valid VBT in
ACPI OpRegion (Mailbox #4)

>
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-skl-6770hq:      [PASS][3] -> [DMESG-FAIL][4]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html

<7>[    4.682232] [drm:intel_opregion_setup [i915]] Found valid VBT in
ACPI OpRegion (Mailbox #4)


Neither of these platforms actually use the PCI rom map, from their boot.log.

Lucas De Marchi

>
>
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_15449 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@i915_selftest@live_gt_heartbeat:
>     - fi-kbl-guc:         [PASS][5] -> [DMESG-FAIL][6] ([fdo#112096])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html
>
>
> #### Possible fixes ####
>
>   * igt@i915_module_load@reload-with-fault-injection:
>     - {fi-kbl-7560u}:     [INCOMPLETE][7] ([fdo#109964] / [fdo#112298]) -> [PASS][8]
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
>
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-skl-lmem:        [DMESG-FAIL][9] -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
>
>
> #### Warnings ####
>
>   * igt@kms_busy@basic-flip-pipe-b:
>     - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +6 similar issues
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>     - fi-kbl-x1275:       [DMESG-WARN][13] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +6 similar issues
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>
>
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
>   [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
>   [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
>   [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
>   [fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
>   [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
>
>
> Participating hosts (49 -> 43)
> ------------------------------
>
>   Additional (2): fi-hsw-4770r fi-whl-u
>   Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600
>
>
> Build changes
> -------------
>
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7426 -> Patchwork_15449
>
>   CI-20190529: 20190529
>   CI_DRM_7426: b204d72d3485a148456e2077683974739b675b21 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_15449: 5f7d442c38ff29d6129f2480cf976b8a5cb5de48 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 5f7d442c38ff drm/i915/bios: assume vbt is 4-byte aligned into oprom
> 8393a984bf15 drm/i915/bios: fold pci rom map/unmap into copy function
> 3a5e67efec79 drm/i915/bios: do not discard address space
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [Intel-gfx]  ✗ Fi.CI.BAT: failure for bios: dot not discard address space
@ 2019-11-27  0:53     ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-27  0:53 UTC (permalink / raw)
  To: Intel Graphics; +Cc: Lucas De Marchi

On Tue, Nov 26, 2019 at 4:14 PM Patchwork
<patchwork@emeril.freedesktop.org> wrote:
>
> == Series Details ==
>
> Series: bios: dot not discard address space
> URL   : https://patchwork.freedesktop.org/series/70075/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7426 -> Patchwork_15449
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_15449 absolutely need to be
>   verified manually.
>
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_15449, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_15449:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@gem_exec_suspend@basic-s0:
>     - fi-kbl-r:           [PASS][1] -> [INCOMPLETE][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html

<7>[    7.184681] [drm:intel_opregion_setup [i915]] Found valid VBT in
ACPI OpRegion (Mailbox #4)

>
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-skl-6770hq:      [PASS][3] -> [DMESG-FAIL][4]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-6770hq/igt@i915_selftest@live_gem_contexts.html

<7>[    4.682232] [drm:intel_opregion_setup [i915]] Found valid VBT in
ACPI OpRegion (Mailbox #4)


Neither of these platforms actually use the PCI rom map, from their boot.log.

Lucas De Marchi

>
>
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_15449 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@i915_selftest@live_gt_heartbeat:
>     - fi-kbl-guc:         [PASS][5] -> [DMESG-FAIL][6] ([fdo#112096])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-guc/igt@i915_selftest@live_gt_heartbeat.html
>
>
> #### Possible fixes ####
>
>   * igt@i915_module_load@reload-with-fault-injection:
>     - {fi-kbl-7560u}:     [INCOMPLETE][7] ([fdo#109964] / [fdo#112298]) -> [PASS][8]
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
>
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-skl-lmem:        [DMESG-FAIL][9] -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
>
>
> #### Warnings ####
>
>   * igt@kms_busy@basic-flip-pipe-b:
>     - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +6 similar issues
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>     - fi-kbl-x1275:       [DMESG-WARN][13] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +6 similar issues
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7426/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>
>
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
>   [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
>   [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
>   [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
>   [fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
>   [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
>
>
> Participating hosts (49 -> 43)
> ------------------------------
>
>   Additional (2): fi-hsw-4770r fi-whl-u
>   Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600
>
>
> Build changes
> -------------
>
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7426 -> Patchwork_15449
>
>   CI-20190529: 20190529
>   CI_DRM_7426: b204d72d3485a148456e2077683974739b675b21 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_15449: 5f7d442c38ff29d6129f2480cf976b8a5cb5de48 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 5f7d442c38ff drm/i915/bios: assume vbt is 4-byte aligned into oprom
> 8393a984bf15 drm/i915/bios: fold pci rom map/unmap into copy function
> 3a5e67efec79 drm/i915/bios: do not discard address space
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15449/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* ✓ Fi.CI.BAT: success for bios: dot not discard address space (rev2)
@ 2019-11-27 11:27   ` Patchwork
  0 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2019-11-27 11:27 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: bios: dot not discard address space (rev2)
URL   : https://patchwork.freedesktop.org/series/70075/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7430 -> Patchwork_15459
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html

Known issues
------------

  Here are the changes found in Patchwork_15459 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [PASS][1] -> [FAIL][2] ([fdo#108511])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-lmem:        [DMESG-WARN][3] ([fdo#112261]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][5] ([fdo#111407]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][7] ([fdo#103167]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Warnings ####

  * igt@kms_busy@basic-flip-pipe-a:
    - fi-kbl-x1275:       [DMESG-WARN][9] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][10] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +5 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602]) +7 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298


Participating hosts (52 -> 44)
------------------------------

  Missing    (8): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7430 -> Patchwork_15459

  CI-20190529: 20190529
  CI_DRM_7430: 39c64d2cb4dcae379486b9887c224472f30b12ce @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15459: e58f093c7eeeb7c95cb535849192d6dc5a8680fa @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

e58f093c7eee drm/i915/bios: assume vbt is 4-byte aligned into oprom
f89fc5a11587 drm/i915/bios: fold pci rom map/unmap into copy function
51e43de35a92 drm/i915/bios: do not discard address space

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for bios: dot not discard address space (rev2)
@ 2019-11-27 11:27   ` Patchwork
  0 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2019-11-27 11:27 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: bios: dot not discard address space (rev2)
URL   : https://patchwork.freedesktop.org/series/70075/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7430 -> Patchwork_15459
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html

Known issues
------------

  Here are the changes found in Patchwork_15459 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [PASS][1] -> [FAIL][2] ([fdo#108511])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-lmem:        [DMESG-WARN][3] ([fdo#112261]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][5] ([fdo#111407]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][7] ([fdo#103167]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Warnings ####

  * igt@kms_busy@basic-flip-pipe-a:
    - fi-kbl-x1275:       [DMESG-WARN][9] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][10] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +5 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602]) +7 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298


Participating hosts (52 -> 44)
------------------------------

  Missing    (8): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7430 -> Patchwork_15459

  CI-20190529: 20190529
  CI_DRM_7430: 39c64d2cb4dcae379486b9887c224472f30b12ce @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15459: e58f093c7eeeb7c95cb535849192d6dc5a8680fa @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

e58f093c7eee drm/i915/bios: assume vbt is 4-byte aligned into oprom
f89fc5a11587 drm/i915/bios: fold pci rom map/unmap into copy function
51e43de35a92 drm/i915/bios: do not discard address space

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* ✗ Fi.CI.IGT: failure for bios: dot not discard address space (rev2)
@ 2019-11-27 20:12   ` Patchwork
  0 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2019-11-27 20:12 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: bios: dot not discard address space (rev2)
URL   : https://patchwork.freedesktop.org/series/70075/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7430_full -> Patchwork_15459_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15459_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15459_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15459_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled:
    - shard-skl:          NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled.html

  
Known issues
------------

  Here are the changes found in Patchwork_15459_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@smoketest:
    - shard-glk:          [PASS][2] -> [TIMEOUT][3] ([fdo#112404])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk4/igt@gem_ctx_persistence@smoketest.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk8/igt@gem_ctx_persistence@smoketest.html

  * igt@gem_exec_schedule@preempt-queue-contexts-blt:
    - shard-tglb:         [PASS][4] -> [INCOMPLETE][5] ([fdo#111606] / [fdo#111677])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@gem_exec_schedule@preempt-queue-contexts-blt.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-blt.html

  * igt@gem_exec_schedule@preempt-queue-vebox:
    - shard-tglb:         [PASS][6] -> [INCOMPLETE][7] ([fdo#111677])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@preempt-queue-vebox.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-vebox.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [PASS][8] -> [FAIL][9] ([fdo#112392])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-hsw:          [PASS][10] -> [DMESG-WARN][11] ([fdo#111870]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [PASS][12] -> [FAIL][13] ([fdo#111830 ])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@i915_pm_dc@dc6-psr.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-180:
    - shard-glk:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103359] / [k.org#198133])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +3 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [PASS][18] -> [DMESG-WARN][19] ([fdo#108566]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-d-cursor-suspend:
    - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111850])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-suspend.html

  * igt@kms_cursor_legacy@cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][22] -> [FAIL][23] ([fdo#103355])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-tglb:         [PASS][24] -> [INCOMPLETE][25] ([fdo#111884])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
    - shard-iclb:         [PASS][26] -> [INCOMPLETE][27] ([fdo#107713])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
    - shard-tglb:         [PASS][28] -> [FAIL][29] ([fdo#103167])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
    - shard-iclb:         [PASS][30] -> [FAIL][31] ([fdo#103167])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
    - shard-skl:          [PASS][32] -> [INCOMPLETE][33] ([fdo#106978])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html

  * igt@kms_plane@pixel-format-pipe-a-planes:
    - shard-skl:          [PASS][34] -> [INCOMPLETE][35] ([fdo#112347])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl10/igt@kms_plane@pixel-format-pipe-a-planes.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_plane@pixel-format-pipe-a-planes.html

  * igt@kms_plane@pixel-format-pipe-b-planes:
    - shard-skl:          [PASS][36] -> [INCOMPLETE][37] ([fdo#112391])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl6/igt@kms_plane@pixel-format-pipe-b-planes.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_plane@pixel-format-pipe-b-planes.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-tglb:         [INCOMPLETE][38] ([fdo#111832]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_ctx_isolation@rcs0-s3.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_exec_parallel@fds:
    - shard-tglb:         [INCOMPLETE][40] ([fdo#111867]) -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@gem_exec_parallel@fds.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_parallel@fds.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
    - shard-hsw:          [TIMEOUT][42] ([fdo#112068 ]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

  * igt@gem_sync@basic-all:
    - shard-tglb:         [INCOMPLETE][44] ([fdo#111880]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@gem_sync@basic-all.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb8/igt@gem_sync@basic-all.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-hsw:          [DMESG-WARN][46] ([fdo#111870]) -> [PASS][47] +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw8/igt@gem_userptr_blits@sync-unmap-after-close.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@i915_selftest@mock_requests:
    - shard-glk:          [DMESG-WARN][48] ([fdo#112158]) -> [PASS][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk7/igt@i915_selftest@mock_requests.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk2/igt@i915_selftest@mock_requests.html

  * igt@kms_big_fb@x-tiled-16bpp-rotate-180:
    - shard-skl:          [INCOMPLETE][50] ([fdo#112347] / [fdo#112409]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl2/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html

  * igt@kms_draw_crc@draw-method-rgb565-render-untiled:
    - shard-skl:          [INCOMPLETE][52] ([fdo#112395]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [FAIL][54] ([fdo#105363]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
    - shard-tglb:         [FAIL][56] ([fdo#103167]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [DMESG-WARN][58] ([fdo#108566]) -> [PASS][59] +1 similar issue
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
    - shard-iclb:         [FAIL][60] ([fdo#103167]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-tglb:         [INCOMPLETE][62] ([fdo#111884]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-apl:          [DMESG-WARN][64] ([fdo#108566]) -> [PASS][65] +1 similar issue
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][66] ([fdo#108145] / [fdo#110403]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
    - shard-tglb:         [INCOMPLETE][68] ([fdo#111850]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb4/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html

  
#### Warnings ####

  * igt@gem_exec_schedule@deep-bsd1:
    - shard-tglb:         [INCOMPLETE][70] ([fdo#111671]) -> [FAIL][71] ([fdo#111646])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_schedule@deep-bsd1.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
  [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
  [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
  [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
  [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830 
  [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
  [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
  [fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
  [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
  [fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068 
  [fdo#112158]: https://bugs.freedesktop.org/show_bug.cgi?id=112158
  [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
  [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
  [fdo#112392]: https://bugs.freedesktop.org/show_bug.cgi?id=112392
  [fdo#112395]: https://bugs.freedesktop.org/show_bug.cgi?id=112395
  [fdo#112404]: https://bugs.freedesktop.org/show_bug.cgi?id=112404
  [fdo#112409]: https://bugs.freedesktop.org/show_bug.cgi?id=112409
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (11 -> 10)
------------------------------

  Missing    (1): pig-skl-6260u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7430 -> Patchwork_15459

  CI-20190529: 20190529
  CI_DRM_7430: 39c64d2cb4dcae379486b9887c224472f30b12ce @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15459: e58f093c7eeeb7c95cb535849192d6dc5a8680fa @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for bios: dot not discard address space (rev2)
@ 2019-11-27 20:12   ` Patchwork
  0 siblings, 0 replies; 24+ messages in thread
From: Patchwork @ 2019-11-27 20:12 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: bios: dot not discard address space (rev2)
URL   : https://patchwork.freedesktop.org/series/70075/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7430_full -> Patchwork_15459_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15459_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15459_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15459_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled:
    - shard-skl:          NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled.html

  
Known issues
------------

  Here are the changes found in Patchwork_15459_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@smoketest:
    - shard-glk:          [PASS][2] -> [TIMEOUT][3] ([fdo#112404])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk4/igt@gem_ctx_persistence@smoketest.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk8/igt@gem_ctx_persistence@smoketest.html

  * igt@gem_exec_schedule@preempt-queue-contexts-blt:
    - shard-tglb:         [PASS][4] -> [INCOMPLETE][5] ([fdo#111606] / [fdo#111677])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@gem_exec_schedule@preempt-queue-contexts-blt.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-blt.html

  * igt@gem_exec_schedule@preempt-queue-vebox:
    - shard-tglb:         [PASS][6] -> [INCOMPLETE][7] ([fdo#111677])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@preempt-queue-vebox.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-vebox.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [PASS][8] -> [FAIL][9] ([fdo#112392])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-hsw:          [PASS][10] -> [DMESG-WARN][11] ([fdo#111870]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [PASS][12] -> [FAIL][13] ([fdo#111830 ])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@i915_pm_dc@dc6-psr.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-180:
    - shard-glk:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103359] / [k.org#198133])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +3 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [PASS][18] -> [DMESG-WARN][19] ([fdo#108566]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-d-cursor-suspend:
    - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111850])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-suspend.html

  * igt@kms_cursor_legacy@cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][22] -> [FAIL][23] ([fdo#103355])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-tglb:         [PASS][24] -> [INCOMPLETE][25] ([fdo#111884])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
    - shard-iclb:         [PASS][26] -> [INCOMPLETE][27] ([fdo#107713])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
    - shard-tglb:         [PASS][28] -> [FAIL][29] ([fdo#103167])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
    - shard-iclb:         [PASS][30] -> [FAIL][31] ([fdo#103167])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
    - shard-skl:          [PASS][32] -> [INCOMPLETE][33] ([fdo#106978])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html

  * igt@kms_plane@pixel-format-pipe-a-planes:
    - shard-skl:          [PASS][34] -> [INCOMPLETE][35] ([fdo#112347])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl10/igt@kms_plane@pixel-format-pipe-a-planes.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_plane@pixel-format-pipe-a-planes.html

  * igt@kms_plane@pixel-format-pipe-b-planes:
    - shard-skl:          [PASS][36] -> [INCOMPLETE][37] ([fdo#112391])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl6/igt@kms_plane@pixel-format-pipe-b-planes.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_plane@pixel-format-pipe-b-planes.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-tglb:         [INCOMPLETE][38] ([fdo#111832]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_ctx_isolation@rcs0-s3.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_exec_parallel@fds:
    - shard-tglb:         [INCOMPLETE][40] ([fdo#111867]) -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@gem_exec_parallel@fds.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_parallel@fds.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
    - shard-hsw:          [TIMEOUT][42] ([fdo#112068 ]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

  * igt@gem_sync@basic-all:
    - shard-tglb:         [INCOMPLETE][44] ([fdo#111880]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@gem_sync@basic-all.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb8/igt@gem_sync@basic-all.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-hsw:          [DMESG-WARN][46] ([fdo#111870]) -> [PASS][47] +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw8/igt@gem_userptr_blits@sync-unmap-after-close.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@i915_selftest@mock_requests:
    - shard-glk:          [DMESG-WARN][48] ([fdo#112158]) -> [PASS][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk7/igt@i915_selftest@mock_requests.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk2/igt@i915_selftest@mock_requests.html

  * igt@kms_big_fb@x-tiled-16bpp-rotate-180:
    - shard-skl:          [INCOMPLETE][50] ([fdo#112347] / [fdo#112409]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl2/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html

  * igt@kms_draw_crc@draw-method-rgb565-render-untiled:
    - shard-skl:          [INCOMPLETE][52] ([fdo#112395]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [FAIL][54] ([fdo#105363]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
    - shard-tglb:         [FAIL][56] ([fdo#103167]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [DMESG-WARN][58] ([fdo#108566]) -> [PASS][59] +1 similar issue
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
    - shard-iclb:         [FAIL][60] ([fdo#103167]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-tglb:         [INCOMPLETE][62] ([fdo#111884]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-apl:          [DMESG-WARN][64] ([fdo#108566]) -> [PASS][65] +1 similar issue
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][66] ([fdo#108145] / [fdo#110403]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
    - shard-tglb:         [INCOMPLETE][68] ([fdo#111850]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb4/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html

  
#### Warnings ####

  * igt@gem_exec_schedule@deep-bsd1:
    - shard-tglb:         [INCOMPLETE][70] ([fdo#111671]) -> [FAIL][71] ([fdo#111646])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_schedule@deep-bsd1.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
  [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
  [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
  [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
  [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830 
  [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
  [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
  [fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
  [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
  [fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068 
  [fdo#112158]: https://bugs.freedesktop.org/show_bug.cgi?id=112158
  [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
  [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
  [fdo#112392]: https://bugs.freedesktop.org/show_bug.cgi?id=112392
  [fdo#112395]: https://bugs.freedesktop.org/show_bug.cgi?id=112395
  [fdo#112404]: https://bugs.freedesktop.org/show_bug.cgi?id=112404
  [fdo#112409]: https://bugs.freedesktop.org/show_bug.cgi?id=112409
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (11 -> 10)
------------------------------

  Missing    (1): pig-skl-6260u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7430 -> Patchwork_15459

  CI-20190529: 20190529
  CI_DRM_7430: 39c64d2cb4dcae379486b9887c224472f30b12ce @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15459: e58f093c7eeeb7c95cb535849192d6dc5a8680fa @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [PATCH 3/3] drm/i915/bios: assume vbt is 4-byte aligned into oprom
@ 2019-11-29 10:00     ` Jani Nikula
  0 siblings, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2019-11-29 10:00 UTC (permalink / raw)
  To: Lucas De Marchi, intel-gfx

On Tue, 26 Nov 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> The unaligned ioread32() will make us read byte by byte looking for the
> vbt. We could just as well have done a ioread8() + a shift and avoid the
> extra confusion on how we are looking for "$VBT".
>
> However when using ACPI it's guaranteed the VBT is 4-byte aligned
> per spec, so we can probably assume it here as well.
>
> v2: do not try to simplify the loop by eliminating the auxiliary counter
> (Jani and Ville)
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 56e566945e98..fec6752b1f56 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1909,7 +1909,7 @@ static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
>  		return NULL;
>  
>  	/* Scour memory looking for the VBT signature. */
> -	for (i = 0; i + 4 < size; i++) {
> +	for (i = 0; i + 4 < size; i += 4) {
>  		if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
>  			continue;

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: assume vbt is 4-byte aligned into oprom
@ 2019-11-29 10:00     ` Jani Nikula
  0 siblings, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2019-11-29 10:00 UTC (permalink / raw)
  To: Lucas De Marchi, intel-gfx

On Tue, 26 Nov 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> The unaligned ioread32() will make us read byte by byte looking for the
> vbt. We could just as well have done a ioread8() + a shift and avoid the
> extra confusion on how we are looking for "$VBT".
>
> However when using ACPI it's guaranteed the VBT is 4-byte aligned
> per spec, so we can probably assume it here as well.
>
> v2: do not try to simplify the loop by eliminating the auxiliary counter
> (Jani and Ville)
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 56e566945e98..fec6752b1f56 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1909,7 +1909,7 @@ static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
>  		return NULL;
>  
>  	/* Scour memory looking for the VBT signature. */
> -	for (i = 0; i + 4 < size; i++) {
> +	for (i = 0; i + 4 < size; i += 4) {
>  		if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
>  			continue;

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for bios: dot not discard address space (rev2)
@ 2019-11-29 18:28     ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-29 18:28 UTC (permalink / raw)
  To: Intel Graphics; +Cc: Lucas De Marchi

On Wed, Nov 27, 2019 at 12:12 PM Patchwork
<patchwork@emeril.freedesktop.org> wrote:
>
> == Series Details ==
>
> Series: bios: dot not discard address space (rev2)
> URL   : https://patchwork.freedesktop.org/series/70075/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7430_full -> Patchwork_15459_full
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_15459_full absolutely need to be
>   verified manually.
>
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_15459_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_15459_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled:
>     - shard-skl:          NOTRUN -> [INCOMPLETE][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled.html

I can't see how this would be related - this machine doesn't even use
the code in question.

Lucas De Marchi

>
>
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_15459_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@gem_ctx_persistence@smoketest:
>     - shard-glk:          [PASS][2] -> [TIMEOUT][3] ([fdo#112404])
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk4/igt@gem_ctx_persistence@smoketest.html
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk8/igt@gem_ctx_persistence@smoketest.html
>
>   * igt@gem_exec_schedule@preempt-queue-contexts-blt:
>     - shard-tglb:         [PASS][4] -> [INCOMPLETE][5] ([fdo#111606] / [fdo#111677])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@gem_exec_schedule@preempt-queue-contexts-blt.html
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-blt.html
>
>   * igt@gem_exec_schedule@preempt-queue-vebox:
>     - shard-tglb:         [PASS][6] -> [INCOMPLETE][7] ([fdo#111677])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@preempt-queue-vebox.html
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-vebox.html
>
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-glk:          [PASS][8] -> [FAIL][9] ([fdo#112392])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
>
>   * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
>     - shard-hsw:          [PASS][10] -> [DMESG-WARN][11] ([fdo#111870]) +1 similar issue
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
>
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-iclb:         [PASS][12] -> [FAIL][13] ([fdo#111830 ])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
>
>   * igt@kms_big_fb@y-tiled-8bpp-rotate-180:
>     - shard-glk:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103359] / [k.org#198133])
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
>
>   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
>     - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +3 similar issues
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>
>   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
>     - shard-kbl:          [PASS][18] -> [DMESG-WARN][19] ([fdo#108566]) +2 similar issues
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>
>   * igt@kms_cursor_crc@pipe-d-cursor-suspend:
>     - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111850])
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
>
>   * igt@kms_cursor_legacy@cursor-vs-flip-atomic:
>     - shard-hsw:          [PASS][22] -> [FAIL][23] ([fdo#103355])
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
>     - shard-tglb:         [PASS][24] -> [INCOMPLETE][25] ([fdo#111884])
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>     - shard-iclb:         [PASS][26] -> [INCOMPLETE][27] ([fdo#107713])
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
>     - shard-tglb:         [PASS][28] -> [FAIL][29] ([fdo#103167])
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
>     - shard-iclb:         [PASS][30] -> [FAIL][31] ([fdo#103167])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
>
>   * igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
>     - shard-skl:          [PASS][32] -> [INCOMPLETE][33] ([fdo#106978])
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
>
>   * igt@kms_plane@pixel-format-pipe-a-planes:
>     - shard-skl:          [PASS][34] -> [INCOMPLETE][35] ([fdo#112347])
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl10/igt@kms_plane@pixel-format-pipe-a-planes.html
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_plane@pixel-format-pipe-a-planes.html
>
>   * igt@kms_plane@pixel-format-pipe-b-planes:
>     - shard-skl:          [PASS][36] -> [INCOMPLETE][37] ([fdo#112391])
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl6/igt@kms_plane@pixel-format-pipe-b-planes.html
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_plane@pixel-format-pipe-b-planes.html
>
>
> #### Possible fixes ####
>
>   * igt@gem_ctx_isolation@rcs0-s3:
>     - shard-tglb:         [INCOMPLETE][38] ([fdo#111832]) -> [PASS][39]
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_ctx_isolation@rcs0-s3.html
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@gem_ctx_isolation@rcs0-s3.html
>
>   * igt@gem_exec_parallel@fds:
>     - shard-tglb:         [INCOMPLETE][40] ([fdo#111867]) -> [PASS][41]
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@gem_exec_parallel@fds.html
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_parallel@fds.html
>
>   * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
>     - shard-hsw:          [TIMEOUT][42] ([fdo#112068 ]) -> [PASS][43]
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
>
>   * igt@gem_sync@basic-all:
>     - shard-tglb:         [INCOMPLETE][44] ([fdo#111880]) -> [PASS][45]
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@gem_sync@basic-all.html
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb8/igt@gem_sync@basic-all.html
>
>   * igt@gem_userptr_blits@sync-unmap-after-close:
>     - shard-hsw:          [DMESG-WARN][46] ([fdo#111870]) -> [PASS][47] +1 similar issue
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw8/igt@gem_userptr_blits@sync-unmap-after-close.html
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html
>
>   * igt@i915_selftest@mock_requests:
>     - shard-glk:          [DMESG-WARN][48] ([fdo#112158]) -> [PASS][49]
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk7/igt@i915_selftest@mock_requests.html
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk2/igt@i915_selftest@mock_requests.html
>
>   * igt@kms_big_fb@x-tiled-16bpp-rotate-180:
>     - shard-skl:          [INCOMPLETE][50] ([fdo#112347] / [fdo#112409]) -> [PASS][51]
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl2/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
>
>   * igt@kms_draw_crc@draw-method-rgb565-render-untiled:
>     - shard-skl:          [INCOMPLETE][52] ([fdo#112395]) -> [PASS][53]
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
>
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-skl:          [FAIL][54] ([fdo#105363]) -> [PASS][55]
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
>     - shard-tglb:         [FAIL][56] ([fdo#103167]) -> [PASS][57]
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
>
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-kbl:          [DMESG-WARN][58] ([fdo#108566]) -> [PASS][59] +1 similar issue
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
>     - shard-iclb:         [FAIL][60] ([fdo#103167]) -> [PASS][61]
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
>
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc:
>     - shard-tglb:         [INCOMPLETE][62] ([fdo#111884]) -> [PASS][63]
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
>
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
>     - shard-apl:          [DMESG-WARN][64] ([fdo#108566]) -> [PASS][65] +1 similar issue
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>     - shard-skl:          [FAIL][66] ([fdo#108145] / [fdo#110403]) -> [PASS][67]
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
>
>   * igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
>     - shard-tglb:         [INCOMPLETE][68] ([fdo#111850]) -> [PASS][69]
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb4/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
>
>
> #### Warnings ####
>
>   * igt@gem_exec_schedule@deep-bsd1:
>     - shard-tglb:         [INCOMPLETE][70] ([fdo#111671]) -> [FAIL][71] ([fdo#111646])
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_schedule@deep-bsd1.html
>
>
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
>   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
>   [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
>   [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
>   [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
>   [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
>   [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
>   [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
>   [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
>   [fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
>   [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
>   [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
>   [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
>   [fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068
>   [fdo#112158]: https://bugs.freedesktop.org/show_bug.cgi?id=112158
>   [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
>   [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
>   [fdo#112392]: https://bugs.freedesktop.org/show_bug.cgi?id=112392
>   [fdo#112395]: https://bugs.freedesktop.org/show_bug.cgi?id=112395
>   [fdo#112404]: https://bugs.freedesktop.org/show_bug.cgi?id=112404
>   [fdo#112409]: https://bugs.freedesktop.org/show_bug.cgi?id=112409
>   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> Participating hosts (11 -> 10)
> ------------------------------
>
>   Missing    (1): pig-skl-6260u
>
>
> Build changes
> -------------
>
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7430 -> Patchwork_15459
>
>   CI-20190529: 20190529
>   CI_DRM_7430: 39c64d2cb4dcae379486b9887c224472f30b12ce @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_15459: e58f093c7eeeb7c95cb535849192d6dc5a8680fa @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [Intel-gfx]  ✗ Fi.CI.IGT: failure for bios: dot not discard address space (rev2)
@ 2019-11-29 18:28     ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-29 18:28 UTC (permalink / raw)
  To: Intel Graphics; +Cc: Lucas De Marchi

On Wed, Nov 27, 2019 at 12:12 PM Patchwork
<patchwork@emeril.freedesktop.org> wrote:
>
> == Series Details ==
>
> Series: bios: dot not discard address space (rev2)
> URL   : https://patchwork.freedesktop.org/series/70075/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7430_full -> Patchwork_15459_full
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_15459_full absolutely need to be
>   verified manually.
>
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_15459_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_15459_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled:
>     - shard-skl:          NOTRUN -> [INCOMPLETE][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled.html

I can't see how this would be related - this machine doesn't even use
the code in question.

Lucas De Marchi

>
>
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_15459_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@gem_ctx_persistence@smoketest:
>     - shard-glk:          [PASS][2] -> [TIMEOUT][3] ([fdo#112404])
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk4/igt@gem_ctx_persistence@smoketest.html
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk8/igt@gem_ctx_persistence@smoketest.html
>
>   * igt@gem_exec_schedule@preempt-queue-contexts-blt:
>     - shard-tglb:         [PASS][4] -> [INCOMPLETE][5] ([fdo#111606] / [fdo#111677])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@gem_exec_schedule@preempt-queue-contexts-blt.html
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-blt.html
>
>   * igt@gem_exec_schedule@preempt-queue-vebox:
>     - shard-tglb:         [PASS][6] -> [INCOMPLETE][7] ([fdo#111677])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@preempt-queue-vebox.html
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@gem_exec_schedule@preempt-queue-vebox.html
>
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-glk:          [PASS][8] -> [FAIL][9] ([fdo#112392])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
>
>   * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
>     - shard-hsw:          [PASS][10] -> [DMESG-WARN][11] ([fdo#111870]) +1 similar issue
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
>
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-iclb:         [PASS][12] -> [FAIL][13] ([fdo#111830 ])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
>
>   * igt@kms_big_fb@y-tiled-8bpp-rotate-180:
>     - shard-glk:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103359] / [k.org#198133])
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk9/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
>
>   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
>     - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +3 similar issues
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>
>   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
>     - shard-kbl:          [PASS][18] -> [DMESG-WARN][19] ([fdo#108566]) +2 similar issues
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>
>   * igt@kms_cursor_crc@pipe-d-cursor-suspend:
>     - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111850])
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
>
>   * igt@kms_cursor_legacy@cursor-vs-flip-atomic:
>     - shard-hsw:          [PASS][22] -> [FAIL][23] ([fdo#103355])
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
>     - shard-tglb:         [PASS][24] -> [INCOMPLETE][25] ([fdo#111884])
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>     - shard-iclb:         [PASS][26] -> [INCOMPLETE][27] ([fdo#107713])
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
>     - shard-tglb:         [PASS][28] -> [FAIL][29] ([fdo#103167])
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
>     - shard-iclb:         [PASS][30] -> [FAIL][31] ([fdo#103167])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
>
>   * igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
>     - shard-skl:          [PASS][32] -> [INCOMPLETE][33] ([fdo#106978])
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
>
>   * igt@kms_plane@pixel-format-pipe-a-planes:
>     - shard-skl:          [PASS][34] -> [INCOMPLETE][35] ([fdo#112347])
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl10/igt@kms_plane@pixel-format-pipe-a-planes.html
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_plane@pixel-format-pipe-a-planes.html
>
>   * igt@kms_plane@pixel-format-pipe-b-planes:
>     - shard-skl:          [PASS][36] -> [INCOMPLETE][37] ([fdo#112391])
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl6/igt@kms_plane@pixel-format-pipe-b-planes.html
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_plane@pixel-format-pipe-b-planes.html
>
>
> #### Possible fixes ####
>
>   * igt@gem_ctx_isolation@rcs0-s3:
>     - shard-tglb:         [INCOMPLETE][38] ([fdo#111832]) -> [PASS][39]
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_ctx_isolation@rcs0-s3.html
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb2/igt@gem_ctx_isolation@rcs0-s3.html
>
>   * igt@gem_exec_parallel@fds:
>     - shard-tglb:         [INCOMPLETE][40] ([fdo#111867]) -> [PASS][41]
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@gem_exec_parallel@fds.html
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_parallel@fds.html
>
>   * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
>     - shard-hsw:          [TIMEOUT][42] ([fdo#112068 ]) -> [PASS][43]
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
>
>   * igt@gem_sync@basic-all:
>     - shard-tglb:         [INCOMPLETE][44] ([fdo#111880]) -> [PASS][45]
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb8/igt@gem_sync@basic-all.html
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb8/igt@gem_sync@basic-all.html
>
>   * igt@gem_userptr_blits@sync-unmap-after-close:
>     - shard-hsw:          [DMESG-WARN][46] ([fdo#111870]) -> [PASS][47] +1 similar issue
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-hsw8/igt@gem_userptr_blits@sync-unmap-after-close.html
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html
>
>   * igt@i915_selftest@mock_requests:
>     - shard-glk:          [DMESG-WARN][48] ([fdo#112158]) -> [PASS][49]
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-glk7/igt@i915_selftest@mock_requests.html
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-glk2/igt@i915_selftest@mock_requests.html
>
>   * igt@kms_big_fb@x-tiled-16bpp-rotate-180:
>     - shard-skl:          [INCOMPLETE][50] ([fdo#112347] / [fdo#112409]) -> [PASS][51]
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl2/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl1/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
>
>   * igt@kms_draw_crc@draw-method-rgb565-render-untiled:
>     - shard-skl:          [INCOMPLETE][52] ([fdo#112395]) -> [PASS][53]
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
>
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-skl:          [FAIL][54] ([fdo#105363]) -> [PASS][55]
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
>     - shard-tglb:         [FAIL][56] ([fdo#103167]) -> [PASS][57]
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
>
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-kbl:          [DMESG-WARN][58] ([fdo#108566]) -> [PASS][59] +1 similar issue
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
>     - shard-iclb:         [FAIL][60] ([fdo#103167]) -> [PASS][61]
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
>
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc:
>     - shard-tglb:         [INCOMPLETE][62] ([fdo#111884]) -> [PASS][63]
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
>
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
>     - shard-apl:          [DMESG-WARN][64] ([fdo#108566]) -> [PASS][65] +1 similar issue
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>     - shard-skl:          [FAIL][66] ([fdo#108145] / [fdo#110403]) -> [PASS][67]
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
>
>   * igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
>     - shard-tglb:         [INCOMPLETE][68] ([fdo#111850]) -> [PASS][69]
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb4/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb6/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
>
>
> #### Warnings ####
>
>   * igt@gem_exec_schedule@deep-bsd1:
>     - shard-tglb:         [INCOMPLETE][70] ([fdo#111671]) -> [FAIL][71] ([fdo#111646])
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7430/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/shard-tglb4/igt@gem_exec_schedule@deep-bsd1.html
>
>
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
>   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
>   [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
>   [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
>   [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
>   [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
>   [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
>   [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
>   [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
>   [fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
>   [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
>   [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
>   [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
>   [fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068
>   [fdo#112158]: https://bugs.freedesktop.org/show_bug.cgi?id=112158
>   [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
>   [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
>   [fdo#112392]: https://bugs.freedesktop.org/show_bug.cgi?id=112392
>   [fdo#112395]: https://bugs.freedesktop.org/show_bug.cgi?id=112395
>   [fdo#112404]: https://bugs.freedesktop.org/show_bug.cgi?id=112404
>   [fdo#112409]: https://bugs.freedesktop.org/show_bug.cgi?id=112409
>   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> Participating hosts (11 -> 10)
> ------------------------------
>
>   Missing    (1): pig-skl-6260u
>
>
> Build changes
> -------------
>
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7430 -> Patchwork_15459
>
>   CI-20190529: 20190529
>   CI_DRM_7430: 39c64d2cb4dcae379486b9887c224472f30b12ce @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5310: d1ea62b3f759f10ff6860561ba82e5c4902511d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_15459: e58f093c7eeeb7c95cb535849192d6dc5a8680fa @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15459/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function
  2019-11-20 23:46 ` [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function Lucas De Marchi
  2019-11-21 13:02   ` Jani Nikula
@ 2019-11-22 13:49   ` Ville Syrjälä
  1 sibling, 0 replies; 24+ messages in thread
From: Ville Syrjälä @ 2019-11-22 13:49 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Wed, Nov 20, 2019 at 03:46:07PM -0800, Lucas De Marchi wrote:
> We don't need to keep the pci rom mapped during the entire
> intel_bios_init() anymore. Move it to the previous copy_vbt() function
> and rename it to oprom_get_vbt() since now it's responsible to to all
> operations related to get the vbt from the oprom.
> 
> v2: fix double __iomem attribute detected by sparse
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 40 +++++++++++------------
>  1 file changed, 19 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 8bdfc1d55040..aa9b182efee5 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1896,12 +1896,17 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
>  	return vbt;
>  }
>  
> -static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
> +static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
>  {
> -	void __iomem *p = NULL;
> +	struct pci_dev *pdev = dev_priv->drm.pdev;
> +	void __iomem *p = NULL, *oprom;
>  	struct vbt_header *vbt;
>  	u16 vbt_size;
> -	size_t i;
> +	size_t i, size;
> +
> +	oprom = pci_map_rom(pdev, &size);
> +	if (!oprom)
> +		return NULL;
>  
>  	/* Scour memory looking for the VBT signature. */
>  	for (i = 0; i + 4 < size; i++) {
> @@ -1914,23 +1919,23 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
>  	}
>  
>  	if (!p)
> -		return NULL;
> +		goto err_unmap_oprom;
>  
>  	if (sizeof(struct vbt_header) > size) {
>  		DRM_DEBUG_DRIVER("VBT header incomplete\n");
> -		return NULL;
> +		goto err_unmap_oprom;
>  	}
>  
>  	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
>  	if (vbt_size > size) {
>  		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
> -		return NULL;
> +		goto err_unmap_oprom;
>  	}
>  
>  	/* The rest will be validated by intel_bios_is_valid_vbt() */
>  	vbt = kmalloc(vbt_size, GFP_KERNEL);
>  	if (!vbt)
> -		return NULL;
> +		goto err_unmap_oprom;
>  
>  	memcpy_fromio(vbt, p, vbt_size);
>  

Where is the unmap for the non-error path?

> @@ -1941,6 +1946,8 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
>  
>  err_free_vbt:
>  	kfree(vbt);
> +err_unmap_oprom:
> +	pci_unmap_rom(pdev, oprom);
>  
>  	return NULL;
>  }
> @@ -1955,10 +1962,9 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
>   */
>  void intel_bios_init(struct drm_i915_private *dev_priv)
>  {
> -	struct pci_dev *pdev = dev_priv->drm.pdev;
>  	const struct vbt_header *vbt = dev_priv->opregion.vbt;
> +	struct vbt_header *oprom_vbt = NULL;
>  	const struct bdb_header *bdb;
> -	u8 __iomem *oprom = NULL;
>  
>  	INIT_LIST_HEAD(&dev_priv->vbt.display_devices);
>  
> @@ -1971,15 +1977,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>  
>  	/* If the OpRegion does not have VBT, look in PCI ROM. */
>  	if (!vbt) {
> -		size_t size;
> -
> -		oprom = pci_map_rom(pdev, &size);
> -		if (!oprom)
> +		oprom_vbt = oprom_get_vbt(dev_priv);
> +		if (!oprom_vbt)
>  			goto out;
>  
> -		vbt = copy_vbt(oprom, size);
> -		if (!vbt)
> -			goto out;
> +		vbt = oprom_vbt;
>  
>  		DRM_DEBUG_KMS("Found valid VBT in PCI ROM\n");
>  	}
> @@ -2012,11 +2014,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>  		init_vbt_missing_defaults(dev_priv);
>  	}
>  
> -	if (oprom)
> -		pci_unmap_rom(pdev, oprom);
> -
> -	if (vbt != dev_priv->opregion.vbt)
> -		kfree(vbt);
> +	kfree(oprom_vbt);
>  }
>  
>  /**
> -- 
> 2.24.0

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function
  2019-11-20 23:46 ` [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function Lucas De Marchi
@ 2019-11-21 13:02   ` Jani Nikula
  2019-11-22 13:49   ` Ville Syrjälä
  1 sibling, 0 replies; 24+ messages in thread
From: Jani Nikula @ 2019-11-21 13:02 UTC (permalink / raw)
  To: Lucas De Marchi, intel-gfx

On Wed, 20 Nov 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> We don't need to keep the pci rom mapped during the entire
> intel_bios_init() anymore. Move it to the previous copy_vbt() function
> and rename it to oprom_get_vbt() since now it's responsible to to all
> operations related to get the vbt from the oprom.
>
> v2: fix double __iomem attribute detected by sparse
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 40 +++++++++++------------
>  1 file changed, 19 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 8bdfc1d55040..aa9b182efee5 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1896,12 +1896,17 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
>  	return vbt;
>  }
>  
> -static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
> +static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
>  {
> -	void __iomem *p = NULL;
> +	struct pci_dev *pdev = dev_priv->drm.pdev;
> +	void __iomem *p = NULL, *oprom;
>  	struct vbt_header *vbt;
>  	u16 vbt_size;
> -	size_t i;
> +	size_t i, size;
> +
> +	oprom = pci_map_rom(pdev, &size);
> +	if (!oprom)
> +		return NULL;
>  
>  	/* Scour memory looking for the VBT signature. */
>  	for (i = 0; i + 4 < size; i++) {
> @@ -1914,23 +1919,23 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
>  	}
>  
>  	if (!p)
> -		return NULL;
> +		goto err_unmap_oprom;
>  
>  	if (sizeof(struct vbt_header) > size) {
>  		DRM_DEBUG_DRIVER("VBT header incomplete\n");
> -		return NULL;
> +		goto err_unmap_oprom;
>  	}
>  
>  	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
>  	if (vbt_size > size) {
>  		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
> -		return NULL;
> +		goto err_unmap_oprom;
>  	}
>  
>  	/* The rest will be validated by intel_bios_is_valid_vbt() */
>  	vbt = kmalloc(vbt_size, GFP_KERNEL);
>  	if (!vbt)
> -		return NULL;
> +		goto err_unmap_oprom;
>  
>  	memcpy_fromio(vbt, p, vbt_size);
>  
> @@ -1941,6 +1946,8 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
>  
>  err_free_vbt:
>  	kfree(vbt);
> +err_unmap_oprom:
> +	pci_unmap_rom(pdev, oprom);
>  
>  	return NULL;
>  }
> @@ -1955,10 +1962,9 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
>   */
>  void intel_bios_init(struct drm_i915_private *dev_priv)
>  {
> -	struct pci_dev *pdev = dev_priv->drm.pdev;
>  	const struct vbt_header *vbt = dev_priv->opregion.vbt;
> +	struct vbt_header *oprom_vbt = NULL;
>  	const struct bdb_header *bdb;
> -	u8 __iomem *oprom = NULL;
>  
>  	INIT_LIST_HEAD(&dev_priv->vbt.display_devices);
>  
> @@ -1971,15 +1977,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>  
>  	/* If the OpRegion does not have VBT, look in PCI ROM. */
>  	if (!vbt) {
> -		size_t size;
> -
> -		oprom = pci_map_rom(pdev, &size);
> -		if (!oprom)
> +		oprom_vbt = oprom_get_vbt(dev_priv);
> +		if (!oprom_vbt)
>  			goto out;
>  
> -		vbt = copy_vbt(oprom, size);
> -		if (!vbt)
> -			goto out;
> +		vbt = oprom_vbt;
>  
>  		DRM_DEBUG_KMS("Found valid VBT in PCI ROM\n");
>  	}
> @@ -2012,11 +2014,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>  		init_vbt_missing_defaults(dev_priv);
>  	}
>  
> -	if (oprom)
> -		pci_unmap_rom(pdev, oprom);
> -
> -	if (vbt != dev_priv->opregion.vbt)
> -		kfree(vbt);
> +	kfree(oprom_vbt);
>  }
>  
>  /**

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function
  2019-11-20 23:46 [PATCH 1/3] drm/i915/bios: do not discard address space Lucas De Marchi
@ 2019-11-20 23:46 ` Lucas De Marchi
  2019-11-21 13:02   ` Jani Nikula
  2019-11-22 13:49   ` Ville Syrjälä
  0 siblings, 2 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-20 23:46 UTC (permalink / raw)
  To: intel-gfx

We don't need to keep the pci rom mapped during the entire
intel_bios_init() anymore. Move it to the previous copy_vbt() function
and rename it to oprom_get_vbt() since now it's responsible to to all
operations related to get the vbt from the oprom.

v2: fix double __iomem attribute detected by sparse

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 40 +++++++++++------------
 1 file changed, 19 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 8bdfc1d55040..aa9b182efee5 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1896,12 +1896,17 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
 	return vbt;
 }
 
-static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
+static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
 {
-	void __iomem *p = NULL;
+	struct pci_dev *pdev = dev_priv->drm.pdev;
+	void __iomem *p = NULL, *oprom;
 	struct vbt_header *vbt;
 	u16 vbt_size;
-	size_t i;
+	size_t i, size;
+
+	oprom = pci_map_rom(pdev, &size);
+	if (!oprom)
+		return NULL;
 
 	/* Scour memory looking for the VBT signature. */
 	for (i = 0; i + 4 < size; i++) {
@@ -1914,23 +1919,23 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 	}
 
 	if (!p)
-		return NULL;
+		goto err_unmap_oprom;
 
 	if (sizeof(struct vbt_header) > size) {
 		DRM_DEBUG_DRIVER("VBT header incomplete\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
 	if (vbt_size > size) {
 		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	/* The rest will be validated by intel_bios_is_valid_vbt() */
 	vbt = kmalloc(vbt_size, GFP_KERNEL);
 	if (!vbt)
-		return NULL;
+		goto err_unmap_oprom;
 
 	memcpy_fromio(vbt, p, vbt_size);
 
@@ -1941,6 +1946,8 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 
 err_free_vbt:
 	kfree(vbt);
+err_unmap_oprom:
+	pci_unmap_rom(pdev, oprom);
 
 	return NULL;
 }
@@ -1955,10 +1962,9 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
  */
 void intel_bios_init(struct drm_i915_private *dev_priv)
 {
-	struct pci_dev *pdev = dev_priv->drm.pdev;
 	const struct vbt_header *vbt = dev_priv->opregion.vbt;
+	struct vbt_header *oprom_vbt = NULL;
 	const struct bdb_header *bdb;
-	u8 __iomem *oprom = NULL;
 
 	INIT_LIST_HEAD(&dev_priv->vbt.display_devices);
 
@@ -1971,15 +1977,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 
 	/* If the OpRegion does not have VBT, look in PCI ROM. */
 	if (!vbt) {
-		size_t size;
-
-		oprom = pci_map_rom(pdev, &size);
-		if (!oprom)
+		oprom_vbt = oprom_get_vbt(dev_priv);
+		if (!oprom_vbt)
 			goto out;
 
-		vbt = copy_vbt(oprom, size);
-		if (!vbt)
-			goto out;
+		vbt = oprom_vbt;
 
 		DRM_DEBUG_KMS("Found valid VBT in PCI ROM\n");
 	}
@@ -2012,11 +2014,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 		init_vbt_missing_defaults(dev_priv);
 	}
 
-	if (oprom)
-		pci_unmap_rom(pdev, oprom);
-
-	if (vbt != dev_priv->opregion.vbt)
-		kfree(vbt);
+	kfree(oprom_vbt);
 }
 
 /**
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function
  2019-11-15 23:35 [PATCH 1/3] drm/i915/bios: do not discard address space Lucas De Marchi
@ 2019-11-15 23:35 ` Lucas De Marchi
  0 siblings, 0 replies; 24+ messages in thread
From: Lucas De Marchi @ 2019-11-15 23:35 UTC (permalink / raw)
  To: intel-gfx

We don't need to keep the pci rom mapped during the entire
intel_bios_init() anymore. Move it to the previous copy_vbt() function
and rename it to oprom_get_vbt() since now it's responsible to to all
operations related to get the vbt from the oprom.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 40 +++++++++++------------
 1 file changed, 19 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index cc0ca2f8dd7b..3ab73f8db8dd 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1796,12 +1796,17 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
 	return vbt;
 }
 
-static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
+static struct vbt_header *oprom_get_vbt(struct drm_i915_private *dev_priv)
 {
-	void __iomem *p = NULL;
+	struct pci_dev *pdev = dev_priv->drm.pdev;
+	void __iomem *p = NULL, __iomem *oprom;
 	struct vbt_header *vbt;
 	u16 vbt_size;
-	size_t i;
+	size_t i, size;
+
+	oprom = pci_map_rom(pdev, &size);
+	if (!oprom)
+		return NULL;
 
 	/* Scour memory looking for the VBT signature. */
 	for (i = 0; i + 4 < size; i++) {
@@ -1814,23 +1819,23 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 	}
 
 	if (!p)
-		return NULL;
+		goto err_unmap_oprom;
 
 	if (sizeof(struct vbt_header) > size) {
 		DRM_DEBUG_DRIVER("VBT header incomplete\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
 	if (vbt_size > size) {
 		DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
-		return NULL;
+		goto err_unmap_oprom;
 	}
 
 	/* The rest will be validated by intel_bios_is_valid_vbt() */
 	vbt = kmalloc(vbt_size, GFP_KERNEL);
 	if (!vbt)
-		return NULL;
+		goto err_unmap_oprom;
 
 	memcpy_fromio(vbt, p, vbt_size);
 
@@ -1841,6 +1846,8 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
 
 err_free_vbt:
 	kfree(vbt);
+err_unmap_oprom:
+	pci_unmap_rom(pdev, oprom);
 
 	return NULL;
 }
@@ -1855,10 +1862,9 @@ static struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
  */
 void intel_bios_init(struct drm_i915_private *dev_priv)
 {
-	struct pci_dev *pdev = dev_priv->drm.pdev;
 	const struct vbt_header *vbt = dev_priv->opregion.vbt;
+	struct vbt_header *oprom_vbt = NULL;
 	const struct bdb_header *bdb;
-	u8 __iomem *oprom = NULL;
 
 	INIT_LIST_HEAD(&dev_priv->vbt.display_devices);
 
@@ -1871,15 +1877,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 
 	/* If the OpRegion does not have VBT, look in PCI ROM. */
 	if (!vbt) {
-		size_t size;
-
-		oprom = pci_map_rom(pdev, &size);
-		if (!oprom)
+		oprom_vbt = oprom_get_vbt(dev_priv);
+		if (!oprom_vbt)
 			goto out;
 
-		vbt = copy_vbt(oprom, size);
-		if (!vbt)
-			goto out;
+		vbt = oprom_vbt;
 
 		DRM_DEBUG_KMS("Found valid VBT in PCI ROM\n");
 	}
@@ -1911,11 +1913,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 		init_vbt_missing_defaults(dev_priv);
 	}
 
-	if (oprom)
-		pci_unmap_rom(pdev, oprom);
-
-	if (vbt != dev_priv->opregion.vbt)
-		kfree(vbt);
+	kfree(oprom_vbt);
 }
 
 /**
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread
end of thread, other threads:[~2019-11-29 18:28 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 22:51 [PATCH 0/3] bios: dot not discard address space Lucas De Marchi
2019-11-26 22:51 ` [Intel-gfx] " Lucas De Marchi
2019-11-26 22:51 ` [PATCH 1/3] drm/i915/bios: do " Lucas De Marchi
2019-11-26 22:51   ` [Intel-gfx] " Lucas De Marchi
2019-11-26 22:51 ` [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function Lucas De Marchi
2019-11-26 22:51   ` [Intel-gfx] " Lucas De Marchi
2019-11-26 22:51 ` [PATCH 3/3] drm/i915/bios: assume vbt is 4-byte aligned into oprom Lucas De Marchi
2019-11-26 22:51   ` [Intel-gfx] " Lucas De Marchi
2019-11-29 10:00   ` Jani Nikula
2019-11-29 10:00     ` [Intel-gfx] " Jani Nikula
2019-11-27  0:14 ` ✗ Fi.CI.BAT: failure for bios: dot not discard address space Patchwork
2019-11-27  0:14   ` [Intel-gfx] " Patchwork
2019-11-27  0:53   ` Lucas De Marchi
2019-11-27  0:53     ` [Intel-gfx] " Lucas De Marchi
2019-11-27 11:27 ` ✓ Fi.CI.BAT: success for bios: dot not discard address space (rev2) Patchwork
2019-11-27 11:27   ` [Intel-gfx] " Patchwork
2019-11-27 20:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-27 20:12   ` [Intel-gfx] " Patchwork
2019-11-29 18:28   ` Lucas De Marchi
2019-11-29 18:28     ` [Intel-gfx] " Lucas De Marchi
  -- strict thread matches above, loose matches on Subject: below --
2019-11-20 23:46 [PATCH 1/3] drm/i915/bios: do not discard address space Lucas De Marchi
2019-11-20 23:46 ` [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function Lucas De Marchi
2019-11-21 13:02   ` Jani Nikula
2019-11-22 13:49   ` Ville Syrjälä
2019-11-15 23:35 [PATCH 1/3] drm/i915/bios: do not discard address space Lucas De Marchi
2019-11-15 23:35 ` [PATCH 2/3] drm/i915/bios: fold pci rom map/unmap into copy function Lucas De Marchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.