* [PATCH iproute2] tc: fix warning in tc/m_ct.c
@ 2019-11-27 5:19 Brian Vazquez
2019-11-27 7:47 ` Paul Blakey
2019-12-04 19:37 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Brian Vazquez @ 2019-11-27 5:19 UTC (permalink / raw)
To: Brian Vazquez, David Ahern, Stephen Hemminger
Cc: Mahesh Bandewar, Maciej Zenczykowski, netdev, Brian Vazquez, Paul Blakey
Warning was:
m_ct.c:370:13: warning: variable 'nat' is used uninitialized whenever
'if' condition is false
Cc: Paul Blakey <paulb@mellanox.com>
Fixes: c8a494314c40 ("tc: Introduce tc ct action")
Signed-off-by: Brian Vazquez <brianvv@google.com>
---
tc/m_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/m_ct.c b/tc/m_ct.c
index 8df2f610..45fa4a8c 100644
--- a/tc/m_ct.c
+++ b/tc/m_ct.c
@@ -359,7 +359,7 @@ static void ct_print_nat(int ct_action, struct rtattr **tb)
{
size_t done = 0;
char out[256] = "";
- bool nat;
+ bool nat = false;
if (!(ct_action & TCA_CT_ACT_NAT))
return;
--
2.24.0.432.g9d3f5f5b63-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] tc: fix warning in tc/m_ct.c
2019-11-27 5:19 [PATCH iproute2] tc: fix warning in tc/m_ct.c Brian Vazquez
@ 2019-11-27 7:47 ` Paul Blakey
2019-12-04 19:37 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Paul Blakey @ 2019-11-27 7:47 UTC (permalink / raw)
To: Brian Vazquez, Brian Vazquez, David Ahern, Stephen Hemminger
Cc: Mahesh Bandewar, Maciej Zenczykowski, netdev
On 11/27/2019 7:19 AM, Brian Vazquez wrote:
> Warning was:
> m_ct.c:370:13: warning: variable 'nat' is used uninitialized whenever
> 'if' condition is false
>
> Cc: Paul Blakey <paulb@mellanox.com>
> Fixes: c8a494314c40 ("tc: Introduce tc ct action")
> Signed-off-by: Brian Vazquez <brianvv@google.com>
> ---
> tc/m_ct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tc/m_ct.c b/tc/m_ct.c
> index 8df2f610..45fa4a8c 100644
> --- a/tc/m_ct.c
> +++ b/tc/m_ct.c
> @@ -359,7 +359,7 @@ static void ct_print_nat(int ct_action, struct rtattr **tb)
> {
> size_t done = 0;
> char out[256] = "";
> - bool nat;
> + bool nat = false;
>
> if (!(ct_action & TCA_CT_ACT_NAT))
> return;
Yes nat should be false here.
Looks good to me.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] tc: fix warning in tc/m_ct.c
2019-11-27 5:19 [PATCH iproute2] tc: fix warning in tc/m_ct.c Brian Vazquez
2019-11-27 7:47 ` Paul Blakey
@ 2019-12-04 19:37 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2019-12-04 19:37 UTC (permalink / raw)
To: Brian Vazquez
Cc: Brian Vazquez, David Ahern, Mahesh Bandewar, Maciej Zenczykowski,
netdev, Paul Blakey
On Tue, 26 Nov 2019 21:19:34 -0800
Brian Vazquez <brianvv@google.com> wrote:
> Warning was:
> m_ct.c:370:13: warning: variable 'nat' is used uninitialized whenever
> 'if' condition is false
>
> Cc: Paul Blakey <paulb@mellanox.com>
> Fixes: c8a494314c40 ("tc: Introduce tc ct action")
> Signed-off-by: Brian Vazquez <brianvv@google.com>
> ---
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-04 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 5:19 [PATCH iproute2] tc: fix warning in tc/m_ct.c Brian Vazquez
2019-11-27 7:47 ` Paul Blakey
2019-12-04 19:37 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.