* [CI 1/3] drm/i915/selftests: Count the number of engines used
@ 2019-11-27 22:32 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-27 22:32 UTC (permalink / raw)
To: intel-gfx
Don't rely on the RUNTIME_INFO() when we loop over a particular context
and only run on a filtered set of engines.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../drm/i915/gem/selftests/i915_gem_context.c | 25 ++++++++++++-------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index 2ea4790f3721..33e56d9af061 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -1343,11 +1343,13 @@ static int igt_ctx_sseu(void *arg)
static int igt_ctx_readonly(void *arg)
{
struct drm_i915_private *i915 = arg;
+ unsigned long idx, ndwords, dw, num_engines;
struct drm_i915_gem_object *obj = NULL;
struct i915_request *tq[5] = {};
+ struct i915_gem_engines_iter it;
struct i915_address_space *vm;
struct i915_gem_context *ctx;
- unsigned long idx, ndwords, dw;
+ struct intel_context *ce;
struct igt_live_test t;
I915_RND_STATE(prng);
IGT_TIMEOUT(end_time);
@@ -1381,12 +1383,15 @@ static int igt_ctx_readonly(void *arg)
goto out_file;
}
+ num_engines = 0;
+ for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it)
+ if (intel_engine_can_store_dword(ce->engine))
+ num_engines++;
+ i915_gem_context_unlock_engines(ctx);
+
ndwords = 0;
dw = 0;
while (!time_after(jiffies, end_time)) {
- struct i915_gem_engines_iter it;
- struct intel_context *ce;
-
for_each_gem_engine(ce,
i915_gem_context_lock_engines(ctx), it) {
if (!intel_engine_can_store_dword(ce->engine))
@@ -1429,8 +1434,8 @@ static int igt_ctx_readonly(void *arg)
}
i915_gem_context_unlock_engines(ctx);
}
- pr_info("Submitted %lu dwords (across %u engines)\n",
- ndwords, RUNTIME_INFO(i915)->num_engines);
+ pr_info("Submitted %lu dwords (across %lu engines)\n",
+ ndwords, num_engines);
dw = 0;
idx = 0;
@@ -1690,10 +1695,10 @@ static int igt_vm_isolation(void *arg)
{
struct drm_i915_private *i915 = arg;
struct i915_gem_context *ctx_a, *ctx_b;
+ unsigned long num_engines, count;
struct intel_engine_cs *engine;
struct igt_live_test t;
I915_RND_STATE(prng);
- unsigned long count;
struct file *file;
u64 vm_total;
int err;
@@ -1735,6 +1740,7 @@ static int igt_vm_isolation(void *arg)
vm_total -= I915_GTT_PAGE_SIZE;
count = 0;
+ num_engines = 0;
for_each_uabi_engine(engine, i915) {
IGT_TIMEOUT(end_time);
unsigned long this = 0;
@@ -1772,9 +1778,10 @@ static int igt_vm_isolation(void *arg)
this++;
}
count += this;
+ num_engines++;
}
- pr_info("Checked %lu scratch offsets across %d engines\n",
- count, RUNTIME_INFO(i915)->num_engines);
+ pr_info("Checked %lu scratch offsets across %lu engines\n",
+ count, num_engines);
out_file:
if (igt_live_test_end(&t))
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [Intel-gfx] [CI 1/3] drm/i915/selftests: Count the number of engines used
@ 2019-11-27 22:32 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-27 22:32 UTC (permalink / raw)
To: intel-gfx
Don't rely on the RUNTIME_INFO() when we loop over a particular context
and only run on a filtered set of engines.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../drm/i915/gem/selftests/i915_gem_context.c | 25 ++++++++++++-------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index 2ea4790f3721..33e56d9af061 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -1343,11 +1343,13 @@ static int igt_ctx_sseu(void *arg)
static int igt_ctx_readonly(void *arg)
{
struct drm_i915_private *i915 = arg;
+ unsigned long idx, ndwords, dw, num_engines;
struct drm_i915_gem_object *obj = NULL;
struct i915_request *tq[5] = {};
+ struct i915_gem_engines_iter it;
struct i915_address_space *vm;
struct i915_gem_context *ctx;
- unsigned long idx, ndwords, dw;
+ struct intel_context *ce;
struct igt_live_test t;
I915_RND_STATE(prng);
IGT_TIMEOUT(end_time);
@@ -1381,12 +1383,15 @@ static int igt_ctx_readonly(void *arg)
goto out_file;
}
+ num_engines = 0;
+ for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it)
+ if (intel_engine_can_store_dword(ce->engine))
+ num_engines++;
+ i915_gem_context_unlock_engines(ctx);
+
ndwords = 0;
dw = 0;
while (!time_after(jiffies, end_time)) {
- struct i915_gem_engines_iter it;
- struct intel_context *ce;
-
for_each_gem_engine(ce,
i915_gem_context_lock_engines(ctx), it) {
if (!intel_engine_can_store_dword(ce->engine))
@@ -1429,8 +1434,8 @@ static int igt_ctx_readonly(void *arg)
}
i915_gem_context_unlock_engines(ctx);
}
- pr_info("Submitted %lu dwords (across %u engines)\n",
- ndwords, RUNTIME_INFO(i915)->num_engines);
+ pr_info("Submitted %lu dwords (across %lu engines)\n",
+ ndwords, num_engines);
dw = 0;
idx = 0;
@@ -1690,10 +1695,10 @@ static int igt_vm_isolation(void *arg)
{
struct drm_i915_private *i915 = arg;
struct i915_gem_context *ctx_a, *ctx_b;
+ unsigned long num_engines, count;
struct intel_engine_cs *engine;
struct igt_live_test t;
I915_RND_STATE(prng);
- unsigned long count;
struct file *file;
u64 vm_total;
int err;
@@ -1735,6 +1740,7 @@ static int igt_vm_isolation(void *arg)
vm_total -= I915_GTT_PAGE_SIZE;
count = 0;
+ num_engines = 0;
for_each_uabi_engine(engine, i915) {
IGT_TIMEOUT(end_time);
unsigned long this = 0;
@@ -1772,9 +1778,10 @@ static int igt_vm_isolation(void *arg)
this++;
}
count += this;
+ num_engines++;
}
- pr_info("Checked %lu scratch offsets across %d engines\n",
- count, RUNTIME_INFO(i915)->num_engines);
+ pr_info("Checked %lu scratch offsets across %lu engines\n",
+ count, num_engines);
out_file:
if (igt_live_test_end(&t))
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [CI 2/3] drm/i915/selftests: Flush fput after running selftests
@ 2019-11-27 22:32 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-27 22:32 UTC (permalink / raw)
To: intel-gfx
Use an rcu_barrier() to flush any mock files used by the selftests as
the deferred cleanup may be holding resources that we need to cleanup.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/i915_selftest.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index d3bf9eefb682..036e30b8b62d 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -152,8 +152,10 @@ static int __run_selftests(const char *name,
continue;
cond_resched();
- if (signal_pending(current))
- return -EINTR;
+ if (signal_pending(current)) {
+ err = -EINTR;
+ goto out;
+ }
pr_info(DRIVER_NAME ": Running %s\n", st->name);
if (data)
@@ -171,6 +173,8 @@ static int __run_selftests(const char *name,
st->name, err))
err = -1;
+out:
+ rcu_barrier(); /* flush deferred fput() */
return err;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [Intel-gfx] [CI 2/3] drm/i915/selftests: Flush fput after running selftests
@ 2019-11-27 22:32 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-27 22:32 UTC (permalink / raw)
To: intel-gfx
Use an rcu_barrier() to flush any mock files used by the selftests as
the deferred cleanup may be holding resources that we need to cleanup.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/i915_selftest.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index d3bf9eefb682..036e30b8b62d 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -152,8 +152,10 @@ static int __run_selftests(const char *name,
continue;
cond_resched();
- if (signal_pending(current))
- return -EINTR;
+ if (signal_pending(current)) {
+ err = -EINTR;
+ goto out;
+ }
pr_info(DRIVER_NAME ": Running %s\n", st->name);
if (data)
@@ -171,6 +173,8 @@ static int __run_selftests(const char *name,
st->name, err))
err = -1;
+out:
+ rcu_barrier(); /* flush deferred fput() */
return err;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [CI 3/3] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
@ 2019-11-27 22:32 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-27 22:32 UTC (permalink / raw)
To: intel-gfx
After much hair pulling, resort to preallocating the ppGTT entries on
init to circumvent the apparent lack of PD invalidate following the
write to PP_DCLV upon switching mm between contexts (and here the same
context after binding new objects). However, the details of that PP_DCLV
invalidate are still unknown, and it appears we need to reload the mm
twice to cover over a timing issue. Worrying.
Fixes: 3dc007fe9b2b ("drm/i915/gtt: Downgrade gen7 (ivb, byt, hsw) back to aliasing-ppgtt")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../gpu/drm/i915/gt/intel_ring_submission.c | 29 +++++++++----------
drivers/gpu/drm/i915/i915_gem_gtt.c | 12 ++++----
drivers/gpu/drm/i915/i915_pci.c | 4 +--
3 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index f25ceccb335e..9b1047df16ee 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -1366,13 +1366,15 @@ static int load_pd_dir(struct i915_request *rq, const struct i915_ppgtt *ppgtt)
const struct intel_engine_cs * const engine = rq->engine;
u32 *cs;
- cs = intel_ring_begin(rq, 6);
+ cs = intel_ring_begin(rq, 8);
if (IS_ERR(cs))
return PTR_ERR(cs);
- *cs++ = MI_LOAD_REGISTER_IMM(1);
+ *cs++ = MI_LOAD_REGISTER_IMM(2);
*cs++ = i915_mmio_reg_offset(RING_PP_DIR_DCLV(engine->mmio_base));
*cs++ = PP_DIR_DCLV_2G;
+ *cs++ = i915_mmio_reg_offset(RING_PP_DIR_DCLV(engine->mmio_base)) + 4;
+ *cs++ = 0;
*cs++ = MI_LOAD_REGISTER_IMM(1);
*cs++ = i915_mmio_reg_offset(RING_PP_DIR_BASE(engine->mmio_base));
@@ -1579,30 +1581,25 @@ static int switch_context(struct i915_request *rq)
{
struct intel_context *ce = rq->hw_context;
struct i915_address_space *vm = vm_alias(ce);
+ u32 hw_flags = 0;
int ret;
GEM_BUG_ON(HAS_EXECLISTS(rq->i915));
if (vm) {
- ret = load_pd_dir(rq, i915_vm_to_ppgtt(vm));
- if (ret)
- return ret;
+ int loops = 8;
+
+ do {
+ ret = load_pd_dir(rq, i915_vm_to_ppgtt(vm));
+ if (ret)
+ return ret;
+ } while (--loops);
}
if (ce->state) {
- u32 hw_flags;
-
GEM_BUG_ON(rq->engine->id != RCS0);
- /*
- * The kernel context(s) is treated as pure scratch and is not
- * expected to retain any state (as we sacrifice it during
- * suspend and on resume it may be corrupted). This is ok,
- * as nothing actually executes using the kernel context; it
- * is purely used for flushing user contexts.
- */
- hw_flags = 0;
- if (i915_gem_context_is_kernel(rq->gem_context))
+ if (!rq->engine->default_state)
hw_flags = MI_RESTORE_INHIBIT;
ret = mi_set_context(rq, hw_flags);
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 6239a9adbf14..0458dc53e0ae 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -1692,7 +1692,6 @@ static int gen6_alloc_va_range(struct i915_address_space *vm,
intel_wakeref_t wakeref;
u64 from = start;
unsigned int pde;
- bool flush = false;
int ret = 0;
wakeref = intel_runtime_pm_get(&vm->i915->runtime_pm);
@@ -1717,11 +1716,6 @@ static int gen6_alloc_va_range(struct i915_address_space *vm,
spin_lock(&pd->lock);
if (pd->entry[pde] == &vm->scratch[1]) {
pd->entry[pde] = pt;
- if (i915_vma_is_bound(ppgtt->vma,
- I915_VMA_GLOBAL_BIND)) {
- gen6_write_pde(ppgtt, pde, pt);
- flush = true;
- }
} else {
alloc = pt;
pt = pd->entry[pde];
@@ -1732,8 +1726,11 @@ static int gen6_alloc_va_range(struct i915_address_space *vm,
}
spin_unlock(&pd->lock);
- if (flush)
+ if (i915_vma_is_bound(ppgtt->vma, I915_VMA_GLOBAL_BIND)) {
+ gen6_for_all_pdes(pt, pd, pde)
+ gen6_write_pde(ppgtt, pde, pt);
gen6_ggtt_invalidate(vm->gt->ggtt);
+ }
goto out;
@@ -1994,6 +1991,7 @@ static struct i915_ppgtt *gen6_ppgtt_create(struct drm_i915_private *i915)
err_pd:
kfree(ppgtt->base.pd);
err_free:
+ mutex_destroy(&ppgtt->pin_mutex);
kfree(ppgtt);
return ERR_PTR(err);
}
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index da3e9b5752ac..bba6b50e6beb 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -436,7 +436,7 @@ static const struct intel_device_info intel_sandybridge_m_gt2_info = {
.has_rc6 = 1, \
.has_rc6p = 1, \
.has_rps = true, \
- .ppgtt_type = INTEL_PPGTT_ALIASING, \
+ .ppgtt_type = INTEL_PPGTT_FULL, \
.ppgtt_size = 31, \
IVB_PIPE_OFFSETS, \
IVB_CURSOR_OFFSETS, \
@@ -493,7 +493,7 @@ static const struct intel_device_info intel_valleyview_info = {
.has_rps = true,
.display.has_gmch = 1,
.display.has_hotplug = 1,
- .ppgtt_type = INTEL_PPGTT_ALIASING,
+ .ppgtt_type = INTEL_PPGTT_FULL,
.ppgtt_size = 31,
.has_snoop = true,
.has_coherent_ggtt = false,
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [Intel-gfx] [CI 3/3] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
@ 2019-11-27 22:32 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-27 22:32 UTC (permalink / raw)
To: intel-gfx
After much hair pulling, resort to preallocating the ppGTT entries on
init to circumvent the apparent lack of PD invalidate following the
write to PP_DCLV upon switching mm between contexts (and here the same
context after binding new objects). However, the details of that PP_DCLV
invalidate are still unknown, and it appears we need to reload the mm
twice to cover over a timing issue. Worrying.
Fixes: 3dc007fe9b2b ("drm/i915/gtt: Downgrade gen7 (ivb, byt, hsw) back to aliasing-ppgtt")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../gpu/drm/i915/gt/intel_ring_submission.c | 29 +++++++++----------
drivers/gpu/drm/i915/i915_gem_gtt.c | 12 ++++----
drivers/gpu/drm/i915/i915_pci.c | 4 +--
3 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index f25ceccb335e..9b1047df16ee 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -1366,13 +1366,15 @@ static int load_pd_dir(struct i915_request *rq, const struct i915_ppgtt *ppgtt)
const struct intel_engine_cs * const engine = rq->engine;
u32 *cs;
- cs = intel_ring_begin(rq, 6);
+ cs = intel_ring_begin(rq, 8);
if (IS_ERR(cs))
return PTR_ERR(cs);
- *cs++ = MI_LOAD_REGISTER_IMM(1);
+ *cs++ = MI_LOAD_REGISTER_IMM(2);
*cs++ = i915_mmio_reg_offset(RING_PP_DIR_DCLV(engine->mmio_base));
*cs++ = PP_DIR_DCLV_2G;
+ *cs++ = i915_mmio_reg_offset(RING_PP_DIR_DCLV(engine->mmio_base)) + 4;
+ *cs++ = 0;
*cs++ = MI_LOAD_REGISTER_IMM(1);
*cs++ = i915_mmio_reg_offset(RING_PP_DIR_BASE(engine->mmio_base));
@@ -1579,30 +1581,25 @@ static int switch_context(struct i915_request *rq)
{
struct intel_context *ce = rq->hw_context;
struct i915_address_space *vm = vm_alias(ce);
+ u32 hw_flags = 0;
int ret;
GEM_BUG_ON(HAS_EXECLISTS(rq->i915));
if (vm) {
- ret = load_pd_dir(rq, i915_vm_to_ppgtt(vm));
- if (ret)
- return ret;
+ int loops = 8;
+
+ do {
+ ret = load_pd_dir(rq, i915_vm_to_ppgtt(vm));
+ if (ret)
+ return ret;
+ } while (--loops);
}
if (ce->state) {
- u32 hw_flags;
-
GEM_BUG_ON(rq->engine->id != RCS0);
- /*
- * The kernel context(s) is treated as pure scratch and is not
- * expected to retain any state (as we sacrifice it during
- * suspend and on resume it may be corrupted). This is ok,
- * as nothing actually executes using the kernel context; it
- * is purely used for flushing user contexts.
- */
- hw_flags = 0;
- if (i915_gem_context_is_kernel(rq->gem_context))
+ if (!rq->engine->default_state)
hw_flags = MI_RESTORE_INHIBIT;
ret = mi_set_context(rq, hw_flags);
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 6239a9adbf14..0458dc53e0ae 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -1692,7 +1692,6 @@ static int gen6_alloc_va_range(struct i915_address_space *vm,
intel_wakeref_t wakeref;
u64 from = start;
unsigned int pde;
- bool flush = false;
int ret = 0;
wakeref = intel_runtime_pm_get(&vm->i915->runtime_pm);
@@ -1717,11 +1716,6 @@ static int gen6_alloc_va_range(struct i915_address_space *vm,
spin_lock(&pd->lock);
if (pd->entry[pde] == &vm->scratch[1]) {
pd->entry[pde] = pt;
- if (i915_vma_is_bound(ppgtt->vma,
- I915_VMA_GLOBAL_BIND)) {
- gen6_write_pde(ppgtt, pde, pt);
- flush = true;
- }
} else {
alloc = pt;
pt = pd->entry[pde];
@@ -1732,8 +1726,11 @@ static int gen6_alloc_va_range(struct i915_address_space *vm,
}
spin_unlock(&pd->lock);
- if (flush)
+ if (i915_vma_is_bound(ppgtt->vma, I915_VMA_GLOBAL_BIND)) {
+ gen6_for_all_pdes(pt, pd, pde)
+ gen6_write_pde(ppgtt, pde, pt);
gen6_ggtt_invalidate(vm->gt->ggtt);
+ }
goto out;
@@ -1994,6 +1991,7 @@ static struct i915_ppgtt *gen6_ppgtt_create(struct drm_i915_private *i915)
err_pd:
kfree(ppgtt->base.pd);
err_free:
+ mutex_destroy(&ppgtt->pin_mutex);
kfree(ppgtt);
return ERR_PTR(err);
}
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index da3e9b5752ac..bba6b50e6beb 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -436,7 +436,7 @@ static const struct intel_device_info intel_sandybridge_m_gt2_info = {
.has_rc6 = 1, \
.has_rc6p = 1, \
.has_rps = true, \
- .ppgtt_type = INTEL_PPGTT_ALIASING, \
+ .ppgtt_type = INTEL_PPGTT_FULL, \
.ppgtt_size = 31, \
IVB_PIPE_OFFSETS, \
IVB_CURSOR_OFFSETS, \
@@ -493,7 +493,7 @@ static const struct intel_device_info intel_valleyview_info = {
.has_rps = true,
.display.has_gmch = 1,
.display.has_hotplug = 1,
- .ppgtt_type = INTEL_PPGTT_ALIASING,
+ .ppgtt_type = INTEL_PPGTT_FULL,
.ppgtt_size = 31,
.has_snoop = true,
.has_coherent_ggtt = false,
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used
@ 2019-11-28 1:07 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 1:07 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used
URL : https://patchwork.freedesktop.org/series/70131/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7434 -> Patchwork_15478
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15478 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15478, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15478:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_execlists:
- fi-bxt-dsi: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
- fi-ivb-3770: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770r: [PASS][11] -> [DMESG-WARN][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_15478 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [PASS][13] -> [FAIL][14] ([fdo#109635 ])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][15] ([fdo#112261]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-icl-u3: [INCOMPLETE][17] ([fdo#107713]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [DMESG-WARN][19] ([fdo#112261]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][21] ([fdo#103558] / [fdo#105602] / [fdo#107139]) -> [DMESG-WARN][22] ([fdo#103558] / [fdo#105602] / [fdo#105763] / [fdo#107139])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-x1275: [DMESG-WARN][23] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [SKIP][24] ([fdo#109271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][25] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][26] ([fdo#103558] / [fdo#105602]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][27] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][28] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +8 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (52 -> 42)
------------------------------
Missing (10): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-byt-n2820 fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7434 -> Patchwork_15478
CI-20190529: 20190529
CI_DRM_7434: 1bbc4d30ca9fd950cbcb73f324e00d0bc357758e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5312: 851c75531043cd906e028632b64b02b9312e9945 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15478: 48329ce8b91ef56e363463e675e1b71b4f17a04f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
48329ce8b91e drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
9ee83a1d7774 drm/i915/selftests: Flush fput after running selftests
294748cd42fb drm/i915/selftests: Count the number of engines used
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used
@ 2019-11-28 1:07 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 1:07 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used
URL : https://patchwork.freedesktop.org/series/70131/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7434 -> Patchwork_15478
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15478 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15478, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15478:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_execlists:
- fi-bxt-dsi: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
- fi-ivb-3770: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770r: [PASS][11] -> [DMESG-WARN][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_15478 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [PASS][13] -> [FAIL][14] ([fdo#109635 ])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][15] ([fdo#112261]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-icl-u3: [INCOMPLETE][17] ([fdo#107713]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [DMESG-WARN][19] ([fdo#112261]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][21] ([fdo#103558] / [fdo#105602] / [fdo#107139]) -> [DMESG-WARN][22] ([fdo#103558] / [fdo#105602] / [fdo#105763] / [fdo#107139])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-x1275: [DMESG-WARN][23] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [SKIP][24] ([fdo#109271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][25] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][26] ([fdo#103558] / [fdo#105602]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][27] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][28] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +8 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7434/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (52 -> 42)
------------------------------
Missing (10): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-byt-n2820 fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7434 -> Patchwork_15478
CI-20190529: 20190529
CI_DRM_7434: 1bbc4d30ca9fd950cbcb73f324e00d0bc357758e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5312: 851c75531043cd906e028632b64b02b9312e9945 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15478: 48329ce8b91ef56e363463e675e1b71b4f17a04f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
48329ce8b91e drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
9ee83a1d7774 drm/i915/selftests: Flush fput after running selftests
294748cd42fb drm/i915/selftests: Count the number of engines used
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15478/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] drm/i915/selftests: Flush fput after running selftests
@ 2019-11-28 8:48 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-28 8:48 UTC (permalink / raw)
To: intel-gfx
Use an rcu_barrier() to flush any mock files used by the selftests as
the deferred cleanup may be holding resources that we need to cleanup.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/i915_selftest.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index d3bf9eefb682..e3a8110d79ba 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -152,8 +152,10 @@ static int __run_selftests(const char *name,
continue;
cond_resched();
- if (signal_pending(current))
- return -EINTR;
+ if (signal_pending(current)) {
+ err = -EINTR;
+ goto out;
+ }
pr_info(DRIVER_NAME ": Running %s\n", st->name);
if (data)
@@ -171,6 +173,10 @@ static int __run_selftests(const char *name,
st->name, err))
err = -1;
+out:
+ rcu_barrier(); /* flush deferred fput() */
+ yield();
+ rcu_barrier(); /* and once more for anything freed from the files */
return err;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Flush fput after running selftests
@ 2019-11-28 8:48 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-28 8:48 UTC (permalink / raw)
To: intel-gfx
Use an rcu_barrier() to flush any mock files used by the selftests as
the deferred cleanup may be holding resources that we need to cleanup.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/i915_selftest.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index d3bf9eefb682..e3a8110d79ba 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -152,8 +152,10 @@ static int __run_selftests(const char *name,
continue;
cond_resched();
- if (signal_pending(current))
- return -EINTR;
+ if (signal_pending(current)) {
+ err = -EINTR;
+ goto out;
+ }
pr_info(DRIVER_NAME ": Running %s\n", st->name);
if (data)
@@ -171,6 +173,10 @@ static int __run_selftests(const char *name,
st->name, err))
err = -1;
+out:
+ rcu_barrier(); /* flush deferred fput() */
+ yield();
+ rcu_barrier(); /* and once more for anything freed from the files */
return err;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
@ 2019-11-28 11:13 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 11:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
URL : https://patchwork.freedesktop.org/series/70131/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5a0525bd9377 drm/i915/selftests: Count the number of engines used
740577e66b4a drm/i915/selftests: Flush fput after running selftests
-:34: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#34: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:178:
+ yield();
total: 0 errors, 1 warnings, 0 checks, 22 lines checked
456bec1820bd drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
@ 2019-11-28 11:13 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 11:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
URL : https://patchwork.freedesktop.org/series/70131/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5a0525bd9377 drm/i915/selftests: Count the number of engines used
740577e66b4a drm/i915/selftests: Flush fput after running selftests
-:34: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#34: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:178:
+ yield();
total: 0 errors, 1 warnings, 0 checks, 22 lines checked
456bec1820bd drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
@ 2019-11-28 11:37 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 11:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
URL : https://patchwork.freedesktop.org/series/70131/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7436 -> Patchwork_15482
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15482 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15482, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15482:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_active:
- fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-bwr-2160/igt@i915_selftest@live_active.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-bwr-2160/igt@i915_selftest@live_active.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
- fi-ivb-3770: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770r: [PASS][11] -> [DMESG-WARN][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
- fi-byt-n2820: [PASS][13] -> [DMESG-WARN][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_15482 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-bsw-n3050: [DMESG-FAIL][15] ([fdo#112176]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-bsw-n3050/igt@i915_selftest@live_blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-bsw-n3050/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-guc: [INCOMPLETE][17] ([fdo#106070] / [fdo#111700]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][19] ([fdo#111045] / [fdo#111096]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@kms_busy@basic-flip-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][21] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][22] ([fdo#103558] / [fdo#105602]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][23] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][24] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
[fdo#112176]: https://bugs.freedesktop.org/show_bug.cgi?id=112176
Participating hosts (49 -> 43)
------------------------------
Additional (2): fi-kbl-8809g fi-pnv-d510
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7436 -> Patchwork_15482
CI-20190529: 20190529
CI_DRM_7436: 8c9c0404c7e4b14f8d3f77af64619f8863ac7eb2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5313: 92caadb4e551ba05aa6e6e567ef69da96ca7e328 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15482: 456bec1820bd5dc1242d77f40bfe6cf0ed2a2d1d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
456bec1820bd drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
740577e66b4a drm/i915/selftests: Flush fput after running selftests
5a0525bd9377 drm/i915/selftests: Count the number of engines used
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
@ 2019-11-28 11:37 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 11:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2)
URL : https://patchwork.freedesktop.org/series/70131/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7436 -> Patchwork_15482
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15482 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15482, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15482:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_active:
- fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-bwr-2160/igt@i915_selftest@live_active.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-bwr-2160/igt@i915_selftest@live_active.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
- fi-ivb-3770: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770r: [PASS][11] -> [DMESG-WARN][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
- fi-byt-n2820: [PASS][13] -> [DMESG-WARN][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_15482 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-bsw-n3050: [DMESG-FAIL][15] ([fdo#112176]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-bsw-n3050/igt@i915_selftest@live_blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-bsw-n3050/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-guc: [INCOMPLETE][17] ([fdo#106070] / [fdo#111700]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][19] ([fdo#111045] / [fdo#111096]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@kms_busy@basic-flip-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][21] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][22] ([fdo#103558] / [fdo#105602]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][23] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][24] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7436/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
[fdo#112176]: https://bugs.freedesktop.org/show_bug.cgi?id=112176
Participating hosts (49 -> 43)
------------------------------
Additional (2): fi-kbl-8809g fi-pnv-d510
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7436 -> Patchwork_15482
CI-20190529: 20190529
CI_DRM_7436: 8c9c0404c7e4b14f8d3f77af64619f8863ac7eb2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5313: 92caadb4e551ba05aa6e6e567ef69da96ca7e328 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15482: 456bec1820bd5dc1242d77f40bfe6cf0ed2a2d1d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
456bec1820bd drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
740577e66b4a drm/i915/selftests: Flush fput after running selftests
5a0525bd9377 drm/i915/selftests: Count the number of engines used
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15482/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [CI 1/3] drm/i915/selftests: Count the number of engines used
@ 2019-11-28 11:56 ` Tvrtko Ursulin
0 siblings, 0 replies; 22+ messages in thread
From: Tvrtko Ursulin @ 2019-11-28 11:56 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 27/11/2019 22:32, Chris Wilson wrote:
> Don't rely on the RUNTIME_INFO() when we loop over a particular context
> and only run on a filtered set of engines.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> .../drm/i915/gem/selftests/i915_gem_context.c | 25 ++++++++++++-------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index 2ea4790f3721..33e56d9af061 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1343,11 +1343,13 @@ static int igt_ctx_sseu(void *arg)
> static int igt_ctx_readonly(void *arg)
> {
> struct drm_i915_private *i915 = arg;
> + unsigned long idx, ndwords, dw, num_engines;
> struct drm_i915_gem_object *obj = NULL;
> struct i915_request *tq[5] = {};
> + struct i915_gem_engines_iter it;
> struct i915_address_space *vm;
> struct i915_gem_context *ctx;
> - unsigned long idx, ndwords, dw;
> + struct intel_context *ce;
> struct igt_live_test t;
> I915_RND_STATE(prng);
> IGT_TIMEOUT(end_time);
> @@ -1381,12 +1383,15 @@ static int igt_ctx_readonly(void *arg)
> goto out_file;
> }
>
> + num_engines = 0;
> + for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it)
> + if (intel_engine_can_store_dword(ce->engine))
> + num_engines++;
> + i915_gem_context_unlock_engines(ctx);
> +
> ndwords = 0;
> dw = 0;
> while (!time_after(jiffies, end_time)) {
> - struct i915_gem_engines_iter it;
> - struct intel_context *ce;
> -
> for_each_gem_engine(ce,
> i915_gem_context_lock_engines(ctx), it) {
> if (!intel_engine_can_store_dword(ce->engine))
> @@ -1429,8 +1434,8 @@ static int igt_ctx_readonly(void *arg)
> }
> i915_gem_context_unlock_engines(ctx);
> }
> - pr_info("Submitted %lu dwords (across %u engines)\n",
> - ndwords, RUNTIME_INFO(i915)->num_engines);
> + pr_info("Submitted %lu dwords (across %lu engines)\n",
> + ndwords, num_engines);
>
> dw = 0;
> idx = 0;
> @@ -1690,10 +1695,10 @@ static int igt_vm_isolation(void *arg)
> {
> struct drm_i915_private *i915 = arg;
> struct i915_gem_context *ctx_a, *ctx_b;
> + unsigned long num_engines, count;
> struct intel_engine_cs *engine;
> struct igt_live_test t;
> I915_RND_STATE(prng);
> - unsigned long count;
> struct file *file;
> u64 vm_total;
> int err;
> @@ -1735,6 +1740,7 @@ static int igt_vm_isolation(void *arg)
> vm_total -= I915_GTT_PAGE_SIZE;
>
> count = 0;
> + num_engines = 0;
> for_each_uabi_engine(engine, i915) {
> IGT_TIMEOUT(end_time);
> unsigned long this = 0;
> @@ -1772,9 +1778,10 @@ static int igt_vm_isolation(void *arg)
> this++;
> }
> count += this;
> + num_engines++;
> }
> - pr_info("Checked %lu scratch offsets across %d engines\n",
> - count, RUNTIME_INFO(i915)->num_engines);
> + pr_info("Checked %lu scratch offsets across %lu engines\n",
> + count, num_engines);
>
> out_file:
> if (igt_live_test_end(&t))
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Intel-gfx] [CI 1/3] drm/i915/selftests: Count the number of engines used
@ 2019-11-28 11:56 ` Tvrtko Ursulin
0 siblings, 0 replies; 22+ messages in thread
From: Tvrtko Ursulin @ 2019-11-28 11:56 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 27/11/2019 22:32, Chris Wilson wrote:
> Don't rely on the RUNTIME_INFO() when we loop over a particular context
> and only run on a filtered set of engines.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> .../drm/i915/gem/selftests/i915_gem_context.c | 25 ++++++++++++-------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index 2ea4790f3721..33e56d9af061 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1343,11 +1343,13 @@ static int igt_ctx_sseu(void *arg)
> static int igt_ctx_readonly(void *arg)
> {
> struct drm_i915_private *i915 = arg;
> + unsigned long idx, ndwords, dw, num_engines;
> struct drm_i915_gem_object *obj = NULL;
> struct i915_request *tq[5] = {};
> + struct i915_gem_engines_iter it;
> struct i915_address_space *vm;
> struct i915_gem_context *ctx;
> - unsigned long idx, ndwords, dw;
> + struct intel_context *ce;
> struct igt_live_test t;
> I915_RND_STATE(prng);
> IGT_TIMEOUT(end_time);
> @@ -1381,12 +1383,15 @@ static int igt_ctx_readonly(void *arg)
> goto out_file;
> }
>
> + num_engines = 0;
> + for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it)
> + if (intel_engine_can_store_dword(ce->engine))
> + num_engines++;
> + i915_gem_context_unlock_engines(ctx);
> +
> ndwords = 0;
> dw = 0;
> while (!time_after(jiffies, end_time)) {
> - struct i915_gem_engines_iter it;
> - struct intel_context *ce;
> -
> for_each_gem_engine(ce,
> i915_gem_context_lock_engines(ctx), it) {
> if (!intel_engine_can_store_dword(ce->engine))
> @@ -1429,8 +1434,8 @@ static int igt_ctx_readonly(void *arg)
> }
> i915_gem_context_unlock_engines(ctx);
> }
> - pr_info("Submitted %lu dwords (across %u engines)\n",
> - ndwords, RUNTIME_INFO(i915)->num_engines);
> + pr_info("Submitted %lu dwords (across %lu engines)\n",
> + ndwords, num_engines);
>
> dw = 0;
> idx = 0;
> @@ -1690,10 +1695,10 @@ static int igt_vm_isolation(void *arg)
> {
> struct drm_i915_private *i915 = arg;
> struct i915_gem_context *ctx_a, *ctx_b;
> + unsigned long num_engines, count;
> struct intel_engine_cs *engine;
> struct igt_live_test t;
> I915_RND_STATE(prng);
> - unsigned long count;
> struct file *file;
> u64 vm_total;
> int err;
> @@ -1735,6 +1740,7 @@ static int igt_vm_isolation(void *arg)
> vm_total -= I915_GTT_PAGE_SIZE;
>
> count = 0;
> + num_engines = 0;
> for_each_uabi_engine(engine, i915) {
> IGT_TIMEOUT(end_time);
> unsigned long this = 0;
> @@ -1772,9 +1778,10 @@ static int igt_vm_isolation(void *arg)
> this++;
> }
> count += this;
> + num_engines++;
> }
> - pr_info("Checked %lu scratch offsets across %d engines\n",
> - count, RUNTIME_INFO(i915)->num_engines);
> + pr_info("Checked %lu scratch offsets across %lu engines\n",
> + count, num_engines);
>
> out_file:
> if (igt_live_test_end(&t))
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] drm/i915/selftests: Flush fput after running selftests
@ 2019-11-28 15:59 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-28 15:59 UTC (permalink / raw)
To: intel-gfx
Use an rcu_barrier() to flush any mock files used by the selftests as
the deferred cleanup may be holding resources that we need to cleanup.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
drivers/gpu/drm/i915/selftests/i915_selftest.c | 10 ++++++++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 6239a9adbf14..61a1582b9f9e 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2752,7 +2752,7 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
atomic_set(&ggtt->vm.open, 0);
rcu_barrier(); /* flush the RCU'ed__i915_vm_release */
- flush_workqueue(ggtt->vm.i915->wq);
+ i915_gem_drain_workqueue(ggtt->vm.i915);
mutex_lock(&ggtt->vm.mutex);
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index d3bf9eefb682..e3a8110d79ba 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -152,8 +152,10 @@ static int __run_selftests(const char *name,
continue;
cond_resched();
- if (signal_pending(current))
- return -EINTR;
+ if (signal_pending(current)) {
+ err = -EINTR;
+ goto out;
+ }
pr_info(DRIVER_NAME ": Running %s\n", st->name);
if (data)
@@ -171,6 +173,10 @@ static int __run_selftests(const char *name,
st->name, err))
err = -1;
+out:
+ rcu_barrier(); /* flush deferred fput() */
+ yield();
+ rcu_barrier(); /* and once more for anything freed from the files */
return err;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Flush fput after running selftests
@ 2019-11-28 15:59 ` Chris Wilson
0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-28 15:59 UTC (permalink / raw)
To: intel-gfx
Use an rcu_barrier() to flush any mock files used by the selftests as
the deferred cleanup may be holding resources that we need to cleanup.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
drivers/gpu/drm/i915/selftests/i915_selftest.c | 10 ++++++++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 6239a9adbf14..61a1582b9f9e 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2752,7 +2752,7 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
atomic_set(&ggtt->vm.open, 0);
rcu_barrier(); /* flush the RCU'ed__i915_vm_release */
- flush_workqueue(ggtt->vm.i915->wq);
+ i915_gem_drain_workqueue(ggtt->vm.i915);
mutex_lock(&ggtt->vm.mutex);
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index d3bf9eefb682..e3a8110d79ba 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -152,8 +152,10 @@ static int __run_selftests(const char *name,
continue;
cond_resched();
- if (signal_pending(current))
- return -EINTR;
+ if (signal_pending(current)) {
+ err = -EINTR;
+ goto out;
+ }
pr_info(DRIVER_NAME ": Running %s\n", st->name);
if (data)
@@ -171,6 +173,10 @@ static int __run_selftests(const char *name,
st->name, err))
err = -1;
+out:
+ rcu_barrier(); /* flush deferred fput() */
+ yield();
+ rcu_barrier(); /* and once more for anything freed from the files */
return err;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 22+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
@ 2019-11-28 17:53 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 17:53 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
URL : https://patchwork.freedesktop.org/series/70131/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
26c994148fba drm/i915/selftests: Flush fput after running selftests
-:47: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#47: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:178:
+ yield();
total: 0 errors, 1 warnings, 0 checks, 30 lines checked
86b85f170a22 drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
@ 2019-11-28 17:53 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 17:53 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
URL : https://patchwork.freedesktop.org/series/70131/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
26c994148fba drm/i915/selftests: Flush fput after running selftests
-:47: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#47: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:178:
+ yield();
total: 0 errors, 1 warnings, 0 checks, 30 lines checked
86b85f170a22 drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
@ 2019-11-28 18:23 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 18:23 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
URL : https://patchwork.freedesktop.org/series/70131/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15493
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15493 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15493, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15493:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
- fi-ivb-3770: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770r: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_15493 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [PASS][11] -> [INCOMPLETE][12] ([fdo#102657])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
- fi-cfl-guc: [PASS][13] -> [INCOMPLETE][14] ([fdo#106070] / [fdo#111700])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][15] -> [FAIL][16] ([fdo#111407])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][17] ([fdo#108511]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
- fi-skl-lmem: [DMESG-WARN][19] ([fdo#112261]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@kms_busy@basic-flip-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][21] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][22] ([fdo#103558] / [fdo#105602]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][23] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][24] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-dsi: [INCOMPLETE][25] ([fdo#107713]) -> [DMESG-WARN][26] ([fdo#107724])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-icl-dsi/igt@kms_flip@basic-flip-vs-dpms.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-icl-dsi/igt@kms_flip@basic-flip-vs-dpms.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
[fdo#112260]: https://bugs.freedesktop.org/show_bug.cgi?id=112260
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (51 -> 44)
------------------------------
Additional (1): fi-tgl-y
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7438 -> Patchwork_15493
CI-20190529: 20190529
CI_DRM_7438: 8a2661592e79e48bcba9c24565b2b16edafbcbaa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5313: 92caadb4e551ba05aa6e6e567ef69da96ca7e328 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15493: 86b85f170a22a2a874191de8946bb67698410bf1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
86b85f170a22 drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
26c994148fba drm/i915/selftests: Flush fput after running selftests
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
@ 2019-11-28 18:23 ` Patchwork
0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-11-28 18:23 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3)
URL : https://patchwork.freedesktop.org/series/70131/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7438 -> Patchwork_15493
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15493 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15493, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15493:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
- fi-ivb-3770: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-4770r: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-hsw-4770r/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_15493 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [PASS][11] -> [INCOMPLETE][12] ([fdo#102657])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
- fi-cfl-guc: [PASS][13] -> [INCOMPLETE][14] ([fdo#106070] / [fdo#111700])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][15] -> [FAIL][16] ([fdo#111407])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][17] ([fdo#108511]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
- fi-skl-lmem: [DMESG-WARN][19] ([fdo#112261]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@kms_busy@basic-flip-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][21] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][22] ([fdo#103558] / [fdo#105602]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-a.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][23] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][24] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-dsi: [INCOMPLETE][25] ([fdo#107713]) -> [DMESG-WARN][26] ([fdo#107724])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7438/fi-icl-dsi/igt@kms_flip@basic-flip-vs-dpms.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/fi-icl-dsi/igt@kms_flip@basic-flip-vs-dpms.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
[fdo#112260]: https://bugs.freedesktop.org/show_bug.cgi?id=112260
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (51 -> 44)
------------------------------
Additional (1): fi-tgl-y
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7438 -> Patchwork_15493
CI-20190529: 20190529
CI_DRM_7438: 8a2661592e79e48bcba9c24565b2b16edafbcbaa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5313: 92caadb4e551ba05aa6e6e567ef69da96ca7e328 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15493: 86b85f170a22a2a874191de8946bb67698410bf1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
86b85f170a22 drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw
26c994148fba drm/i915/selftests: Flush fput after running selftests
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15493/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2019-11-28 18:23 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 22:32 [CI 1/3] drm/i915/selftests: Count the number of engines used Chris Wilson
2019-11-27 22:32 ` [Intel-gfx] " Chris Wilson
2019-11-27 22:32 ` [CI 2/3] drm/i915/selftests: Flush fput after running selftests Chris Wilson
2019-11-27 22:32 ` [Intel-gfx] " Chris Wilson
2019-11-28 8:48 ` [PATCH] " Chris Wilson
2019-11-28 8:48 ` [Intel-gfx] " Chris Wilson
2019-11-28 15:59 ` Chris Wilson
2019-11-28 15:59 ` [Intel-gfx] " Chris Wilson
2019-11-27 22:32 ` [CI 3/3] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw Chris Wilson
2019-11-27 22:32 ` [Intel-gfx] " Chris Wilson
2019-11-28 1:07 ` ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used Patchwork
2019-11-28 1:07 ` [Intel-gfx] " Patchwork
2019-11-28 11:13 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev2) Patchwork
2019-11-28 11:13 ` [Intel-gfx] " Patchwork
2019-11-28 11:37 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-28 11:37 ` [Intel-gfx] " Patchwork
2019-11-28 11:56 ` [CI 1/3] drm/i915/selftests: Count the number of engines used Tvrtko Ursulin
2019-11-28 11:56 ` [Intel-gfx] " Tvrtko Ursulin
2019-11-28 17:53 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Count the number of engines used (rev3) Patchwork
2019-11-28 17:53 ` [Intel-gfx] " Patchwork
2019-11-28 18:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-28 18:23 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.