[PATCH] hg: Add python3-native to native paths

[PATCH] hg: Add python3-native to native paths

[Khem Raj]

This helps fix an issue where python interpreter in hg script could
overflow the BINPRM_BUF_SIZE which is 128 on most of systems, because
interpreter is hardcoded and build paths can be deep.

This patch helps, because now the absolute python interp path in hg can
be replaced with '/usr/bin/env python3' and it will ensure that python3
from native install is used instead of the one on host.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 lib/bb/fetch2/hg.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/bb/fetch2/hg.py b/lib/bb/fetch2/hg.py
index e21115de..a640a80c 100644
--- a/lib/bb/fetch2/hg.py
+++ b/lib/bb/fetch2/hg.py
@@ -65,6 +65,7 @@ class Hg(FetchMethod):
         ud.pkgdir = os.path.join(hgdir, hgsrcname)
         ud.moddir = os.path.join(ud.pkgdir, ud.module)
         ud.localfile = ud.moddir
+        d.appendVar("EXTRANATIVEPATH", " python3-native ")
         ud.basecmd = d.getVar("FETCHCMD_hg") or "/usr/bin/env hg"
 
         ud.setup_revisions(d)
-- 
2.24.0

Re: [PATCH] hg: Add python3-native to native paths

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

EXTRANATIVEPATH is an oe-core-ism, not bitbake, so this isn’t an appropriate place for it. Perhaps in do_fetch in base.bbclass.
On Nov 27, 2019, 9:10 PM -0700, Khem Raj <raj.khem@gmail.com>, wrote:
> This helps fix an issue where python interpreter in hg script could
> overflow the BINPRM_BUF_SIZE which is 128 on most of systems, because
> interpreter is hardcoded and build paths can be deep.
>
> This patch helps, because now the absolute python interp path in hg can
> be replaced with '/usr/bin/env python3' and it will ensure that python3
> from native install is used instead of the one on host.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> lib/bb/fetch2/hg.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/bb/fetch2/hg.py b/lib/bb/fetch2/hg.py
> index e21115de..a640a80c 100644
> --- a/lib/bb/fetch2/hg.py
> +++ b/lib/bb/fetch2/hg.py
> @@ -65,6 +65,7 @@ class Hg(FetchMethod):
> ud.pkgdir = os.path.join(hgdir, hgsrcname)
> ud.moddir = os.path.join(ud.pkgdir, ud.module)
> ud.localfile = ud.moddir
> + d.appendVar("EXTRANATIVEPATH", " python3-native ")
> ud.basecmd = d.getVar("FETCHCMD_hg") or "/usr/bin/env hg"
>
> ud.setup_revisions(d)
> --
> 2.24.0
>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

[-- Attachment #2: Type: text/html, Size: 1911 bytes --]

Re: [PATCH] hg: Add python3-native to native paths

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

On Thu, Nov 28, 2019 at 1:20 PM Christopher Larson <kergoth@gmail.com>
wrote:

> EXTRANATIVEPATH is an oe-core-ism, not bitbake, so this isn’t an
> appropriate place for it. Perhaps in do_fetch in base.bbclass.
>

Perhaps a better idea thanks

On Nov 27, 2019, 9:10 PM -0700, Khem Raj <raj.khem@gmail.com>, wrote:
>
> This helps fix an issue where python interpreter in hg script could
> overflow the BINPRM_BUF_SIZE which is 128 on most of systems, because
> interpreter is hardcoded and build paths can be deep.
>
> This patch helps, because now the absolute python interp path in hg can
> be replaced with '/usr/bin/env python3' and it will ensure that python3
> from native install is used instead of the one on host.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> lib/bb/fetch2/hg.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/bb/fetch2/hg.py b/lib/bb/fetch2/hg.py
> index e21115de..a640a80c 100644
> --- a/lib/bb/fetch2/hg.py
> +++ b/lib/bb/fetch2/hg.py
> @@ -65,6 +65,7 @@ class Hg(FetchMethod):
> ud.pkgdir = os.path.join(hgdir, hgsrcname)
> ud.moddir = os.path.join(ud.pkgdir, ud.module)
> ud.localfile = ud.moddir
> + d.appendVar("EXTRANATIVEPATH", " python3-native ")
> ud.basecmd = d.getVar("FETCHCMD_hg") or "/usr/bin/env hg"
>
> ud.setup_revisions(d)
> --
> 2.24.0
>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
>
>

[-- Attachment #2: Type: text/html, Size: 2744 bytes --]