* [U-Boot] [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
@ 2019-12-02 2:33 Simon Glass
2019-12-02 15:45 ` Tom Rini
0 siblings, 1 reply; 10+ messages in thread
From: Simon Glass @ 2019-12-02 2:33 UTC (permalink / raw)
To: u-boot
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
the UARTs do not correctly select the pinconfig to enable the UART pins.
Fix this so that the U-Boot banner is printed.
Signed-off-by: Simon Glass <sjg@chromium.org>
Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
index 36548dad62..68d03627f4 100644
--- a/arch/arm/dts/bcm283x-u-boot.dtsi
+++ b/arch/arm/dts/bcm283x-u-boot.dtsi
@@ -19,3 +19,11 @@
&gpio {
u-boot,dm-pre-reloc;
};
+
+&uart0_gpio14 {
+ u-boot,dm-pre-reloc;
+};
+
+&uart1_gpio14 {
+ u-boot,dm-pre-reloc;
+};
--
2.24.0.393.g34dc348eaf-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2019-12-02 2:33 [U-Boot] [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation Simon Glass
@ 2019-12-02 15:45 ` Tom Rini
2019-12-10 9:43 ` Matthias Brugger
0 siblings, 1 reply; 10+ messages in thread
From: Tom Rini @ 2019-12-02 15:45 UTC (permalink / raw)
To: u-boot
On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> the UARTs do not correctly select the pinconfig to enable the UART pins.
> Fix this so that the U-Boot banner is printed.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> ---
>
> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> index 36548dad62..68d03627f4 100644
> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> @@ -19,3 +19,11 @@
> &gpio {
> u-boot,dm-pre-reloc;
> };
> +
> +&uart0_gpio14 {
> + u-boot,dm-pre-reloc;
> +};
> +
> +&uart1_gpio14 {
> + u-boot,dm-pre-reloc;
> +};
I think this is superseded by the RPi PR that I had been testing and
just now pushed. Can you confirm that master is fine on your Pis as
well? I gather you hit this failure doing pytest on the board, which is
also how I found it. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191202/f2a101a7/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2019-12-02 15:45 ` Tom Rini
@ 2019-12-10 9:43 ` Matthias Brugger
2019-12-31 21:28 ` Simon Glass
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Brugger @ 2019-12-10 9:43 UTC (permalink / raw)
To: u-boot
Hi Simon,
On 02/12/2019 16:45, Tom Rini wrote:
> On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
>
>> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
>> the UARTs do not correctly select the pinconfig to enable the UART pins.
>> Fix this so that the U-Boot banner is printed.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
>> ---
>>
>> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
>> index 36548dad62..68d03627f4 100644
>> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
>> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
>> @@ -19,3 +19,11 @@
>> &gpio {
>> u-boot,dm-pre-reloc;
>> };
>> +
>> +&uart0_gpio14 {
>> + u-boot,dm-pre-reloc;
>> +};
>> +
>> +&uart1_gpio14 {
>> + u-boot,dm-pre-reloc;
>> +};
>
> I think this is superseded by the RPi PR that I had been testing and
> just now pushed. Can you confirm that master is fine on your Pis as
> well? I gather you hit this failure doing pytest on the board, which is
> also how I found it. Thanks!
>
Can you confirm if this is working with master branch or if we still need your
patch. In which situation would we need your patch then?
Regards,
Matthias
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2019-12-10 9:43 ` Matthias Brugger
@ 2019-12-31 21:28 ` Simon Glass
2020-01-02 23:11 ` Tom Rini
0 siblings, 1 reply; 10+ messages in thread
From: Simon Glass @ 2019-12-31 21:28 UTC (permalink / raw)
To: u-boot
Hi Matthias,
On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger@suse.com> wrote:
>
> Hi Simon,
>
> On 02/12/2019 16:45, Tom Rini wrote:
> > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> >
> >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> >> Fix this so that the U-Boot banner is printed.
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> >> ---
> >>
> >> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> >> index 36548dad62..68d03627f4 100644
> >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> >> @@ -19,3 +19,11 @@
> >> &gpio {
> >> u-boot,dm-pre-reloc;
> >> };
> >> +
> >> +&uart0_gpio14 {
> >> + u-boot,dm-pre-reloc;
> >> +};
> >> +
> >> +&uart1_gpio14 {
> >> + u-boot,dm-pre-reloc;
> >> +};
> >
> > I think this is superseded by the RPi PR that I had been testing and
> > just now pushed. Can you confirm that master is fine on your Pis as
> > well? I gather you hit this failure doing pytest on the board, which is
> > also how I found it. Thanks!
> >
>
> Can you confirm if this is working with master branch or if we still need your
> patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout
it I don't get the pre-relocation serial output and tests fail.
Regards,
Simon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2019-12-31 21:28 ` Simon Glass
@ 2020-01-02 23:11 ` Tom Rini
2020-01-03 2:27 ` Simon Glass
0 siblings, 1 reply; 10+ messages in thread
From: Tom Rini @ 2020-01-02 23:11 UTC (permalink / raw)
To: u-boot
On Tue, Dec 31, 2019 at 02:28:19PM -0700, Simon Glass wrote:
> Hi Matthias,
>
> On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger@suse.com> wrote:
> >
> > Hi Simon,
> >
> > On 02/12/2019 16:45, Tom Rini wrote:
> > > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> > >
> > >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> > >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> > >> Fix this so that the U-Boot banner is printed.
> > >>
> > >> Signed-off-by: Simon Glass <sjg@chromium.org>
> > >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> > >> ---
> > >>
> > >> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> > >> 1 file changed, 8 insertions(+)
> > >>
> > >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> > >> index 36548dad62..68d03627f4 100644
> > >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> > >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> > >> @@ -19,3 +19,11 @@
> > >> &gpio {
> > >> u-boot,dm-pre-reloc;
> > >> };
> > >> +
> > >> +&uart0_gpio14 {
> > >> + u-boot,dm-pre-reloc;
> > >> +};
> > >> +
> > >> +&uart1_gpio14 {
> > >> + u-boot,dm-pre-reloc;
> > >> +};
> > >
> > > I think this is superseded by the RPi PR that I had been testing and
> > > just now pushed. Can you confirm that master is fine on your Pis as
> > > well? I gather you hit this failure doing pytest on the board, which is
> > > also how I found it. Thanks!
> > >
> >
> > Can you confirm if this is working with master branch or if we still need your
> > patch. In which situation would we need your patch then?
>
> Unfortunately with the 'next' branch I still need this patch. WIthout
> it I don't get the pre-relocation serial output and tests fail.
Which Pi exactly? My 3B works with rpi_3_32b, rpi_3 and rpi_arm64
defconfigs and test.py.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200102/7c0797ec/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2020-01-02 23:11 ` Tom Rini
@ 2020-01-03 2:27 ` Simon Glass
2020-01-03 2:28 ` Simon Glass
0 siblings, 1 reply; 10+ messages in thread
From: Simon Glass @ 2020-01-03 2:27 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Thu, 2 Jan 2020 at 16:11, Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Dec 31, 2019 at 02:28:19PM -0700, Simon Glass wrote:
> > Hi Matthias,
> >
> > On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger@suse.com> wrote:
> > >
> > > Hi Simon,
> > >
> > > On 02/12/2019 16:45, Tom Rini wrote:
> > > > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> > > >
> > > >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> > > >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> > > >> Fix this so that the U-Boot banner is printed.
> > > >>
> > > >> Signed-off-by: Simon Glass <sjg@chromium.org>
> > > >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> > > >> ---
> > > >>
> > > >> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> > > >> 1 file changed, 8 insertions(+)
> > > >>
> > > >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > >> index 36548dad62..68d03627f4 100644
> > > >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> > > >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > >> @@ -19,3 +19,11 @@
> > > >> &gpio {
> > > >> u-boot,dm-pre-reloc;
> > > >> };
> > > >> +
> > > >> +&uart0_gpio14 {
> > > >> + u-boot,dm-pre-reloc;
> > > >> +};
> > > >> +
> > > >> +&uart1_gpio14 {
> > > >> + u-boot,dm-pre-reloc;
> > > >> +};
> > > >
> > > > I think this is superseded by the RPi PR that I had been testing and
> > > > just now pushed. Can you confirm that master is fine on your Pis as
> > > > well? I gather you hit this failure doing pytest on the board, which is
> > > > also how I found it. Thanks!
> > > >
> > >
> > > Can you confirm if this is working with master branch or if we still need your
> > > patch. In which situation would we need your patch then?
> >
> > Unfortunately with the 'next' branch I still need this patch. WIthout
> > it I don't get the pre-relocation serial output and tests fail.
>
> Which Pi exactly? My 3B works with rpi_3_32b, rpi_3 and rpi_arm64
> defconfigs and test.py.
It is a rpi_3b I believe, and I am using the rpi_3_32b.
When I cherry-pick the patch the banner appears but before that it
doesn't. Shall I check it again?
Regards,
Simon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2020-01-03 2:27 ` Simon Glass
@ 2020-01-03 2:28 ` Simon Glass
2020-01-03 3:59 ` Tom Rini
0 siblings, 1 reply; 10+ messages in thread
From: Simon Glass @ 2020-01-03 2:28 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Thu, 2 Jan 2020 at 19:27, Simon Glass <sjg@chromium.org> wrote:
>
> Hi Tom,
>
> On Thu, 2 Jan 2020 at 16:11, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Dec 31, 2019 at 02:28:19PM -0700, Simon Glass wrote:
> > > Hi Matthias,
> > >
> > > On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger@suse.com> wrote:
> > > >
> > > > Hi Simon,
> > > >
> > > > On 02/12/2019 16:45, Tom Rini wrote:
> > > > > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> > > > >
> > > > >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> > > > >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> > > > >> Fix this so that the U-Boot banner is printed.
> > > > >>
> > > > >> Signed-off-by: Simon Glass <sjg@chromium.org>
> > > > >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> > > > >> ---
> > > > >>
> > > > >> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> > > > >> 1 file changed, 8 insertions(+)
> > > > >>
> > > > >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > >> index 36548dad62..68d03627f4 100644
> > > > >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > >> @@ -19,3 +19,11 @@
> > > > >> &gpio {
> > > > >> u-boot,dm-pre-reloc;
> > > > >> };
> > > > >> +
> > > > >> +&uart0_gpio14 {
> > > > >> + u-boot,dm-pre-reloc;
> > > > >> +};
> > > > >> +
> > > > >> +&uart1_gpio14 {
> > > > >> + u-boot,dm-pre-reloc;
> > > > >> +};
> > > > >
> > > > > I think this is superseded by the RPi PR that I had been testing and
> > > > > just now pushed. Can you confirm that master is fine on your Pis as
> > > > > well? I gather you hit this failure doing pytest on the board, which is
> > > > > also how I found it. Thanks!
> > > > >
> > > >
> > > > Can you confirm if this is working with master branch or if we still need your
> > > > patch. In which situation would we need your patch then?
> > >
> > > Unfortunately with the 'next' branch I still need this patch. WIthout
> > > it I don't get the pre-relocation serial output and tests fail.
> >
> > Which Pi exactly? My 3B works with rpi_3_32b, rpi_3 and rpi_arm64
> > defconfigs and test.py.
>
> It is a rpi_3b I believe, and I am using the rpi_3_32b.
>
> When I cherry-pick the patch the banner appears but before that it
> doesn't. Shall I check it again?
Actually, can you please confirm the tree you are using? I was testing
with -next. I wonder if I was missing a patch?
Regards,
SImon
>
> Regards,
> Simon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2020-01-03 2:28 ` Simon Glass
@ 2020-01-03 3:59 ` Tom Rini
2020-03-23 1:54 ` Simon Glass
0 siblings, 1 reply; 10+ messages in thread
From: Tom Rini @ 2020-01-03 3:59 UTC (permalink / raw)
To: u-boot
On Thu, Jan 02, 2020 at 07:28:50PM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 2 Jan 2020 at 19:27, Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Tom,
> >
> > On Thu, 2 Jan 2020 at 16:11, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Tue, Dec 31, 2019 at 02:28:19PM -0700, Simon Glass wrote:
> > > > Hi Matthias,
> > > >
> > > > On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger@suse.com> wrote:
> > > > >
> > > > > Hi Simon,
> > > > >
> > > > > On 02/12/2019 16:45, Tom Rini wrote:
> > > > > > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> > > > > >
> > > > > >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> > > > > >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> > > > > >> Fix this so that the U-Boot banner is printed.
> > > > > >>
> > > > > >> Signed-off-by: Simon Glass <sjg@chromium.org>
> > > > > >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> > > > > >> ---
> > > > > >>
> > > > > >> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> > > > > >> 1 file changed, 8 insertions(+)
> > > > > >>
> > > > > >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > >> index 36548dad62..68d03627f4 100644
> > > > > >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > >> @@ -19,3 +19,11 @@
> > > > > >> &gpio {
> > > > > >> u-boot,dm-pre-reloc;
> > > > > >> };
> > > > > >> +
> > > > > >> +&uart0_gpio14 {
> > > > > >> + u-boot,dm-pre-reloc;
> > > > > >> +};
> > > > > >> +
> > > > > >> +&uart1_gpio14 {
> > > > > >> + u-boot,dm-pre-reloc;
> > > > > >> +};
> > > > > >
> > > > > > I think this is superseded by the RPi PR that I had been testing and
> > > > > > just now pushed. Can you confirm that master is fine on your Pis as
> > > > > > well? I gather you hit this failure doing pytest on the board, which is
> > > > > > also how I found it. Thanks!
> > > > > >
> > > > >
> > > > > Can you confirm if this is working with master branch or if we still need your
> > > > > patch. In which situation would we need your patch then?
> > > >
> > > > Unfortunately with the 'next' branch I still need this patch. WIthout
> > > > it I don't get the pre-relocation serial output and tests fail.
> > >
> > > Which Pi exactly? My 3B works with rpi_3_32b, rpi_3 and rpi_arm64
> > > defconfigs and test.py.
> >
> > It is a rpi_3b I believe, and I am using the rpi_3_32b.
> >
> > When I cherry-pick the patch the banner appears but before that it
> > doesn't. Shall I check it again?
>
> Actually, can you please confirm the tree you are using? I was testing
> with -next. I wonder if I was missing a patch?
I just re-confirmed by checking out current 'next' and re-running
test.py on all of the above combinations and they pass.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200102/a6d53060/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2020-01-03 3:59 ` Tom Rini
@ 2020-03-23 1:54 ` Simon Glass
2020-03-23 14:00 ` Tom Rini
0 siblings, 1 reply; 10+ messages in thread
From: Simon Glass @ 2020-03-23 1:54 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Thu, 2 Jan 2020 at 20:59, Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Jan 02, 2020 at 07:28:50PM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Thu, 2 Jan 2020 at 19:27, Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Hi Tom,
> > >
> > > On Thu, 2 Jan 2020 at 16:11, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Tue, Dec 31, 2019 at 02:28:19PM -0700, Simon Glass wrote:
> > > > > Hi Matthias,
> > > > >
> > > > > On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger@suse.com> wrote:
> > > > > >
> > > > > > Hi Simon,
> > > > > >
> > > > > > On 02/12/2019 16:45, Tom Rini wrote:
> > > > > > > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> > > > > > >
> > > > > > >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> > > > > > >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> > > > > > >> Fix this so that the U-Boot banner is printed.
> > > > > > >>
> > > > > > >> Signed-off-by: Simon Glass <sjg@chromium.org>
> > > > > > >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> > > > > > >> ---
> > > > > > >>
> > > > > > >> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> > > > > > >> 1 file changed, 8 insertions(+)
> > > > > > >>
> > > > > > >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > > >> index 36548dad62..68d03627f4 100644
> > > > > > >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > > >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > > >> @@ -19,3 +19,11 @@
> > > > > > >> &gpio {
> > > > > > >> u-boot,dm-pre-reloc;
> > > > > > >> };
> > > > > > >> +
> > > > > > >> +&uart0_gpio14 {
> > > > > > >> + u-boot,dm-pre-reloc;
> > > > > > >> +};
> > > > > > >> +
> > > > > > >> +&uart1_gpio14 {
> > > > > > >> + u-boot,dm-pre-reloc;
> > > > > > >> +};
> > > > > > >
> > > > > > > I think this is superseded by the RPi PR that I had been testing and
> > > > > > > just now pushed. Can you confirm that master is fine on your Pis as
> > > > > > > well? I gather you hit this failure doing pytest on the board, which is
> > > > > > > also how I found it. Thanks!
> > > > > > >
> > > > > >
> > > > > > Can you confirm if this is working with master branch or if we still need your
> > > > > > patch. In which situation would we need your patch then?
> > > > >
> > > > > Unfortunately with the 'next' branch I still need this patch. WIthout
> > > > > it I don't get the pre-relocation serial output and tests fail.
> > > >
> > > > Which Pi exactly? My 3B works with rpi_3_32b, rpi_3 and rpi_arm64
> > > > defconfigs and test.py.
> > >
> > > It is a rpi_3b I believe, and I am using the rpi_3_32b.
> > >
> > > When I cherry-pick the patch the banner appears but before that it
> > > doesn't. Shall I check it again?
> >
> > Actually, can you please confirm the tree you are using? I was testing
> > with -next. I wonder if I was missing a patch?
>
> I just re-confirmed by checking out current 'next' and re-running
> test.py on all of the above combinations and they pass.
I'm reviving this thread as I still have problems. I have these in config.txt:
enable_uart =1
gpu_freq=250
Have you tried with those?
Separately, on latest mainline I don't see any serial output at all
from U-Boot with this config although linux does boot. I'm taking a
look as the culprit is the ofdata commit.
Regards,
Simon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation
2020-03-23 1:54 ` Simon Glass
@ 2020-03-23 14:00 ` Tom Rini
0 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2020-03-23 14:00 UTC (permalink / raw)
To: u-boot
On Sun, Mar 22, 2020 at 07:54:25PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 2 Jan 2020 at 20:59, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Jan 02, 2020 at 07:28:50PM -0700, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Thu, 2 Jan 2020 at 19:27, Simon Glass <sjg@chromium.org> wrote:
> > > >
> > > > Hi Tom,
> > > >
> > > > On Thu, 2 Jan 2020 at 16:11, Tom Rini <trini@konsulko.com> wrote:
> > > > >
> > > > > On Tue, Dec 31, 2019 at 02:28:19PM -0700, Simon Glass wrote:
> > > > > > Hi Matthias,
> > > > > >
> > > > > > On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger@suse.com> wrote:
> > > > > > >
> > > > > > > Hi Simon,
> > > > > > >
> > > > > > > On 02/12/2019 16:45, Tom Rini wrote:
> > > > > > > > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> > > > > > > >
> > > > > > > >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> > > > > > > >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> > > > > > > >> Fix this so that the U-Boot banner is printed.
> > > > > > > >>
> > > > > > > >> Signed-off-by: Simon Glass <sjg@chromium.org>
> > > > > > > >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> > > > > > > >> ---
> > > > > > > >>
> > > > > > > >> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> > > > > > > >> 1 file changed, 8 insertions(+)
> > > > > > > >>
> > > > > > > >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > > > >> index 36548dad62..68d03627f4 100644
> > > > > > > >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > > > >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> > > > > > > >> @@ -19,3 +19,11 @@
> > > > > > > >> &gpio {
> > > > > > > >> u-boot,dm-pre-reloc;
> > > > > > > >> };
> > > > > > > >> +
> > > > > > > >> +&uart0_gpio14 {
> > > > > > > >> + u-boot,dm-pre-reloc;
> > > > > > > >> +};
> > > > > > > >> +
> > > > > > > >> +&uart1_gpio14 {
> > > > > > > >> + u-boot,dm-pre-reloc;
> > > > > > > >> +};
> > > > > > > >
> > > > > > > > I think this is superseded by the RPi PR that I had been testing and
> > > > > > > > just now pushed. Can you confirm that master is fine on your Pis as
> > > > > > > > well? I gather you hit this failure doing pytest on the board, which is
> > > > > > > > also how I found it. Thanks!
> > > > > > > >
> > > > > > >
> > > > > > > Can you confirm if this is working with master branch or if we still need your
> > > > > > > patch. In which situation would we need your patch then?
> > > > > >
> > > > > > Unfortunately with the 'next' branch I still need this patch. WIthout
> > > > > > it I don't get the pre-relocation serial output and tests fail.
> > > > >
> > > > > Which Pi exactly? My 3B works with rpi_3_32b, rpi_3 and rpi_arm64
> > > > > defconfigs and test.py.
> > > >
> > > > It is a rpi_3b I believe, and I am using the rpi_3_32b.
> > > >
> > > > When I cherry-pick the patch the banner appears but before that it
> > > > doesn't. Shall I check it again?
> > >
> > > Actually, can you please confirm the tree you are using? I was testing
> > > with -next. I wonder if I was missing a patch?
> >
> > I just re-confirmed by checking out current 'next' and re-running
> > test.py on all of the above combinations and they pass.
>
> I'm reviving this thread as I still have problems. I have these in config.txt:
>
> enable_uart =1
> gpu_freq=250
>
> Have you tried with those?
No as I only have enable_uart=1 in mine.
> Separately, on latest mainline I don't see any serial output at all
> from U-Boot with this config although linux does boot. I'm taking a
> look as the culprit is the ofdata commit.
OK, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200323/8c32220d/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-23 14:00 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 2:33 [U-Boot] [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation Simon Glass
2019-12-02 15:45 ` Tom Rini
2019-12-10 9:43 ` Matthias Brugger
2019-12-31 21:28 ` Simon Glass
2020-01-02 23:11 ` Tom Rini
2020-01-03 2:27 ` Simon Glass
2020-01-03 2:28 ` Simon Glass
2020-01-03 3:59 ` Tom Rini
2020-03-23 1:54 ` Simon Glass
2020-03-23 14:00 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.