All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH CI 2/3] drm/i915/dp: Power down sink before disable pipe/transcoder clock
Date: Mon,  2 Dec 2019 14:25:12 -0800	[thread overview]
Message-ID: <20191202222513.337777-2-jose.souza@intel.com> (raw)
In-Reply-To: <20191202222513.337777-1-jose.souza@intel.com>

Disabling pipe/transcoder clock before power down sink could cause
sink lost signal, causing it to trigger a hotplug to notify source
that link signal was lost.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index a976606d21c7..0ce06a94a27e 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3802,12 +3802,12 @@ static void intel_ddi_post_disable_dp(struct intel_encoder *encoder,
 	enum phy phy = intel_port_to_phy(dev_priv, encoder->port);
 
 	if (!is_mst) {
-		intel_ddi_disable_pipe_clock(old_crtc_state);
 		/*
 		 * Power down sink before disabling the port, otherwise we end
 		 * up getting interrupts from the sink on detecting link loss.
 		 */
 		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
+		intel_ddi_disable_pipe_clock(old_crtc_state);
 	}
 
 	intel_disable_ddi_buf(encoder, old_crtc_state);
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [Intel-gfx] [PATCH CI 2/3] drm/i915/dp: Power down sink before disable pipe/transcoder clock
Date: Mon,  2 Dec 2019 14:25:12 -0800	[thread overview]
Message-ID: <20191202222513.337777-2-jose.souza@intel.com> (raw)
Message-ID: <20191202222512.dqmzuZt_KWx1ktOE24-08P9V8sg_ggrrTqe8mvs6Zo8@z> (raw)
In-Reply-To: <20191202222513.337777-1-jose.souza@intel.com>

Disabling pipe/transcoder clock before power down sink could cause
sink lost signal, causing it to trigger a hotplug to notify source
that link signal was lost.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index a976606d21c7..0ce06a94a27e 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3802,12 +3802,12 @@ static void intel_ddi_post_disable_dp(struct intel_encoder *encoder,
 	enum phy phy = intel_port_to_phy(dev_priv, encoder->port);
 
 	if (!is_mst) {
-		intel_ddi_disable_pipe_clock(old_crtc_state);
 		/*
 		 * Power down sink before disabling the port, otherwise we end
 		 * up getting interrupts from the sink on detecting link loss.
 		 */
 		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
+		intel_ddi_disable_pipe_clock(old_crtc_state);
 	}
 
 	intel_disable_ddi_buf(encoder, old_crtc_state);
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-12-02 22:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 22:25 [PATCH CI 1/3] drm/i915/display: Check the old state to find port sync slave José Roberto de Souza
2019-12-02 22:25 ` [Intel-gfx] " José Roberto de Souza
2019-12-02 22:25 ` José Roberto de Souza [this message]
2019-12-02 22:25   ` [Intel-gfx] [PATCH CI 2/3] drm/i915/dp: Power down sink before disable pipe/transcoder clock José Roberto de Souza
2019-12-02 22:25 ` [PATCH CI 3/3] drm/i915/display/mst: Move DPMS_OFF call to post_disable José Roberto de Souza
2019-12-02 22:25   ` [Intel-gfx] " José Roberto de Souza
2019-12-03  1:09 ` ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/display: Check the old state to find port sync slave Patchwork
2019-12-03  1:09   ` [Intel-gfx] " Patchwork
2019-12-03  2:11 ` ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/display: Check the old state to find port sync slave (rev2) Patchwork
2019-12-03  2:11   ` [Intel-gfx] " Patchwork
2019-12-03  8:24 ` ✓ Fi.CI.IGT: " Patchwork
2019-12-03  8:24   ` [Intel-gfx] " Patchwork
2019-12-03 20:36   ` Souza, Jose
2019-12-03 22:08 ` [Intel-gfx] [PATCH CI 1/3] drm/i915/display: Check the old state to find port sync slave Manasi Navare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202222513.337777-2-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.