All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] cmd: pxe: Increase maximum path length
@ 2019-12-03  5:13 Ben Wolsieffer
  2019-12-05 19:42 ` Joe Hershberger
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Wolsieffer @ 2019-12-03  5:13 UTC (permalink / raw)
  To: u-boot

On NixOS, cross compiled kernels have long suffixes that cause them to
exceed the current maximum path length. The PXE/TFTP max path length is
used for extlinux.conf support as well, which is where this problem
usually manifest's itself.

Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>

---

 cmd/pxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/pxe.c b/cmd/pxe.c
index 2059975446..744cd82730 100644
--- a/cmd/pxe.c
+++ b/cmd/pxe.c
@@ -21,7 +21,7 @@
 #include "menu.h"
 #include "cli.h"
 
-#define MAX_TFTP_PATH_LEN 127
+#define MAX_TFTP_PATH_LEN 512
 
 const char *pxe_default_paths[] = {
 #ifdef CONFIG_SYS_SOC
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] cmd: pxe: Increase maximum path length
  2019-12-03  5:13 [U-Boot] [PATCH] cmd: pxe: Increase maximum path length Ben Wolsieffer
@ 2019-12-05 19:42 ` Joe Hershberger
  0 siblings, 0 replies; 3+ messages in thread
From: Joe Hershberger @ 2019-12-05 19:42 UTC (permalink / raw)
  To: u-boot

On Tue, Dec 3, 2019 at 6:35 AM Ben Wolsieffer <benwolsieffer@gmail.com> wrote:
>
> On NixOS, cross compiled kernels have long suffixes that cause them to
> exceed the current maximum path length. The PXE/TFTP max path length is
> used for extlinux.conf support as well, which is where this problem
> usually manifest's itself.
>
> Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>

We'll try it and see if it blows any memory limits.

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

>
> ---
>
>  cmd/pxe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/pxe.c b/cmd/pxe.c
> index 2059975446..744cd82730 100644
> --- a/cmd/pxe.c
> +++ b/cmd/pxe.c
> @@ -21,7 +21,7 @@
>  #include "menu.h"
>  #include "cli.h"
>
> -#define MAX_TFTP_PATH_LEN 127
> +#define MAX_TFTP_PATH_LEN 512
>
>  const char *pxe_default_paths[] = {
>  #ifdef CONFIG_SYS_SOC
> --
> 2.24.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] cmd: pxe: Increase maximum path length
@ 2019-11-28  5:07 Ben Wolsieffer
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Wolsieffer @ 2019-11-28  5:07 UTC (permalink / raw)
  To: u-boot

On NixOS, cross compiled kernels have long suffixes that cause them to
exceed the current maximum path length. The PXE/TFTP max path length is
used for extlinux.conf support as well, which is where this problem
usually manifest's itself.

Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
---
 cmd/pxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/pxe.c b/cmd/pxe.c
index 2059975446..744cd82730 100644
--- a/cmd/pxe.c
+++ b/cmd/pxe.c
@@ -21,7 +21,7 @@
 #include "menu.h"
 #include "cli.h"
 
-#define MAX_TFTP_PATH_LEN 127
+#define MAX_TFTP_PATH_LEN 512
 
 const char *pxe_default_paths[] = {
 #ifdef CONFIG_SYS_SOC
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-05 19:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03  5:13 [U-Boot] [PATCH] cmd: pxe: Increase maximum path length Ben Wolsieffer
2019-12-05 19:42 ` Joe Hershberger
  -- strict thread matches above, loose matches on Subject: below --
2019-11-28  5:07 Ben Wolsieffer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.