All of lore.kernel.org
 help / color / mirror / Atom feed
* [virtio-dev] [PATCH] virtio-gpu: add 3d command overview
@ 2019-11-29  8:31 Gerd Hoffmann
  2019-11-29 14:11 ` Matti Moell
  2019-12-02 16:58 ` Michael S. Tsirkin
  0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2019-11-29  8:31 UTC (permalink / raw)
  To: virtio-dev; +Cc: Gerd Hoffmann

Add 3d commands to the command enumeration.
Add a section with a very short overview.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 virtio-gpu.tex | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/virtio-gpu.tex b/virtio-gpu.tex
index eced3095a494..631aaf24ea18 100644
--- a/virtio-gpu.tex
+++ b/virtio-gpu.tex
@@ -213,6 +213,16 @@ \subsubsection{Device Operation: Request header}\label{sec:Device Types / GPU De
         VIRTIO_GPU_CMD_GET_EDID,
         VIRTIO_GPU_CMD_RESOURCE_CREATE_2D_SHARED,
 
+        /* 3d commands (OpenGL) */
+        VIRTIO_GPU_CMD_CTX_CREATE = 0x0200,
+        VIRTIO_GPU_CMD_CTX_DESTROY,
+        VIRTIO_GPU_CMD_CTX_ATTACH_RESOURCE,
+        VIRTIO_GPU_CMD_CTX_DETACH_RESOURCE,
+        VIRTIO_GPU_CMD_RESOURCE_CREATE_3D,
+        VIRTIO_GPU_CMD_TRANSFER_TO_HOST_3D,
+        VIRTIO_GPU_CMD_TRANSFER_FROM_HOST_3D,
+        VIRTIO_GPU_CMD_SUBMIT_3D,
+
         /* cursor commands */
         VIRTIO_GPU_CMD_UPDATE_CURSOR = 0x0300,
         VIRTIO_GPU_CMD_MOVE_CURSOR,
@@ -488,6 +498,31 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 
 \end{description}
 
+\subsubsection{Device Operation: controlq (3d)}\label{sec:Device Types / GPU Device / Device Operation / Device Operation: controlq (3d)}
+
+These commands are supported by the device if the VIRTIO_GPU_F_VIRGL
+feature flag is set.
+
+\begin{description}
+
+\item[VIRTIO_GPU_CMD_CTX_CREATE]
+\item[VIRTIO_GPU_CMD_CTX_DESTROY]
+\item[VIRTIO_GPU_CMD_CTX_ATTACH_RESOURCE]
+\item[VIRTIO_GPU_CMD_CTX_DETACH_RESOURCE]
+  Manage OpenGL contexts.
+
+\item[VIRTIO_GPU_CMD_RESOURCE_CREATE_3D]
+  Create OpenGL resources.
+
+\item[VIRTIO_GPU_CMD_TRANSFER_TO_HOST_3D]
+\item[VIRTIO_GPU_CMD_TRANSFER_FROM_HOST_3D]
+  Transfer data from and to OpenGL resources.
+
+\item[VIRTIO_GPU_CMD_SUBMIT_3D]
+  Submit rendering commands (mesa gallium command stream).
+
+\end{description}
+
 \subsubsection{Device Operation: cursorq}\label{sec:Device Types / GPU Device / Device Operation / Device Operation: cursorq}
 
 Both cursorq commands use the same command struct.
-- 
2.18.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [virtio-dev] [PATCH] virtio-gpu: add 3d command overview
  2019-11-29  8:31 [virtio-dev] [PATCH] virtio-gpu: add 3d command overview Gerd Hoffmann
@ 2019-11-29 14:11 ` Matti Moell
  2019-12-02 16:58 ` Michael S. Tsirkin
  1 sibling, 0 replies; 4+ messages in thread
From: Matti Moell @ 2019-11-29 14:11 UTC (permalink / raw)
  To: Gerd Hoffmann, virtio-dev

On 29.11.19 09:31, Gerd Hoffmann wrote:
> Add 3d commands to the command enumeration.
> Add a section with a very short overview.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Matti Möll <Matti.Moell@opensynergy.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [virtio-dev] [PATCH] virtio-gpu: add 3d command overview
  2019-11-29  8:31 [virtio-dev] [PATCH] virtio-gpu: add 3d command overview Gerd Hoffmann
  2019-11-29 14:11 ` Matti Moell
@ 2019-12-02 16:58 ` Michael S. Tsirkin
  2019-12-03  9:37   ` Gerd Hoffmann
  1 sibling, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2019-12-02 16:58 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: virtio-dev

On Fri, Nov 29, 2019 at 09:31:30AM +0100, Gerd Hoffmann wrote:
> Add 3d commands to the command enumeration.
> Add a section with a very short overview.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Pls don't forget to create github issues and request
voting when you are ready.

> ---
>  virtio-gpu.tex | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/virtio-gpu.tex b/virtio-gpu.tex
> index eced3095a494..631aaf24ea18 100644
> --- a/virtio-gpu.tex
> +++ b/virtio-gpu.tex
> @@ -213,6 +213,16 @@ \subsubsection{Device Operation: Request header}\label{sec:Device Types / GPU De
>          VIRTIO_GPU_CMD_GET_EDID,
>          VIRTIO_GPU_CMD_RESOURCE_CREATE_2D_SHARED,
>  
> +        /* 3d commands (OpenGL) */
> +        VIRTIO_GPU_CMD_CTX_CREATE = 0x0200,
> +        VIRTIO_GPU_CMD_CTX_DESTROY,
> +        VIRTIO_GPU_CMD_CTX_ATTACH_RESOURCE,
> +        VIRTIO_GPU_CMD_CTX_DETACH_RESOURCE,
> +        VIRTIO_GPU_CMD_RESOURCE_CREATE_3D,
> +        VIRTIO_GPU_CMD_TRANSFER_TO_HOST_3D,
> +        VIRTIO_GPU_CMD_TRANSFER_FROM_HOST_3D,
> +        VIRTIO_GPU_CMD_SUBMIT_3D,
> +
>          /* cursor commands */
>          VIRTIO_GPU_CMD_UPDATE_CURSOR = 0x0300,
>          VIRTIO_GPU_CMD_MOVE_CURSOR,
> @@ -488,6 +498,31 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
>  
>  \end{description}
>  
> +\subsubsection{Device Operation: controlq (3d)}\label{sec:Device Types / GPU Device / Device Operation / Device Operation: controlq (3d)}
> +
> +These commands are supported by the device if the VIRTIO_GPU_F_VIRGL
> +feature flag is set.
> +
> +\begin{description}
> +
> +\item[VIRTIO_GPU_CMD_CTX_CREATE]
> +\item[VIRTIO_GPU_CMD_CTX_DESTROY]
> +\item[VIRTIO_GPU_CMD_CTX_ATTACH_RESOURCE]
> +\item[VIRTIO_GPU_CMD_CTX_DETACH_RESOURCE]
> +  Manage OpenGL contexts.
> +
> +\item[VIRTIO_GPU_CMD_RESOURCE_CREATE_3D]
> +  Create OpenGL resources.
> +
> +\item[VIRTIO_GPU_CMD_TRANSFER_TO_HOST_3D]
> +\item[VIRTIO_GPU_CMD_TRANSFER_FROM_HOST_3D]
> +  Transfer data from and to OpenGL resources.
> +
> +\item[VIRTIO_GPU_CMD_SUBMIT_3D]
> +  Submit rendering commands (mesa gallium command stream).
> +
> +\end{description}
> +
>  \subsubsection{Device Operation: cursorq}\label{sec:Device Types / GPU Device / Device Operation / Device Operation: cursorq}
>  
>  Both cursorq commands use the same command struct.
> -- 
> 2.18.1
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [virtio-dev] [PATCH] virtio-gpu: add 3d command overview
  2019-12-02 16:58 ` Michael S. Tsirkin
@ 2019-12-03  9:37   ` Gerd Hoffmann
  0 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2019-12-03  9:37 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: virtio-dev

On Mon, Dec 02, 2019 at 11:58:51AM -0500, Michael S. Tsirkin wrote:
> On Fri, Nov 29, 2019 at 09:31:30AM +0100, Gerd Hoffmann wrote:
> > Add 3d commands to the command enumeration.
> > Add a section with a very short overview.
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Pls don't forget to create github issues and request
> voting when you are ready.

Sure, just wanted people give some time to comment before
opening an issue.

https://github.com/oasis-tcs/virtio-spec/issues/65

cheers,
  Gerd


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-12-03  9:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29  8:31 [virtio-dev] [PATCH] virtio-gpu: add 3d command overview Gerd Hoffmann
2019-11-29 14:11 ` Matti Moell
2019-12-02 16:58 ` Michael S. Tsirkin
2019-12-03  9:37   ` Gerd Hoffmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.