* [Xen-devel] [PATCH 0/2] automation: improve tests
@ 2019-12-03 10:33 Roger Pau Monne
2019-12-03 10:33 ` [Xen-devel] [PATCH 1/2] automation: add timestamps to Xen tests Roger Pau Monne
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Roger Pau Monne @ 2019-12-03 10:33 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Doug Goldstein, Jan Beulich,
Ian Jackson, Roger Pau Monne
Hello,
Small series to improve the automated tests, first patch enables Xen
console timestamps and the second one increases the test timeout to 30s
since the clang PVH tests already takes ~10s without taking into account
the time to initialize QEMU.
Thanks, Roger.
Roger Pau Monne (2):
automation: add timestamps to Xen tests
automation: increase tests maximum time from 10s to 30s
automation/scripts/qemu-smoke-x86-64.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.24.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Xen-devel] [PATCH 1/2] automation: add timestamps to Xen tests
2019-12-03 10:33 [Xen-devel] [PATCH 0/2] automation: improve tests Roger Pau Monne
@ 2019-12-03 10:33 ` Roger Pau Monne
2019-12-03 11:24 ` Wei Liu
2019-12-03 10:33 ` [Xen-devel] [PATCH 2/2] automation: increase tests maximum time from 10s to 30s Roger Pau Monne
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Roger Pau Monne @ 2019-12-03 10:33 UTC (permalink / raw)
To: xen-devel; +Cc: Doug Goldstein, Roger Pau Monne
Enable Xen timestamps in the automated Xen tests, this is helpful in
order to figure out if Xen is stuck or just slow in the automated
tests.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
automation/scripts/qemu-smoke-x86-64.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/automation/scripts/qemu-smoke-x86-64.sh b/automation/scripts/qemu-smoke-x86-64.sh
index 5fa3a63dbd..f38eacfd9f 100755
--- a/automation/scripts/qemu-smoke-x86-64.sh
+++ b/automation/scripts/qemu-smoke-x86-64.sh
@@ -24,7 +24,8 @@ set +e
timeout -k 1 10 \
qemu-system-x86_64 -nographic -kernel binaries/xen \
-initrd xtf/tests/example/$k \
- -append "loglvl=all com1=115200,,8n1 console=com1 noreboot $extra" \
+ -append "loglvl=all com1=115200,,8n1 console=com1 noreboot \
+ console_timestamps=boot $extra" \
-m 512 -monitor none -serial file:smoke.serial
set -e
grep -q 'Test result: SUCCESS' smoke.serial || exit 1
--
2.24.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Xen-devel] [PATCH 2/2] automation: increase tests maximum time from 10s to 30s
2019-12-03 10:33 [Xen-devel] [PATCH 0/2] automation: improve tests Roger Pau Monne
2019-12-03 10:33 ` [Xen-devel] [PATCH 1/2] automation: add timestamps to Xen tests Roger Pau Monne
@ 2019-12-03 10:33 ` Roger Pau Monne
2019-12-03 11:23 ` Wei Liu
2019-12-03 10:37 ` [Xen-devel] [PATCH 0/2] automation: improve tests Andrew Cooper
2019-12-03 13:20 ` Jürgen Groß
3 siblings, 1 reply; 7+ messages in thread
From: Roger Pau Monne @ 2019-12-03 10:33 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Jan Beulich,
Doug Goldstein, Roger Pau Monne
10s is too low for the clang tests, this is the output from a clang
test:
(XEN) [ 6.512748] ***************************************************
(XEN) [ 6.513323] SELFTEST FAILURE: CORRECT BEHAVIOR CANNOT BE GUARANTEED
(XEN) [ 6.513891] ***************************************************
(XEN) [ 6.514469] 3... 2... 1...
(XEN) [ 9.520011] *** Serial input to DOM0 (type 'CTRL-a' three times to switch input)
(XEN) [ 9.544319] Freed 488kB init memory
--- Xen Test Framework ---
Environment: HVM 32bit (PAE 3 levels)
Hello World
Test result: SUCCESS
(XEN) [ 9.610977] Hardware Dom0 halted: halting machine
As can be seen from the output above booting Xen and the XTF test
takes ~10s, without accounting for the time it takes for QEMU to
initialize.
Increase the timeout to 30s to be on the safe side.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
automation/scripts/qemu-smoke-x86-64.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/automation/scripts/qemu-smoke-x86-64.sh b/automation/scripts/qemu-smoke-x86-64.sh
index f38eacfd9f..09152e3e9c 100755
--- a/automation/scripts/qemu-smoke-x86-64.sh
+++ b/automation/scripts/qemu-smoke-x86-64.sh
@@ -21,7 +21,7 @@ esac
rm -f smoke.serial
set +e
-timeout -k 1 10 \
+timeout -k 1 30 \
qemu-system-x86_64 -nographic -kernel binaries/xen \
-initrd xtf/tests/example/$k \
-append "loglvl=all com1=115200,,8n1 console=com1 noreboot \
--
2.24.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 0/2] automation: improve tests
2019-12-03 10:33 [Xen-devel] [PATCH 0/2] automation: improve tests Roger Pau Monne
2019-12-03 10:33 ` [Xen-devel] [PATCH 1/2] automation: add timestamps to Xen tests Roger Pau Monne
2019-12-03 10:33 ` [Xen-devel] [PATCH 2/2] automation: increase tests maximum time from 10s to 30s Roger Pau Monne
@ 2019-12-03 10:37 ` Andrew Cooper
2019-12-03 13:20 ` Jürgen Groß
3 siblings, 0 replies; 7+ messages in thread
From: Andrew Cooper @ 2019-12-03 10:37 UTC (permalink / raw)
To: Roger Pau Monne, xen-devel
Cc: Juergen Gross, Stefano Stabellini, Julien Grall, Wei Liu,
Konrad Rzeszutek Wilk, George Dunlap, Doug Goldstein,
Ian Jackson, Jan Beulich
On 03/12/2019 10:33, Roger Pau Monne wrote:
> Hello,
>
> Small series to improve the automated tests, first patch enables Xen
> console timestamps and the second one increases the test timeout to 30s
> since the clang PVH tests already takes ~10s without taking into account
> the time to initialize QEMU.
>
> Thanks, Roger.
>
> Roger Pau Monne (2):
> automation: add timestamps to Xen tests
> automation: increase tests maximum time from 10s to 30s
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC Juergen for a view towards 4.13
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 2/2] automation: increase tests maximum time from 10s to 30s
2019-12-03 10:33 ` [Xen-devel] [PATCH 2/2] automation: increase tests maximum time from 10s to 30s Roger Pau Monne
@ 2019-12-03 11:23 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2019-12-03 11:23 UTC (permalink / raw)
To: Roger Pau Monne
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Jan Beulich,
Xen-devel, Doug Goldstein
On Tue, 3 Dec 2019 at 10:34, Roger Pau Monne <roger.pau@citrix.com> wrote:
>
> 10s is too low for the clang tests, this is the output from a clang
> test:
>
> (XEN) [ 6.512748] ***************************************************
> (XEN) [ 6.513323] SELFTEST FAILURE: CORRECT BEHAVIOR CANNOT BE GUARANTEED
> (XEN) [ 6.513891] ***************************************************
> (XEN) [ 6.514469] 3... 2... 1...
> (XEN) [ 9.520011] *** Serial input to DOM0 (type 'CTRL-a' three times to switch input)
> (XEN) [ 9.544319] Freed 488kB init memory
> --- Xen Test Framework ---
> Environment: HVM 32bit (PAE 3 levels)
> Hello World
> Test result: SUCCESS
> (XEN) [ 9.610977] Hardware Dom0 halted: halting machine
>
> As can be seen from the output above booting Xen and the XTF test
> takes ~10s, without accounting for the time it takes for QEMU to
> initialize.
>
> Increase the timeout to 30s to be on the safe side.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wl@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 1/2] automation: add timestamps to Xen tests
2019-12-03 10:33 ` [Xen-devel] [PATCH 1/2] automation: add timestamps to Xen tests Roger Pau Monne
@ 2019-12-03 11:24 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2019-12-03 11:24 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: Xen-devel, Doug Goldstein
On Tue, 3 Dec 2019 at 10:35, Roger Pau Monne <roger.pau@citrix.com> wrote:
>
> Enable Xen timestamps in the automated Xen tests, this is helpful in
> order to figure out if Xen is stuck or just slow in the automated
> tests.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wl@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 0/2] automation: improve tests
2019-12-03 10:33 [Xen-devel] [PATCH 0/2] automation: improve tests Roger Pau Monne
` (2 preceding siblings ...)
2019-12-03 10:37 ` [Xen-devel] [PATCH 0/2] automation: improve tests Andrew Cooper
@ 2019-12-03 13:20 ` Jürgen Groß
3 siblings, 0 replies; 7+ messages in thread
From: Jürgen Groß @ 2019-12-03 13:20 UTC (permalink / raw)
To: Roger Pau Monne, xen-devel
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Doug Goldstein, Jan Beulich,
Ian Jackson
On 03.12.19 11:33, Roger Pau Monne wrote:
> Hello,
>
> Small series to improve the automated tests, first patch enables Xen
> console timestamps and the second one increases the test timeout to 30s
> since the clang PVH tests already takes ~10s without taking into account
> the time to initialize QEMU.
>
> Thanks, Roger.
>
> Roger Pau Monne (2):
> automation: add timestamps to Xen tests
> automation: increase tests maximum time from 10s to 30s
>
> automation/scripts/qemu-smoke-x86-64.sh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
For the series:
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-03 13:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 10:33 [Xen-devel] [PATCH 0/2] automation: improve tests Roger Pau Monne
2019-12-03 10:33 ` [Xen-devel] [PATCH 1/2] automation: add timestamps to Xen tests Roger Pau Monne
2019-12-03 11:24 ` Wei Liu
2019-12-03 10:33 ` [Xen-devel] [PATCH 2/2] automation: increase tests maximum time from 10s to 30s Roger Pau Monne
2019-12-03 11:23 ` Wei Liu
2019-12-03 10:37 ` [Xen-devel] [PATCH 0/2] automation: improve tests Andrew Cooper
2019-12-03 13:20 ` Jürgen Groß
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.