[igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add igt_connector_sysfs_open()

[igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add igt_connector_sysfs_open()

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Add a helper to open the sysfs directory for a connector.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_kms.c | 34 ++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  3 +++
 2 files changed, 37 insertions(+)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 44647a2263bd..74ae98d774f1 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -965,6 +965,40 @@ static void reset_connectors_at_exit(int sig)
 	igt_reset_connectors();
 }
 
+static char *kmstest_connector_dirname(int idx,
+				       uint32_t connector_type,
+				       uint32_t connector_type_id,
+				       char *name, int namelen)
+{
+	snprintf(name, namelen, "card%d-%s-%d", idx,
+		 kmstest_connector_type_str(connector_type),
+		 connector_type_id);
+
+	return name;
+}
+
+int igt_connector_sysfs_open(int drm_fd,
+			     drmModeConnector *connector)
+{
+	char name[80];
+	int dir, conn_dir;
+
+	dir = igt_sysfs_open(drm_fd);
+	if (dir < 0)
+		return dir;
+
+	if (!kmstest_connector_dirname(igt_device_get_card_index(drm_fd),
+				       connector->connector_type,
+				       connector->connector_type_id,
+				       name, sizeof(name)))
+		return -1;
+
+	conn_dir = openat(dir, name, O_RDONLY);
+	close(dir);
+
+	return conn_dir;
+}
+
 /**
  * kmstest_force_connector:
  * @fd: drm file descriptor
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 3f798392f8a0..6c919e92f488 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -844,4 +844,7 @@ static inline bool igt_vblank_before(uint32_t a, uint32_t b)
 void igt_parse_connector_tile_blob(drmModePropertyBlobPtr blob,
 		igt_tile_info_t *tile);
 
+int igt_connector_sysfs_open(int drm_fd,
+			     drmModeConnector *connector);
+
 #endif /* __IGT_KMS_H__ */
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/4] lib/igt_kms: Don't leak fds when forcing connector multiple times

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Close the new sysfs directory fd when we've already forced
the same connector previously. Currently we're leaking the fd.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_kms.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 74ae98d774f1..ba1657d06d45 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1075,6 +1075,8 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
 	if (len != -1 && len < MAX_CONNECTORS) {
 		forced_connectors[len] = path;
 		forced_connectors_device[len] = dir;
+	} else {
+		close(dir);
 	}
 
 	if (len >= MAX_CONNECTORS)
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/4] lib/igt_kms: Rework forced connector handling

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Let's use igt_connector_sysfs_open() for connector forcing.
Since we're getting rid of the allcoated connector 'path' we'll
change the tracking to use the connector type and type_id,
and we'll chop things up a bit to make the code easier to follow.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_kms.c | 150 ++++++++++++++++++++++++++++++++------------------
 1 file changed, 96 insertions(+), 54 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index ba1657d06d45..06fff0261b47 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -84,8 +84,12 @@
 
 /* list of connectors that need resetting on exit */
 #define MAX_CONNECTORS 32
-static char *forced_connectors[MAX_CONNECTORS + 1];
-static int forced_connectors_device[MAX_CONNECTORS + 1];
+static struct {
+	uint32_t connector_type;
+	uint32_t connector_type_id;
+	int idx;
+	int dir;
+} forced_connectors[MAX_CONNECTORS + 1];
 
 /**
  * igt_kms_get_base_edid:
@@ -999,6 +1003,92 @@ int igt_connector_sysfs_open(int drm_fd,
 	return conn_dir;
 }
 
+static bool connector_is_forced(int idx, drmModeConnector *connector)
+{
+	igt_assert(connector->connector_type != 0);
+
+	for (int i = 0; forced_connectors[i].connector_type; i++) {
+		if (forced_connectors[i].idx == idx &&
+		    forced_connectors[i].connector_type == connector->connector_type &&
+		    forced_connectors[i].connector_type_id == connector->connector_type_id)
+			return true;
+	}
+
+	return false;
+}
+
+static int forced_connector_free_index(void)
+{
+	int i;
+
+	for (i = 0; forced_connectors[i].connector_type; i++)
+		;
+
+	return i < ARRAY_SIZE(forced_connectors) ? i : -1;
+}
+
+static bool force_connector(int drm_fd,
+			    drmModeConnector *connector,
+			    const char *value)
+{
+	char name[80];
+	int i, idx, dir;
+
+	idx = igt_device_get_card_index(drm_fd);
+	if (idx < 0 || idx > 63)
+		return false;
+
+	kmstest_connector_dirname(idx, connector->connector_type,
+				  connector->connector_type_id,
+				  name, sizeof(name));
+
+	dir = igt_connector_sysfs_open(drm_fd, connector);
+	if (dir < 0)
+		return false;
+
+	if (!igt_sysfs_set(dir, "status", value)) {
+		close(dir);
+		return false;
+	}
+
+	igt_debug("Connector %s is now forced %s\n", name, value);
+
+	/* already tracked? */
+	if (connector_is_forced(idx, connector)) {
+		close(dir);
+		return true;
+	}
+
+	i = forced_connector_free_index();
+	if (i < 0) {
+		igt_warn("Connector limit reached, %s will not be reset\n", name);
+		close(dir);
+		return true;
+	}
+
+	forced_connectors[i].idx = idx;
+	forced_connectors[i].connector_type = connector->connector_type;
+	forced_connectors[i].connector_type_id = connector->connector_type_id;
+	forced_connectors[i].dir = dir;
+
+	return true;
+}
+
+static void dump_forced_connectors(void)
+{
+	char name[80];
+
+	igt_debug("Current forced connectors:\n");
+
+	for (int i = 0; forced_connectors[i].connector_type; i++) {
+		kmstest_connector_dirname(forced_connectors[i].idx,
+					  forced_connectors[i].connector_type,
+					  forced_connectors[i].connector_type_id,
+					  name, sizeof(name));
+		igt_debug("\t%s\n", name);
+	}
+}
+
 /**
  * kmstest_force_connector:
  * @fd: drm file descriptor
@@ -1012,10 +1102,8 @@ int igt_connector_sysfs_open(int drm_fd,
 bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
 			     enum kmstest_force_connector_state state)
 {
-	char *path, **tmp;
 	const char *value;
 	drmModeConnector *temp;
-	int len, dir, idx;
 
 	/*
 	 * Forcing DP connectors doesn't currently work, so
@@ -1042,54 +1130,10 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
 		break;
 	}
 
-	dir = igt_sysfs_open(drm_fd);
-	if (dir < 0)
+	if (!force_connector(drm_fd, connector, value))
 		return false;
 
-	idx = igt_device_get_card_index(drm_fd);
-	if (idx < 0 || idx > 63)
-		return false;
-
-	if (asprintf(&path, "card%d-%s-%d/status",
-		     idx,
-		     kmstest_connector_type_str(connector->connector_type),
-		     connector->connector_type_id) < 0) {
-		close(dir);
-		return false;
-	}
-
-	if (!igt_sysfs_set(dir, path, value)) {
-		close(dir);
-		return false;
-	}
-
-	for (len = 0, tmp = forced_connectors; *tmp; tmp++) {
-		/* check the connector is not already present */
-		if (strcmp(*tmp, path) == 0) {
-			len = -1;
-			break;
-		}
-		len++;
-	}
-
-	if (len != -1 && len < MAX_CONNECTORS) {
-		forced_connectors[len] = path;
-		forced_connectors_device[len] = dir;
-	} else {
-		close(dir);
-	}
-
-	if (len >= MAX_CONNECTORS)
-		igt_warn("Connector limit reached, %s will not be reset\n",
-			 path);
-
-	igt_debug("Connector %s is now forced %s\n", path, value);
-	igt_debug("Current forced connectors:\n");
-	tmp = forced_connectors;
-	while (*tmp) {
-		igt_debug("\t%s\n", *tmp);
-		tmp++;
-	}
+	dump_forced_connectors();
 
 	igt_install_exit_handler(reset_connectors_at_exit);
 
@@ -4069,10 +4113,8 @@ void igt_reset_connectors(void)
 {
 	/* reset the connectors stored in forced_connectors, avoiding any
 	 * functions that are not safe to call in signal handlers */
-	for (int i = 0; forced_connectors[i]; i++)
-		igt_sysfs_set(forced_connectors_device[i],
-			      forced_connectors[i],
-			      "detect");
+	for (int i = 0; i < forced_connectors[i].connector_type; i++)
+		igt_sysfs_set(forced_connectors[i].dir, "status",  "detect");
 }
 
 /**
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 4/4] tests/kms_dp_aux_dev: Add drm_dp_aux test

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Add a basic test for /dev/drm_dp_aux. We just try to read 16 bytes
from each connector's aux device, and if succesful we do a few
quick sanity checks on the data.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/Makefile.sources |   1 +
 tests/kms_dp_aux_dev.c | 117 +++++++++++++++++++++++++++++++++++++++++
 tests/meson.build      |   1 +
 3 files changed, 119 insertions(+)
 create mode 100644 tests/kms_dp_aux_dev.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 17980ed607d1..1d37228655e4 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -42,6 +42,7 @@ TESTS_progs = \
 	kms_cursor_crc \
 	kms_cursor_edge_walk \
 	kms_cursor_legacy \
+	kms_dp_aux_dev \
 	kms_dp_dsc \
 	kms_dp_tiled_display \
 	kms_draw_crc \
diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
new file mode 100644
index 000000000000..8db85899cf4d
--- /dev/null
+++ b/tests/kms_dp_aux_dev.c
@@ -0,0 +1,117 @@
+/*
+ * Copyright © 2019 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include "config.h"
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <dirent.h>
+
+#include "igt.h"
+#include "igt_kms.h"
+
+IGT_TEST_DESCRIPTION("Test that /dev/drm_dp_aux reads work");
+
+static bool test(int drm_fd, uint32_t connector_id)
+{
+	drmModeConnector *connector;
+	DIR *dir;
+	int dir_fd;
+
+	connector = drmModeGetConnectorCurrent(drm_fd, connector_id);
+	dir_fd = igt_connector_sysfs_open(drm_fd, connector);
+	drmModeFreeConnector(connector);
+	igt_assert(dir_fd >= 0);
+
+	dir = fdopendir(dir_fd);
+	igt_assert(dir);
+
+	for (;;) {
+		struct dirent *ent;
+		char path[5 + sizeof(ent->d_name)];
+		uint8_t buf[16];
+		int fd, ret;
+
+		ent = readdir(dir);
+		if (!ent)
+			break;
+
+		if (strncmp(ent->d_name, "drm_dp_aux", 10))
+			continue;
+
+		snprintf(path, sizeof(path), "/dev/%s", ent->d_name);
+
+		fd = open(path, O_RDONLY);
+		igt_assert(fd >= 0);
+
+		ret = read(fd, buf, sizeof(buf));
+		igt_assert(ret == sizeof(buf) || errno == ETIMEDOUT);
+
+		igt_info("%s: %s\n", path,
+			 ret > 0 ? "success" : "timed out");
+
+		close(fd);
+
+		closedir(dir);
+		close(dir_fd);
+
+		if (ret > 0) {
+			/* DPCD rev sanity check */
+			igt_assert(buf[0] == 0x10 ||
+				   buf[0] == 0x11 ||
+				   buf[0] == 0x12 ||
+				   buf[0] == 0x13 ||
+				   buf[0] == 0x14);
+			/* DPCD max lane count sanity check */
+			igt_assert((buf[2] & 0x1f) == 0x01 ||
+				   (buf[2] & 0x1f) == 0x02 ||
+				   (buf[2] & 0x1f) == 0x04);
+		}
+
+		return ret > 0;
+	}
+
+	closedir(dir);
+	close(dir_fd);
+	return false;
+}
+
+igt_simple_main
+{
+	int valid_connectors = 0;
+	drmModeRes *res;
+	int drm_fd;
+
+	drm_fd = drm_open_driver_master(DRIVER_ANY);
+
+	res = drmModeGetResources(drm_fd);
+	igt_require(res);
+
+	for (int i = 0; i < res->count_connectors; i++)
+		valid_connectors += test(drm_fd, res->connectors[i]);
+	igt_require(valid_connectors);
+
+	drmModeFreeResources(res);
+}
diff --git a/tests/meson.build b/tests/meson.build
index 0b15609c2558..dceea8ef9fec 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -26,6 +26,7 @@ test_progs = [
 	'kms_cursor_crc',
 	'kms_cursor_edge_walk',
 	'kms_cursor_legacy',
+	'kms_dp_aux_dev',
 	'kms_dp_dsc',
 	'kms_dp_tiled_display',
 	'kms_draw_crc',
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_kms: Add igt_connector_sysfs_open()

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/4] lib/igt_kms: Add igt_connector_sysfs_open()
URL   : https://patchwork.freedesktop.org/series/70381/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7471 -> IGTPW_3802
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/index.html

Known issues
------------

  Here are the changes found in IGTPW_3802 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-lmem:        [PASS][1] -> [DMESG-WARN][2] ([i915#592])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [PASS][3] -> [FAIL][4] ([i915#49])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_blt:
    - fi-apl-guc:         [DMESG-WARN][5] -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-apl-guc/igt@i915_selftest@live_blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-apl-guc/igt@i915_selftest@live_blt.html
    - fi-bsw-n3050:       [DMESG-FAIL][7] ([i915#563]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-bsw-n3050/igt@i915_selftest@live_blt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-bsw-n3050/igt@i915_selftest@live_blt.html
    - fi-bwr-2160:        [INCOMPLETE][9] ([i915#695]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-bwr-2160/igt@i915_selftest@live_blt.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-bwr-2160/igt@i915_selftest@live_blt.html
    - fi-bsw-nick:        [DMESG-FAIL][11] ([i915#563]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-bsw-nick/igt@i915_selftest@live_blt.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-bsw-nick/igt@i915_selftest@live_blt.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-icl-u2:          [FAIL][13] ([fdo#109635]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][15] ([fdo#111096] / [i915#323]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-kbl-x1275:       [DMESG-WARN][17] ([fdo#107139] / [i915#62] / [i915#92]) -> [DMESG-WARN][18] ([fdo#107139] / [i915#62] / [i915#92] / [i915#95])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-kbl-x1275:       [SKIP][19] ([fdo#109271]) -> [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-x1275:       [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][22] ([i915#62] / [i915#92]) +4 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-kbl-x1275:       [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
  [i915#591]: https://gitlab.freedesktop.org/drm/intel/issues/591
  [i915#592]: https://gitlab.freedesktop.org/drm/intel/issues/592
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#695]: https://gitlab.freedesktop.org/drm/intel/issues/695
  [i915#710]: https://gitlab.freedesktop.org/drm/intel/issues/710
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (50 -> 45)
------------------------------

  Missing    (5): fi-ilk-m540 fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5323 -> IGTPW_3802

  CI-20190529: 20190529
  CI_DRM_7471: 7187e860071abd027d6eeaecc0674becc137e939 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3802: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/index.html
  IGT_5323: b0f877d06a78b9c38ed246be2537a0453b6c214f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@kms_dp_aux_dev

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add igt_connector_sysfs_open()

[Chris Wilson]

Quoting Ville Syrjala (2019-12-03 15:35:52)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Add a helper to open the sysfs directory for a connector.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  lib/igt_kms.c | 34 ++++++++++++++++++++++++++++++++++
>  lib/igt_kms.h |  3 +++
>  2 files changed, 37 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 44647a2263bd..74ae98d774f1 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -965,6 +965,40 @@ static void reset_connectors_at_exit(int sig)
>         igt_reset_connectors();
>  }
>  
> +static char *kmstest_connector_dirname(int idx,
> +                                      uint32_t connector_type,
> +                                      uint32_t connector_type_id,
> +                                      char *name, int namelen)
> +{
> +       snprintf(name, namelen, "card%d-%s-%d", idx,
> +                kmstest_connector_type_str(connector_type),
> +                connector_type_id);
> +
> +       return name;
> +}
> +
> +int igt_connector_sysfs_open(int drm_fd,
> +                            drmModeConnector *connector)
> +{
> +       char name[80];
> +       int dir, conn_dir;
> +
> +       dir = igt_sysfs_open(drm_fd);
> +       if (dir < 0)
> +               return dir;
> +
> +       if (!kmstest_connector_dirname(igt_device_get_card_index(drm_fd),
> +                                      connector->connector_type,
> +                                      connector->connector_type_id,
> +                                      name, sizeof(name)))
> +               return -1;

Before igt_sysfs_open() or close(dir);

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/4] lib/igt_kms: Don't leak fds when forcing connector multiple times

[Chris Wilson]

Quoting Ville Syrjala (2019-12-03 15:35:53)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Close the new sysfs directory fd when we've already forced
> the same connector previously. Currently we're leaking the fd.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  lib/igt_kms.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 74ae98d774f1..ba1657d06d45 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1075,6 +1075,8 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
>         if (len != -1 && len < MAX_CONNECTORS) {
>                 forced_connectors[len] = path;
>                 forced_connectors_device[len] = dir;
> +       } else {
> +               close(dir);
>         }

On igt_device_get_card_index() fail there's also a leak.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 3/4] lib/igt_kms: Rework forced connector handling

[Chris Wilson]

Quoting Ville Syrjala (2019-12-03 15:35:54)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Let's use igt_connector_sysfs_open() for connector forcing.
> Since we're getting rid of the allcoated connector 'path' we'll
> change the tracking to use the connector type and type_id,
> and we'll chop things up a bit to make the code easier to follow.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 4/4] tests/kms_dp_aux_dev: Add drm_dp_aux test

[Chris Wilson]

Quoting Ville Syrjala (2019-12-03 15:35:55)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Add a basic test for /dev/drm_dp_aux. We just try to read 16 bytes
> from each connector's aux device, and if succesful we do a few
> quick sanity checks on the data.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  tests/Makefile.sources |   1 +
>  tests/kms_dp_aux_dev.c | 117 +++++++++++++++++++++++++++++++++++++++++
>  tests/meson.build      |   1 +
>  3 files changed, 119 insertions(+)
>  create mode 100644 tests/kms_dp_aux_dev.c
> 
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 17980ed607d1..1d37228655e4 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -42,6 +42,7 @@ TESTS_progs = \
>         kms_cursor_crc \
>         kms_cursor_edge_walk \
>         kms_cursor_legacy \
> +       kms_dp_aux_dev \
>         kms_dp_dsc \
>         kms_dp_tiled_display \
>         kms_draw_crc \
> diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
> new file mode 100644
> index 000000000000..8db85899cf4d
> --- /dev/null
> +++ b/tests/kms_dp_aux_dev.c
> @@ -0,0 +1,117 @@
> +/*
> + * Copyright © 2019 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + */
> +
> +#include "config.h"
> +
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +#include <fcntl.h>
> +#include <dirent.h>
> +
> +#include "igt.h"
> +#include "igt_kms.h"
> +
> +IGT_TEST_DESCRIPTION("Test that /dev/drm_dp_aux reads work");
> +
> +static bool test(int drm_fd, uint32_t connector_id)
> +{
> +       drmModeConnector *connector;
> +       DIR *dir;
> +       int dir_fd;
> +
> +       connector = drmModeGetConnectorCurrent(drm_fd, connector_id);
> +       dir_fd = igt_connector_sysfs_open(drm_fd, connector);
> +       drmModeFreeConnector(connector);
> +       igt_assert(dir_fd >= 0);
> +
> +       dir = fdopendir(dir_fd);
> +       igt_assert(dir);
> +
> +       for (;;) {
> +               struct dirent *ent;
> +               char path[5 + sizeof(ent->d_name)];
> +               uint8_t buf[16];
> +               int fd, ret;
> +
> +               ent = readdir(dir);
> +               if (!ent)
> +                       break;
> +
> +               if (strncmp(ent->d_name, "drm_dp_aux", 10))
> +                       continue;

So find the drm_dp_aux name for this connector and open it in /dev/

> +               snprintf(path, sizeof(path), "/dev/%s", ent->d_name);
> +
> +               fd = open(path, O_RDONLY);
> +               igt_assert(fd >= 0);
> +
> +               ret = read(fd, buf, sizeof(buf));
> +               igt_assert(ret == sizeof(buf) || errno == ETIMEDOUT);
> +
> +               igt_info("%s: %s\n", path,
> +                        ret > 0 ? "success" : "timed out");

Expect to be able to read 16 bytes.

> +
> +               close(fd);
> +
> +               closedir(dir);
> +               close(dir_fd);
> +
> +               if (ret > 0) {
> +                       /* DPCD rev sanity check */
> +                       igt_assert(buf[0] == 0x10 ||
> +                                  buf[0] == 0x11 ||
> +                                  buf[0] == 0x12 ||
> +                                  buf[0] == 0x13 ||
> +                                  buf[0] == 0x14);
> +                       /* DPCD max lane count sanity check */
> +                       igt_assert((buf[2] & 0x1f) == 0x01 ||
> +                                  (buf[2] & 0x1f) == 0x02 ||
> +                                  (buf[2] & 0x1f) == 0x04);

I believe you.

Might be worth using igt_assert_f() as I doubt these will make much
sense if they ever fail.

> +               }
> +
> +               return ret > 0;

Only care about drm_dp_aux, and there should only be one.
> +       }
> +
> +       closedir(dir);
> +       close(dir_fd);
> +       return false;
> +}
> +
> +igt_simple_main
> +{
> +       int valid_connectors = 0;
> +       drmModeRes *res;
> +       int drm_fd;
> +
> +       drm_fd = drm_open_driver_master(DRIVER_ANY);
> +
> +       res = drmModeGetResources(drm_fd);
> +       igt_require(res);
> +
> +       for (int i = 0; i < res->count_connectors; i++)
> +               valid_connectors += test(drm_fd, res->connectors[i]);
> +       igt_require(valid_connectors);
> +
> +       drmModeFreeResources(res);

I was able to follow along, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 4/4] tests/kms_dp_aux_dev: Add drm_dp_aux test

[Ville Syrjälä]

On Tue, Dec 03, 2019 at 04:32:15PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2019-12-03 15:35:55)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Add a basic test for /dev/drm_dp_aux. We just try to read 16 bytes
> > from each connector's aux device, and if succesful we do a few
> > quick sanity checks on the data.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  tests/Makefile.sources |   1 +
> >  tests/kms_dp_aux_dev.c | 117 +++++++++++++++++++++++++++++++++++++++++
> >  tests/meson.build      |   1 +
> >  3 files changed, 119 insertions(+)
> >  create mode 100644 tests/kms_dp_aux_dev.c
> > 
> > diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> > index 17980ed607d1..1d37228655e4 100644
> > --- a/tests/Makefile.sources
> > +++ b/tests/Makefile.sources
> > @@ -42,6 +42,7 @@ TESTS_progs = \
> >         kms_cursor_crc \
> >         kms_cursor_edge_walk \
> >         kms_cursor_legacy \
> > +       kms_dp_aux_dev \
> >         kms_dp_dsc \
> >         kms_dp_tiled_display \
> >         kms_draw_crc \
> > diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
> > new file mode 100644
> > index 000000000000..8db85899cf4d
> > --- /dev/null
> > +++ b/tests/kms_dp_aux_dev.c
> > @@ -0,0 +1,117 @@
> > +/*
> > + * Copyright © 2019 Intel Corporation
> > + *
> > + * Permission is hereby granted, free of charge, to any person obtaining a
> > + * copy of this software and associated documentation files (the "Software"),
> > + * to deal in the Software without restriction, including without limitation
> > + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > + * and/or sell copies of the Software, and to permit persons to whom the
> > + * Software is furnished to do so, subject to the following conditions:
> > + *
> > + * The above copyright notice and this permission notice (including the next
> > + * paragraph) shall be included in all copies or substantial portions of the
> > + * Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> > + * IN THE SOFTWARE.
> > + *
> > + */
> > +
> > +#include "config.h"
> > +
> > +#include <sys/types.h>
> > +#include <sys/stat.h>
> > +#include <fcntl.h>
> > +#include <dirent.h>
> > +
> > +#include "igt.h"
> > +#include "igt_kms.h"
> > +
> > +IGT_TEST_DESCRIPTION("Test that /dev/drm_dp_aux reads work");
> > +
> > +static bool test(int drm_fd, uint32_t connector_id)
> > +{
> > +       drmModeConnector *connector;
> > +       DIR *dir;
> > +       int dir_fd;
> > +
> > +       connector = drmModeGetConnectorCurrent(drm_fd, connector_id);
> > +       dir_fd = igt_connector_sysfs_open(drm_fd, connector);
> > +       drmModeFreeConnector(connector);
> > +       igt_assert(dir_fd >= 0);
> > +
> > +       dir = fdopendir(dir_fd);
> > +       igt_assert(dir);
> > +
> > +       for (;;) {
> > +               struct dirent *ent;
> > +               char path[5 + sizeof(ent->d_name)];
> > +               uint8_t buf[16];
> > +               int fd, ret;
> > +
> > +               ent = readdir(dir);
> > +               if (!ent)
> > +                       break;
> > +
> > +               if (strncmp(ent->d_name, "drm_dp_aux", 10))
> > +                       continue;
> 
> So find the drm_dp_aux name for this connector and open it in /dev/

I was pondering if we have a good way to get the actual device node.

Ideas that came to mind:
a) assume it's there with the kernel provided name
b) get the major:minor from sysfs and trawl though 
   the whole of /dev looking for it
c) ask udev?

I went with a) since I was too lazy to try the other options.

> 
> > +               snprintf(path, sizeof(path), "/dev/%s", ent->d_name);
> > +
> > +               fd = open(path, O_RDONLY);
> > +               igt_assert(fd >= 0);
> > +
> > +               ret = read(fd, buf, sizeof(buf));
> > +               igt_assert(ret == sizeof(buf) || errno == ETIMEDOUT);
> > +
> > +               igt_info("%s: %s\n", path,
> > +                        ret > 0 ? "success" : "timed out");
> 
> Expect to be able to read 16 bytes.
> 
> > +
> > +               close(fd);
> > +
> > +               closedir(dir);
> > +               close(dir_fd);
> > +
> > +               if (ret > 0) {
> > +                       /* DPCD rev sanity check */
> > +                       igt_assert(buf[0] == 0x10 ||
> > +                                  buf[0] == 0x11 ||
> > +                                  buf[0] == 0x12 ||
> > +                                  buf[0] == 0x13 ||
> > +                                  buf[0] == 0x14);
> > +                       /* DPCD max lane count sanity check */
> > +                       igt_assert((buf[2] & 0x1f) == 0x01 ||
> > +                                  (buf[2] & 0x1f) == 0x02 ||
> > +                                  (buf[2] & 0x1f) == 0x04);
> 
> I believe you.
> 
> Might be worth using igt_assert_f() as I doubt these will make much
> sense if they ever fail.

Yeah, I guess I can add a bit of extra paint on top.

> 
> > +               }
> > +
> > +               return ret > 0;
> 
> Only care about drm_dp_aux, and there should only be one.
> > +       }
> > +
> > +       closedir(dir);
> > +       close(dir_fd);
> > +       return false;
> > +}
> > +
> > +igt_simple_main
> > +{
> > +       int valid_connectors = 0;
> > +       drmModeRes *res;
> > +       int drm_fd;
> > +
> > +       drm_fd = drm_open_driver_master(DRIVER_ANY);
> > +
> > +       res = drmModeGetResources(drm_fd);
> > +       igt_require(res);
> > +
> > +       for (int i = 0; i < res->count_connectors; i++)
> > +               valid_connectors += test(drm_fd, res->connectors[i]);
> > +       igt_require(valid_connectors);
> > +
> > +       drmModeFreeResources(res);
> 
> I was able to follow along, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] lib/igt_kms: Add igt_connector_sysfs_open()

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/4] lib/igt_kms: Add igt_connector_sysfs_open()
URL   : https://patchwork.freedesktop.org/series/70381/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7471_full -> IGTPW_3802_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3802_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3802_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3802_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_persistence@vcs1-mixed-process:
    - shard-tglb:         [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb2/igt@gem_ctx_persistence@vcs1-mixed-process.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb3/igt@gem_ctx_persistence@vcs1-mixed-process.html

  
New tests
---------

  New tests have been introduced between CI_DRM_7471_full and IGTPW_3802_full:

### New IGT tests (1) ###

  * igt@kms_dp_aux_dev:
    - Statuses : 2 pass(s) 3 skip(s)
    - Exec time: [0.10, 0.50] s

  

Known issues
------------

  Here are the changes found in IGTPW_3802_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl3/igt@gem_ctx_isolation@bcs0-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl2/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_exec_parallel@vecs0-fds:
    - shard-hsw:          [PASS][5] -> [FAIL][6] ([i915#676])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-hsw5/igt@gem_exec_parallel@vecs0-fds.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-hsw6/igt@gem_exec_parallel@vecs0-fds.html

  * igt@gem_exec_schedule@in-order-bsd:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#112146]) +4 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb3/igt@gem_exec_schedule@in-order-bsd.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html

  * igt@gem_exec_schedule@preempt-queue-bsd2:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#109276]) +5 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd2.html

  * igt@gem_exec_schedule@smoketest-bsd1:
    - shard-tglb:         [PASS][11] -> [INCOMPLETE][12] ([i915#463])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb2/igt@gem_exec_schedule@smoketest-bsd1.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb6/igt@gem_exec_schedule@smoketest-bsd1.html

  * igt@gem_exec_schedule@smoketest-bsd2:
    - shard-tglb:         [PASS][13] -> [INCOMPLETE][14] ([fdo#111998])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb3/igt@gem_exec_schedule@smoketest-bsd2.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb3/igt@gem_exec_schedule@smoketest-bsd2.html

  * igt@gem_exec_suspend@basic-s3:
    - shard-tglb:         [PASS][15] -> [INCOMPLETE][16] ([fdo#111736] / [i915#460])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb2/igt@gem_exec_suspend@basic-s3.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb7/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy:
    - shard-snb:          [PASS][17] -> [DMESG-WARN][18] ([fdo#111870])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html

  * igt@kms_cursor_crc@pipe-c-cursor-dpms:
    - shard-apl:          [PASS][19] -> [FAIL][20] ([i915#54])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-dpms.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-dpms.html
    - shard-kbl:          [PASS][21] -> [FAIL][22] ([i915#54])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-dpms.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-dpms.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-tglb:         [PASS][23] -> [INCOMPLETE][24] ([i915#456] / [i915#460])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb6/igt@kms_fbcon_fbt@psr-suspend.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb4/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-tglb:         [PASS][25] -> [INCOMPLETE][26] ([i915#456] / [i915#460] / [i915#474])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
    - shard-iclb:         [PASS][27] -> [FAIL][28] ([i915#49])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu:
    - shard-iclb:         [PASS][29] -> [INCOMPLETE][30] ([i915#123] / [i915#140])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
    - shard-tglb:         [PASS][31] -> [INCOMPLETE][32] ([i915#474])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-onoff:
    - shard-tglb:         [PASS][33] -> [FAIL][34] ([i915#49]) +6 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-onoff.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-onoff.html

  * igt@kms_plane@pixel-format-pipe-b-planes:
    - shard-kbl:          [PASS][35] -> [INCOMPLETE][36] ([fdo#103665])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl1/igt@kms_plane@pixel-format-pipe-b-planes.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl6/igt@kms_plane@pixel-format-pipe-b-planes.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vcs1-clean:
    - shard-iclb:         [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38] +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb5/igt@gem_ctx_isolation@vcs1-clean.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html

  * igt@gem_ctx_isolation@vecs0-s3:
    - shard-tglb:         [INCOMPLETE][39] ([i915#456]) -> [PASS][40] +3 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb2/igt@gem_ctx_isolation@vecs0-s3.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb5/igt@gem_ctx_isolation@vecs0-s3.html

  * igt@gem_ctx_persistence@processes:
    - shard-kbl:          [FAIL][41] -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl7/igt@gem_ctx_persistence@processes.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl2/igt@gem_ctx_persistence@processes.html

  * igt@gem_exec_parallel@vcs0-fds:
    - shard-hsw:          [FAIL][43] ([i915#676]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-hsw4/igt@gem_exec_parallel@vcs0-fds.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-hsw5/igt@gem_exec_parallel@vcs0-fds.html

  * igt@gem_exec_schedule@preempt-queue-bsd1:
    - shard-iclb:         [SKIP][45] ([fdo#109276]) -> [PASS][46] +4 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html

  * igt@gem_exec_schedule@preempt-queue-chain-vebox:
    - shard-glk:          [INCOMPLETE][47] ([i915#58] / [k.org#198133]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-glk5/igt@gem_exec_schedule@preempt-queue-chain-vebox.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-glk9/igt@gem_exec_schedule@preempt-queue-chain-vebox.html

  * igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
    - shard-iclb:         [SKIP][49] ([fdo#112146]) -> [PASS][50] +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb2/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
    - shard-hsw:          [TIMEOUT][51] ([i915#530]) -> [PASS][52] +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-hsw6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

  * igt@gem_persistent_relocs@forked-interruptible-thrashing:
    - shard-snb:          [FAIL][53] ([i915#520]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-snb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-snb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-hsw:          [FAIL][55] ([i915#520]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-hsw6/igt@gem_persistent_relocs@forked-thrashing.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-hsw4/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [DMESG-WARN][57] ([fdo#111870]) -> [PASS][58] +2 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-tglb:         [INCOMPLETE][59] ([i915#456] / [i915#460]) -> [PASS][60] +1 similar issue
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb2/igt@gem_workarounds@suspend-resume-fd.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb2/igt@gem_workarounds@suspend-resume-fd.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +5 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
    - shard-iclb:         [FAIL][63] ([i915#49]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
    - shard-kbl:          [FAIL][65] ([i915#49]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
    - shard-apl:          [FAIL][67] ([i915#49]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html

  * igt@kms_plane@pixel-format-pipe-a-planes:
    - shard-kbl:          [INCOMPLETE][69] ([fdo#103665]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl4/igt@kms_plane@pixel-format-pipe-a-planes.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl2/igt@kms_plane@pixel-format-pipe-a-planes.html

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-kbl:          [INCOMPLETE][71] ([fdo#103665] / [i915#435]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl7/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl3/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [FAIL][73] ([i915#173]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb1/igt@kms_psr@no_drrs.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb3/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][75] ([fdo#109441]) -> [PASS][76] +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][77] ([i915#31]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl6/igt@kms_setmode@basic.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl1/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [DMESG-WARN][79] ([i915#180]) -> [PASS][80] +9 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf_pmu@busy-start-vcs1:
    - shard-iclb:         [SKIP][81] ([fdo#112080]) -> [PASS][82] +4 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb5/igt@perf_pmu@busy-start-vcs1.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb1/igt@perf_pmu@busy-start-vcs1.html

  * {igt@perf_pmu@frequency-idle}:
    - shard-apl:          [FAIL][83] ([i915#675]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-apl4/igt@perf_pmu@frequency-idle.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-apl2/igt@perf_pmu@frequency-idle.html
    - shard-glk:          [FAIL][85] ([i915#675]) -> [PASS][86]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-glk9/igt@perf_pmu@frequency-idle.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-glk6/igt@perf_pmu@frequency-idle.html
    - shard-hsw:          [FAIL][87] ([i915#675]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-hsw1/igt@perf_pmu@frequency-idle.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-hsw4/igt@perf_pmu@frequency-idle.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv-switch:
    - shard-iclb:         [SKIP][89] ([fdo#109276] / [fdo#112080]) -> [FAIL][90] ([IGT#28])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html

  * igt@gem_ctx_isolation@vcs2-clean:
    - shard-tglb:         [SKIP][91] ([fdo#112080]) -> [SKIP][92] ([fdo#111912] / [fdo#112080])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-tglb9/igt@gem_ctx_isolation@vcs2-clean.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-tglb7/igt@gem_ctx_isolation@vcs2-clean.html

  * igt@gem_eio@kms:
    - shard-snb:          [DMESG-WARN][93] ([i915#444] / [i915#502]) -> [INCOMPLETE][94] ([i915#82])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7471/shard-snb5/igt@gem_eio@kms.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/shard-snb2/igt@gem_eio@kms.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
  [fdo#111998]: https://bugs.freedesktop.org/show_bug.cgi?id=111998
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
  [i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444
  [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
  [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
  [i915#463]: https://gitlab.freedesktop.org/drm/intel/issues/463
  [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#502]: https://gitlab.freedesktop.org/drm/intel/issues/502
  [i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
  [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
  [i915#675]: https://gitlab.freedesktop.org/drm/intel/issues/675
  [i915#676]: https://gitlab.freedesktop.org/drm/intel/issues/676
  [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
  [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (11 -> 8)
------------------------------

  Missing    (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5323 -> IGTPW_3802
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_7471: 7187e860071abd027d6eeaecc0674becc137e939 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3802: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/index.html
  IGT_5323: b0f877d06a78b9c38ed246be2537a0453b6c214f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3802/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add igt_connector_sysfs_open()

[Ville Syrjälä]

On Tue, Dec 03, 2019 at 04:22:05PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2019-12-03 15:35:52)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Add a helper to open the sysfs directory for a connector.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  lib/igt_kms.c | 34 ++++++++++++++++++++++++++++++++++
> >  lib/igt_kms.h |  3 +++
> >  2 files changed, 37 insertions(+)
> > 
> > diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> > index 44647a2263bd..74ae98d774f1 100644
> > --- a/lib/igt_kms.c
> > +++ b/lib/igt_kms.c
> > @@ -965,6 +965,40 @@ static void reset_connectors_at_exit(int sig)
> >         igt_reset_connectors();
> >  }
> >  
> > +static char *kmstest_connector_dirname(int idx,
> > +                                      uint32_t connector_type,
> > +                                      uint32_t connector_type_id,
> > +                                      char *name, int namelen)
> > +{
> > +       snprintf(name, namelen, "card%d-%s-%d", idx,
> > +                kmstest_connector_type_str(connector_type),
> > +                connector_type_id);
> > +
> > +       return name;
> > +}
> > +
> > +int igt_connector_sysfs_open(int drm_fd,
> > +                            drmModeConnector *connector)
> > +{
> > +       char name[80];
> > +       int dir, conn_dir;
> > +
> > +       dir = igt_sysfs_open(drm_fd);
> > +       if (dir < 0)
> > +               return dir;
> > +
> > +       if (!kmstest_connector_dirname(igt_device_get_card_index(drm_fd),
> > +                                      connector->connector_type,
> > +                                      connector->connector_type_id,
> > +                                      name, sizeof(name)))
> > +               return -1;
> 
> Before igt_sysfs_open() or close(dir);

Just realized that this never even returns NULL unless you pass in
NULL. I'll just drop the check.

> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev