* [PATCH] net: thunderx: start phy before starting autonegotiation
@ 2019-12-04 15:26 ` Mian Yousaf Kaukab
0 siblings, 0 replies; 8+ messages in thread
From: Mian Yousaf Kaukab @ 2019-12-04 15:26 UTC (permalink / raw)
To: netdev
Cc: rric, tharvey, Mian Yousaf Kaukab, linux-kernel, sgoutham, davem,
linux-arm-kernel
Since "2b3e88ea6528 net: phy: improve phy state checking"
phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
before calling phy_start_aneg() during probe so that autonegotiation
is initiated.
Network fails without this patch on Octeon TX.
Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 1e09fdb63c4f..504644257aff 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1115,6 +1115,7 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid)
phy_interface_mode(lmac->lmac_type)))
return -ENODEV;
+ phy_start(lmac->phydev);
phy_start_aneg(lmac->phydev);
return 0;
}
--
2.16.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] net: thunderx: start phy before starting autonegotiation
2019-12-04 15:26 ` Mian Yousaf Kaukab
@ 2019-12-04 15:42 ` Andrew Lunn
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2019-12-04 15:42 UTC (permalink / raw)
To: Mian Yousaf Kaukab
Cc: netdev, rric, tharvey, linux-kernel, sgoutham, davem, linux-arm-kernel
On Wed, Dec 04, 2019 at 04:26:51PM +0100, Mian Yousaf Kaukab wrote:
> Since "2b3e88ea6528 net: phy: improve phy state checking"
> phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
> before calling phy_start_aneg() during probe so that autonegotiation
> is initiated.
>
> Network fails without this patch on Octeon TX.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
> ---
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 1e09fdb63c4f..504644257aff 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1115,6 +1115,7 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid)
> phy_interface_mode(lmac->lmac_type)))
> return -ENODEV;
>
> + phy_start(lmac->phydev);
> phy_start_aneg(lmac->phydev);
> return 0;
phy_start() will start aneg, if aneg is configured. So you should be
able to remove the call to phy_start_aneg().
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] net: thunderx: start phy before starting autonegotiation
@ 2019-12-04 15:42 ` Andrew Lunn
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2019-12-04 15:42 UTC (permalink / raw)
To: Mian Yousaf Kaukab
Cc: rric, netdev, tharvey, linux-kernel, sgoutham, davem, linux-arm-kernel
On Wed, Dec 04, 2019 at 04:26:51PM +0100, Mian Yousaf Kaukab wrote:
> Since "2b3e88ea6528 net: phy: improve phy state checking"
> phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
> before calling phy_start_aneg() during probe so that autonegotiation
> is initiated.
>
> Network fails without this patch on Octeon TX.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
> ---
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 1e09fdb63c4f..504644257aff 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1115,6 +1115,7 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid)
> phy_interface_mode(lmac->lmac_type)))
> return -ENODEV;
>
> + phy_start(lmac->phydev);
> phy_start_aneg(lmac->phydev);
> return 0;
phy_start() will start aneg, if aneg is configured. So you should be
able to remove the call to phy_start_aneg().
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net: thunderx: start phy before starting autonegotiation
2019-12-04 15:26 ` Mian Yousaf Kaukab
@ 2019-12-04 15:43 ` Sergei Shtylyov
-1 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2019-12-04 15:43 UTC (permalink / raw)
To: Mian Yousaf Kaukab, netdev
Cc: linux-kernel, linux-arm-kernel, tharvey, davem, rric, sgoutham
On 12/04/2019 06:26 PM, Mian Yousaf Kaukab wrote:
> Since "2b3e88ea6528 net: phy: improve phy state checking"
Since 2b3e88ea6528 ("net: phy: improve phy state checking")
> phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
> before calling phy_start_aneg() during probe so that autonegotiation
> is initiated.
>
> Network fails without this patch on Octeon TX.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] net: thunderx: start phy before starting autonegotiation
@ 2019-12-04 15:43 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2019-12-04 15:43 UTC (permalink / raw)
To: Mian Yousaf Kaukab, netdev
Cc: rric, tharvey, linux-kernel, sgoutham, davem, linux-arm-kernel
On 12/04/2019 06:26 PM, Mian Yousaf Kaukab wrote:
> Since "2b3e88ea6528 net: phy: improve phy state checking"
Since 2b3e88ea6528 ("net: phy: improve phy state checking")
> phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
> before calling phy_start_aneg() during probe so that autonegotiation
> is initiated.
>
> Network fails without this patch on Octeon TX.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
[...]
MBR, Sergei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net: thunderx: start phy before starting autonegotiation
2019-12-04 15:26 ` Mian Yousaf Kaukab
@ 2019-12-04 20:30 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2019-12-04 20:30 UTC (permalink / raw)
To: ykaukab; +Cc: netdev, linux-kernel, linux-arm-kernel, tharvey, rric, sgoutham
From: Mian Yousaf Kaukab <ykaukab@suse.de>
Date: Wed, 4 Dec 2019 16:26:51 +0100
> Since "2b3e88ea6528 net: phy: improve phy state checking"
As Sergei said, please format this properly and make it the
Fixes: tag.
Thank you.
^ permalink raw reply [flat|nested] 8+ messages in thread