All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org,
	Lucas Stach <l.stach@pengutronix.de>,
	Chris Healy <cphealy@gmail.com>,
	Andrey Smirnov <andrew.smirnov@gmail.com>,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	kernel@collabora.com, Daniel Vetter <daniel@ffwll.ch>,
	Inki Dae <inki.dae@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Clark <robdclark@gmail.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object
Date: Wed, 4 Dec 2019 10:42:07 +0100	[thread overview]
Message-ID: <20191204104207.38367944@collabora.com> (raw)
In-Reply-To: <20191204091255.GB6705@pendragon.ideasonboard.com>

On Wed, 4 Dec 2019 11:12:55 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Boris,
> 
> On Wed, Dec 04, 2019 at 10:03:02AM +0100, Boris Brezillon wrote:
> > On Tue, 3 Dec 2019 20:17:05 +0200 Laurent Pinchart wrote:  
> > > On Tue, Dec 03, 2019 at 03:15:12PM +0100, Boris Brezillon wrote:  
> > > > One of the last remaining objects to not have its atomic state.
> > > > 
> > > > This is being motivated by our attempt to support runtime bus-format
> > > > negotiation between elements of the bridge chain.
> > > > This patch just paves the road for such a feature by adding a new
> > > > drm_bridge_state object inheriting from drm_private_obj so we can
> > > > re-use some of the existing state initialization/tracking logic.
> > > > 
> > > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > ---
> > > > Changes in v4:
> > > > * Fix the doc
> > > > * Kill default helpers (inlined)    
> > > 
> > > I liked the default helpers, inlining their content makes the code more
> > > difficult to follow in my opinion.  
> > 
> > I'll go back to this approach then. Should I keep the original helper
> > names even though they're not globally visible (and should probably
> > never be)?  
> 
> I agree they should probably never be visible, and I trust your
> judgement on naming. Please double-check the documentation though, to
> ensure that it matches the implementation.
> 

Is there any point keeping the documentation if they're not exposed?

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org,
	Thierry Reding <thierry.reding@gmail.com>,
	kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Andrey Smirnov <andrew.smirnov@gmail.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chris Healy <cphealy@gmail.com>,
	devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
	Rob Herring <robh+dt@kernel.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Seung-Woo Kim <sw0312.kim@samsung.com>
Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object
Date: Wed, 4 Dec 2019 10:42:07 +0100	[thread overview]
Message-ID: <20191204104207.38367944@collabora.com> (raw)
In-Reply-To: <20191204091255.GB6705@pendragon.ideasonboard.com>

On Wed, 4 Dec 2019 11:12:55 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Boris,
> 
> On Wed, Dec 04, 2019 at 10:03:02AM +0100, Boris Brezillon wrote:
> > On Tue, 3 Dec 2019 20:17:05 +0200 Laurent Pinchart wrote:  
> > > On Tue, Dec 03, 2019 at 03:15:12PM +0100, Boris Brezillon wrote:  
> > > > One of the last remaining objects to not have its atomic state.
> > > > 
> > > > This is being motivated by our attempt to support runtime bus-format
> > > > negotiation between elements of the bridge chain.
> > > > This patch just paves the road for such a feature by adding a new
> > > > drm_bridge_state object inheriting from drm_private_obj so we can
> > > > re-use some of the existing state initialization/tracking logic.
> > > > 
> > > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > ---
> > > > Changes in v4:
> > > > * Fix the doc
> > > > * Kill default helpers (inlined)    
> > > 
> > > I liked the default helpers, inlining their content makes the code more
> > > difficult to follow in my opinion.  
> > 
> > I'll go back to this approach then. Should I keep the original helper
> > names even though they're not globally visible (and should probably
> > never be)?  
> 
> I agree they should probably never be visible, and I trust your
> judgement on naming. Please double-check the documentation though, to
> ensure that it matches the implementation.
> 

Is there any point keeping the documentation if they're not exposed?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-12-04  9:42 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 14:15 [PATCH v4 00/11] drm: Add support for bus-format negotiation Boris Brezillon
2019-12-03 14:15 ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 01/11] drm/bridge: Rename bridge helpers targeting a bridge chain Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 02/11] drm/bridge: Introduce drm_bridge_get_next_bridge() Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 03/11] drm: Stop accessing encoder->bridge directly Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-16 13:54   ` Marek Szyprowski
2019-12-16 13:54     ` Marek Szyprowski
2019-12-16 14:55     ` Boris Brezillon
2019-12-16 14:55       ` Boris Brezillon
2019-12-16 15:02       ` Marek Szyprowski
2019-12-16 15:02         ` Marek Szyprowski
2019-12-16 15:25         ` Boris Brezillon
2019-12-16 15:25           ` Boris Brezillon
2019-12-23  9:55           ` Marek Szyprowski
2019-12-23  9:55             ` Marek Szyprowski
2019-12-24  9:16             ` Andrzej Hajda
2019-12-24  9:16               ` Andrzej Hajda
2019-12-24  9:44               ` Boris Brezillon
2019-12-24  9:44                 ` Boris Brezillon
2019-12-24  9:49                 ` Boris Brezillon
2019-12-24  9:49                   ` Boris Brezillon
2019-12-24 10:03                   ` Boris Brezillon
2019-12-24 10:03                     ` Boris Brezillon
2019-12-27 10:25                     ` Marek Szyprowski
2019-12-27 10:25                       ` Marek Szyprowski
2019-12-27 11:03                       ` Marek Szyprowski
2019-12-27 11:03                         ` Marek Szyprowski
2019-12-24 11:31                 ` Sam Ravnborg
2019-12-24 11:31                   ` Sam Ravnborg
2019-12-25  1:36                   ` Laurent Pinchart
2019-12-25  1:36                     ` Laurent Pinchart
2019-12-27 12:39                   ` Boris Brezillon
2019-12-27 12:39                     ` Boris Brezillon
2019-12-27  9:42                 ` Andrzej Hajda
2019-12-27  9:42                   ` Andrzej Hajda
2019-12-27 10:51                   ` Laurent Pinchart
2019-12-27 10:51                     ` Laurent Pinchart
2019-12-27 12:21                     ` Boris Brezillon
2019-12-27 12:21                       ` Boris Brezillon
2020-01-01 17:13                       ` Laurent Pinchart
2020-01-01 17:13                         ` Laurent Pinchart
2019-12-03 14:15 ` [PATCH v4 05/11] drm/bridge: Add the drm_for_each_bridge_in_chain() helper Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 06/11] drm/bridge: Add the drm_bridge_get_prev_bridge() helper Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 07/11] drm/bridge: Clarify the atomic enable/disable hooks semantics Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 18:02   ` Laurent Pinchart
2019-12-03 18:02     ` Laurent Pinchart
2019-12-04  9:00     ` Boris Brezillon
2019-12-04  9:00       ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 18:17   ` Laurent Pinchart
2019-12-03 18:17     ` Laurent Pinchart
2019-12-04  9:03     ` Boris Brezillon
2019-12-04  9:03       ` Boris Brezillon
2019-12-04  9:12       ` Laurent Pinchart
2019-12-04  9:12         ` Laurent Pinchart
2019-12-04  9:42         ` Boris Brezillon [this message]
2019-12-04  9:42           ` Boris Brezillon
2019-12-04 10:38           ` Laurent Pinchart
2019-12-04 10:38             ` Laurent Pinchart
2019-12-03 14:15 ` [PATCH v4 09/11] drm/bridge: Patch atomic hooks to take a drm_bridge_state Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 10/11] drm/bridge: Add an ->atomic_check() hook Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 14:15 ` [PATCH v4 11/11] drm/bridge: Add the necessary bits to support bus format negotiation Boris Brezillon
2019-12-03 14:15   ` Boris Brezillon
2019-12-03 18:19 ` [PATCH v4 00/11] drm: Add support for bus-format negotiation Laurent Pinchart
2019-12-03 18:19   ` Laurent Pinchart
2019-12-04  9:09   ` Boris Brezillon
2019-12-04  9:09     ` Boris Brezillon
2019-12-04  9:15     ` Laurent Pinchart
2019-12-04  9:15       ` Laurent Pinchart
2019-12-04 13:43   ` Neil Armstrong
2019-12-04 13:43     ` Neil Armstrong
2019-12-09  9:43   ` Boris Brezillon
2019-12-09  9:43     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204104207.38367944@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=a.hajda@samsung.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=inki.dae@samsung.com \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=jy0922.shim@samsung.com \
    --cc=kernel@collabora.com \
    --cc=kyungmin.park@samsung.com \
    --cc=l.stach@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sw0312.kim@samsung.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.