All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled
Date: Wed, 4 Dec 2019 11:47:54 +0100	[thread overview]
Message-ID: <20191204104754.GH980@Air-de-Roger> (raw)
In-Reply-To: <0bcf69cf-646a-fd72-4216-6819554e34d9@suse.com>

On Tue, Dec 03, 2019 at 04:11:07PM +0100, Jan Beulich wrote:
> On 29.11.2019 12:28, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/io_apic.c
> > +++ b/xen/arch/x86/io_apic.c
> > @@ -562,7 +562,7 @@ set_ioapic_affinity_irq(struct irq_desc *desc, const cpumask_t *mask)
> >  
> >      dest = set_desc_affinity(desc, mask);
> >      if (dest != BAD_APICID) {
> > -        if ( !x2apic_enabled )
> > +        if ( !iommu_intremap )
> 
> To match description as well as the other changes done, doesn't
> this need to be "!x2apic_enabled || !iommu_intremap"?

Yes, in fact I already had this change on my local branch, not sure
why it didn't end up in the patch I sent.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-12-04 10:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 11:28 [Xen-devel] [PATCH v2 0/4] x86: enable x2APIC mode regardless of interrupt remapping support Roger Pau Monne
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled Roger Pau Monne
2019-12-03 15:11   ` Jan Beulich
2019-12-04 10:47     ` Roger Pau Monné [this message]
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 2/4] x86/apic: force phys mode if interrupt remapping is disabled Roger Pau Monne
2019-11-29 11:38   ` Roger Pau Monné
2019-12-03 15:14     ` Jan Beulich
2019-12-04  9:17       ` Roger Pau Monné
2019-12-04  9:34         ` Jan Beulich
2019-12-04 10:50           ` Roger Pau Monné
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 3/4] x86/smp: check APIC ID on AP bringup Roger Pau Monne
2019-12-03 15:23   ` Jan Beulich
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping Roger Pau Monne
2019-12-03 15:33   ` Jan Beulich
2019-12-04 13:51     ` Roger Pau Monné
2019-12-04 14:28       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204104754.GH980@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.