From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping
Date: Tue, 3 Dec 2019 16:33:09 +0100 [thread overview]
Message-ID: <7ed6d33a-8f99-684b-f5ca-d3f4cb8d984b@suse.com> (raw)
In-Reply-To: <20191129112851.19273-5-roger.pau@citrix.com>
On 29.11.2019 12:28, Roger Pau Monne wrote:
> --- a/xen/arch/x86/apic.c
> +++ b/xen/arch/x86/apic.c
> @@ -492,7 +492,8 @@ static void __enable_x2apic(void)
>
> static void resume_x2apic(void)
> {
> - iommu_enable_x2apic();
> + if ( iommu_supports_x2apic() )
> + iommu_enable_x2apic();
The hooks called by this function are __init, and at least the AMD
one also isn't (I think) prepared to be called more than once.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-03 15:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 11:28 [Xen-devel] [PATCH v2 0/4] x86: enable x2APIC mode regardless of interrupt remapping support Roger Pau Monne
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled Roger Pau Monne
2019-12-03 15:11 ` Jan Beulich
2019-12-04 10:47 ` Roger Pau Monné
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 2/4] x86/apic: force phys mode if interrupt remapping is disabled Roger Pau Monne
2019-11-29 11:38 ` Roger Pau Monné
2019-12-03 15:14 ` Jan Beulich
2019-12-04 9:17 ` Roger Pau Monné
2019-12-04 9:34 ` Jan Beulich
2019-12-04 10:50 ` Roger Pau Monné
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 3/4] x86/smp: check APIC ID on AP bringup Roger Pau Monne
2019-12-03 15:23 ` Jan Beulich
2019-11-29 11:28 ` [Xen-devel] [PATCH v2 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping Roger Pau Monne
2019-12-03 15:33 ` Jan Beulich [this message]
2019-12-04 13:51 ` Roger Pau Monné
2019-12-04 14:28 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ed6d33a-8f99-684b-f5ca-d3f4cb8d984b@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.