From: Matthew Wilcox <willy@infradead.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Eric Biggers <ebiggers@kernel.org>,
Tyler Hicks <tyhicks@canonical.com>,
linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-fscrypt@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup
Date: Wed, 4 Dec 2019 23:06:46 -0800 [thread overview]
Message-ID: <20191205070646.GA29612@bombadil.infradead.org> (raw)
In-Reply-To: <0003a252-b003-0a8c-b4ac-6280557ece06@loongson.cn>
On Thu, Dec 05, 2019 at 08:56:07AM +0800, Tiezhu Yang wrote:
> > And, as I asked twice in the last round of review, did you benchmark
> > this change?
>
> Before sending this v2 patch, I have done the test used with your test
> program and already pointed out the following implementation is better:
I didn't mean "have you run the test program i wrote". I meant "have you
booted a kernel with this change and done some performance measurements
to see if you've changed anything".
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: ecryptfs@vger.kernel.org, "Theodore Y. Ts'o" <tytso@mit.edu>,
linux-kernel@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup
Date: Wed, 4 Dec 2019 23:06:46 -0800 [thread overview]
Message-ID: <20191205070646.GA29612@bombadil.infradead.org> (raw)
In-Reply-To: <0003a252-b003-0a8c-b4ac-6280557ece06@loongson.cn>
On Thu, Dec 05, 2019 at 08:56:07AM +0800, Tiezhu Yang wrote:
> > And, as I asked twice in the last round of review, did you benchmark
> > this change?
>
> Before sending this v2 patch, I have done the test used with your test
> program and already pointed out the following implementation is better:
I didn't mean "have you run the test program i wrote". I meant "have you
booted a kernel with this change and done some performance measurements
to see if you've changed anything".
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-12-05 7:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 12:56 [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup Tiezhu Yang
2019-12-03 12:56 ` [f2fs-dev] " Tiezhu Yang
2019-12-03 13:56 ` Matthew Wilcox
2019-12-03 13:56 ` Matthew Wilcox
2019-12-03 13:56 ` [f2fs-dev] " Matthew Wilcox
2019-12-05 0:56 ` Tiezhu Yang
2019-12-05 0:56 ` Tiezhu Yang
2019-12-05 0:56 ` [f2fs-dev] " Tiezhu Yang
2019-12-05 7:06 ` Matthew Wilcox [this message]
2019-12-05 7:06 ` Matthew Wilcox
2019-12-05 7:55 ` Tiezhu Yang
2019-12-05 7:55 ` Tiezhu Yang
2019-12-05 7:55 ` [f2fs-dev] " Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205070646.GA29612@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=ebiggers@kernel.org \
--cc=ecryptfs@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yangtiezhu@loongson.cn \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.