[igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs

[igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs

[Chris Wilson]

i915_module_reload/fault-injection is valuable for its exhaustive trawl
through (hopefully) every path that hits i915_probe_error, unfortunately
such thoroughness comes at a cost. On kbl-guc, it takes almost 3minutes,
which is unacceptable for BAT, so leave it to the shards and idle runs
to catch unusual errors on module load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index d5f13bec2..14507c347 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -200,6 +200,4 @@ igt@vgem_basic@sysfs
 
 igt@vgem_basic@unload
 igt@i915_module_load@reload
-igt@i915_module_load@reload-no-display
-igt@i915_module_load@reload-with-fault-injection
 igt@i915_pm_rpm@module-reload
-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for intel-ci: Delegate exhaustive fault-injection to the idle runs

[Patchwork]

== Series Details ==

Series: intel-ci: Delegate exhaustive fault-injection to the idle runs
URL   : https://patchwork.freedesktop.org/series/70452/
State : success

== Summary ==

CI Bug Log - changes from IGT_5329 -> IGTPW_3813
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/index.html

Known issues
------------

  Here are the changes found in IGTPW_3813 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [PASS][1] -> [DMESG-FAIL][2] ([i915#563])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111407])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@basic:
    - {fi-tgl-guc}:       [INCOMPLETE][5] ([i915#476]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-tgl-guc/igt@gem_exec_parallel@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-tgl-guc/igt@gem_exec_parallel@basic.html

  * igt@i915_selftest@live_blt:
    - fi-byt-j1900:       [DMESG-FAIL][7] -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-byt-j1900/igt@i915_selftest@live_blt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-byt-j1900/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-hsw-peppy:       [INCOMPLETE][9] ([i915#694]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
    - fi-byt-n2820:       [INCOMPLETE][11] ([i915#45]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  
#### Warnings ####

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-x1275:       [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([i915#62] / [i915#92]) +6 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-a:
    - fi-kbl-x1275:       [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5329/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
  [i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (55 -> 47)
------------------------------

  Missing    (8): fi-icl-1065g7 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5329 -> IGTPW_3813

  CI-20190529: 20190529
  CI_DRM_7484: 1b2e7ab84231764361a41bbe00a4cd501d467f04 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3813: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/index.html
  IGT_5329: c11f328d1391d1e89c54755587de070672d3749f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3813/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs

[Petri Latvala]

On Wed, Dec 04, 2019 at 05:48:17PM +0000, Chris Wilson wrote:
> i915_module_reload/fault-injection is valuable for its exhaustive trawl
> through (hopefully) every path that hits i915_probe_error, unfortunately
> such thoroughness comes at a cost. On kbl-guc, it takes almost 3minutes,
> which is unacceptable for BAT, so leave it to the shards and idle runs
> to catch unusual errors on module load.


Pointed this out in IRC, but for the benefit of the mailing list:
i915_module_load is blacklisted on shards so this would leave these
tests only for the idle runs.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs

[Martin Peres]

On 04/02/2020 13:48, Chris Wilson wrote:
> i915_module_reload/fault-injection is valuable for its exhaustive trawl
> through (hopefully) every path that hits i915_probe_error, unfortunately
> such thoroughness comes at a cost. On kbl-guc, it takes almost 3minutes,
> and on tgl-y takes over 4 minutes, which is unacceptable for BAT, so leave
> it to the shards and idle runs to catch unusual errors on module load.
> 
> v2: remove blacklisting to allow module-reload in shards.
> 
> Tomi prefers not to have to manually create a runlist for the idle-runs,
> so let's take a risk by allowing the module-reload within the shards.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>

I think this is the right call! Thanks for doing it :)

Acked-by: Martin Peres <martin.peres@linux.intel.com>

Martin

> ---
>  tests/intel-ci/blacklist.txt          | 2 +-
>  tests/intel-ci/fast-feedback.testlist | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index 723f24457..181c8cd5f 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -12,7 +12,7 @@ igt@drm_mm(@.*)?
>  # self-contained tests, leading to random
>  # failures in tests run afterwards.
>  ###############################################
> -igt@i915_module_load(@.*)?
> +#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
>  igt@i915_pm_rpm@module-reload
>  igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
>  ###############################################
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 40d273c1d..467e11267 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -172,6 +172,4 @@ igt@vgem_basic@sysfs
>  
>  igt@vgem_basic@unload
>  igt@i915_module_load@reload
> -igt@i915_module_load@reload-no-display
> -igt@i915_module_load@reload-with-fault-injection
>  igt@i915_pm_rpm@module-reload
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs

[Chris Wilson]

i915_module_reload/fault-injection is valuable for its exhaustive trawl
through (hopefully) every path that hits i915_probe_error, unfortunately
such thoroughness comes at a cost. On kbl-guc, it takes almost 3minutes,
and on tgl-y takes over 4 minutes, which is unacceptable for BAT, so leave
it to the shards and idle runs to catch unusual errors on module load.

v2: remove blacklisting to allow module-reload in shards.

Tomi prefers not to have to manually create a runlist for the idle-runs,
so let's take a risk by allowing the module-reload within the shards.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
 tests/intel-ci/blacklist.txt          | 2 +-
 tests/intel-ci/fast-feedback.testlist | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 723f24457..181c8cd5f 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -12,7 +12,7 @@ igt@drm_mm(@.*)?
 # self-contained tests, leading to random
 # failures in tests run afterwards.
 ###############################################
-igt@i915_module_load(@.*)?
+#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
 igt@i915_pm_rpm@module-reload
 igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
 ###############################################
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 40d273c1d..467e11267 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -172,6 +172,4 @@ igt@vgem_basic@sysfs
 
 igt@vgem_basic@unload
 igt@i915_module_load@reload
-igt@i915_module_load@reload-no-display
-igt@i915_module_load@reload-with-fault-injection
 igt@i915_pm_rpm@module-reload
-- 
2.25.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev