All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v4 1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes
@ 2019-12-05 21:03 José Roberto de Souza
  2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 2/3] drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off José Roberto de Souza
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: José Roberto de Souza @ 2019-12-05 21:03 UTC (permalink / raw)
  To: intel-gfx

It should not care about DDB allocations of pipes going through
a fullmodeset, as at this point those pipes are disabled.
The comment in the code also points to that but that was not what
was being executed.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index eb0505a66ea8..68575457d40e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14603,7 +14603,7 @@ static void skl_commit_modeset_enables(struct intel_atomic_state *state)
 
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i)
 		/* ignore allocations for crtc's that have been turned off. */
-		if (new_crtc_state->hw.active)
+		if (!needs_modeset(new_crtc_state) && new_crtc_state->hw.active)
 			entries[i] = old_crtc_state->wm.skl.ddb;
 
 	/* If 2nd DBuf slice required, enable it here */
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Intel-gfx] [PATCH v4 2/3] drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off
  2019-12-05 21:03 [Intel-gfx] [PATCH v4 1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes José Roberto de Souza
@ 2019-12-05 21:03 ` José Roberto de Souza
  2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables() José Roberto de Souza
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: José Roberto de Souza @ 2019-12-05 21:03 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

For TGL the step to turn off the transcoder clock was moved to after
the complete shutdown of DDI. Only the MST slave transcoders should
disable the clock before that.

v2:
- Adding last_mst_stream to intel_mst_post_disable_dp, make code more
easy to read and is similar to first_mst_stream in
intel_mst_pre_enable_dp()(Ville's idea)
- Calling intel_ddi_disable_pipe_clock() for GEN12+ right
intel_disable_ddi_buf() as stated in BSpec(Ville)

BSpec: 49190
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c    | 10 +++++++++-
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 20 +++++++++++++++-----
 2 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index ebcc7302706b..3cacb1e279c1 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3807,11 +3807,19 @@ static void intel_ddi_post_disable_dp(struct intel_encoder *encoder,
 	 */
 	intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
 
-	if (!is_mst)
+	if (INTEL_GEN(dev_priv) < 12 && !is_mst)
 		intel_ddi_disable_pipe_clock(old_crtc_state);
 
 	intel_disable_ddi_buf(encoder, old_crtc_state);
 
+	/*
+	 * From TGL spec: "If single stream or multi-stream master transcoder:
+	 * Configure Transcoder Clock select to direct no clock to the
+	 * transcoder"
+	 */
+	if (INTEL_GEN(dev_priv) >= 12)
+		intel_ddi_disable_pipe_clock(old_crtc_state);
+
 	intel_edp_panel_vdd_on(intel_dp);
 	intel_edp_panel_off(intel_dp);
 
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index a1e4f4197a67..926e49f449a6 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -235,8 +235,21 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
 	struct intel_dp *intel_dp = &intel_dig_port->dp;
 	struct intel_connector *connector =
 		to_intel_connector(old_conn_state->connector);
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	bool last_mst_stream;
 
-	intel_ddi_disable_pipe_clock(old_crtc_state);
+	intel_dp->active_mst_links--;
+	last_mst_stream = intel_dp->active_mst_links == 0;
+
+	/*
+	 * From TGL spec: "If multi-stream slave transcoder: Configure
+	 * Transcoder Clock Select to direct no clock to the transcoder"
+	 *
+	 * From older GENs spec: "Configure Transcoder Clock Select to direct
+	 * no clock to the transcoder"
+	 */
+	if (INTEL_GEN(dev_priv) < 12 || !last_mst_stream)
+		intel_ddi_disable_pipe_clock(old_crtc_state);
 
 	/* this can fail */
 	drm_dp_check_act_status(&intel_dp->mst_mgr);
@@ -252,13 +265,10 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
 	drm_dp_send_power_updown_phy(&intel_dp->mst_mgr, connector->port,
 				     false);
 
-	intel_dp->active_mst_links--;
-
 	intel_mst->connector = NULL;
-	if (intel_dp->active_mst_links == 0) {
+	if (last_mst_stream)
 		intel_dig_port->base.post_disable(&intel_dig_port->base,
 						  old_crtc_state, NULL);
-	}
 
 	DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links);
 }
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables()
  2019-12-05 21:03 [Intel-gfx] [PATCH v4 1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes José Roberto de Souza
  2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 2/3] drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off José Roberto de Souza
@ 2019-12-05 21:03 ` José Roberto de Souza
  2019-12-06 22:22   ` Matt Roper
  2019-12-05 21:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes Patchwork
  2019-12-06  5:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 1 reply; 9+ messages in thread
From: José Roberto de Souza @ 2019-12-05 21:03 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

Commit 9c722e17c1b9 ("drm/i915: Disable pipes in reverse order")
reverted the order that pipes gets disabled because of TGL
master/slave relationship between transcoders in MST mode.

But as stated in a comment in skl_commit_modeset_enables() the
enabling order is not always crescent, possibly causing previously
selected slave transcoder being enabled before master so another
approach will be needed to select a transcoder to master in MST mode.
It will be similar to the approach taken in port sync.

But instead of implement something like
intel_trans_port_sync_modeset_disables() to MST lets simply it and
iterate over all pipes 2 times, the first one disabling any slave and
then disabling everything else.
The MST bits will be added in another patch.

v2:
Not using crtc->active as it is deprecated

v3:
Removing is_trans_port_sync_mode() check, just check for
is_trans_port_sync_master() is enough

v4:
Adding and using is_trans_port_sync_slave(), otherwise non-port sync
pipes will be disabled in the first loop, what is not wrong but is
not what patch description promises

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v2)
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 88 +++++++-------------
 1 file changed, 32 insertions(+), 56 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 68575457d40e..821ba8053f9d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -561,6 +561,12 @@ is_trans_port_sync_master(const struct intel_crtc_state *crtc_state)
 		crtc_state->sync_mode_slaves_mask);
 }
 
+static bool
+is_trans_port_sync_slave(const struct intel_crtc_state *crtc_state)
+{
+	return crtc_state->master_transcoder != INVALID_TRANSCODER;
+}
+
 /*
  * Platform specific helpers to calculate the port PLL loopback- (clock.m),
  * and post-divider (clock.p) values, pre- (clock.vco) and post-divided fast
@@ -14393,77 +14399,47 @@ static void intel_old_crtc_state_disables(struct intel_atomic_state *state,
 		dev_priv->display.initial_watermarks(state, crtc);
 }
 
-static void intel_trans_port_sync_modeset_disables(struct intel_atomic_state *state,
-						   struct intel_crtc *crtc,
-						   struct intel_crtc_state *old_crtc_state,
-						   struct intel_crtc_state *new_crtc_state)
-{
-	struct intel_crtc *slave_crtc = intel_get_slave_crtc(new_crtc_state);
-	struct intel_crtc_state *new_slave_crtc_state =
-		intel_atomic_get_new_crtc_state(state, slave_crtc);
-	struct intel_crtc_state *old_slave_crtc_state =
-		intel_atomic_get_old_crtc_state(state, slave_crtc);
-
-	WARN_ON(!slave_crtc || !new_slave_crtc_state ||
-		!old_slave_crtc_state);
-
-	/* Disable Slave first */
-	intel_pre_plane_update(state, slave_crtc);
-	if (old_slave_crtc_state->hw.active)
-		intel_old_crtc_state_disables(state,
-					      old_slave_crtc_state,
-					      new_slave_crtc_state,
-					      slave_crtc);
-
-	/* Disable Master */
-	intel_pre_plane_update(state, crtc);
-	if (old_crtc_state->hw.active)
-		intel_old_crtc_state_disables(state,
-					      old_crtc_state,
-					      new_crtc_state,
-					      crtc);
-}
-
 static void intel_commit_modeset_disables(struct intel_atomic_state *state)
 {
 	struct intel_crtc_state *new_crtc_state, *old_crtc_state;
 	struct intel_crtc *crtc;
+	u32 handled = 0;
 	int i;
 
-	/*
-	 * Disable CRTC/pipes in reverse order because some features(MST in
-	 * TGL+) requires master and slave relationship between pipes, so it
-	 * should always pick the lowest pipe as master as it will be enabled
-	 * first and disable in the reverse order so the master will be the
-	 * last one to be disabled.
-	 */
-	for_each_oldnew_intel_crtc_in_state_reverse(state, crtc, old_crtc_state,
-						    new_crtc_state, i) {
+	/* Only disable port sync slaves */
+	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
+					    new_crtc_state, i) {
 		if (!needs_modeset(new_crtc_state))
 			continue;
 
+		if (!old_crtc_state->hw.active)
+			continue;
+
 		/* In case of Transcoder port Sync master slave CRTCs can be
 		 * assigned in any order and we need to make sure that
 		 * slave CRTCs are disabled first and then master CRTC since
 		 * Slave vblanks are masked till Master Vblanks.
 		 */
-		if (is_trans_port_sync_mode(old_crtc_state)) {
-			if (is_trans_port_sync_master(old_crtc_state))
-				intel_trans_port_sync_modeset_disables(state,
-								       crtc,
-								       old_crtc_state,
-								       new_crtc_state);
-			else
-				continue;
-		} else {
-			intel_pre_plane_update(state, crtc);
+		if (!is_trans_port_sync_slave(old_crtc_state))
+			continue;
 
-			if (old_crtc_state->hw.active)
-				intel_old_crtc_state_disables(state,
-							      old_crtc_state,
-							      new_crtc_state,
-							      crtc);
-		}
+		intel_pre_plane_update(state, crtc);
+		intel_old_crtc_state_disables(state, old_crtc_state,
+					      new_crtc_state, crtc);
+		handled |= BIT(crtc->pipe);
+	}
+
+	/* Disable everything else left on */
+	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
+					    new_crtc_state, i) {
+		if (!needs_modeset(new_crtc_state) ||
+		    (handled & BIT(crtc->pipe)))
+			continue;
+
+		intel_pre_plane_update(state, crtc);
+		if (old_crtc_state->hw.active)
+			intel_old_crtc_state_disables(state, old_crtc_state,
+						      new_crtc_state, crtc);
 	}
 }
 
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes
  2019-12-05 21:03 [Intel-gfx] [PATCH v4 1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes José Roberto de Souza
  2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 2/3] drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off José Roberto de Souza
  2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables() José Roberto de Souza
@ 2019-12-05 21:49 ` Patchwork
  2019-12-06  5:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-12-05 21:49 UTC (permalink / raw)
  To: José Roberto de Souza; +Cc: intel-gfx

== Series Details ==

Series: series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes
URL   : https://patchwork.freedesktop.org/series/70520/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7492 -> Patchwork_15614
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/index.html

Known issues
------------

  Here are the changes found in Patchwork_15614 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-skl-6770hq:      [PASS][1] -> [DMESG-WARN][2] ([i915#88])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [PASS][3] -> [DMESG-WARN][4] ([i915#592])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][5] ([i915#553] / [i915#725]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-hsw-4770/igt@i915_selftest@live_blt.html
    - fi-hsw-4770r:       [DMESG-FAIL][7] ([i915#553] / [i915#725]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-hsw-4770r/igt@i915_selftest@live_blt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-hsw-4770r/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-n2820:       [INCOMPLETE][9] ([i915#45]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][11] ([i915#44]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-kbl-x1275:       [DMESG-WARN][13] ([fdo#107139] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([fdo#107139] / [i915#62] / [i915#92])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_pm_rpm@module-reload:
    - fi-icl-u2:          [DMESG-WARN][15] ([i915#109] / [i915#289]) -> [DMESG-WARN][16] ([i915#289])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-icl-u2/igt@i915_pm_rpm@module-reload.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-icl-u2/igt@i915_pm_rpm@module-reload.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +7 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-x1275:       [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#62] / [i915#92]) +5 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
  [i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
  [i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#592]: https://gitlab.freedesktop.org/drm/intel/issues/592
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#88]: https://gitlab.freedesktop.org/drm/intel/issues/88
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (54 -> 46)
------------------------------

  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-icl-dsi fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7492 -> Patchwork_15614

  CI-20190529: 20190529
  CI_DRM_7492: ec21eea4cc81d13a08e97f35d02ec7f7bc472949 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5333: e08522bb09ff1b9720359b3867da7e4aca0bd5f1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15614: 653132e4f9e9423f23d8b0afa720b8df50267bb8 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

653132e4f9e9 drm/i915/display: Refactor intel_commit_modeset_disables()
de10b36a0498 drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off
d9c8bd2f5c06 drm/i915/display: Do not check for the ddb allocations of turned off pipes

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes
  2019-12-05 21:03 [Intel-gfx] [PATCH v4 1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes José Roberto de Souza
                   ` (2 preceding siblings ...)
  2019-12-05 21:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes Patchwork
@ 2019-12-06  5:56 ` Patchwork
  2019-12-06 23:23   ` Souza, Jose
  3 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2019-12-06  5:56 UTC (permalink / raw)
  To: Souza, Jose; +Cc: intel-gfx

== Series Details ==

Series: series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes
URL   : https://patchwork.freedesktop.org/series/70520/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7492_full -> Patchwork_15614_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15614_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15614_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15614_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_parallel@vcs0-contexts:
    - shard-tglb:         [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb1/igt@gem_exec_parallel@vcs0-contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@gem_exec_parallel@vcs0-contexts.html

  * igt@gem_exec_parse_blt@allowed-single:
    - shard-skl:          [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl4/igt@gem_exec_parse_blt@allowed-single.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl5/igt@gem_exec_parse_blt@allowed-single.html

  * igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled:
    - shard-skl:          [PASS][5] -> [INCOMPLETE][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl5/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html

  
Known issues
------------

  Here are the changes found in Patchwork_15614_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@rcs0-mixed-process:
    - shard-skl:          [PASS][7] -> [FAIL][8] ([i915#679]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl6/igt@gem_ctx_persistence@rcs0-mixed-process.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl4/igt@gem_ctx_persistence@rcs0-mixed-process.html

  * igt@gem_ctx_persistence@vcs1-queued:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#109276] / [fdo#112080]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@gem_ctx_persistence@vcs1-queued.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html

  * igt@gem_exec_create@forked:
    - shard-tglb:         [PASS][11] -> [INCOMPLETE][12] ([fdo#108838] / [i915#435])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb1/igt@gem_exec_create@forked.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb3/igt@gem_exec_create@forked.html

  * igt@gem_exec_parallel@fds:
    - shard-tglb:         [PASS][13] -> [INCOMPLETE][14] ([i915#470])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb9/igt@gem_exec_parallel@fds.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb6/igt@gem_exec_parallel@fds.html

  * igt@gem_exec_schedule@in-order-bsd2:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109276]) +5 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@gem_exec_schedule@in-order-bsd2.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@gem_exec_schedule@in-order-bsd2.html

  * igt@gem_exec_schedule@pi-ringfull-bsd:
    - shard-iclb:         [PASS][17] -> [SKIP][18] ([fdo#112146]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb5/igt@gem_exec_schedule@pi-ringfull-bsd.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb1/igt@gem_exec_schedule@pi-ringfull-bsd.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#644])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_softpin@noreloc-s3:
    - shard-apl:          [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +2 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl7/igt@gem_softpin@noreloc-s3.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl6/igt@gem_softpin@noreloc-s3.html

  * igt@gem_sync@basic-each:
    - shard-tglb:         [PASS][23] -> [INCOMPLETE][24] ([i915#472] / [i915#707])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb5/igt@gem_sync@basic-each.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@gem_sync@basic-each.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-snb:          [PASS][25] -> [DMESG-WARN][26] ([fdo#111870]) +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@i915_pm_rpm@modeset-stress-extra-wait:
    - shard-glk:          [PASS][27] -> [DMESG-WARN][28] ([i915#118] / [i915#95])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-glk3/igt@i915_pm_rpm@modeset-stress-extra-wait.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html

  * igt@kms_big_fb@y-tiled-32bpp-rotate-0:
    - shard-skl:          [PASS][29] -> [DMESG-WARN][30] ([i915#109])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl3/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl3/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html

  * igt@kms_big_fb@y-tiled-32bpp-rotate-270:
    - shard-skl:          [PASS][31] -> [INCOMPLETE][32] ([fdo#112347] / [i915#655])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl2/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl6/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
    - shard-skl:          [PASS][33] -> [FAIL][34] ([i915#54]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-tglb:         [PASS][35] -> [INCOMPLETE][36] ([i915#456] / [i915#460])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled:
    - shard-kbl:          [PASS][37] -> [DMESG-WARN][38] ([i915#728]) +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl4/igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl4/igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
    - shard-iclb:         [PASS][39] -> [FAIL][40] ([i915#49]) +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
    - shard-kbl:          [PASS][41] -> [INCOMPLETE][42] ([fdo#103665] / [i915#634])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [PASS][43] -> [DMESG-WARN][44] ([i915#180]) +5 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
    - shard-apl:          [PASS][45] -> [INCOMPLETE][46] ([fdo#103927])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
    - shard-tglb:         [PASS][47] -> [INCOMPLETE][48] ([i915#456] / [i915#460] / [i915#474])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
    - shard-tglb:         [PASS][49] -> [FAIL][50] ([i915#49])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt:
    - shard-skl:          [PASS][51] -> [DMESG-WARN][52] ([i915#728]) +5 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_plane@pixel-format-pipe-b-planes:
    - shard-kbl:          [PASS][53] -> [INCOMPLETE][54] ([fdo#103665]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl4/igt@kms_plane@pixel-format-pipe-b-planes.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl3/igt@kms_plane@pixel-format-pipe-b-planes.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [PASS][55] -> [SKIP][56] ([fdo#109441]) +3 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
    - shard-tglb:         [PASS][57] -> [INCOMPLETE][58] ([i915#460])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb2/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb8/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html

  * igt@perf@short-reads:
    - shard-hsw:          [PASS][59] -> [FAIL][60] ([i915#51])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw7/igt@perf@short-reads.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw6/igt@perf@short-reads.html

  * igt@perf_pmu@busy-check-all-vcs1:
    - shard-iclb:         [PASS][61] -> [SKIP][62] ([fdo#112080]) +3 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@perf_pmu@busy-check-all-vcs1.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@perf_pmu@busy-check-all-vcs1.html

  * igt@perf_pmu@multi-client-rcs0:
    - shard-iclb:         [PASS][63] -> [DMESG-WARN][64] ([i915#728])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb5/igt@perf_pmu@multi-client-rcs0.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb8/igt@perf_pmu@multi-client-rcs0.html

  
#### Possible fixes ####

  * igt@gem_ctx_persistence@vcs0-mixed-process:
    - shard-tglb:         [FAIL][65] -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb3/igt@gem_ctx_persistence@vcs0-mixed-process.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb8/igt@gem_ctx_persistence@vcs0-mixed-process.html

  * igt@gem_ctx_persistence@vcs1-hostile-preempt:
    - shard-iclb:         [SKIP][67] ([fdo#109276] / [fdo#112080]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb5/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb1/igt@gem_ctx_persistence@vcs1-hostile-preempt.html

  * igt@gem_exec_parallel@rcs0-fds:
    - shard-hsw:          [DMESG-WARN][69] -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw1/igt@gem_exec_parallel@rcs0-fds.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw2/igt@gem_exec_parallel@rcs0-fds.html

  * igt@gem_exec_schedule@fifo-bsd:
    - shard-iclb:         [SKIP][71] ([fdo#112146]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@gem_exec_schedule@fifo-bsd.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@gem_exec_schedule@fifo-bsd.html

  * igt@gem_exec_schedule@independent-bsd2:
    - shard-iclb:         [SKIP][73] ([fdo#109276]) -> [PASS][74] +3 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb4/igt@gem_exec_schedule@independent-bsd2.html

  * igt@gem_exec_schedule@smoketest-vebox:
    - shard-tglb:         [INCOMPLETE][75] ([i915#707]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@gem_exec_schedule@smoketest-vebox.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb5/igt@gem_exec_schedule@smoketest-vebox.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-iclb:         [INCOMPLETE][77] ([fdo#109100] / [i915#140]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-apl:          [FAIL][79] ([i915#644]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl1/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [DMESG-WARN][81] ([fdo#111870]) -> [PASS][82] +1 similar issue
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [FAIL][83] ([i915#454]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-tglb:         [INCOMPLETE][85] ([i915#456] / [i915#460]) -> [PASS][86] +1 similar issue
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb7/igt@i915_pm_rpm@system-suspend-execbuf.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb1/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][87] ([i915#180]) -> [PASS][88] +2 similar issues
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_atomic_transition@plane-all-transition:
    - shard-tglb:         [DMESG-WARN][89] ([i915#402]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@kms_atomic_transition@plane-all-transition.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@kms_atomic_transition@plane-all-transition.html

  * igt@kms_big_fb@y-tiled-32bpp-rotate-90:
    - shard-kbl:          [INCOMPLETE][91] ([fdo#103665]) -> [PASS][92] +3 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl6/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl4/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
    - shard-skl:          [INCOMPLETE][93] -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl7/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl8/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-180:
    - shard-skl:          [INCOMPLETE][95] ([fdo#112347]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl1/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl6/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-kbl:          [DMESG-WARN][97] ([i915#728]) -> [PASS][98] +2 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl2/igt@kms_ccs@pipe-a-crc-sprite-planes-basic.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
    - shard-skl:          [FAIL][99] ([i915#54]) -> [PASS][100] +2 similar issues
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +3 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          [FAIL][103] ([i915#96]) -> [PASS][104]
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_flip@2x-flip-vs-expired-vblank:
    - shard-glk:          [FAIL][105] ([i915#79]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html

  * igt@kms_flip@2x-plain-flip-ts-check:
    - shard-hsw:          [INCOMPLETE][107] ([i915#61]) -> [PASS][108] +2 similar issues
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw7/igt@kms_flip@2x-plain-flip-ts-check.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw4/igt@kms_flip@2x-plain-flip-ts-check.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-iclb:         [FAIL][109] ([i915#49]) -> [PASS][110] +3 similar issues
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb6/igt@kms_frontbuffer_tracking@basic.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-tglb:         [FAIL][111] ([i915#49]) -> [PASS][112]
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-tglb:         [INCOMPLETE][113] ([i915#456] / [i915#460] / [i915#474]) -> [PASS][114]
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt:
    - shard-skl:          [DMESG-WARN][115] ([i915#728]) -> [PASS][116] +4 similar issues
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt.html

  * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
    - shard-skl:          [INCOMPLETE][117] ([i915#648]) -> [PASS][118]
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl5/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl7/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
    - shard-skl:          [FAIL][119] ([fdo#108145]) -> [PASS][120] +1 similar issue
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html

  * igt@perf_pmu@busy-accuracy-98-vcs0:
    - shard-iclb:         [DMESG-WARN][121] ([i915#728]) -> [PASS][122] +1 similar issue
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb3/igt@perf_pmu@busy-accuracy-98-vcs0.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@perf_pmu@busy-accuracy-98-vcs0.html

  * igt@perf_pmu@busy-vcs1:
    - shard-iclb:         [SKIP][123] ([fdo#112080]) -> [PASS][124] +8 similar issues
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@perf_pmu@busy-vcs1.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb4/igt@perf_pmu@busy-vcs1.html

  * igt@perf_pmu@render-node-busy-vcs1:
    - shard-tglb:         [DMESG-WARN][125] ([i915#728]) -> [PASS][126] +3 similar issues
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb3/igt@perf_pmu@render-node-busy-vcs1.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb8/igt@perf_pmu@render-node-busy-vcs1.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [SKIP][127] ([fdo#109276] / [fdo#112080]) -> [FAIL][128] ([IGT#28]) +1 similar issue
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-tglb:         [SKIP][129] ([i915#468]) -> [FAIL][130] ([i915#454])
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@i915_pm_dc@dc6-psr.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb5/igt@i915_pm_dc@dc6-psr.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-kbl:          [FAIL][131] ([i915#54]) -> [DMESG-FAIL][132] ([i915#180] / [i915#54])
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [INCOMPLETE][133] ([i915#140]) -> [FAIL][134] ([i915#49])
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
    - shard-iclb:         [FAIL][135] ([i915#49]) -> [DMESG-WARN][136] ([i915#728])
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html

  * igt@kms_plane@pixel-format-pipe-a-planes:
    - shard-skl:          [INCOMPLETE][137] ([fdo#112347] / [i915#648]) -> [INCOMPLETE][138] ([fdo#112391] / [i915#648])
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl10/igt@kms_plane@pixel-format-pipe-a-planes.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl1/igt@kms_plane@pixel-format-pipe-a-planes.html

  * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
    - shard-kbl:          [INCOMPLETE][139] ([fdo#103665]) -> [DMESG-WARN][140] ([i915#728])
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl2/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl2/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html

  * igt@kms_plane@pixel-format-pipe-b-planes:
    - shard-skl:          [INCOMPLETE][141] ([fdo#112391] / [i915#648]) -> [INCOMPLETE][142] ([fdo#112347] / [i915#648]) +1 similar issue
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl10/igt@kms_plane@pixel-format-pipe-b-planes.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl10/igt@kms_plane@pixel-format-pipe-b-planes.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108838]: https://bugs.freedesktop.org/show_bug.cgi?id=108838
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
  [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
  [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
  [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
  [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
  [i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
  [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
  [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
  [i915#634]: https://gitlab.freedesktop.org/drm/intel/issues/634
  [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
  [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
  [i915#655]: https://gitlab.freedesktop.org/drm/intel/issues/655
  [i915#669]: https://gitlab.freedesktop.org/drm/intel/issues/669
  [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
  [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
  [i915#728]: https://gitlab.free

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables()
  2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables() José Roberto de Souza
@ 2019-12-06 22:22   ` Matt Roper
  2019-12-06 22:35     ` Souza, Jose
  0 siblings, 1 reply; 9+ messages in thread
From: Matt Roper @ 2019-12-06 22:22 UTC (permalink / raw)
  To: José Roberto de Souza; +Cc: intel-gfx, Lucas De Marchi

On Thu, Dec 05, 2019 at 01:03:50PM -0800, José Roberto de Souza wrote:
> Commit 9c722e17c1b9 ("drm/i915: Disable pipes in reverse order")
> reverted the order that pipes gets disabled because of TGL
> master/slave relationship between transcoders in MST mode.
> 
> But as stated in a comment in skl_commit_modeset_enables() the
> enabling order is not always crescent, possibly causing previously
> selected slave transcoder being enabled before master so another
> approach will be needed to select a transcoder to master in MST mode.
> It will be similar to the approach taken in port sync.
> 
> But instead of implement something like
> intel_trans_port_sync_modeset_disables() to MST lets simply it and
> iterate over all pipes 2 times, the first one disabling any slave and
> then disabling everything else.
> The MST bits will be added in another patch.
> 
> v2:
> Not using crtc->active as it is deprecated
> 
> v3:
> Removing is_trans_port_sync_mode() check, just check for
> is_trans_port_sync_master() is enough
> 
> v4:
> Adding and using is_trans_port_sync_slave(), otherwise non-port sync
> pipes will be disabled in the first loop, what is not wrong but is
> not what patch description promises
> 
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v2)
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 88 +++++++-------------
>  1 file changed, 32 insertions(+), 56 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 68575457d40e..821ba8053f9d 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -561,6 +561,12 @@ is_trans_port_sync_master(const struct intel_crtc_state *crtc_state)
>  		crtc_state->sync_mode_slaves_mask);
>  }
>  
> +static bool
> +is_trans_port_sync_slave(const struct intel_crtc_state *crtc_state)
> +{
> +	return crtc_state->master_transcoder != INVALID_TRANSCODER;
> +}
> +
>  /*
>   * Platform specific helpers to calculate the port PLL loopback- (clock.m),
>   * and post-divider (clock.p) values, pre- (clock.vco) and post-divided fast
> @@ -14393,77 +14399,47 @@ static void intel_old_crtc_state_disables(struct intel_atomic_state *state,
>  		dev_priv->display.initial_watermarks(state, crtc);
>  }
>  
> -static void intel_trans_port_sync_modeset_disables(struct intel_atomic_state *state,
> -						   struct intel_crtc *crtc,
> -						   struct intel_crtc_state *old_crtc_state,
> -						   struct intel_crtc_state *new_crtc_state)
> -{
> -	struct intel_crtc *slave_crtc = intel_get_slave_crtc(new_crtc_state);
> -	struct intel_crtc_state *new_slave_crtc_state =
> -		intel_atomic_get_new_crtc_state(state, slave_crtc);
> -	struct intel_crtc_state *old_slave_crtc_state =
> -		intel_atomic_get_old_crtc_state(state, slave_crtc);
> -
> -	WARN_ON(!slave_crtc || !new_slave_crtc_state ||
> -		!old_slave_crtc_state);
> -
> -	/* Disable Slave first */
> -	intel_pre_plane_update(state, slave_crtc);
> -	if (old_slave_crtc_state->hw.active)
> -		intel_old_crtc_state_disables(state,
> -					      old_slave_crtc_state,
> -					      new_slave_crtc_state,
> -					      slave_crtc);
> -
> -	/* Disable Master */
> -	intel_pre_plane_update(state, crtc);
> -	if (old_crtc_state->hw.active)
> -		intel_old_crtc_state_disables(state,
> -					      old_crtc_state,
> -					      new_crtc_state,
> -					      crtc);
> -}
> -
>  static void intel_commit_modeset_disables(struct intel_atomic_state *state)
>  {
>  	struct intel_crtc_state *new_crtc_state, *old_crtc_state;
>  	struct intel_crtc *crtc;
> +	u32 handled = 0;
>  	int i;
>  
> -	/*
> -	 * Disable CRTC/pipes in reverse order because some features(MST in
> -	 * TGL+) requires master and slave relationship between pipes, so it
> -	 * should always pick the lowest pipe as master as it will be enabled
> -	 * first and disable in the reverse order so the master will be the
> -	 * last one to be disabled.
> -	 */
> -	for_each_oldnew_intel_crtc_in_state_reverse(state, crtc, old_crtc_state,
> -						    new_crtc_state, i) {
> +	/* Only disable port sync slaves */
> +	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> +					    new_crtc_state, i) {
>  		if (!needs_modeset(new_crtc_state))
>  			continue;
>  
> +		if (!old_crtc_state->hw.active)
> +			continue;

Is it intentional that we skip the intel_pre_plane_update() in this case
for the slaves, but not the masters?  Should this test be moved farther
down below the pre_plane_update call?


Matt

> +
>  		/* In case of Transcoder port Sync master slave CRTCs can be
>  		 * assigned in any order and we need to make sure that
>  		 * slave CRTCs are disabled first and then master CRTC since
>  		 * Slave vblanks are masked till Master Vblanks.
>  		 */
> -		if (is_trans_port_sync_mode(old_crtc_state)) {
> -			if (is_trans_port_sync_master(old_crtc_state))
> -				intel_trans_port_sync_modeset_disables(state,
> -								       crtc,
> -								       old_crtc_state,
> -								       new_crtc_state);
> -			else
> -				continue;
> -		} else {
> -			intel_pre_plane_update(state, crtc);
> +		if (!is_trans_port_sync_slave(old_crtc_state))
> +			continue;
>  
> -			if (old_crtc_state->hw.active)
> -				intel_old_crtc_state_disables(state,
> -							      old_crtc_state,
> -							      new_crtc_state,
> -							      crtc);
> -		}
> +		intel_pre_plane_update(state, crtc);
> +		intel_old_crtc_state_disables(state, old_crtc_state,
> +					      new_crtc_state, crtc);
> +		handled |= BIT(crtc->pipe);
> +	}
> +
> +	/* Disable everything else left on */
> +	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> +					    new_crtc_state, i) {
> +		if (!needs_modeset(new_crtc_state) ||
> +		    (handled & BIT(crtc->pipe)))
> +			continue;
> +
> +		intel_pre_plane_update(state, crtc);
> +		if (old_crtc_state->hw.active)
> +			intel_old_crtc_state_disables(state, old_crtc_state,
> +						      new_crtc_state, crtc);
>  	}
>  }
>  
> -- 
> 2.24.0
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables()
  2019-12-06 22:22   ` Matt Roper
@ 2019-12-06 22:35     ` Souza, Jose
  2019-12-06 22:37       ` Matt Roper
  0 siblings, 1 reply; 9+ messages in thread
From: Souza, Jose @ 2019-12-06 22:35 UTC (permalink / raw)
  To: Roper, Matthew D; +Cc: De Marchi, Lucas, intel-gfx

On Fri, 2019-12-06 at 14:22 -0800, Matt Roper wrote:
> On Thu, Dec 05, 2019 at 01:03:50PM -0800, José Roberto de Souza
> wrote:
> > Commit 9c722e17c1b9 ("drm/i915: Disable pipes in reverse order")
> > reverted the order that pipes gets disabled because of TGL
> > master/slave relationship between transcoders in MST mode.
> > 
> > But as stated in a comment in skl_commit_modeset_enables() the
> > enabling order is not always crescent, possibly causing previously
> > selected slave transcoder being enabled before master so another
> > approach will be needed to select a transcoder to master in MST
> > mode.
> > It will be similar to the approach taken in port sync.
> > 
> > But instead of implement something like
> > intel_trans_port_sync_modeset_disables() to MST lets simply it and
> > iterate over all pipes 2 times, the first one disabling any slave
> > and
> > then disabling everything else.
> > The MST bits will be added in another patch.
> > 
> > v2:
> > Not using crtc->active as it is deprecated
> > 
> > v3:
> > Removing is_trans_port_sync_mode() check, just check for
> > is_trans_port_sync_master() is enough
> > 
> > v4:
> > Adding and using is_trans_port_sync_slave(), otherwise non-port
> > sync
> > pipes will be disabled in the first loop, what is not wrong but is
> > not what patch description promises
> > 
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v2)
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_display.c | 88 +++++++---------
> > ----
> >  1 file changed, 32 insertions(+), 56 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 68575457d40e..821ba8053f9d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -561,6 +561,12 @@ is_trans_port_sync_master(const struct
> > intel_crtc_state *crtc_state)
> >  		crtc_state->sync_mode_slaves_mask);
> >  }
> >  
> > +static bool
> > +is_trans_port_sync_slave(const struct intel_crtc_state
> > *crtc_state)
> > +{
> > +	return crtc_state->master_transcoder != INVALID_TRANSCODER;
> > +}
> > +
> >  /*
> >   * Platform specific helpers to calculate the port PLL loopback-
> > (clock.m),
> >   * and post-divider (clock.p) values, pre- (clock.vco) and post-
> > divided fast
> > @@ -14393,77 +14399,47 @@ static void
> > intel_old_crtc_state_disables(struct intel_atomic_state *state,
> >  		dev_priv->display.initial_watermarks(state, crtc);
> >  }
> >  
> > -static void intel_trans_port_sync_modeset_disables(struct
> > intel_atomic_state *state,
> > -						   struct intel_crtc
> > *crtc,
> > -						   struct
> > intel_crtc_state *old_crtc_state,
> > -						   struct
> > intel_crtc_state *new_crtc_state)
> > -{
> > -	struct intel_crtc *slave_crtc =
> > intel_get_slave_crtc(new_crtc_state);
> > -	struct intel_crtc_state *new_slave_crtc_state =
> > -		intel_atomic_get_new_crtc_state(state, slave_crtc);
> > -	struct intel_crtc_state *old_slave_crtc_state =
> > -		intel_atomic_get_old_crtc_state(state, slave_crtc);
> > -
> > -	WARN_ON(!slave_crtc || !new_slave_crtc_state ||
> > -		!old_slave_crtc_state);
> > -
> > -	/* Disable Slave first */
> > -	intel_pre_plane_update(state, slave_crtc);
> > -	if (old_slave_crtc_state->hw.active)
> > -		intel_old_crtc_state_disables(state,
> > -					      old_slave_crtc_state,
> > -					      new_slave_crtc_state,
> > -					      slave_crtc);
> > -
> > -	/* Disable Master */
> > -	intel_pre_plane_update(state, crtc);
> > -	if (old_crtc_state->hw.active)
> > -		intel_old_crtc_state_disables(state,
> > -					      old_crtc_state,
> > -					      new_crtc_state,
> > -					      crtc);
> > -}
> > -
> >  static void intel_commit_modeset_disables(struct
> > intel_atomic_state *state)
> >  {
> >  	struct intel_crtc_state *new_crtc_state, *old_crtc_state;
> >  	struct intel_crtc *crtc;
> > +	u32 handled = 0;
> >  	int i;
> >  
> > -	/*
> > -	 * Disable CRTC/pipes in reverse order because some
> > features(MST in
> > -	 * TGL+) requires master and slave relationship between pipes,
> > so it
> > -	 * should always pick the lowest pipe as master as it will be
> > enabled
> > -	 * first and disable in the reverse order so the master will be
> > the
> > -	 * last one to be disabled.
> > -	 */
> > -	for_each_oldnew_intel_crtc_in_state_reverse(state, crtc,
> > old_crtc_state,
> > -						    new_crtc_state, i)
> > {
> > +	/* Only disable port sync slaves */
> > +	for_each_oldnew_intel_crtc_in_state(state, crtc,
> > old_crtc_state,
> > +					    new_crtc_state, i) {
> >  		if (!needs_modeset(new_crtc_state))
> >  			continue;
> >  
> > +		if (!old_crtc_state->hw.active)
> > +			continue;
> 
> Is it intentional that we skip the intel_pre_plane_update() in this
> case
> for the slaves, but not the masters?  Should this test be moved
> farther
> down below the pre_plane_update call?

If it was inative it is not a port sync slave, for the pipes going from
disabled to enabled in port sync slave mode the pre_plane_update() will
be executed in the second loop.

This is more of an optimization to not even check if is port sync slave
and in future if is MST slave.

I had a comment here but Ville asked to remove it. 
https://patchwork.freedesktop.org/patch/343736/?series=70462&rev=2

> 
> 
> Matt
> 
> > +
> >  		/* In case of Transcoder port Sync master slave CRTCs
> > can be
> >  		 * assigned in any order and we need to make sure that
> >  		 * slave CRTCs are disabled first and then master CRTC
> > since
> >  		 * Slave vblanks are masked till Master Vblanks.
> >  		 */
> > -		if (is_trans_port_sync_mode(old_crtc_state)) {
> > -			if (is_trans_port_sync_master(old_crtc_state))
> > -				intel_trans_port_sync_modeset_disables(
> > state,
> > -								       
> > crtc,
> > -								       
> > old_crtc_state,
> > -								       
> > new_crtc_state);
> > -			else
> > -				continue;
> > -		} else {
> > -			intel_pre_plane_update(state, crtc);
> > +		if (!is_trans_port_sync_slave(old_crtc_state))
> > +			continue;
> >  
> > -			if (old_crtc_state->hw.active)
> > -				intel_old_crtc_state_disables(state,
> > -							      old_crtc_
> > state,
> > -							      new_crtc_
> > state,
> > -							      crtc);
> > -		}
> > +		intel_pre_plane_update(state, crtc);
> > +		intel_old_crtc_state_disables(state, old_crtc_state,
> > +					      new_crtc_state, crtc);
> > +		handled |= BIT(crtc->pipe);
> > +	}
> > +
> > +	/* Disable everything else left on */
> > +	for_each_oldnew_intel_crtc_in_state(state, crtc,
> > old_crtc_state,
> > +					    new_crtc_state, i) {
> > +		if (!needs_modeset(new_crtc_state) ||
> > +		    (handled & BIT(crtc->pipe)))
> > +			continue;
> > +
> > +		intel_pre_plane_update(state, crtc);
> > +		if (old_crtc_state->hw.active)
> > +			intel_old_crtc_state_disables(state,
> > old_crtc_state,
> > +						      new_crtc_state,
> > crtc);
> >  	}
> >  }
> >  
> > -- 
> > 2.24.0
> > 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables()
  2019-12-06 22:35     ` Souza, Jose
@ 2019-12-06 22:37       ` Matt Roper
  0 siblings, 0 replies; 9+ messages in thread
From: Matt Roper @ 2019-12-06 22:37 UTC (permalink / raw)
  To: Souza, Jose; +Cc: De Marchi, Lucas, intel-gfx

On Fri, Dec 06, 2019 at 02:35:38PM -0800, Souza, Jose wrote:
> On Fri, 2019-12-06 at 14:22 -0800, Matt Roper wrote:
> > On Thu, Dec 05, 2019 at 01:03:50PM -0800, José Roberto de Souza
> > wrote:
> > > Commit 9c722e17c1b9 ("drm/i915: Disable pipes in reverse order")
> > > reverted the order that pipes gets disabled because of TGL
> > > master/slave relationship between transcoders in MST mode.
> > > 
> > > But as stated in a comment in skl_commit_modeset_enables() the
> > > enabling order is not always crescent, possibly causing previously
> > > selected slave transcoder being enabled before master so another
> > > approach will be needed to select a transcoder to master in MST
> > > mode.
> > > It will be similar to the approach taken in port sync.
> > > 
> > > But instead of implement something like
> > > intel_trans_port_sync_modeset_disables() to MST lets simply it and
> > > iterate over all pipes 2 times, the first one disabling any slave
> > > and
> > > then disabling everything else.
> > > The MST bits will be added in another patch.
> > > 
> > > v2:
> > > Not using crtc->active as it is deprecated
> > > 
> > > v3:
> > > Removing is_trans_port_sync_mode() check, just check for
> > > is_trans_port_sync_master() is enough
> > > 
> > > v4:
> > > Adding and using is_trans_port_sync_slave(), otherwise non-port
> > > sync
> > > pipes will be disabled in the first loop, what is not wrong but is
> > > not what patch description promises
> > > 
> > > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v2)
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_display.c | 88 +++++++---------
> > > ----
> > >  1 file changed, 32 insertions(+), 56 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > index 68575457d40e..821ba8053f9d 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -561,6 +561,12 @@ is_trans_port_sync_master(const struct
> > > intel_crtc_state *crtc_state)
> > >  		crtc_state->sync_mode_slaves_mask);
> > >  }
> > >  
> > > +static bool
> > > +is_trans_port_sync_slave(const struct intel_crtc_state
> > > *crtc_state)
> > > +{
> > > +	return crtc_state->master_transcoder != INVALID_TRANSCODER;
> > > +}
> > > +
> > >  /*
> > >   * Platform specific helpers to calculate the port PLL loopback-
> > > (clock.m),
> > >   * and post-divider (clock.p) values, pre- (clock.vco) and post-
> > > divided fast
> > > @@ -14393,77 +14399,47 @@ static void
> > > intel_old_crtc_state_disables(struct intel_atomic_state *state,
> > >  		dev_priv->display.initial_watermarks(state, crtc);
> > >  }
> > >  
> > > -static void intel_trans_port_sync_modeset_disables(struct
> > > intel_atomic_state *state,
> > > -						   struct intel_crtc
> > > *crtc,
> > > -						   struct
> > > intel_crtc_state *old_crtc_state,
> > > -						   struct
> > > intel_crtc_state *new_crtc_state)
> > > -{
> > > -	struct intel_crtc *slave_crtc =
> > > intel_get_slave_crtc(new_crtc_state);
> > > -	struct intel_crtc_state *new_slave_crtc_state =
> > > -		intel_atomic_get_new_crtc_state(state, slave_crtc);
> > > -	struct intel_crtc_state *old_slave_crtc_state =
> > > -		intel_atomic_get_old_crtc_state(state, slave_crtc);
> > > -
> > > -	WARN_ON(!slave_crtc || !new_slave_crtc_state ||
> > > -		!old_slave_crtc_state);
> > > -
> > > -	/* Disable Slave first */
> > > -	intel_pre_plane_update(state, slave_crtc);
> > > -	if (old_slave_crtc_state->hw.active)
> > > -		intel_old_crtc_state_disables(state,
> > > -					      old_slave_crtc_state,
> > > -					      new_slave_crtc_state,
> > > -					      slave_crtc);
> > > -
> > > -	/* Disable Master */
> > > -	intel_pre_plane_update(state, crtc);
> > > -	if (old_crtc_state->hw.active)
> > > -		intel_old_crtc_state_disables(state,
> > > -					      old_crtc_state,
> > > -					      new_crtc_state,
> > > -					      crtc);
> > > -}
> > > -
> > >  static void intel_commit_modeset_disables(struct
> > > intel_atomic_state *state)
> > >  {
> > >  	struct intel_crtc_state *new_crtc_state, *old_crtc_state;
> > >  	struct intel_crtc *crtc;
> > > +	u32 handled = 0;
> > >  	int i;
> > >  
> > > -	/*
> > > -	 * Disable CRTC/pipes in reverse order because some
> > > features(MST in
> > > -	 * TGL+) requires master and slave relationship between pipes,
> > > so it
> > > -	 * should always pick the lowest pipe as master as it will be
> > > enabled
> > > -	 * first and disable in the reverse order so the master will be
> > > the
> > > -	 * last one to be disabled.
> > > -	 */
> > > -	for_each_oldnew_intel_crtc_in_state_reverse(state, crtc,
> > > old_crtc_state,
> > > -						    new_crtc_state, i)
> > > {
> > > +	/* Only disable port sync slaves */
> > > +	for_each_oldnew_intel_crtc_in_state(state, crtc,
> > > old_crtc_state,
> > > +					    new_crtc_state, i) {
> > >  		if (!needs_modeset(new_crtc_state))
> > >  			continue;
> > >  
> > > +		if (!old_crtc_state->hw.active)
> > > +			continue;
> > 
> > Is it intentional that we skip the intel_pre_plane_update() in this
> > case
> > for the slaves, but not the masters?  Should this test be moved
> > farther
> > down below the pre_plane_update call?
> 
> If it was inative it is not a port sync slave, for the pipes going from
> disabled to enabled in port sync slave mode the pre_plane_update() will
> be executed in the second loop.
> 
> This is more of an optimization to not even check if is port sync slave
> and in future if is MST slave.
> 
> I had a comment here but Ville asked to remove it. 
> https://patchwork.freedesktop.org/patch/343736/?series=70462&rev=2

Makes sense, thanks for clarifying.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> 
> > 
> > 
> > Matt
> > 
> > > +
> > >  		/* In case of Transcoder port Sync master slave CRTCs
> > > can be
> > >  		 * assigned in any order and we need to make sure that
> > >  		 * slave CRTCs are disabled first and then master CRTC
> > > since
> > >  		 * Slave vblanks are masked till Master Vblanks.
> > >  		 */
> > > -		if (is_trans_port_sync_mode(old_crtc_state)) {
> > > -			if (is_trans_port_sync_master(old_crtc_state))
> > > -				intel_trans_port_sync_modeset_disables(
> > > state,
> > > -								       
> > > crtc,
> > > -								       
> > > old_crtc_state,
> > > -								       
> > > new_crtc_state);
> > > -			else
> > > -				continue;
> > > -		} else {
> > > -			intel_pre_plane_update(state, crtc);
> > > +		if (!is_trans_port_sync_slave(old_crtc_state))
> > > +			continue;
> > >  
> > > -			if (old_crtc_state->hw.active)
> > > -				intel_old_crtc_state_disables(state,
> > > -							      old_crtc_
> > > state,
> > > -							      new_crtc_
> > > state,
> > > -							      crtc);
> > > -		}
> > > +		intel_pre_plane_update(state, crtc);
> > > +		intel_old_crtc_state_disables(state, old_crtc_state,
> > > +					      new_crtc_state, crtc);
> > > +		handled |= BIT(crtc->pipe);
> > > +	}
> > > +
> > > +	/* Disable everything else left on */
> > > +	for_each_oldnew_intel_crtc_in_state(state, crtc,
> > > old_crtc_state,
> > > +					    new_crtc_state, i) {
> > > +		if (!needs_modeset(new_crtc_state) ||
> > > +		    (handled & BIT(crtc->pipe)))
> > > +			continue;
> > > +
> > > +		intel_pre_plane_update(state, crtc);
> > > +		if (old_crtc_state->hw.active)
> > > +			intel_old_crtc_state_disables(state,
> > > old_crtc_state,
> > > +						      new_crtc_state,
> > > crtc);
> > >  	}
> > >  }
> > >  
> > > -- 
> > > 2.24.0
> > > 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Intel-gfx]  ✗ Fi.CI.IGT: failure for series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes
  2019-12-06  5:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-12-06 23:23   ` Souza, Jose
  0 siblings, 0 replies; 9+ messages in thread
From: Souza, Jose @ 2019-12-06 23:23 UTC (permalink / raw)
  To: intel-gfx

On Fri, 2019-12-06 at 05:56 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v4,1/3] drm/i915/display: Do not check
> for the ddb allocations of turned off pipes
> URL   : https://patchwork.freedesktop.org/series/70520/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7492_full -> Patchwork_15614_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_15614_full absolutely
> need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the
> changes
>   introduced in Patchwork_15614_full, please notify your bug team to
> allow them
>   to document this new failure mode, which will reduce false
> positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_15614_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_exec_parallel@vcs0-contexts:
>     - shard-tglb:         [PASS][1] -> [INCOMPLETE][2]
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb1/igt@gem_exec_parallel@vcs0-contexts.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@gem_exec_parallel@vcs0-contexts.html
> 
>   * igt@gem_exec_parse_blt@allowed-single:
>     - shard-skl:          [PASS][3] -> [DMESG-WARN][4]
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl4/igt@gem_exec_parse_blt@allowed-single.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl5/igt@gem_exec_parse_blt@allowed-single.html
> 
>   * igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled:
>     - shard-skl:          [PASS][5] -> [INCOMPLETE][6]
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl5/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html
> 


Not related to this changes, pushed do dinq. Thanks for the reviews
Matt and Ville.

>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_15614_full that come from
> known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_persistence@rcs0-mixed-process:
>     - shard-skl:          [PASS][7] -> [FAIL][8] ([i915#679]) +1
> similar issue
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl6/igt@gem_ctx_persistence@rcs0-mixed-process.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl4/igt@gem_ctx_persistence@rcs0-mixed-process.html
> 
>   * igt@gem_ctx_persistence@vcs1-queued:
>     - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#109276] /
> [fdo#112080]) +1 similar issue
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@gem_ctx_persistence@vcs1-queued.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html
> 
>   * igt@gem_exec_create@forked:
>     - shard-tglb:         [PASS][11] -> [INCOMPLETE][12]
> ([fdo#108838] / [i915#435])
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb1/igt@gem_exec_create@forked.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb3/igt@gem_exec_create@forked.html
> 
>   * igt@gem_exec_parallel@fds:
>     - shard-tglb:         [PASS][13] -> [INCOMPLETE][14] ([i915#470])
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb9/igt@gem_exec_parallel@fds.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb6/igt@gem_exec_parallel@fds.html
> 
>   * igt@gem_exec_schedule@in-order-bsd2:
>     - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109276]) +5
> similar issues
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@gem_exec_schedule@in-order-bsd2.html
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@gem_exec_schedule@in-order-bsd2.html
> 
>   * igt@gem_exec_schedule@pi-ringfull-bsd:
>     - shard-iclb:         [PASS][17] -> [SKIP][18] ([fdo#112146]) +2
> similar issues
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb5/igt@gem_exec_schedule@pi-ringfull-bsd.html
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb1/igt@gem_exec_schedule@pi-ringfull-bsd.html
> 
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#644])
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [20]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
> 
>   * igt@gem_softpin@noreloc-s3:
>     - shard-apl:          [PASS][21] -> [DMESG-WARN][22] ([i915#180])
> +2 similar issues
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl7/igt@gem_softpin@noreloc-s3.html
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl6/igt@gem_softpin@noreloc-s3.html
> 
>   * igt@gem_sync@basic-each:
>     - shard-tglb:         [PASS][23] -> [INCOMPLETE][24] ([i915#472]
> / [i915#707])
>    [23]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb5/igt@gem_sync@basic-each.html
>    [24]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@gem_sync@basic-each.html
> 
>   * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
>     - shard-snb:          [PASS][25] -> [DMESG-WARN][26]
> ([fdo#111870]) +1 similar issue
>    [25]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
> 
>   * igt@i915_pm_rpm@modeset-stress-extra-wait:
>     - shard-glk:          [PASS][27] -> [DMESG-WARN][28] ([i915#118]
> / [i915#95])
>    [27]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-glk3/igt@i915_pm_rpm@modeset-stress-extra-wait.html
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
> 
>   * igt@kms_big_fb@y-tiled-32bpp-rotate-0:
>     - shard-skl:          [PASS][29] -> [DMESG-WARN][30] ([i915#109])
>    [29]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl3/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl3/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
> 
>   * igt@kms_big_fb@y-tiled-32bpp-rotate-270:
>     - shard-skl:          [PASS][31] -> [INCOMPLETE][32]
> ([fdo#112347] / [i915#655])
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl2/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl6/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
>     - shard-skl:          [PASS][33] -> [FAIL][34] ([i915#54]) +1
> similar issue
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
>     - shard-tglb:         [PASS][35] -> [INCOMPLETE][36] ([i915#456]
> / [i915#460])
>    [35]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> 
>   * igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled:
>     - shard-kbl:          [PASS][37] -> [DMESG-WARN][38] ([i915#728])
> +1 similar issue
>    [37]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl4/igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled.html
>    [38]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl4/igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
>     - shard-iclb:         [PASS][39] -> [FAIL][40] ([i915#49]) +1
> similar issue
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
>    [40]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
>     - shard-kbl:          [PASS][41] -> [INCOMPLETE][42]
> ([fdo#103665] / [i915#634])
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-kbl:          [PASS][43] -> [DMESG-WARN][44] ([i915#180])
> +5 similar issues
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [44]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
>     - shard-apl:          [PASS][45] -> [INCOMPLETE][46]
> ([fdo#103927])
>    [45]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
>     - shard-tglb:         [PASS][47] -> [INCOMPLETE][48] ([i915#456]
> / [i915#460] / [i915#474])
>    [47]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [48]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
>     - shard-tglb:         [PASS][49] -> [FAIL][50] ([i915#49])
>    [49]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
>    [50]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
> 
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt:
>     - shard-skl:          [PASS][51] -> [DMESG-WARN][52] ([i915#728])
> +5 similar issues
>    [51]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html
>    [52]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html
> 
>   * igt@kms_plane@pixel-format-pipe-b-planes:
>     - shard-kbl:          [PASS][53] -> [INCOMPLETE][54]
> ([fdo#103665]) +1 similar issue
>    [53]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl4/igt@kms_plane@pixel-format-pipe-b-planes.html
>    [54]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl3/igt@kms_plane@pixel-format-pipe-b-planes.html
> 
>   * igt@kms_psr@psr2_sprite_mmap_gtt:
>     - shard-iclb:         [PASS][55] -> [SKIP][56] ([fdo#109441]) +3
> similar issues
>    [55]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
>    [56]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
> 
>   * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
>     - shard-tglb:         [PASS][57] -> [INCOMPLETE][58] ([i915#460])
>    [57]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb2/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
>    [58]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb8/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
> 
>   * igt@perf@short-reads:
>     - shard-hsw:          [PASS][59] -> [FAIL][60] ([i915#51])
>    [59]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw7/igt@perf@short-reads.html
>    [60]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw6/igt@perf@short-reads.html
> 
>   * igt@perf_pmu@busy-check-all-vcs1:
>     - shard-iclb:         [PASS][61] -> [SKIP][62] ([fdo#112080]) +3
> similar issues
>    [61]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@perf_pmu@busy-check-all-vcs1.html
>    [62]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@perf_pmu@busy-check-all-vcs1.html
> 
>   * igt@perf_pmu@multi-client-rcs0:
>     - shard-iclb:         [PASS][63] -> [DMESG-WARN][64] ([i915#728])
>    [63]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb5/igt@perf_pmu@multi-client-rcs0.html
>    [64]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb8/igt@perf_pmu@multi-client-rcs0.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_ctx_persistence@vcs0-mixed-process:
>     - shard-tglb:         [FAIL][65] -> [PASS][66]
>    [65]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb3/igt@gem_ctx_persistence@vcs0-mixed-process.html
>    [66]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb8/igt@gem_ctx_persistence@vcs0-mixed-process.html
> 
>   * igt@gem_ctx_persistence@vcs1-hostile-preempt:
>     - shard-iclb:         [SKIP][67] ([fdo#109276] / [fdo#112080]) ->
> [PASS][68]
>    [67]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb5/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
>    [68]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb1/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
> 
>   * igt@gem_exec_parallel@rcs0-fds:
>     - shard-hsw:          [DMESG-WARN][69] -> [PASS][70]
>    [69]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw1/igt@gem_exec_parallel@rcs0-fds.html
>    [70]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw2/igt@gem_exec_parallel@rcs0-fds.html
> 
>   * igt@gem_exec_schedule@fifo-bsd:
>     - shard-iclb:         [SKIP][71] ([fdo#112146]) -> [PASS][72]
>    [71]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@gem_exec_schedule@fifo-bsd.html
>    [72]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@gem_exec_schedule@fifo-bsd.html
> 
>   * igt@gem_exec_schedule@independent-bsd2:
>     - shard-iclb:         [SKIP][73] ([fdo#109276]) -> [PASS][74] +3
> similar issues
>    [73]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html
>    [74]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb4/igt@gem_exec_schedule@independent-bsd2.html
> 
>   * igt@gem_exec_schedule@smoketest-vebox:
>     - shard-tglb:         [INCOMPLETE][75] ([i915#707]) -> [PASS][76]
>    [75]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@gem_exec_schedule@smoketest-vebox.html
>    [76]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb5/igt@gem_exec_schedule@smoketest-vebox.html
> 
>   * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
>     - shard-iclb:         [INCOMPLETE][77] ([fdo#109100] /
> [i915#140]) -> [PASS][78]
>    [77]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
>    [78]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
> 
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-apl:          [FAIL][79] ([i915#644]) -> [PASS][80]
>    [79]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [80]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl1/igt@gem_ppgtt@flink-and-close-vma-leak.html
> 
>   * igt@gem_userptr_blits@sync-unmap-cycles:
>     - shard-snb:          [DMESG-WARN][81] ([fdo#111870]) ->
> [PASS][82] +1 similar issue
>    [81]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
>    [82]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html
> 
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-iclb:         [FAIL][83] ([i915#454]) -> [PASS][84]
>    [83]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
>    [84]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
> 
>   * igt@i915_pm_rpm@system-suspend-execbuf:
>     - shard-tglb:         [INCOMPLETE][85] ([i915#456] / [i915#460])
> -> [PASS][86] +1 similar issue
>    [85]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb7/igt@i915_pm_rpm@system-suspend-execbuf.html
>    [86]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb1/igt@i915_pm_rpm@system-suspend-execbuf.html
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-apl:          [DMESG-WARN][87] ([i915#180]) -> [PASS][88]
> +2 similar issues
>    [87]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
>    [88]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
> 
>   * igt@kms_atomic_transition@plane-all-transition:
>     - shard-tglb:         [DMESG-WARN][89] ([i915#402]) -> [PASS][90]
>    [89]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@kms_atomic_transition@plane-all-transition.html
>    [90]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@kms_atomic_transition@plane-all-transition.html
> 
>   * igt@kms_big_fb@y-tiled-32bpp-rotate-90:
>     - shard-kbl:          [INCOMPLETE][91] ([fdo#103665]) ->
> [PASS][92] +3 similar issues
>    [91]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl6/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
>    [92]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl4/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
>     - shard-skl:          [INCOMPLETE][93] -> [PASS][94]
>    [93]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl7/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
>    [94]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl8/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
> 
>   * igt@kms_big_fb@y-tiled-8bpp-rotate-180:
>     - shard-skl:          [INCOMPLETE][95] ([fdo#112347]) ->
> [PASS][96]
>    [95]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl1/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
>    [96]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl6/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
> 
>   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
>     - shard-kbl:          [DMESG-WARN][97] ([i915#728]) -> [PASS][98]
> +2 similar issues
>    [97]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic.html
>    [98]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl2/igt@kms_ccs@pipe-a-crc-sprite-planes-basic.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
>     - shard-skl:          [FAIL][99] ([i915#54]) -> [PASS][100] +2
> similar issues
>    [99]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
>    [100]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
>     - shard-kbl:          [DMESG-WARN][101] ([i915#180]) ->
> [PASS][102] +3 similar issues
>    [101]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>    [102]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> 
>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
>     - shard-hsw:          [FAIL][103] ([i915#96]) -> [PASS][104]
>    [103]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
>    [104]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
> 
>   * igt@kms_flip@2x-flip-vs-expired-vblank:
>     - shard-glk:          [FAIL][105] ([i915#79]) -> [PASS][106]
>    [105]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
>    [106]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html
> 
>   * igt@kms_flip@2x-plain-flip-ts-check:
>     - shard-hsw:          [INCOMPLETE][107] ([i915#61]) ->
> [PASS][108] +2 similar issues
>    [107]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-hsw7/igt@kms_flip@2x-plain-flip-ts-check.html
>    [108]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-hsw4/igt@kms_flip@2x-plain-flip-ts-check.html
> 
>   * igt@kms_frontbuffer_tracking@basic:
>     - shard-iclb:         [FAIL][109] ([i915#49]) -> [PASS][110] +3
> similar issues
>    [109]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb6/igt@kms_frontbuffer_tracking@basic.html
>    [110]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@kms_frontbuffer_tracking@basic.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
>     - shard-tglb:         [FAIL][111] ([i915#49]) -> [PASS][112]
>    [111]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
>    [112]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
>     - shard-tglb:         [INCOMPLETE][113] ([i915#456] / [i915#460]
> / [i915#474]) -> [PASS][114]
>    [113]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
>    [114]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt:
>     - shard-skl:          [DMESG-WARN][115] ([i915#728]) ->
> [PASS][116] +4 similar issues
>    [115]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt.html
>    [116]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt.html
> 
>   * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
>     - shard-skl:          [INCOMPLETE][117] ([i915#648]) ->
> [PASS][118]
>    [117]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl5/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
>    [118]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl7/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>     - shard-skl:          [FAIL][119] ([fdo#108145]) -> [PASS][120]
> +1 similar issue
>    [119]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>    [120]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> 
>   * igt@perf_pmu@busy-accuracy-98-vcs0:
>     - shard-iclb:         [DMESG-WARN][121] ([i915#728]) ->
> [PASS][122] +1 similar issue
>    [121]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb3/igt@perf_pmu@busy-accuracy-98-vcs0.html
>    [122]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@perf_pmu@busy-accuracy-98-vcs0.html
> 
>   * igt@perf_pmu@busy-vcs1:
>     - shard-iclb:         [SKIP][123] ([fdo#112080]) -> [PASS][124]
> +8 similar issues
>    [123]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@perf_pmu@busy-vcs1.html
>    [124]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb4/igt@perf_pmu@busy-vcs1.html
> 
>   * igt@perf_pmu@render-node-busy-vcs1:
>     - shard-tglb:         [DMESG-WARN][125] ([i915#728]) ->
> [PASS][126] +3 similar issues
>    [125]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb3/igt@perf_pmu@render-node-busy-vcs1.html
>    [126]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb8/igt@perf_pmu@render-node-busy-vcs1.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_ctx_isolation@vcs1-nonpriv:
>     - shard-iclb:         [SKIP][127] ([fdo#109276] / [fdo#112080])
> -> [FAIL][128] ([IGT#28]) +1 similar issue
>    [127]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
>    [128]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
> 
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-tglb:         [SKIP][129] ([i915#468]) -> [FAIL][130]
> ([i915#454])
>    [129]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-tglb6/igt@i915_pm_dc@dc6-psr.html
>    [130]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-tglb5/igt@i915_pm_dc@dc6-psr.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
>     - shard-kbl:          [FAIL][131] ([i915#54]) -> [DMESG-
> FAIL][132] ([i915#180] / [i915#54])
>    [131]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>    [132]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>     - shard-iclb:         [INCOMPLETE][133] ([i915#140]) ->
> [FAIL][134] ([i915#49])
>    [133]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
>    [134]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
>     - shard-iclb:         [FAIL][135] ([i915#49]) -> [DMESG-
> WARN][136] ([i915#728])
>    [135]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
>    [136]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
> 
>   * igt@kms_plane@pixel-format-pipe-a-planes:
>     - shard-skl:          [INCOMPLETE][137] ([fdo#112347] /
> [i915#648]) -> [INCOMPLETE][138] ([fdo#112391] / [i915#648])
>    [137]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl10/igt@kms_plane@pixel-format-pipe-a-planes.html
>    [138]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl1/igt@kms_plane@pixel-format-pipe-a-planes.html
> 
>   * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
>     - shard-kbl:          [INCOMPLETE][139] ([fdo#103665]) -> [DMESG-
> WARN][140] ([i915#728])
>    [139]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-kbl2/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
>    [140]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-kbl2/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
> 
>   * igt@kms_plane@pixel-format-pipe-b-planes:
>     - shard-skl:          [INCOMPLETE][141] ([fdo#112391] /
> [i915#648]) -> [INCOMPLETE][142] ([fdo#112347] / [i915#648]) +1
> similar issue
>    [141]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7492/shard-skl10/igt@kms_plane@pixel-format-pipe-b-planes.html
>    [142]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/shard-skl10/igt@kms_plane@pixel-format-pipe-b-planes.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when
> computing
>           the status of the difference (SUCCESS, WARNING, or
> FAILURE).
> 
>   [IGT#28]: 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108838]: https://bugs.freedesktop.org/show_bug.cgi?id=108838
>   [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
>   [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
>   [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
>   [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
>   [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
>   [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
>   [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
>   [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
>   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
>   [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
>   [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
>   [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
>   [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
>   [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
>   [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
>   [i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
>   [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
>   [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
>   [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
>   [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
>   [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
>   [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
>   [i915#634]: https://gitlab.freedesktop.org/drm/intel/issues/634
>   [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
>   [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
>   [i915#655]: https://gitlab.freedesktop.org/drm/intel/issues/655
>   [i915#669]: https://gitlab.freedesktop.org/drm/intel/issues/669
>   [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
>   [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
>   [i915#728]: https://gitlab.free
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15614/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-12-06 23:23 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 21:03 [Intel-gfx] [PATCH v4 1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes José Roberto de Souza
2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 2/3] drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off José Roberto de Souza
2019-12-05 21:03 ` [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Refactor intel_commit_modeset_disables() José Roberto de Souza
2019-12-06 22:22   ` Matt Roper
2019-12-06 22:35     ` Souza, Jose
2019-12-06 22:37       ` Matt Roper
2019-12-05 21:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915/display: Do not check for the ddb allocations of turned off pipes Patchwork
2019-12-06  5:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-06 23:23   ` Souza, Jose

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.