* [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers
@ 2019-12-05 22:07 Peter Kjellerstedt
2019-12-05 22:07 ` [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of " Peter Kjellerstedt
2019-12-06 4:56 ` [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for " Khem Raj
0 siblings, 2 replies; 8+ messages in thread
From: Peter Kjellerstedt @ 2019-12-05 22:07 UTC (permalink / raw)
To: openembedded-core
This also corrects the symbolic links installed in
/usr/include/rpcsvc.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
.../libtirpc/libtirpc_1.1.4.bb | 27 +++++++++----------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
index 633cececd4..91e0ce6fd2 100644
--- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
+++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
@@ -1,5 +1,5 @@
SUMMARY = "Transport-Independent RPC library"
-DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC library to Linux"
+DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC library to Linux"
SECTION = "libs/network"
HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
BUGTRACKER = "http://sourceforge.net/tracker/?group_id=183075&atid=903784"
@@ -22,21 +22,18 @@ inherit autotools pkgconfig
EXTRA_OECONF = "--disable-gssapi"
do_install_append() {
- chown root:root ${D}${sysconfdir}/netconfig
- install -d ${D}${includedir}/rpc
- install -d ${D}${includedir}/rpcsvc
- for link_header in ${D}${includedir}/tirpc/rpc/*; do
- if [ -f $link_header -a ! -e ${D}/${includedir}/rpc/$(basename $link_header) ]; then
- ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpc/$(basename $link_header)
- fi
- done
- for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
- if [ -f $link_header -a ! -e ${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then
- ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpcsvc/$(basename $link_header)
- fi
- done
- ln -sf tirpc/netconfig.h ${D}/${includedir}/netconfig.h
+ chown root:root ${D}${sysconfdir}/netconfig
+ for dir in rpc rpcsvc; do
+ install -d ${D}${includedir}/$dir
+ for link_header in ${D}${includedir}/tirpc/$dir/*; do
+ if [ -f $link_header ] &&
+ [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
+ ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
+ fi
+ done
+ done
+ ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
}
BBCLASSEXTEND = "native nativesdk"
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of legacy headers
2019-12-05 22:07 [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers Peter Kjellerstedt
@ 2019-12-05 22:07 ` Peter Kjellerstedt
2019-12-06 4:56 ` [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for " Khem Raj
1 sibling, 0 replies; 8+ messages in thread
From: Peter Kjellerstedt @ 2019-12-05 22:07 UTC (permalink / raw)
To: openembedded-core
Providing symbolic links to the header files to replace the old
corresponding glibc headers seems like a band aid for applications
that have not been updated to cope with the lack of the RPC headers
from glibc. Additionally they clash with glibc if an older version of
glibc is used that still provides the header files. To remedy this,
make it easy to disable the installation of the legacy headers by not
setting the legacy-headers PACKAGECONFIG.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
.../libtirpc/libtirpc_1.1.4.bb | 23 +++++++++++--------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
index 91e0ce6fd2..3c84694161 100644
--- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
+++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
@@ -17,6 +17,9 @@ UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)/"
SRC_URI[md5sum] = "f5d2a623e9dfbd818d2f3f3a4a878e3a"
SRC_URI[sha256sum] = "2ca529f02292e10c158562295a1ffd95d2ce8af97820e3534fe1b0e3aec7561d"
+PACKAGECONFIG = "legacy-headers"
+PACKAGECONFIG[legacy-headers] = ""
+
inherit autotools pkgconfig
EXTRA_OECONF = "--disable-gssapi"
@@ -24,16 +27,18 @@ EXTRA_OECONF = "--disable-gssapi"
do_install_append() {
chown root:root ${D}${sysconfdir}/netconfig
- for dir in rpc rpcsvc; do
- install -d ${D}${includedir}/$dir
- for link_header in ${D}${includedir}/tirpc/$dir/*; do
- if [ -f $link_header ] &&
- [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
- ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
- fi
+ if [ "${@bb.utils.filter('PACKAGECONFIG', 'legacy-headers', d)}" ]; then
+ for dir in rpc rpcsvc; do
+ install -d ${D}${includedir}/$dir
+ for link_header in ${D}${includedir}/tirpc/$dir/*; do
+ if [ -f $link_header ] &&
+ [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
+ ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
+ fi
+ done
done
- done
- ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
+ ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
+ fi
}
BBCLASSEXTEND = "native nativesdk"
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers
2019-12-05 22:07 [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers Peter Kjellerstedt
2019-12-05 22:07 ` [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of " Peter Kjellerstedt
@ 2019-12-06 4:56 ` Khem Raj
2019-12-06 8:59 ` Peter Kjellerstedt
1 sibling, 1 reply; 8+ messages in thread
From: Khem Raj @ 2019-12-06 4:56 UTC (permalink / raw)
To: openembedded-core
On 12/5/19 2:07 PM, Peter Kjellerstedt wrote:
> This also corrects the symbolic links installed in
> /usr/include/rpcsvc.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
> .../libtirpc/libtirpc_1.1.4.bb | 27 +++++++++----------
> 1 file changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> index 633cececd4..91e0ce6fd2 100644
> --- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> +++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> @@ -1,5 +1,5 @@
> SUMMARY = "Transport-Independent RPC library"
> -DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC library to Linux"
> +DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC library to Linux"
> SECTION = "libs/network"
> HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
> BUGTRACKER = "http://sourceforge.net/tracker/?group_id=183075&atid=903784"
> @@ -22,21 +22,18 @@ inherit autotools pkgconfig
> EXTRA_OECONF = "--disable-gssapi"
>
> do_install_append() {
> - chown root:root ${D}${sysconfdir}/netconfig
> - install -d ${D}${includedir}/rpc
> - install -d ${D}${includedir}/rpcsvc
> - for link_header in ${D}${includedir}/tirpc/rpc/*; do
> - if [ -f $link_header -a ! -e ${D}/${includedir}/rpc/$(basename $link_header) ]; then
> - ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpc/$(basename $link_header)
> - fi
> - done
> - for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
> - if [ -f $link_header -a ! -e ${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then
> - ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpcsvc/$(basename $link_header)
> - fi
> - done
> - ln -sf tirpc/netconfig.h ${D}/${includedir}/netconfig.h
> + chown root:root ${D}${sysconfdir}/netconfig
>
> + for dir in rpc rpcsvc; do
> + install -d ${D}${includedir}/$dir
> + for link_header in ${D}${includedir}/tirpc/$dir/*; do
> + if [ -f $link_header ] &&
> + [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
> + ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> + fi
> + done
> + done
> + ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> }
>
I know this patch is making the existing logic better. But I dont think
we should be substituting, sunrpc headers like this, what problems does
this fix is not clear. tirpc is not a drop in replacement for sun rpc.
Applications have to use it consciously. Sneaking the headers like this
can cause subtle errors.
Perhaps original patch should just be reverted.
> BBCLASSEXTEND = "native nativesdk"
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers
2019-12-06 4:56 ` [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for " Khem Raj
@ 2019-12-06 8:59 ` Peter Kjellerstedt
2019-12-06 15:21 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: Peter Kjellerstedt @ 2019-12-06 8:59 UTC (permalink / raw)
To: Khem Raj, openembedded-core
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-core-
> bounces@lists.openembedded.org> On Behalf Of Khem Raj
> Sent: den 6 december 2019 05:56
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify the
> installation of symlinks for legacy headers
>
> On 12/5/19 2:07 PM, Peter Kjellerstedt wrote:
> > This also corrects the symbolic links installed in
> > /usr/include/rpcsvc.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > ---
> > .../libtirpc/libtirpc_1.1.4.bb | 27 +++++++++----------
> > 1 file changed, 12 insertions(+), 15 deletions(-)
> >
> > diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > index 633cececd4..91e0ce6fd2 100644
> > --- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > +++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > @@ -1,5 +1,5 @@
> > SUMMARY = "Transport-Independent RPC library"
> > -DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC
> library to Linux"
> > +DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC
> library to Linux"
> > SECTION = "libs/network"
> > HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
> > BUGTRACKER =
> "http://sourceforge.net/tracker/?group_id=183075&atid=903784"
> > @@ -22,21 +22,18 @@ inherit autotools pkgconfig
> > EXTRA_OECONF = "--disable-gssapi"
> >
> > do_install_append() {
> > - chown root:root ${D}${sysconfdir}/netconfig
> > - install -d ${D}${includedir}/rpc
> > - install -d ${D}${includedir}/rpcsvc
> > - for link_header in ${D}${includedir}/tirpc/rpc/*; do
> > - if [ -f $link_header -a ! -e
> ${D}/${includedir}/rpc/$(basename $link_header) ]; then
> > - ln -sf ../tirpc/rpc/$(basename $link_header)
> ${D}${includedir}/rpc/$(basename $link_header)
> > - fi
> > - done
> > - for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
> > - if [ -f $link_header -a ! -e
> ${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then
> > - ln -sf ../tirpc/rpc/$(basename $link_header)
> ${D}${includedir}/rpcsvc/$(basename $link_header)
> > - fi
> > - done
> > - ln -sf tirpc/netconfig.h ${D}/${includedir}/netconfig.h
> > + chown root:root ${D}${sysconfdir}/netconfig
> >
> > + for dir in rpc rpcsvc; do
> > + install -d ${D}${includedir}/$dir
> > + for link_header in ${D}${includedir}/tirpc/$dir/*;
> do
> > + if [ -f $link_header ] &&
> > + [ ! -e
> ${D}${includedir}/$dir/$(basename $link_header) ]; then
> > + ln -sf ../tirpc/$dir/$(basename
> $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> > + fi
> > + done
> > + done
> > + ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> > }
> >
>
> I know this patch is making the existing logic better. But I dont think
> we should be substituting, sunrpc headers like this, what problems does
> this fix is not clear. tirpc is not a drop in replacement for sun rpc.
> Applications have to use it consciously. Sneaking the headers like this
> can cause subtle errors.
>
> Perhaps original patch should just be reverted.
I'm perfectly fine with reverting the original patch instead as that will
solve my problem.
> > BBCLASSEXTEND = "native nativesdk"
//Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers
2019-12-06 8:59 ` Peter Kjellerstedt
@ 2019-12-06 15:21 ` Khem Raj
2019-12-06 18:01 ` Peter Kjellerstedt
0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2019-12-06 15:21 UTC (permalink / raw)
To: Peter Kjellerstedt; +Cc: openembedded-core
perhaps send a revert request instead
On Fri, Dec 6, 2019 at 12:59 AM Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org <openembedded-core-
> > bounces@lists.openembedded.org> On Behalf Of Khem Raj
> > Sent: den 6 december 2019 05:56
> > To: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify the
> > installation of symlinks for legacy headers
> >
> > On 12/5/19 2:07 PM, Peter Kjellerstedt wrote:
> > > This also corrects the symbolic links installed in
> > > /usr/include/rpcsvc.
> > >
> > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > ---
> > > .../libtirpc/libtirpc_1.1.4.bb | 27 +++++++++----------
> > > 1 file changed, 12 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > > index 633cececd4..91e0ce6fd2 100644
> > > --- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > > +++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > > @@ -1,5 +1,5 @@
> > > SUMMARY = "Transport-Independent RPC library"
> > > -DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC
> > library to Linux"
> > > +DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC
> > library to Linux"
> > > SECTION = "libs/network"
> > > HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
> > > BUGTRACKER =
> > "http://sourceforge.net/tracker/?group_id=183075&atid=903784"
> > > @@ -22,21 +22,18 @@ inherit autotools pkgconfig
> > > EXTRA_OECONF = "--disable-gssapi"
> > >
> > > do_install_append() {
> > > - chown root:root ${D}${sysconfdir}/netconfig
> > > - install -d ${D}${includedir}/rpc
> > > - install -d ${D}${includedir}/rpcsvc
> > > - for link_header in ${D}${includedir}/tirpc/rpc/*; do
> > > - if [ -f $link_header -a ! -e
> > ${D}/${includedir}/rpc/$(basename $link_header) ]; then
> > > - ln -sf ../tirpc/rpc/$(basename $link_header)
> > ${D}${includedir}/rpc/$(basename $link_header)
> > > - fi
> > > - done
> > > - for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
> > > - if [ -f $link_header -a ! -e
> > ${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then
> > > - ln -sf ../tirpc/rpc/$(basename $link_header)
> > ${D}${includedir}/rpcsvc/$(basename $link_header)
> > > - fi
> > > - done
> > > - ln -sf tirpc/netconfig.h ${D}/${includedir}/netconfig.h
> > > + chown root:root ${D}${sysconfdir}/netconfig
> > >
> > > + for dir in rpc rpcsvc; do
> > > + install -d ${D}${includedir}/$dir
> > > + for link_header in ${D}${includedir}/tirpc/$dir/*;
> > do
> > > + if [ -f $link_header ] &&
> > > + [ ! -e
> > ${D}${includedir}/$dir/$(basename $link_header) ]; then
> > > + ln -sf ../tirpc/$dir/$(basename
> > $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> > > + fi
> > > + done
> > > + done
> > > + ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> > > }
> > >
> >
> > I know this patch is making the existing logic better. But I dont think
> > we should be substituting, sunrpc headers like this, what problems does
> > this fix is not clear. tirpc is not a drop in replacement for sun rpc.
> > Applications have to use it consciously. Sneaking the headers like this
> > can cause subtle errors.
> >
> > Perhaps original patch should just be reverted.
>
> I'm perfectly fine with reverting the original patch instead as that will
> solve my problem.
>
> > > BBCLASSEXTEND = "native nativesdk"
>
> //Peter
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers
2019-12-06 15:21 ` Khem Raj
@ 2019-12-06 18:01 ` Peter Kjellerstedt
0 siblings, 0 replies; 8+ messages in thread
From: Peter Kjellerstedt @ 2019-12-06 18:01 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
Will do.
//Peter
> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com>
> Sent: den 6 december 2019 16:21
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify the
> installation of symlinks for legacy headers
>
> perhaps send a revert request instead
>
> On Fri, Dec 6, 2019 at 12:59 AM Peter Kjellerstedt
> <peter.kjellerstedt@axis.com> wrote:
> >
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-
> > > bounces@lists.openembedded.org> On Behalf Of Khem Raj
> > > Sent: den 6 december 2019 05:56
> > > To: openembedded-core@lists.openembedded.org
> > > Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify
> the
> > > installation of symlinks for legacy headers
> > >
> > > On 12/5/19 2:07 PM, Peter Kjellerstedt wrote:
> > > > This also corrects the symbolic links installed in
> > > > /usr/include/rpcsvc.
> > > >
> > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > > ---
> > > > .../libtirpc/libtirpc_1.1.4.bb | 27 +++++++++------
> ----
> > > > 1 file changed, 12 insertions(+), 15 deletions(-)
> > > >
> > > > diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > > b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > > > index 633cececd4..91e0ce6fd2 100644
> > > > --- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > > > +++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > > > @@ -1,5 +1,5 @@
> > > > SUMMARY = "Transport-Independent RPC library"
> > > > -DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC
> > > library to Linux"
> > > > +DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent
> RPC
> > > library to Linux"
> > > > SECTION = "libs/network"
> > > > HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
> > > > BUGTRACKER =
> > > "http://sourceforge.net/tracker/?group_id=183075&atid=903784"
> > > > @@ -22,21 +22,18 @@ inherit autotools pkgconfig
> > > > EXTRA_OECONF = "--disable-gssapi"
> > > >
> > > > do_install_append() {
> > > > - chown root:root ${D}${sysconfdir}/netconfig
> > > > - install -d ${D}${includedir}/rpc
> > > > - install -d ${D}${includedir}/rpcsvc
> > > > - for link_header in ${D}${includedir}/tirpc/rpc/*; do
> > > > - if [ -f $link_header -a ! -e
> > > ${D}/${includedir}/rpc/$(basename $link_header) ]; then
> > > > - ln -sf ../tirpc/rpc/$(basename $link_header)
> > > ${D}${includedir}/rpc/$(basename $link_header)
> > > > - fi
> > > > - done
> > > > - for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
> > > > - if [ -f $link_header -a ! -e
> > > ${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then
> > > > - ln -sf ../tirpc/rpc/$(basename $link_header)
> > > ${D}${includedir}/rpcsvc/$(basename $link_header)
> > > > - fi
> > > > - done
> > > > - ln -sf tirpc/netconfig.h ${D}/${includedir}/netconfig.h
> > > > + chown root:root ${D}${sysconfdir}/netconfig
> > > >
> > > > + for dir in rpc rpcsvc; do
> > > > + install -d ${D}${includedir}/$dir
> > > > + for link_header in ${D}${includedir}/tirpc/$dir/*;
> > > do
> > > > + if [ -f $link_header ] &&
> > > > + [ ! -e
> > > ${D}${includedir}/$dir/$(basename $link_header) ]; then
> > > > + ln -sf ../tirpc/$dir/$(basename
> > > $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> > > > + fi
> > > > + done
> > > > + done
> > > > + ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> > > > }
> > > >
> > >
> > > I know this patch is making the existing logic better. But I dont
> think
> > > we should be substituting, sunrpc headers like this, what problems
> does
> > > this fix is not clear. tirpc is not a drop in replacement for sun rpc.
> > > Applications have to use it consciously. Sneaking the headers like
> this
> > > can cause subtle errors.
> > >
> > > Perhaps original patch should just be reverted.
> >
> > I'm perfectly fine with reverting the original patch instead as that
> will
> > solve my problem.
> >
> > > > BBCLASSEXTEND = "native nativesdk"
> >
> > //Peter
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of legacy headers
2019-12-05 22:22 [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of " Peter Kjellerstedt
@ 2019-12-05 22:30 ` Andre McCurdy
0 siblings, 0 replies; 8+ messages in thread
From: Andre McCurdy @ 2019-12-05 22:30 UTC (permalink / raw)
To: Peter Kjellerstedt; +Cc: openembedded-core
On Thu, Dec 5, 2019 at 2:23 PM Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org <openembedded-core-bounces@lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> > Sent: den 5 december 2019 23:07
> > To: openembedded-core@lists.openembedded.org
> > Subject: [OE-core] [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of legacy headers
> >
> > Providing symbolic links to the header files to replace the old
> > corresponding glibc headers seems like a band aid for applications
> > that have not been updated to cope with the lack of the RPC headers
> > from glibc. Additionally they clash with glibc if an older version of
> > glibc is used that still provides the header files. To remedy this,
> > make it easy to disable the installation of the legacy headers by not
> > setting the legacy-headers PACKAGECONFIG.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > ---
> > .../libtirpc/libtirpc_1.1.4.bb | 23 +++++++++++--------
> > 1 file changed, 14 insertions(+), 9 deletions(-)
> >
> > diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > index 91e0ce6fd2..3c84694161 100644
> > --- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > +++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> > @@ -17,6 +17,9 @@ UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)/"
> > SRC_URI[md5sum] = "f5d2a623e9dfbd818d2f3f3a4a878e3a"
> > SRC_URI[sha256sum] = "2ca529f02292e10c158562295a1ffd95d2ce8af97820e3534fe1b0e3aec7561d"
> >
> > +PACKAGECONFIG = "legacy-headers"
>
> I set the legacy-headers PACKAGECONFIG by default to maintain the
> compatibility with zeus-22.0.1. However, it can be argued that it
> should not be set to maintain compatibility with zeus-22.0.0. In
> our case, the change between 22.0.0 and 22.0.1 broke the build
> for a couple of our products that build using an older glibc.
The change broke builds for me too. I'd prefer to have the
PACKAGECONFIG disabled by default in zeus.
> > +PACKAGECONFIG[legacy-headers] = ""
> > +
> > inherit autotools pkgconfig
> >
> > EXTRA_OECONF = "--disable-gssapi"
> > @@ -24,16 +27,18 @@ EXTRA_OECONF = "--disable-gssapi"
> > do_install_append() {
> > chown root:root ${D}${sysconfdir}/netconfig
> >
> > - for dir in rpc rpcsvc; do
> > - install -d ${D}${includedir}/$dir
> > - for link_header in ${D}${includedir}/tirpc/$dir/*; do
> > - if [ -f $link_header ] &&
> > - [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
> > - ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> > - fi
> > + if [ "${@bb.utils.filter('PACKAGECONFIG', 'legacy-headers', d)}" ]; then
> > + for dir in rpc rpcsvc; do
> > + install -d ${D}${includedir}/$dir
> > + for link_header in ${D}${includedir}/tirpc/$dir/*; do
> > + if [ -f $link_header ] &&
> > + [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
> > + ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> > + fi
> > + done
> > done
> > - done
> > - ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> > + ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> > + fi
> > }
> >
> > BBCLASSEXTEND = "native nativesdk"
> > --
> > 2.21.0
>
> //Peter
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of legacy headers
@ 2019-12-05 22:22 Peter Kjellerstedt
2019-12-05 22:30 ` Andre McCurdy
0 siblings, 1 reply; 8+ messages in thread
From: Peter Kjellerstedt @ 2019-12-05 22:22 UTC (permalink / raw)
To: openembedded-core
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-core-bounces@lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> Sent: den 5 december 2019 23:07
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of legacy headers
>
> Providing symbolic links to the header files to replace the old
> corresponding glibc headers seems like a band aid for applications
> that have not been updated to cope with the lack of the RPC headers
> from glibc. Additionally they clash with glibc if an older version of
> glibc is used that still provides the header files. To remedy this,
> make it easy to disable the installation of the legacy headers by not
> setting the legacy-headers PACKAGECONFIG.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
> .../libtirpc/libtirpc_1.1.4.bb | 23 +++++++++++--------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> index 91e0ce6fd2..3c84694161 100644
> --- a/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> +++ b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb
> @@ -17,6 +17,9 @@ UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)/"
> SRC_URI[md5sum] = "f5d2a623e9dfbd818d2f3f3a4a878e3a"
> SRC_URI[sha256sum] = "2ca529f02292e10c158562295a1ffd95d2ce8af97820e3534fe1b0e3aec7561d"
>
> +PACKAGECONFIG = "legacy-headers"
I set the legacy-headers PACKAGECONFIG by default to maintain the
compatibility with zeus-22.0.1. However, it can be argued that it
should not be set to maintain compatibility with zeus-22.0.0. In
our case, the change between 22.0.0 and 22.0.1 broke the build
for a couple of our products that build using an older glibc.
> +PACKAGECONFIG[legacy-headers] = ""
> +
> inherit autotools pkgconfig
>
> EXTRA_OECONF = "--disable-gssapi"
> @@ -24,16 +27,18 @@ EXTRA_OECONF = "--disable-gssapi"
> do_install_append() {
> chown root:root ${D}${sysconfdir}/netconfig
>
> - for dir in rpc rpcsvc; do
> - install -d ${D}${includedir}/$dir
> - for link_header in ${D}${includedir}/tirpc/$dir/*; do
> - if [ -f $link_header ] &&
> - [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
> - ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> - fi
> + if [ "${@bb.utils.filter('PACKAGECONFIG', 'legacy-headers', d)}" ]; then
> + for dir in rpc rpcsvc; do
> + install -d ${D}${includedir}/$dir
> + for link_header in ${D}${includedir}/tirpc/$dir/*; do
> + if [ -f $link_header ] &&
> + [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
> + ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
> + fi
> + done
> done
> - done
> - ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> + ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
> + fi
> }
>
> BBCLASSEXTEND = "native nativesdk"
> --
> 2.21.0
//Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-06 18:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 22:07 [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers Peter Kjellerstedt
2019-12-05 22:07 ` [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of " Peter Kjellerstedt
2019-12-06 4:56 ` [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for " Khem Raj
2019-12-06 8:59 ` Peter Kjellerstedt
2019-12-06 15:21 ` Khem Raj
2019-12-06 18:01 ` Peter Kjellerstedt
2019-12-05 22:22 [master][zeus][PATCH 2/2] libtirpc: Make it easy to disable the installation of " Peter Kjellerstedt
2019-12-05 22:30 ` Andre McCurdy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.