* [yhuang:lru-r0.1 55/55] mm/page_idle.c:837:8: error: 'rp_state' undeclared; did you mean 'rd_state'?
@ 2019-12-05 23:30 kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2019-12-05 23:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3403 bytes --]
tree: yhuang/lru-r0.1
head: 2656fd3ec2e60b7de639272904e117aa584a53e3
commit: 2656fd3ec2e60b7de639272904e117aa584a53e3 [55/55] Accelerate threshold adjust
config: x86_64-rhel-7.2-aep (attached as .config)
compiler: gcc-7 (Debian 7.5.0-1) 7.5.0
reproduce:
git checkout 2656fd3ec2e60b7de639272904e117aa584a53e3
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
mm/page_idle.c: In function 'node_random_demote_check':
>> mm/page_idle.c:837:8: error: 'rp_state' undeclared (first use in this function); did you mean 'rd_state'?
!(rp_state->nr_pass > target_pass * 11 / 10))
^~~~~~~~
rd_state
mm/page_idle.c:837:8: note: each undeclared identifier is reported only once for each function it appears in
vim +837 mm/page_idle.c
816
817 static void node_random_demote_check(struct pglist_data *pgdat,
818 struct random_migrate_state *rd_state,
819 struct random_migrate_work_item *item)
820 {
821 int nrk, tnid, threshold, tpthreshold;
822 int target_pass = rd_state->nr_scan_window * rd_state->nr_page;
823 bool tpenabled;
824 struct pglist_data *tpgdat;
825
826 nrk = node_random_keep_pages(&item->pages, item->nr, rd_state,
827 NODE_RANDOM_KEEP_IDLE);
828 rd_state->nr_migrate += nrk;
829
830 tnid = next_migration_node(pgdat->node_id);
831 if (tnid == -1)
832 return;
833
834 node_random_migrate(&item->pages, nrk, tnid);
835
836 if (!(rd_state->flags & RANDOM_MIGRATE_ADJUST) &&
> 837 !(rp_state->nr_pass > target_pass * 11 / 10))
838 return;
839
840 rd_state->flags &= ~RANDOM_MIGRATE_ADJUST;
841
842 threshold = item->threshold;
843 if (rd_state->nr_pass > target_pass * 11 / 10 ||
844 rd_state->nr_pass > rd_state->nr_scan / 8) {
845 threshold = max(threshold * 6 / 5, threshold + 1);
846 threshold = min(threshold, random_migrate_threshold_max(rd_state));
847 } else if (rd_state->nr_pass < target_pass * 9 / 10) {
848 tpgdat = NODE_DATA(tnid);
849 tpenabled = node_random_enabled(&tpgdat->random_promote_state);
850 tpthreshold = tpgdat->random_promote_state.threshold;
851 threshold = min(threshold * 4 / 5, threshold - 1);
852 threshold = max(threshold, 1);
853 if (tpenabled) {
854 threshold = max(threshold, tpthreshold * 3 / 2);
855 threshold = max(threshold, tpthreshold + 1);
856 }
857 }
858 rd_state->threshold = threshold;
859 trace_random_migrate_threshold(pgdat->node_id, target_pass,
860 rd_state->nr_pass, rd_state->nr_migrate,
861 threshold);
862 pr_info("rd: nid=%d scan=%d target=%d pass=%d migrate=%d threshold=%d\n",
863 pgdat->node_id, rd_state->nr_scan,
864 target_pass, rd_state->nr_pass, rd_state->nr_migrate,
865 threshold);
866
867 rd_state->nr_scan = 0;
868 rd_state->nr_pass = 0;
869 rd_state->nr_migrate = 0;
870 }
871
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42741 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-05 23:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 23:30 [yhuang:lru-r0.1 55/55] mm/page_idle.c:837:8: error: 'rp_state' undeclared; did you mean 'rd_state'? kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.