* [PATCH] ASoC: tas2552: add missed regulator_bulk_disable in remove
@ 2019-12-06 7:52 ` Chuhong Yuan
0 siblings, 0 replies; 4+ messages in thread
From: Chuhong Yuan @ 2019-12-06 7:52 UTC (permalink / raw)
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, Chuhong Yuan
The driver forgets to call regulator_bulk_disable() in remove like that
in probe failure.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
sound/soc/codecs/tas2552.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index 56671f21cfe5..0e19ec76aae0 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -616,6 +616,9 @@ static void tas2552_component_remove(struct snd_soc_component *component)
pm_runtime_put(component->dev);
gpiod_set_value(tas2552->enable_gpio, 0);
+
+ regulator_bulk_disable(ARRAY_SIZE(tas2552->supplies),
+ tas2552->supplies);
};
#ifdef CONFIG_PM
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [alsa-devel] [PATCH] ASoC: tas2552: add missed regulator_bulk_disable in remove
@ 2019-12-06 7:52 ` Chuhong Yuan
0 siblings, 0 replies; 4+ messages in thread
From: Chuhong Yuan @ 2019-12-06 7:52 UTC (permalink / raw)
Cc: alsa-devel, Liam Girdwood, Chuhong Yuan, linux-kernel,
Takashi Iwai, Mark Brown
The driver forgets to call regulator_bulk_disable() in remove like that
in probe failure.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
sound/soc/codecs/tas2552.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index 56671f21cfe5..0e19ec76aae0 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -616,6 +616,9 @@ static void tas2552_component_remove(struct snd_soc_component *component)
pm_runtime_put(component->dev);
gpiod_set_value(tas2552->enable_gpio, 0);
+
+ regulator_bulk_disable(ARRAY_SIZE(tas2552->supplies),
+ tas2552->supplies);
};
#ifdef CONFIG_PM
--
2.24.0
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: tas2552: add missed regulator_bulk_disable in remove
2019-12-06 7:52 ` [alsa-devel] " Chuhong Yuan
@ 2019-12-09 16:25 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-12-09 16:25 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
On Fri, Dec 06, 2019 at 03:52:39PM +0800, Chuhong Yuan wrote:
> The driver forgets to call regulator_bulk_disable() in remove like that
> in probe failure.
> Add the missed call to fix it.
Another runtime PM interaction here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: tas2552: add missed regulator_bulk_disable in remove
@ 2019-12-09 16:25 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-12-09 16:25 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: linux-kernel, alsa-devel, Takashi Iwai, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 227 bytes --]
On Fri, Dec 06, 2019 at 03:52:39PM +0800, Chuhong Yuan wrote:
> The driver forgets to call regulator_bulk_disable() in remove like that
> in probe failure.
> Add the missed call to fix it.
Another runtime PM interaction here.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-09 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 7:52 [PATCH] ASoC: tas2552: add missed regulator_bulk_disable in remove Chuhong Yuan
2019-12-06 7:52 ` [alsa-devel] " Chuhong Yuan
2019-12-09 16:25 ` Mark Brown
2019-12-09 16:25 ` [alsa-devel] " Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.