* [igt-dev] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
@ 2019-12-07 1:08 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2019-12-07 1:08 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b.
__for_each_physical_engine() reprograms the context, invalidating the
use of e->flags to select engines, necessitating e->index instead.
Withot also fixing up the engine selection, the result is that random
engines were being used to read registers from the intended engine.
This does not end well.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Stuart Summers <stuart.summers@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/i915/gem_ctx_isolation.c | 4 ++--
tests/i915/gem_ctx_persistence.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
index 9435209e9..6aa27133c 100644
--- a/tests/i915/gem_ctx_isolation.c
+++ b/tests/i915/gem_ctx_isolation.c
@@ -856,7 +856,6 @@ static unsigned int __has_context_isolation(int fd)
igt_main
{
- struct intel_execution_engine2 *e;
unsigned int has_context_isolation = 0;
int fd = -1;
@@ -877,7 +876,8 @@ igt_main
igt_skip_on(gen > LAST_KNOWN_GEN);
}
- __for_each_physical_engine(fd, e) {
+ for (const struct intel_execution_engine2 *e = intel_execution_engines2;
+ e->name; e++) {
igt_subtest_group {
igt_fixture {
igt_require(has_context_isolation & (1 << e->class));
diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
index 30772159b..d68431ae0 100644
--- a/tests/i915/gem_ctx_persistence.c
+++ b/tests/i915/gem_ctx_persistence.c
@@ -727,7 +727,7 @@ igt_main
igt_subtest("hangcheck")
test_nohangcheck_hostile(i915);
- __for_each_physical_engine(i915, e) {
+ __for_each_static_engine(e) {
igt_subtest_group {
igt_fixture {
gem_require_ring(i915, e->flags);
--
2.24.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
2019-12-07 1:08 ` [igt-dev] " Chris Wilson
(?)
@ 2019-12-07 1:45 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-12-07 1:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
URL : https://patchwork.freedesktop.org/series/70580/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7506 -> IGTPW_3824
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/index.html
Known issues
------------
Here are the changes found in IGTPW_3824 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_blt:
- fi-bsw-nick: [PASS][1] -> [DMESG-FAIL][2] ([i915#723])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-bsw-nick/igt@i915_selftest@live_blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-bsw-nick/igt@i915_selftest@live_blt.html
- fi-byt-j1900: [PASS][3] -> [DMESG-FAIL][4] ([i915#725])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-byt-j1900/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-byt-j1900/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [PASS][5] -> [INCOMPLETE][6] ([i915#45])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- {fi-tgl-u}: [INCOMPLETE][7] ([fdo#111593]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-tgl-u/igt@gem_exec_gttfill@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-tgl-u/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-ivb-3770: [DMESG-FAIL][11] ([i915#725]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-ivb-3770/igt@i915_selftest@live_blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-ivb-3770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [DMESG-FAIL][13] ([i915#722]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [INCOMPLETE][15] ([i915#694]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
#### Warnings ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][17] ([i915#553] / [i915#725]) -> [DMESG-FAIL][18] ([i915#563])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/fi-hsw-4770/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/fi-hsw-4770/igt@i915_selftest@live_blt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#710]: https://gitlab.freedesktop.org/drm/intel/issues/710
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#723]: https://gitlab.freedesktop.org/drm/intel/issues/723
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#726]: https://gitlab.freedesktop.org/drm/intel/issues/726
Participating hosts (38 -> 33)
------------------------------
Missing (5): fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5335 -> IGTPW_3824
CI-20190529: 20190529
CI_DRM_7506: ebfb3e0542800b63ac73a4546fb7d486f9ade587 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3824: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/index.html
IGT_5335: 06aa2c377ed40df1e246fca009c441fa18e53825 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
2019-12-07 1:08 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2019-12-07 15:24 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-12-07 15:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
URL : https://patchwork.freedesktop.org/series/70580/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7506_full -> IGTPW_3824_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3824_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3824_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3824_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-iclb: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@i915_selftest@mock_sanitycheck:
- shard-kbl: [PASS][2] -> [DMESG-WARN][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl7/igt@i915_selftest@mock_sanitycheck.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl6/igt@i915_selftest@mock_sanitycheck.html
Known issues
------------
Here are the changes found in IGTPW_3824_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs0-mixed-process:
- shard-apl: [PASS][4] -> [FAIL][5] ([i915#679])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-apl2/igt@gem_ctx_persistence@vcs0-mixed-process.html
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb3/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_exec_schedule@deep-bsd2:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#109276]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb4/igt@gem_exec_schedule@deep-bsd2.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb6/igt@gem_exec_schedule@deep-bsd2.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#112146]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb3/igt@gem_exec_schedule@preempt-bsd.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-hsw: [PASS][12] -> [TIMEOUT][13] ([i915#530])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-snb: [PASS][14] -> [FAIL][15] ([i915#520])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-snb5/igt@gem_persistent_relocs@forked-thrashing.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-snb7/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#644])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][18] -> [DMESG-WARN][19] ([fdo#110789] / [fdo#111870])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [PASS][20] -> [DMESG-WARN][21] ([fdo#111870])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][22] -> [FAIL][23] ([i915#454])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-tglb: [PASS][24] -> [INCOMPLETE][25] ([i915#456] / [i915#460]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb1/igt@i915_suspend@fence-restore-tiled2untiled.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb4/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-270:
- shard-tglb: [PASS][26] -> [DMESG-WARN][27] ([i915#728]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb1/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb6/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-180:
- shard-kbl: [PASS][28] -> [DMESG-WARN][29] ([i915#728])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl3/igt@kms_big_fb@yf-tiled-16bpp-rotate-180.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl6/igt@kms_big_fb@yf-tiled-16bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-random:
- shard-kbl: [PASS][30] -> [FAIL][31] ([i915#54]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-128x42-random.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-128x42-random.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][32] -> [DMESG-WARN][33] ([i915#180]) +4 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- shard-glk: [PASS][34] -> [FAIL][35] ([i915#54])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-glk8/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-glk1/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
- shard-apl: [PASS][36] -> [FAIL][37] ([i915#54]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][38] -> [FAIL][39] ([i915#96])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][40] -> [FAIL][41] ([i915#49]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-iclb: [PASS][42] -> [DMESG-WARN][43] ([i915#728]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-kbl: [PASS][44] -> [INCOMPLETE][45] ([fdo#103665])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-kbl: [PASS][46] -> [INCOMPLETE][47] ([fdo#103665] / [i915#435])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl3/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][48] -> [DMESG-WARN][49] ([i915#180])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][50] -> [FAIL][51] ([i915#31])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl4/igt@kms_setmode@basic.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl4/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- shard-tglb: [PASS][52] -> [INCOMPLETE][53] ([i915#460])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb5/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb7/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
* igt@perf@disabled-read-error:
- shard-hsw: [PASS][54] -> [INCOMPLETE][55] ([i915#61])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-hsw7/igt@perf@disabled-read-error.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-hsw7/igt@perf@disabled-read-error.html
* igt@perf_pmu@busy-start-vcs1:
- shard-iclb: [PASS][56] -> [SKIP][57] ([fdo#112080]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb1/igt@perf_pmu@busy-start-vcs1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb5/igt@perf_pmu@busy-start-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-nonpriv:
- shard-iclb: [FAIL][58] -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb3/igt@gem_ctx_isolation@bcs0-nonpriv.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb1/igt@gem_ctx_isolation@bcs0-nonpriv.html
* igt@gem_ctx_isolation@bcs0-nonpriv-switch:
- shard-apl: [FAIL][60] -> [PASS][61] +9 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-apl6/igt@gem_ctx_isolation@bcs0-nonpriv-switch.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-apl7/igt@gem_ctx_isolation@bcs0-nonpriv-switch.html
- shard-glk: [FAIL][62] -> [PASS][63] +9 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-glk1/igt@gem_ctx_isolation@bcs0-nonpriv-switch.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-glk4/igt@gem_ctx_isolation@bcs0-nonpriv-switch.html
* igt@gem_ctx_isolation@vcs0-nonpriv:
- shard-tglb: [FAIL][64] -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb8/igt@gem_ctx_isolation@vcs0-nonpriv.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb6/igt@gem_ctx_isolation@vcs0-nonpriv.html
* igt@gem_ctx_isolation@vcs1-reset:
- shard-kbl: [FAIL][66] -> [PASS][67] +7 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl3/igt@gem_ctx_isolation@vcs1-reset.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl4/igt@gem_ctx_isolation@vcs1-reset.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-tglb: [INCOMPLETE][68] ([i915#456]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb1/igt@gem_ctx_isolation@vcs1-s3.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb3/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_shared@q-smoketest-all:
- shard-tglb: [INCOMPLETE][70] ([fdo#111735]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb4/igt@gem_ctx_shared@q-smoketest-all.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb4/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_eio@in-flight-suspend:
- shard-tglb: [INCOMPLETE][72] ([i915#456] / [i915#460] / [i915#534]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb7/igt@gem_eio@in-flight-suspend.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb8/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_parallel@rcs0-fds:
- shard-hsw: [FAIL][74] -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-hsw6/igt@gem_exec_parallel@rcs0-fds.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-hsw2/igt@gem_exec_parallel@rcs0-fds.html
* {igt@gem_exec_schedule@pi-userfault-bsd}:
- shard-iclb: [SKIP][76] ([i915#677]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb1/igt@gem_exec_schedule@pi-userfault-bsd.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb3/igt@gem_exec_schedule@pi-userfault-bsd.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][78] ([fdo#112146]) -> [PASS][79] +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][80] ([fdo#111736] / [i915#460]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb2/igt@gem_exec_suspend@basic-s3.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb6/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive:
- shard-tglb: [TIMEOUT][82] ([i915#530]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb5/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][84] ([i915#644]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-apl1/igt@gem_ppgtt@flink-and-close-vma-leak.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][86] ([fdo#111870]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_selftest@mock_sanitycheck:
- shard-snb: [DMESG-WARN][88] -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-snb1/igt@i915_selftest@mock_sanitycheck.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-snb7/igt@i915_selftest@mock_sanitycheck.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- shard-iclb: [DMESG-WARN][90] ([i915#728]) -> [PASS][91] +6 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb4/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb3/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- shard-snb: [SKIP][92] ([fdo#109271]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-snb1/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-snb1/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-kbl: [DMESG-WARN][94] ([i915#728]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl7/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl4/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [DMESG-WARN][96] ([i915#180]) -> [PASS][97] +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen:
- shard-apl: [FAIL][98] ([i915#54]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][100] ([i915#180]) -> [PASS][101] +3 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
- shard-tglb: [FAIL][102] ([i915#49]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][104] ([i915#49]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [INCOMPLETE][106] ([i915#123] / [i915#140]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-tglb: [INCOMPLETE][108] ([i915#456] / [i915#460]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb7/igt@kms_frontbuffer_tracking@psr-suspend.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb6/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][110] ([i915#460]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb5/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-accuracy-98-vcs1:
- shard-iclb: [SKIP][112] ([fdo#112080]) -> [PASS][113] +3 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb3/igt@perf_pmu@busy-accuracy-98-vcs1.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb4/igt@perf_pmu@busy-accuracy-98-vcs1.html
* igt@perf_pmu@busy-check-all-rcs0:
- shard-tglb: [DMESG-WARN][114] ([i915#728]) -> [PASS][115] +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb2/igt@perf_pmu@busy-check-all-rcs0.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb6/igt@perf_pmu@busy-check-all-rcs0.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][116] ([fdo#109276]) -> [PASS][117] +8 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb8/igt@prime_busy@hang-bsd2.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb1/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][118] ([fdo#112080]) -> [SKIP][119] ([fdo#109276] / [fdo#112080]) +5 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-kbl: [FAIL][120] -> [DMESG-WARN][121] ([i915#180])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl7/igt@gem_ctx_isolation@vcs1-s3.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl6/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_isolation@vcs2-nonpriv-switch:
- shard-tglb: [SKIP][122] ([fdo#112080]) -> [SKIP][123] ([fdo#111912] / [fdo#112080]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-tglb3/igt@gem_ctx_isolation@vcs2-nonpriv-switch.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-tglb8/igt@gem_ctx_isolation@vcs2-nonpriv-switch.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [FAIL][124] ([i915#49]) -> [DMESG-WARN][125] ([i915#728])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-kbl: [INCOMPLETE][126] ([fdo#103665]) -> [DMESG-WARN][127] ([i915#728])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7506/shard-kbl7/igt@kms_plane@pixel-format-pipe-a-planes.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/shard-kbl4/igt@kms_plane@pixel-format-pipe-a-planes.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#534]: https://gitlab.freedesktop.org/drm/intel/issues/534
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#728]: https://gitlab.freedesktop.org/drm/intel/issues/728
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5335 -> IGTPW_3824
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7506: ebfb3e0542800b63ac73a4546fb7d486f9ade587 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3824: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/index.html
IGT_5335: 06aa2c377ed40df1e246fca009c441fa18e53825 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3824/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
2019-12-07 1:08 ` [igt-dev] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2019-12-07 17:42 ` Andi Shyti
2019-12-07 17:43 ` [igt-dev] " Andi Shyti
2019-12-07 17:46 ` [igt-dev] " Chris Wilson
-1 siblings, 2 replies; 11+ messages in thread
From: Andi Shyti @ 2019-12-07 17:42 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
Hi Chris,
On Sat, Dec 07, 2019 at 01:08:35AM +0000, Chris Wilson wrote:
> This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b.
>
> __for_each_physical_engine() reprograms the context, invalidating the
> use of e->flags to select engines, necessitating e->index instead.
> Withot also fixing up the engine selection, the result is that random
> engines were being used to read registers from the intended engine.
> This does not end well.
So, the problem here is that with __for_each_physical_engine() we
"reprogram the context" which means that there is a re-mapping of
engines in it. Have I understood correctly?
Doesn't that happen only in the case when the context has no
engines in it?
> @@ -877,7 +876,8 @@ igt_main
> igt_skip_on(gen > LAST_KNOWN_GEN);
> }
>
> - __for_each_physical_engine(fd, e) {
> + for (const struct intel_execution_engine2 *e = intel_execution_engines2;
> + e->name; e++) {
__for_each_static_engine() ?
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
2019-12-07 17:42 ` [Intel-gfx] [PATCH i-g-t] " Andi Shyti
@ 2019-12-07 17:43 ` Andi Shyti
2019-12-07 17:46 ` [igt-dev] " Chris Wilson
1 sibling, 0 replies; 11+ messages in thread
From: Andi Shyti @ 2019-12-07 17:43 UTC (permalink / raw)
To: Andi Shyti; +Cc: igt-dev, intel-gfx
> > This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b.
[...]
> > - __for_each_physical_engine(fd, e) {
> > + for (const struct intel_execution_engine2 *e = intel_execution_engines2;
> > + e->name; e++) {
>
> __for_each_static_engine() ?
oh yes, that's a revert! ignore it.
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
2019-12-07 17:42 ` [Intel-gfx] [PATCH i-g-t] " Andi Shyti
@ 2019-12-07 17:46 ` Chris Wilson
2019-12-07 17:46 ` [igt-dev] " Chris Wilson
1 sibling, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2019-12-07 17:46 UTC (permalink / raw)
To: Andi Shyti; +Cc: igt-dev, intel-gfx
Quoting Andi Shyti (2019-12-07 17:42:39)
> Hi Chris,
>
> On Sat, Dec 07, 2019 at 01:08:35AM +0000, Chris Wilson wrote:
> > This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b.
> >
> > __for_each_physical_engine() reprograms the context, invalidating the
> > use of e->flags to select engines, necessitating e->index instead.
> > Withot also fixing up the engine selection, the result is that random
> > engines were being used to read registers from the intended engine.
> > This does not end well.
>
> So, the problem here is that with __for_each_physical_engine() we
> "reprogram the context" which means that there is a re-mapping of
> engines in it. Have I understood correctly?
>
> Doesn't that happen only in the case when the context has no
> engines in it?
iirc, it does something like init_engine_map and sets a consistent
engine layout on the context -- but switches execbuf over to index mode.
> > @@ -877,7 +876,8 @@ igt_main
> > igt_skip_on(gen > LAST_KNOWN_GEN);
> > }
> >
> > - __for_each_physical_engine(fd, e) {
> > + for (const struct intel_execution_engine2 *e = intel_execution_engines2;
> > + e->name; e++) {
>
> __for_each_static_engine() ?
I'm just doing a simple revert so we can try again :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
@ 2019-12-07 17:46 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2019-12-07 17:46 UTC (permalink / raw)
To: Andi Shyti; +Cc: igt-dev, intel-gfx
Quoting Andi Shyti (2019-12-07 17:42:39)
> Hi Chris,
>
> On Sat, Dec 07, 2019 at 01:08:35AM +0000, Chris Wilson wrote:
> > This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b.
> >
> > __for_each_physical_engine() reprograms the context, invalidating the
> > use of e->flags to select engines, necessitating e->index instead.
> > Withot also fixing up the engine selection, the result is that random
> > engines were being used to read registers from the intended engine.
> > This does not end well.
>
> So, the problem here is that with __for_each_physical_engine() we
> "reprogram the context" which means that there is a re-mapping of
> engines in it. Have I understood correctly?
>
> Doesn't that happen only in the case when the context has no
> engines in it?
iirc, it does something like init_engine_map and sets a consistent
engine layout on the context -- but switches execbuf over to index mode.
> > @@ -877,7 +876,8 @@ igt_main
> > igt_skip_on(gen > LAST_KNOWN_GEN);
> > }
> >
> > - __for_each_physical_engine(fd, e) {
> > + for (const struct intel_execution_engine2 *e = intel_execution_engines2;
> > + e->name; e++) {
>
> __for_each_static_engine() ?
I'm just doing a simple revert so we can try again :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
2019-12-07 1:08 ` [igt-dev] " Chris Wilson
@ 2019-12-09 9:25 ` Tvrtko Ursulin
-1 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2019-12-09 9:25 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 07/12/2019 01:08, Chris Wilson wrote:
> This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b.
>
> __for_each_physical_engine() reprograms the context, invalidating the
> use of e->flags to select engines, necessitating e->index instead.
> Withot also fixing up the engine selection, the result is that random
> engines were being used to read registers from the intended engine.
> This does not end well.
Argh, an oversight.. test(s) needs to be looked at in detail and
converted fully. On a cursory glance a sprinkle of
gem_context_set_all_engines on internally created contexts is needed to
align with the passed in e and e->flags.
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Stuart Summers <stuart.summers@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/i915/gem_ctx_isolation.c | 4 ++--
> tests/i915/gem_ctx_persistence.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
> index 9435209e9..6aa27133c 100644
> --- a/tests/i915/gem_ctx_isolation.c
> +++ b/tests/i915/gem_ctx_isolation.c
> @@ -856,7 +856,6 @@ static unsigned int __has_context_isolation(int fd)
>
> igt_main
> {
> - struct intel_execution_engine2 *e;
> unsigned int has_context_isolation = 0;
> int fd = -1;
>
> @@ -877,7 +876,8 @@ igt_main
> igt_skip_on(gen > LAST_KNOWN_GEN);
> }
>
> - __for_each_physical_engine(fd, e) {
> + for (const struct intel_execution_engine2 *e = intel_execution_engines2;
> + e->name; e++) {
> igt_subtest_group {
> igt_fixture {
> igt_require(has_context_isolation & (1 << e->class));
> diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
> index 30772159b..d68431ae0 100644
> --- a/tests/i915/gem_ctx_persistence.c
> +++ b/tests/i915/gem_ctx_persistence.c
> @@ -727,7 +727,7 @@ igt_main
> igt_subtest("hangcheck")
> test_nohangcheck_hostile(i915);
>
> - __for_each_physical_engine(i915, e) {
> + __for_each_static_engine(e) {
> igt_subtest_group {
> igt_fixture {
> gem_require_ring(i915, e->flags);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [igt-dev] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"
@ 2019-12-09 9:25 ` Tvrtko Ursulin
0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2019-12-09 9:25 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
On 07/12/2019 01:08, Chris Wilson wrote:
> This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b.
>
> __for_each_physical_engine() reprograms the context, invalidating the
> use of e->flags to select engines, necessitating e->index instead.
> Withot also fixing up the engine selection, the result is that random
> engines were being used to read registers from the intended engine.
> This does not end well.
Argh, an oversight.. test(s) needs to be looked at in detail and
converted fully. On a cursory glance a sprinkle of
gem_context_set_all_engines on internally created contexts is needed to
align with the passed in e and e->flags.
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Stuart Summers <stuart.summers@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/i915/gem_ctx_isolation.c | 4 ++--
> tests/i915/gem_ctx_persistence.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
> index 9435209e9..6aa27133c 100644
> --- a/tests/i915/gem_ctx_isolation.c
> +++ b/tests/i915/gem_ctx_isolation.c
> @@ -856,7 +856,6 @@ static unsigned int __has_context_isolation(int fd)
>
> igt_main
> {
> - struct intel_execution_engine2 *e;
> unsigned int has_context_isolation = 0;
> int fd = -1;
>
> @@ -877,7 +876,8 @@ igt_main
> igt_skip_on(gen > LAST_KNOWN_GEN);
> }
>
> - __for_each_physical_engine(fd, e) {
> + for (const struct intel_execution_engine2 *e = intel_execution_engines2;
> + e->name; e++) {
> igt_subtest_group {
> igt_fixture {
> igt_require(has_context_isolation & (1 << e->class));
> diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
> index 30772159b..d68431ae0 100644
> --- a/tests/i915/gem_ctx_persistence.c
> +++ b/tests/i915/gem_ctx_persistence.c
> @@ -727,7 +727,7 @@ igt_main
> igt_subtest("hangcheck")
> test_nohangcheck_hostile(i915);
>
> - __for_each_physical_engine(i915, e) {
> + __for_each_static_engine(e) {
> igt_subtest_group {
> igt_fixture {
> gem_require_ring(i915, e->flags);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread