All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libtraceevent: allow custom libdir path
@ 2019-12-07 11:14 Sudip Mukherjee
  2019-12-12 16:19 ` Steven Rostedt
  2019-12-17 11:31 ` [tip: perf/urgent] libtraceevent: Allow " tip-bot2 for Sudip Mukherjee
  0 siblings, 2 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2019-12-07 11:14 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, rostedt, arnaldo.melo
  Cc: linux-kernel, linux-trace-devel, Sudip Mukherjee

When I use prefix=/usr and try to install libtraceevent in my laptop it
tries to install in /usr/lib64. I am not having any folder as /usr/lib64
and also the debian policy doesnot allow installing in /usr/lib64. It
should be in /usr/lib/x86_64-linux-gnu/.

Quote: No package for a 64 bit architecture may install files in
	/usr/lib64/ or in a subdirectory of it.
ref: https://www.debian.org/doc/debian-policy/ch-opersys.html

Make it more flexible by allowing to mention libdir_relative while
installing so that distros can mention the path according to their policy
or use the default one.

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---

Hi Steve,

And yet another one (hopefully the final one for now). I know I missed
the merge window, but your Ack should be ok.

 tools/lib/traceevent/Makefile         | 5 +++--
 tools/lib/traceevent/plugins/Makefile | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index c5a03356a999..7e2450ddd7e1 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
 
 LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
 ifeq ($(LP64), 1)
-  libdir_relative = lib64
+  libdir_relative_temp = lib64
 else
-  libdir_relative = lib
+  libdir_relative_temp = lib
 endif
 
+libdir_relative ?= $(libdir_relative_temp)
 prefix ?= /usr/local
 libdir = $(prefix)/$(libdir_relative)
 man_dir = $(prefix)/share/man
diff --git a/tools/lib/traceevent/plugins/Makefile b/tools/lib/traceevent/plugins/Makefile
index f440989fa55e..edb046151305 100644
--- a/tools/lib/traceevent/plugins/Makefile
+++ b/tools/lib/traceevent/plugins/Makefile
@@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
 
 LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
 ifeq ($(LP64), 1)
-  libdir_relative = lib64
+  libdir_relative_tmp = lib64
 else
-  libdir_relative = lib
+  libdir_relative_tmp = lib
 endif
 
+libdir_relative ?= $(libdir_relative_tmp)
 prefix ?= /usr/local
 libdir = $(prefix)/$(libdir_relative)
 
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] libtraceevent: allow custom libdir path
  2019-12-07 11:14 [PATCH] libtraceevent: allow custom libdir path Sudip Mukherjee
@ 2019-12-12 16:19 ` Steven Rostedt
  2019-12-12 17:55   ` Arnaldo Carvalho de Melo
  2019-12-17 11:31 ` [tip: perf/urgent] libtraceevent: Allow " tip-bot2 for Sudip Mukherjee
  1 sibling, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2019-12-12 16:19 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Sudip Mukherjee, arnaldo.melo, linux-kernel, linux-trace-devel


Arnaldo,

Can you pull this patch in?

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve


On Sat,  7 Dec 2019 11:14:40 +0000
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> When I use prefix=/usr and try to install libtraceevent in my laptop it
> tries to install in /usr/lib64. I am not having any folder as /usr/lib64
> and also the debian policy doesnot allow installing in /usr/lib64. It
> should be in /usr/lib/x86_64-linux-gnu/.
> 
> Quote: No package for a 64 bit architecture may install files in
> 	/usr/lib64/ or in a subdirectory of it.
> ref: https://www.debian.org/doc/debian-policy/ch-opersys.html
> 
> Make it more flexible by allowing to mention libdir_relative while
> installing so that distros can mention the path according to their policy
> or use the default one.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> 
> Hi Steve,
> 
> And yet another one (hopefully the final one for now). I know I missed
> the merge window, but your Ack should be ok.
> 
>  tools/lib/traceevent/Makefile         | 5 +++--
>  tools/lib/traceevent/plugins/Makefile | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index c5a03356a999..7e2450ddd7e1 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
>  
>  LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
>  ifeq ($(LP64), 1)
> -  libdir_relative = lib64
> +  libdir_relative_temp = lib64
>  else
> -  libdir_relative = lib
> +  libdir_relative_temp = lib
>  endif
>  
> +libdir_relative ?= $(libdir_relative_temp)
>  prefix ?= /usr/local
>  libdir = $(prefix)/$(libdir_relative)
>  man_dir = $(prefix)/share/man
> diff --git a/tools/lib/traceevent/plugins/Makefile b/tools/lib/traceevent/plugins/Makefile
> index f440989fa55e..edb046151305 100644
> --- a/tools/lib/traceevent/plugins/Makefile
> +++ b/tools/lib/traceevent/plugins/Makefile
> @@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
>  
>  LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
>  ifeq ($(LP64), 1)
> -  libdir_relative = lib64
> +  libdir_relative_tmp = lib64
>  else
> -  libdir_relative = lib
> +  libdir_relative_tmp = lib
>  endif
>  
> +libdir_relative ?= $(libdir_relative_tmp)
>  prefix ?= /usr/local
>  libdir = $(prefix)/$(libdir_relative)
>  


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] libtraceevent: allow custom libdir path
  2019-12-12 16:19 ` Steven Rostedt
@ 2019-12-12 17:55   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-12-12 17:55 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Arnaldo Carvalho de Melo, Sudip Mukherjee, arnaldo.melo,
	linux-kernel, linux-trace-devel

Em Thu, Dec 12, 2019 at 11:19:00AM -0500, Steven Rostedt escreveu:
> 
> Arnaldo,
> 
> Can you pull this patch in?
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Sure, applied.

- Arnaldo
 
> -- Steve
> 
> 
> On Sat,  7 Dec 2019 11:14:40 +0000
> Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> 
> > When I use prefix=/usr and try to install libtraceevent in my laptop it
> > tries to install in /usr/lib64. I am not having any folder as /usr/lib64
> > and also the debian policy doesnot allow installing in /usr/lib64. It
> > should be in /usr/lib/x86_64-linux-gnu/.
> > 
> > Quote: No package for a 64 bit architecture may install files in
> > 	/usr/lib64/ or in a subdirectory of it.
> > ref: https://www.debian.org/doc/debian-policy/ch-opersys.html
> > 
> > Make it more flexible by allowing to mention libdir_relative while
> > installing so that distros can mention the path according to their policy
> > or use the default one.
> > 
> > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> > ---
> > 
> > Hi Steve,
> > 
> > And yet another one (hopefully the final one for now). I know I missed
> > the merge window, but your Ack should be ok.
> > 
> >  tools/lib/traceevent/Makefile         | 5 +++--
> >  tools/lib/traceevent/plugins/Makefile | 5 +++--
> >  2 files changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> > index c5a03356a999..7e2450ddd7e1 100644
> > --- a/tools/lib/traceevent/Makefile
> > +++ b/tools/lib/traceevent/Makefile
> > @@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
> >  
> >  LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
> >  ifeq ($(LP64), 1)
> > -  libdir_relative = lib64
> > +  libdir_relative_temp = lib64
> >  else
> > -  libdir_relative = lib
> > +  libdir_relative_temp = lib
> >  endif
> >  
> > +libdir_relative ?= $(libdir_relative_temp)
> >  prefix ?= /usr/local
> >  libdir = $(prefix)/$(libdir_relative)
> >  man_dir = $(prefix)/share/man
> > diff --git a/tools/lib/traceevent/plugins/Makefile b/tools/lib/traceevent/plugins/Makefile
> > index f440989fa55e..edb046151305 100644
> > --- a/tools/lib/traceevent/plugins/Makefile
> > +++ b/tools/lib/traceevent/plugins/Makefile
> > @@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
> >  
> >  LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
> >  ifeq ($(LP64), 1)
> > -  libdir_relative = lib64
> > +  libdir_relative_tmp = lib64
> >  else
> > -  libdir_relative = lib
> > +  libdir_relative_tmp = lib
> >  endif
> >  
> > +libdir_relative ?= $(libdir_relative_tmp)
> >  prefix ?= /usr/local
> >  libdir = $(prefix)/$(libdir_relative)
> >  

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip: perf/urgent] libtraceevent: Allow custom libdir path
  2019-12-07 11:14 [PATCH] libtraceevent: allow custom libdir path Sudip Mukherjee
  2019-12-12 16:19 ` Steven Rostedt
@ 2019-12-17 11:31 ` tip-bot2 for Sudip Mukherjee
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Sudip Mukherjee @ 2019-12-17 11:31 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Sudipm Mukherjee, Steven Rostedt (VMware),
	linux-trace-devel, Arnaldo Carvalho de Melo, x86, LKML

The following commit has been merged into the perf/urgent branch of tip:

Commit-ID:     c09982f8e2bae80a66232630ec4ba50afacea486
Gitweb:        https://git.kernel.org/tip/c09982f8e2bae80a66232630ec4ba50afacea486
Author:        Sudip Mukherjee <sudipm.mukherjee@gmail.com>
AuthorDate:    Sat, 07 Dec 2019 11:14:40 
Committer:     Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Mon, 16 Dec 2019 13:40:26 -03:00

libtraceevent: Allow custom libdir path

When I use prefix=/usr and try to install libtraceevent in my laptop it
tries to install in /usr/lib64. I am not having any folder as /usr/lib64
and also the debian policy doesnot allow installing in /usr/lib64. It
should be in /usr/lib/x86_64-linux-gnu/.

Quote: No package for a 64 bit architecture may install files in
	/usr/lib64/ or in a subdirectory of it.

ref: https://www.debian.org/doc/debian-policy/ch-opersys.html

Make it more flexible by allowing to mention libdir_relative while
installing so that distros can mention the path according to their
policy or use the default one.

Signed-off-by: Sudipm Mukherjee <sudipm.mukherjee@gmail.com>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Sudipm Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Link: http://lore.kernel.org/lkml/20191207111440.6574-1-sudipm.mukherjee@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/Makefile         | 5 +++--
 tools/lib/traceevent/plugins/Makefile | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index c5a0335..c874c01 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -39,11 +39,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
 
 LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
 ifeq ($(LP64), 1)
-  libdir_relative = lib64
+  libdir_relative_temp = lib64
 else
-  libdir_relative = lib
+  libdir_relative_temp = lib
 endif
 
+libdir_relative ?= $(libdir_relative_temp)
 prefix ?= /usr/local
 libdir = $(prefix)/$(libdir_relative)
 man_dir = $(prefix)/share/man
diff --git a/tools/lib/traceevent/plugins/Makefile b/tools/lib/traceevent/plugins/Makefile
index f440989..349bb81 100644
--- a/tools/lib/traceevent/plugins/Makefile
+++ b/tools/lib/traceevent/plugins/Makefile
@@ -32,11 +32,12 @@ DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
 
 LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
 ifeq ($(LP64), 1)
-  libdir_relative = lib64
+  libdir_relative_tmp = lib64
 else
-  libdir_relative = lib
+  libdir_relative_tmp = lib
 endif
 
+libdir_relative ?= $(libdir_relative_tmp)
 prefix ?= /usr/local
 libdir = $(prefix)/$(libdir_relative)
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-17 11:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-07 11:14 [PATCH] libtraceevent: allow custom libdir path Sudip Mukherjee
2019-12-12 16:19 ` Steven Rostedt
2019-12-12 17:55   ` Arnaldo Carvalho de Melo
2019-12-17 11:31 ` [tip: perf/urgent] libtraceevent: Allow " tip-bot2 for Sudip Mukherjee

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.