From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-alpha@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
kbuild test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha
Date: Sat, 7 Dec 2019 14:54:24 -0800 [thread overview]
Message-ID: <20191207225424.GA9476@roeck-us.net> (raw)
In-Reply-To: <20191207191043.656328-1-arnd@arndb.de>
On Sat, Dec 07, 2019 at 08:10:26PM +0100, Arnd Bergmann wrote:
> Using compat_sys_getitimer and compat_sys_setitimer on alpha
> causes a link failure in the Alpha tinyconfig and other configurations
> that turn off CONFIG_POSIX_TIMERS.
>
> Use the same #ifdef check for the stub version as well.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 4c22ea2b9120 ("y2038: use compat_{get,set}_itimer on alpha")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> kernel/time/posix-stubs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
> index 67df65f887ac..20c65a7d4e3a 100644
> --- a/kernel/time/posix-stubs.c
> +++ b/kernel/time/posix-stubs.c
> @@ -151,6 +151,9 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
>
> #ifdef CONFIG_COMPAT
> COMPAT_SYS_NI(timer_create);
> +#endif
> +
> +#if defined(CONFIG_COMPAT) || defined(CONFIG_ALPHA)
> COMPAT_SYS_NI(getitimer);
> COMPAT_SYS_NI(setitimer);
> #endif
> --
> 2.20.0
>
next prev parent reply other threads:[~2019-12-07 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 19:10 [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha Arnd Bergmann
2019-12-07 22:54 ` Guenter Roeck [this message]
2020-01-09 17:28 ` [tip: timers/urgent] time/posix-stubs: Provide " tip-bot2 for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207225424.GA9476@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.