All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha
@ 2019-12-07 19:10 Arnd Bergmann
  2019-12-07 22:54 ` Guenter Roeck
  2020-01-09 17:28 ` [tip: timers/urgent] time/posix-stubs: Provide " tip-bot2 for Arnd Bergmann
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-12-07 19:10 UTC (permalink / raw)
  To: Thomas Gleixner, Andrew Morton
  Cc: linux-alpha, Richard Henderson, Ivan Kokshaysky, Matt Turner,
	Arnd Bergmann, Guenter Roeck, kbuild test robot, linux-kernel

Using compat_sys_getitimer and compat_sys_setitimer on alpha
causes a link failure in the Alpha tinyconfig and other configurations
that turn off CONFIG_POSIX_TIMERS.

Use the same #ifdef check for the stub version as well.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 4c22ea2b9120 ("y2038: use compat_{get,set}_itimer on alpha")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/time/posix-stubs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
index 67df65f887ac..20c65a7d4e3a 100644
--- a/kernel/time/posix-stubs.c
+++ b/kernel/time/posix-stubs.c
@@ -151,6 +151,9 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
 
 #ifdef CONFIG_COMPAT
 COMPAT_SYS_NI(timer_create);
+#endif
+
+#if defined(CONFIG_COMPAT) || defined(CONFIG_ALPHA)
 COMPAT_SYS_NI(getitimer);
 COMPAT_SYS_NI(setitimer);
 #endif
-- 
2.20.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha
  2019-12-07 19:10 [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha Arnd Bergmann
@ 2019-12-07 22:54 ` Guenter Roeck
  2020-01-09 17:28 ` [tip: timers/urgent] time/posix-stubs: Provide " tip-bot2 for Arnd Bergmann
  1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-12-07 22:54 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Thomas Gleixner, Andrew Morton, linux-alpha, Richard Henderson,
	Ivan Kokshaysky, Matt Turner, kbuild test robot, linux-kernel

On Sat, Dec 07, 2019 at 08:10:26PM +0100, Arnd Bergmann wrote:
> Using compat_sys_getitimer and compat_sys_setitimer on alpha
> causes a link failure in the Alpha tinyconfig and other configurations
> that turn off CONFIG_POSIX_TIMERS.
> 
> Use the same #ifdef check for the stub version as well.
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 4c22ea2b9120 ("y2038: use compat_{get,set}_itimer on alpha")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  kernel/time/posix-stubs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
> index 67df65f887ac..20c65a7d4e3a 100644
> --- a/kernel/time/posix-stubs.c
> +++ b/kernel/time/posix-stubs.c
> @@ -151,6 +151,9 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
>  
>  #ifdef CONFIG_COMPAT
>  COMPAT_SYS_NI(timer_create);
> +#endif
> +
> +#if defined(CONFIG_COMPAT) || defined(CONFIG_ALPHA)
>  COMPAT_SYS_NI(getitimer);
>  COMPAT_SYS_NI(setitimer);
>  #endif
> -- 
> 2.20.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip: timers/urgent] time/posix-stubs: Provide compat itimer supoprt for alpha
  2019-12-07 19:10 [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha Arnd Bergmann
  2019-12-07 22:54 ` Guenter Roeck
@ 2020-01-09 17:28 ` tip-bot2 for Arnd Bergmann
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Arnd Bergmann @ 2020-01-09 17:28 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Guenter Roeck, kbuild test robot, Arnd Bergmann, Thomas Gleixner,
	x86, LKML

The following commit has been merged into the timers/urgent branch of tip:

Commit-ID:     f35deaff1b8eadb9897e4fb8b3edc7717f4ec6fa
Gitweb:        https://git.kernel.org/tip/f35deaff1b8eadb9897e4fb8b3edc7717f4ec6fa
Author:        Arnd Bergmann <arnd@arndb.de>
AuthorDate:    Sat, 07 Dec 2019 20:10:26 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 09 Jan 2020 18:20:23 +01:00

time/posix-stubs: Provide compat itimer supoprt for alpha

Using compat_sys_getitimer and compat_sys_setitimer on alpha
causes a link failure in the Alpha tinyconfig and other configurations
that turn off CONFIG_POSIX_TIMERS.

Use the same #ifdef check for the stub version as well.

Fixes: 4c22ea2b9120 ("y2038: use compat_{get,set}_itimer on alpha")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20191207191043.656328-1-arnd@arndb.de
---
 kernel/time/posix-stubs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
index 67df65f..20c65a7 100644
--- a/kernel/time/posix-stubs.c
+++ b/kernel/time/posix-stubs.c
@@ -151,6 +151,9 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
 
 #ifdef CONFIG_COMPAT
 COMPAT_SYS_NI(timer_create);
+#endif
+
+#if defined(CONFIG_COMPAT) || defined(CONFIG_ALPHA)
 COMPAT_SYS_NI(getitimer);
 COMPAT_SYS_NI(setitimer);
 #endif

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-09 17:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-07 19:10 [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha Arnd Bergmann
2019-12-07 22:54 ` Guenter Roeck
2020-01-09 17:28 ` [tip: timers/urgent] time/posix-stubs: Provide " tip-bot2 for Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.