* [PATCH net] tc-testing: unbreak full listing of tdc testcases
@ 2019-12-09 16:58 Davide Caratti
2019-12-09 22:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Davide Caratti @ 2019-12-09 16:58 UTC (permalink / raw)
To: Roman Mashak, David S. Miller, netdev
the following command currently fails:
[root@fedora tc-testing]# ./tdc.py -l
The following test case IDs are not unique:
{'6f5e'}
Please correct them before continuing.
this happens because there are two tests having the same id:
[root@fedora tc-testing]# grep -r 6f5e tc-tests/*
tc-tests/actions/pedit.json: "id": "6f5e",
tc-tests/filters/basic.json: "id": "6f5e",
fix it replacing the latest duplicate id with a brand new one:
[root@fedora tc-testing]# sed -i 's/6f5e//1' tc-tests/filters/basic.json
[root@fedora tc-testing]# ./tdc.py -i
Fixes: 4717b05328ba ("tc-testing: Introduced tdc tests for basic filter")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
tools/testing/selftests/tc-testing/tc-tests/filters/basic.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json b/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json
index 76ae03a64506..2e361cea63bc 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json
@@ -152,7 +152,7 @@
]
},
{
- "id": "6f5e",
+ "id": "b99c",
"name": "Add basic filter with cmp ematch u8/transport layer and default action",
"category": [
"filter",
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] tc-testing: unbreak full listing of tdc testcases
2019-12-09 16:58 [PATCH net] tc-testing: unbreak full listing of tdc testcases Davide Caratti
@ 2019-12-09 22:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-09 22:44 UTC (permalink / raw)
To: dcaratti; +Cc: mrv, netdev
From: Davide Caratti <dcaratti@redhat.com>
Date: Mon, 9 Dec 2019 17:58:52 +0100
> the following command currently fails:
>
> [root@fedora tc-testing]# ./tdc.py -l
> The following test case IDs are not unique:
> {'6f5e'}
> Please correct them before continuing.
>
> this happens because there are two tests having the same id:
>
> [root@fedora tc-testing]# grep -r 6f5e tc-tests/*
> tc-tests/actions/pedit.json: "id": "6f5e",
> tc-tests/filters/basic.json: "id": "6f5e",
>
> fix it replacing the latest duplicate id with a brand new one:
>
> [root@fedora tc-testing]# sed -i 's/6f5e//1' tc-tests/filters/basic.json
> [root@fedora tc-testing]# ./tdc.py -i
>
> Fixes: 4717b05328ba ("tc-testing: Introduced tdc tests for basic filter")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-09 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 16:58 [PATCH net] tc-testing: unbreak full listing of tdc testcases Davide Caratti
2019-12-09 22:44 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.