From: kbuild test robot <lkp@intel.com>
To: Gaurav Kohli <gkohli@codeaurora.org>
Cc: kbuild-all@lists.01.org, tglx@linutronix.de, maz@kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Gaurav Kohli <gkohli@codeaurora.org>
Subject: Re: [PATCH v0] irqchip/gic-v3: Avoid check of lpi configuration for non existent cpu
Date: Tue, 10 Dec 2019 04:55:00 +0800 [thread overview]
Message-ID: <201912100457.zVTc2cLX%lkp@intel.com> (raw)
In-Reply-To: <1575543357-31892-1-git-send-email-gkohli@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3146 bytes --]
Hi Gaurav,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/irq/core]
[also build test ERROR on v5.5-rc1 next-20191209]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Gaurav-Kohli/irqchip-gic-v3-Avoid-check-of-lpi-configuration-for-non-existent-cpu/20191207-092729
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 407e62f52aadd8124dcba407f18a03aedce9b86a
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers//irqchip/irq-gic-v3.c: In function 'gic_iterate_rdists':
>> drivers//irqchip/irq-gic-v3.c:801:30: error: 'INVALID_HWID' undeclared (first use in this function); did you mean 'INVALID_UID'?
cpu_logical_map(cpu) != INVALID_HWID);
^~~~~~~~~~~~
INVALID_UID
drivers//irqchip/irq-gic-v3.c:801:30: note: each undeclared identifier is reported only once for each function it appears in
vim +801 drivers//irqchip/irq-gic-v3.c
764
765 static int gic_iterate_rdists(int (*fn)(struct redist_region *, void __iomem *))
766 {
767 int ret = -ENODEV;
768 int i;
769 int cpu = 0;
770
771 for (i = 0; i < gic_data.nr_redist_regions; i++) {
772 void __iomem *ptr = gic_data.redist_regions[i].redist_base;
773 u64 typer;
774 u32 reg;
775
776 reg = readl_relaxed(ptr + GICR_PIDR2) & GIC_PIDR2_ARCH_MASK;
777 if (reg != GIC_PIDR2_ARCH_GICv3 &&
778 reg != GIC_PIDR2_ARCH_GICv4) { /* We're in trouble... */
779 pr_warn("No redistributor present @%p\n", ptr);
780 break;
781 }
782
783 do {
784 cpu++;
785 typer = gic_read_typer(ptr + GICR_TYPER);
786 ret = fn(gic_data.redist_regions + i, ptr);
787 if (!ret)
788 return 0;
789
790 if (gic_data.redist_regions[i].single_redist)
791 break;
792
793 if (gic_data.redist_stride) {
794 ptr += gic_data.redist_stride;
795 } else {
796 ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */
797 if (typer & GICR_TYPER_VLPIS)
798 ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
799 }
800 } while (!(typer & GICR_TYPER_LAST) &&
> 801 cpu_logical_map(cpu) != INVALID_HWID);
802 }
803
804 return ret ? -ENODEV : 0;
805 }
806
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72070 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v0] irqchip/gic-v3: Avoid check of lpi configuration for non existent cpu
Date: Tue, 10 Dec 2019 04:55:00 +0800 [thread overview]
Message-ID: <201912100457.zVTc2cLX%lkp@intel.com> (raw)
In-Reply-To: <1575543357-31892-1-git-send-email-gkohli@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3229 bytes --]
Hi Gaurav,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/irq/core]
[also build test ERROR on v5.5-rc1 next-20191209]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Gaurav-Kohli/irqchip-gic-v3-Avoid-check-of-lpi-configuration-for-non-existent-cpu/20191207-092729
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 407e62f52aadd8124dcba407f18a03aedce9b86a
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers//irqchip/irq-gic-v3.c: In function 'gic_iterate_rdists':
>> drivers//irqchip/irq-gic-v3.c:801:30: error: 'INVALID_HWID' undeclared (first use in this function); did you mean 'INVALID_UID'?
cpu_logical_map(cpu) != INVALID_HWID);
^~~~~~~~~~~~
INVALID_UID
drivers//irqchip/irq-gic-v3.c:801:30: note: each undeclared identifier is reported only once for each function it appears in
vim +801 drivers//irqchip/irq-gic-v3.c
764
765 static int gic_iterate_rdists(int (*fn)(struct redist_region *, void __iomem *))
766 {
767 int ret = -ENODEV;
768 int i;
769 int cpu = 0;
770
771 for (i = 0; i < gic_data.nr_redist_regions; i++) {
772 void __iomem *ptr = gic_data.redist_regions[i].redist_base;
773 u64 typer;
774 u32 reg;
775
776 reg = readl_relaxed(ptr + GICR_PIDR2) & GIC_PIDR2_ARCH_MASK;
777 if (reg != GIC_PIDR2_ARCH_GICv3 &&
778 reg != GIC_PIDR2_ARCH_GICv4) { /* We're in trouble... */
779 pr_warn("No redistributor present @%p\n", ptr);
780 break;
781 }
782
783 do {
784 cpu++;
785 typer = gic_read_typer(ptr + GICR_TYPER);
786 ret = fn(gic_data.redist_regions + i, ptr);
787 if (!ret)
788 return 0;
789
790 if (gic_data.redist_regions[i].single_redist)
791 break;
792
793 if (gic_data.redist_stride) {
794 ptr += gic_data.redist_stride;
795 } else {
796 ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */
797 if (typer & GICR_TYPER_VLPIS)
798 ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
799 }
800 } while (!(typer & GICR_TYPER_LAST) &&
> 801 cpu_logical_map(cpu) != INVALID_HWID);
802 }
803
804 return ret ? -ENODEV : 0;
805 }
806
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72070 bytes --]
next prev parent reply other threads:[~2019-12-09 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 10:55 [PATCH v0] irqchip/gic-v3: Avoid check of lpi configuration for non existent cpu Gaurav Kohli
2019-12-05 12:47 ` Marc Zyngier
2019-12-05 13:01 ` Gaurav Kohli
[not found] ` <209f30c6-c03a-daeb-1f01-e03c489f41d8@codeaurora.org>
2019-12-05 13:18 ` Marc Zyngier
2019-12-06 8:45 ` Gaurav Kohli
[not found] ` <cfec6054-0ebe-f70b-b1a8-6c7bd7fc4450@codeaurora.org>
2019-12-06 8:54 ` Marc Zyngier
2019-12-09 20:55 ` kbuild test robot [this message]
2019-12-09 20:55 ` kbuild test robot
2019-12-10 0:39 ` kbuild test robot
2019-12-10 0:39 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912100457.zVTc2cLX%lkp@intel.com \
--to=lkp@intel.com \
--cc=gkohli@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.