* [PATCH 1/1] common: remove duplicate typedef for uchar
@ 2019-12-10 6:43 Heinrich Schuchardt
2019-12-10 8:34 ` Joe Hershberger
2019-12-14 1:59 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2019-12-10 6:43 UTC (permalink / raw)
To: u-boot
With commit 37db55b7e9db ("linux/types.h: fix typo unchar") we have a
duplicate typedef for uchar. As linux/types.h is included in common.h we
don't need another typedef for uchar there.
Fixes: 37db55b7e9db ("linux/types.h: fix typo unchar")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
include/common.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/common.h b/include/common.h
index 8b37b58747..52c02185f4 100644
--- a/include/common.h
+++ b/include/common.h
@@ -15,7 +15,6 @@
#ifndef __ASSEMBLY__ /* put C only stuff in this section */
-typedef unsigned char uchar;
typedef volatile unsigned long vu_long;
typedef volatile unsigned short vu_short;
typedef volatile unsigned char vu_char;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] common: remove duplicate typedef for uchar
2019-12-10 6:43 [PATCH 1/1] common: remove duplicate typedef for uchar Heinrich Schuchardt
@ 2019-12-10 8:34 ` Joe Hershberger
2019-12-14 1:59 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Joe Hershberger @ 2019-12-10 8:34 UTC (permalink / raw)
To: u-boot
Hi Heinrich,
On Tue, Dec 10, 2019 at 12:44 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> With commit 37db55b7e9db ("linux/types.h: fix typo unchar") we have a
> duplicate typedef for uchar. As linux/types.h is included in common.h we
> don't need another typedef for uchar there.
>
> Fixes: 37db55b7e9db ("linux/types.h: fix typo unchar")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] common: remove duplicate typedef for uchar
2019-12-10 6:43 [PATCH 1/1] common: remove duplicate typedef for uchar Heinrich Schuchardt
2019-12-10 8:34 ` Joe Hershberger
@ 2019-12-14 1:59 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2019-12-14 1:59 UTC (permalink / raw)
To: u-boot
On Tue, Dec 10, 2019 at 07:43:33AM +0100, Heinrich Schuchardt wrote:
> With commit 37db55b7e9db ("linux/types.h: fix typo unchar") we have a
> duplicate typedef for uchar. As linux/types.h is included in common.h we
> don't need another typedef for uchar there.
>
> Fixes: 37db55b7e9db ("linux/types.h: fix typo unchar")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191213/fe90acb8/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-14 1:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 6:43 [PATCH 1/1] common: remove duplicate typedef for uchar Heinrich Schuchardt
2019-12-10 8:34 ` Joe Hershberger
2019-12-14 1:59 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.