All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Jürgen Groß" <jgross@suse.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jens Axboe <axboe@kernel.dk>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	<xen-devel@lists.xenproject.org>, <linux-block@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk
Date: Tue, 10 Dec 2019 12:27:14 +0100	[thread overview]
Message-ID: <20191210112714.GH980@Air-de-Roger> (raw)
In-Reply-To: <bf13410c-b62e-d82f-6351-ee49d7964fe7@suse.com>

On Tue, Dec 10, 2019 at 08:15:22AM +0100, Jürgen Groß wrote:
> On 09.12.19 21:14, Nathan Chancellor wrote:
> > Clang warns:
> > 
> > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation;
> > statement is not part of the previous 'if' [-Wmisleading-indentation]
> >                  nr_parts = PARTS_PER_DISK;
> >                  ^
> > ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here
> >                  if (err)
> >                  ^
> > 
> > This is because there is a space at the beginning of this line; remove
> > it so that the indentation is consistent according to the Linux kernel
> > coding style and clang no longer warns.
> > 
> > While we are here, the previous line has some trailing whitespace; clean
> > that up as well.
> > 
> > Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/791
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Jürgen Groß" <jgross@suse.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	clang-built-linux@googlegroups.com,
	xen-devel@lists.xenproject.org,
	Nathan Chancellor <natechancellor@gmail.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk
Date: Tue, 10 Dec 2019 12:27:14 +0100	[thread overview]
Message-ID: <20191210112714.GH980@Air-de-Roger> (raw)
In-Reply-To: <bf13410c-b62e-d82f-6351-ee49d7964fe7@suse.com>

On Tue, Dec 10, 2019 at 08:15:22AM +0100, Jürgen Groß wrote:
> On 09.12.19 21:14, Nathan Chancellor wrote:
> > Clang warns:
> > 
> > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation;
> > statement is not part of the previous 'if' [-Wmisleading-indentation]
> >                  nr_parts = PARTS_PER_DISK;
> >                  ^
> > ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here
> >                  if (err)
> >                  ^
> > 
> > This is because there is a space at the beginning of this line; remove
> > it so that the indentation is consistent according to the Linux kernel
> > coding style and clang no longer warns.
> > 
> > While we are here, the previous line has some trailing whitespace; clean
> > that up as well.
> > 
> > Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/791
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-12-10 11:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 20:14 [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk Nathan Chancellor
2019-12-09 20:14 ` [Xen-devel] " Nathan Chancellor
2019-12-09 21:07 ` Nick Desaulniers
2019-12-09 21:07   ` [Xen-devel] " Nick Desaulniers
2019-12-09 21:14   ` Nathan Chancellor
2019-12-09 21:14     ` [Xen-devel] " Nathan Chancellor
2019-12-10  5:36   ` Jürgen Groß
2019-12-10  5:36     ` [Xen-devel] " Jürgen Groß
2019-12-10  7:15 ` Jürgen Groß
2019-12-10  7:15   ` [Xen-devel] " Jürgen Groß
2019-12-10 11:27   ` Roger Pau Monné [this message]
2019-12-10 11:27     ` Roger Pau Monné
2019-12-20 12:39 ` Jürgen Groß
2019-12-20 12:39   ` [Xen-devel] " Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210112714.GH980@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=axboe@kernel.dk \
    --cc=boris.ostrovsky@oracle.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.