All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/8] drm/client: convert to drm device based logging
Date: Tue, 10 Dec 2019 14:30:44 +0200	[thread overview]
Message-ID: <20191210123050.8799-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20191210123050.8799-1-jani.nikula@intel.com>

Prefer drm_dbg_kms() and drm_err() over DRM_DEV_DEBUG_KMS() and
DRM_DEV_ERROR().

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_client.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index d9a2e3695525..b031b45aa8ef 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -150,7 +150,7 @@ void drm_client_release(struct drm_client_dev *client)
 {
 	struct drm_device *dev = client->dev;
 
-	DRM_DEV_DEBUG_KMS(dev->dev, "%s\n", client->name);
+	drm_dbg_kms(dev, "%s\n", client->name);
 
 	drm_client_modeset_free(client);
 	drm_client_close(client);
@@ -203,7 +203,7 @@ void drm_client_dev_hotplug(struct drm_device *dev)
 			continue;
 
 		ret = client->funcs->hotplug(client);
-		DRM_DEV_DEBUG_KMS(dev->dev, "%s: ret=%d\n", client->name, ret);
+		drm_dbg_kms(dev, "%s: ret=%d\n", client->name, ret);
 	}
 	mutex_unlock(&dev->clientlist_mutex);
 }
@@ -223,7 +223,7 @@ void drm_client_dev_restore(struct drm_device *dev)
 			continue;
 
 		ret = client->funcs->restore(client);
-		DRM_DEV_DEBUG_KMS(dev->dev, "%s: ret=%d\n", client->name, ret);
+		drm_dbg_kms(dev, "%s: ret=%d\n", client->name, ret);
 		if (!ret) /* The first one to return zero gets the privilege to restore */
 			break;
 	}
@@ -351,8 +351,8 @@ static void drm_client_buffer_rmfb(struct drm_client_buffer *buffer)
 
 	ret = drm_mode_rmfb(buffer->client->dev, buffer->fb->base.id, buffer->client->file);
 	if (ret)
-		DRM_DEV_ERROR(buffer->client->dev->dev,
-			      "Error removing FB:%u (%d)\n", buffer->fb->base.id, ret);
+		drm_err(buffer->client->dev,
+			"Error removing FB:%u (%d)\n", buffer->fb->base.id, ret);
 
 	buffer->fb = NULL;
 }
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/8] drm/client: convert to drm device based logging
Date: Tue, 10 Dec 2019 14:30:44 +0200	[thread overview]
Message-ID: <20191210123050.8799-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20191210123050.8799-1-jani.nikula@intel.com>

Prefer drm_dbg_kms() and drm_err() over DRM_DEV_DEBUG_KMS() and
DRM_DEV_ERROR().

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_client.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index d9a2e3695525..b031b45aa8ef 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -150,7 +150,7 @@ void drm_client_release(struct drm_client_dev *client)
 {
 	struct drm_device *dev = client->dev;
 
-	DRM_DEV_DEBUG_KMS(dev->dev, "%s\n", client->name);
+	drm_dbg_kms(dev, "%s\n", client->name);
 
 	drm_client_modeset_free(client);
 	drm_client_close(client);
@@ -203,7 +203,7 @@ void drm_client_dev_hotplug(struct drm_device *dev)
 			continue;
 
 		ret = client->funcs->hotplug(client);
-		DRM_DEV_DEBUG_KMS(dev->dev, "%s: ret=%d\n", client->name, ret);
+		drm_dbg_kms(dev, "%s: ret=%d\n", client->name, ret);
 	}
 	mutex_unlock(&dev->clientlist_mutex);
 }
@@ -223,7 +223,7 @@ void drm_client_dev_restore(struct drm_device *dev)
 			continue;
 
 		ret = client->funcs->restore(client);
-		DRM_DEV_DEBUG_KMS(dev->dev, "%s: ret=%d\n", client->name, ret);
+		drm_dbg_kms(dev, "%s: ret=%d\n", client->name, ret);
 		if (!ret) /* The first one to return zero gets the privilege to restore */
 			break;
 	}
@@ -351,8 +351,8 @@ static void drm_client_buffer_rmfb(struct drm_client_buffer *buffer)
 
 	ret = drm_mode_rmfb(buffer->client->dev, buffer->fb->base.id, buffer->client->file);
 	if (ret)
-		DRM_DEV_ERROR(buffer->client->dev->dev,
-			      "Error removing FB:%u (%d)\n", buffer->fb->base.id, ret);
+		drm_err(buffer->client->dev,
+			"Error removing FB:%u (%d)\n", buffer->fb->base.id, ret);
 
 	buffer->fb = NULL;
 }
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-12-10 12:31 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 12:30 [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-10 12:30 ` Jani Nikula [this message]
2019-12-10 12:30   ` [Intel-gfx] [PATCH 2/8] drm/client: convert to drm device based logging Jani Nikula
2019-12-17 18:51   ` Sam Ravnborg
2019-12-17 18:51     ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 3/8] drm/fb-helper: " Jani Nikula
2019-12-10 12:30   ` [Intel-gfx] " Jani Nikula
2019-12-17 18:56   ` Sam Ravnborg
2019-12-17 18:56     ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 4/8] drm/gem-fb-helper: " Jani Nikula
2019-12-10 12:30   ` [Intel-gfx] " Jani Nikula
2019-12-17 18:57   ` Sam Ravnborg
2019-12-17 18:57     ` [Intel-gfx] " Sam Ravnborg
2019-12-19 14:23     ` Jani Nikula
2019-12-19 14:23       ` [Intel-gfx] " Jani Nikula
2019-12-10 12:30 ` [PATCH 5/8] drm/mipi-dbi: " Jani Nikula
2019-12-10 12:30   ` [Intel-gfx] " Jani Nikula
2019-12-17 19:00   ` Sam Ravnborg
2019-12-17 19:00     ` [Intel-gfx] " Sam Ravnborg
2019-12-17 19:10     ` Sam Ravnborg
2019-12-17 19:10       ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 6/8] drm/atomic: " Jani Nikula
2019-12-10 12:30   ` [Intel-gfx] " Jani Nikula
2019-12-12  8:07   ` [6/8] " james qian wang (Arm Technology China)
2019-12-12  8:07     ` [Intel-gfx] " james qian wang (Arm Technology China)
2019-12-12  8:33     ` Jani Nikula
2019-12-12  8:33       ` [Intel-gfx] " Jani Nikula
2019-12-17 19:07   ` [PATCH 6/8] " Sam Ravnborg
2019-12-17 19:07     ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 7/8] drm/i915/uc: " Jani Nikula
2019-12-10 12:30   ` [Intel-gfx] " Jani Nikula
2019-12-10 12:30 ` [PATCH 8/8] drm/i915/wopcm: " Jani Nikula
2019-12-10 12:30   ` [Intel-gfx] " Jani Nikula
2019-12-10 12:34 ` [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-12-10 12:34   ` [Intel-gfx] " Jani Nikula
2019-12-10 22:07   ` Daniel Vetter
2019-12-10 22:07     ` [Intel-gfx] " Daniel Vetter
2019-12-10 19:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] " Patchwork
2019-12-10 19:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-12 21:53 ` [PATCH 1/8] " Sam Ravnborg
2019-12-12 21:53   ` [Intel-gfx] " Sam Ravnborg
2019-12-13 14:41   ` Jani Nikula
2019-12-13 14:41     ` [Intel-gfx] " Jani Nikula
2019-12-13 13:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/print: introduce new struct drm_device based logging macros (rev2) Patchwork
2019-12-13 15:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-13 19:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/print: introduce new struct drm_device based logging macros (rev3) Patchwork
2019-12-13 20:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-14 16:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-17 14:45 ` [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-12-17 14:45   ` [Intel-gfx] " Jani Nikula
2019-12-17 16:11   ` Sam Ravnborg
2019-12-17 16:11     ` [Intel-gfx] " Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210123050.8799-2-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.