[f2fs-dev] [PATCH] fsck.f2fs: do not access nat etnries in ckpt before initialization

[f2fs-dev] [PATCH] fsck.f2fs: do not access nat etnries in ckpt before initialization

[Jaegeuk Kim]

ckpt->entries is initialized by fsck_init(), but we tried to access it during
f2fs_do_mount().

The call sequence is:
 - f2fs_do_mount
  - record_fsync_data
    - traverse_dnodes
     - do_record_fsync_data
      - ADDRS_PER_PAGE
       - get_node_info
        - node_info_from_raw_nat(fsck->entries[nid])
 - do_fsck
  - fsck_init
   - build_nat_area_bitmap
    - fsck->entries = calloc(fsck->nr_nat_entries);

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fsck/mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fsck/mount.c b/fsck/mount.c
index 47fe488..475ef67 100644
--- a/fsck/mount.c
+++ b/fsck/mount.c
@@ -2139,7 +2139,7 @@ void get_node_info(struct f2fs_sb_info *sbi, nid_t nid, struct node_info *ni)
 	struct f2fs_nat_entry raw_nat;
 
 	ni->nid = nid;
-	if (c.func == FSCK) {
+	if (c.func == FSCK && F2FS_FSCK(sbi)->nr_nat_entries) {
 		node_info_from_raw_nat(ni, &(F2FS_FSCK(sbi)->entries[nid]));
 		if (ni->blk_addr)
 			return;
-- 
2.19.0.605.g01d371f741-goog



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] fsck.f2fs: do not access nat etnries in ckpt before initialization

[Chao Yu]

On 2019/12/11 0:47, Jaegeuk Kim wrote:
> ckpt->entries is initialized by fsck_init(), but we tried to access it during
> f2fs_do_mount().
> 
> The call sequence is:
>  - f2fs_do_mount
>   - record_fsync_data
>     - traverse_dnodes
>      - do_record_fsync_data
>       - ADDRS_PER_PAGE
>        - get_node_info
>         - node_info_from_raw_nat(fsck->entries[nid])
>  - do_fsck
>   - fsck_init
>    - build_nat_area_bitmap
>     - fsck->entries = calloc(fsck->nr_nat_entries);
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] fsck.f2fs: do not access nat etnries in ckpt before initialization

[Jaegeuk Kim]

On 01/03, Chao Yu wrote:
> On 2019/12/11 0:47, Jaegeuk Kim wrote:
> > ckpt->entries is initialized by fsck_init(), but we tried to access it during
> > f2fs_do_mount().
> > 
> > The call sequence is:
> >  - f2fs_do_mount
> >   - record_fsync_data
> >     - traverse_dnodes
> >      - do_record_fsync_data
> >       - ADDRS_PER_PAGE
> >        - get_node_info
> >         - node_info_from_raw_nat(fsck->entries[nid])
> >  - do_fsck
> >   - fsck_init
> >    - build_nat_area_bitmap
> >     - fsck->entries = calloc(fsck->nr_nat_entries);
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> 
> Reviewed-by: Chao Yu <yuchao0@huawei.com>

Sorry, merged in master before.

> 
> Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel