All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Stephan Gerhold <stephan@gerhold.net>,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	lakml <linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL] Qualcomm ARM64 DT updates for 5.5
Date: Tue, 10 Dec 2019 10:17:25 -0800	[thread overview]
Message-ID: <20191210181725.GD314059@yoga> (raw)
In-Reply-To: <CAHLCerPs8+Fp1N-x7cQ2ETQ8d+fHN5b08V-jVFyFdQLYDndoBA@mail.gmail.com>

On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote:

> On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> >
> > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote:
> > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote:
> > > > (Removing arm-soc)
> > > >
> > > > Hi Andy,
> > > >
> > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote:
> > > > >
> > > > > Arnd, Olof, and Kevin,
> > > > >
> > > > > I have one slight faux paux in this pull request.  A drivers: soc change got
> > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix
> > > > > without messing up a lot of people who depend on the SHAs not changing.  So I'm
> > > > > sorry for this inclusion.  I'll scrub this better next time.
> > > > >
> > > > > Andy
> > > >
> > > > > ----------------------------------------------------------------
> > > > > Amit Kucheria (5):
> > > > >       arm64: dts: qcs404: thermal: Add interrupt support
> > > > >       arm64: dts: msm8998: thermal: Add interrupt support
> > > > >       arm64: dts: msm8996: thermal: Add interrupt support
> > > > >       arm64: dts: sdm845: thermal: Add interrupt support
> > > > >       arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors
> > > >
> > > > One of my patches to add interrupt support to msm8916 tsens is missing
> > > > here. Specifically this one:
> > > > https://patchwork.kernel.org/patch/11201853/
> > > >
> > > > Will there be a second PR this cycle?
> > >
> > > I can work up another and throw it on top.
> > >
> >
> > FYI, the patch seems to be still missing in 5.5-rc1.
> > tsens now fails to probe on MSM8916 with:
> >
> >   qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found
> >
> > Can you queue up the patch as fix for 5.5?
> 
> Indeed. Andy/Bjorn, let me know if you need anything from me to get
> this into -rc2.
> 

I'm pulling in some fixes for a rc-pull, so I could add it there.

But why are we breaking backwards compatibility with existing dtbs to
add a new (optional) feature? Shouldn't there be a rc-fix in the driver
for this regression?

Regards,
Bjorn

WARNING: multiple messages have this Message-ID
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Andy Gross <agross@kernel.org>,
	lakml <linux-arm-kernel@lists.infradead.org>,
	Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [GIT PULL] Qualcomm ARM64 DT updates for 5.5
Date: Tue, 10 Dec 2019 10:17:25 -0800	[thread overview]
Message-ID: <20191210181725.GD314059@yoga> (raw)
In-Reply-To: <CAHLCerPs8+Fp1N-x7cQ2ETQ8d+fHN5b08V-jVFyFdQLYDndoBA@mail.gmail.com>

On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote:

> On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> >
> > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote:
> > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote:
> > > > (Removing arm-soc)
> > > >
> > > > Hi Andy,
> > > >
> > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote:
> > > > >
> > > > > Arnd, Olof, and Kevin,
> > > > >
> > > > > I have one slight faux paux in this pull request.  A drivers: soc change got
> > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix
> > > > > without messing up a lot of people who depend on the SHAs not changing.  So I'm
> > > > > sorry for this inclusion.  I'll scrub this better next time.
> > > > >
> > > > > Andy
> > > >
> > > > > ----------------------------------------------------------------
> > > > > Amit Kucheria (5):
> > > > >       arm64: dts: qcs404: thermal: Add interrupt support
> > > > >       arm64: dts: msm8998: thermal: Add interrupt support
> > > > >       arm64: dts: msm8996: thermal: Add interrupt support
> > > > >       arm64: dts: sdm845: thermal: Add interrupt support
> > > > >       arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors
> > > >
> > > > One of my patches to add interrupt support to msm8916 tsens is missing
> > > > here. Specifically this one:
> > > > https://patchwork.kernel.org/patch/11201853/
> > > >
> > > > Will there be a second PR this cycle?
> > >
> > > I can work up another and throw it on top.
> > >
> >
> > FYI, the patch seems to be still missing in 5.5-rc1.
> > tsens now fails to probe on MSM8916 with:
> >
> >   qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found
> >
> > Can you queue up the patch as fix for 5.5?
> 
> Indeed. Andy/Bjorn, let me know if you need anything from me to get
> this into -rc2.
> 

I'm pulling in some fixes for a rc-pull, so I could add it there.

But why are we breaking backwards compatibility with existing dtbs to
add a new (optional) feature? Shouldn't there be a rc-fix in the driver
for this regression?

Regards,
Bjorn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-10 18:17 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 19:33 [GIT PULL] Qualcomm ARM64 Defconfig updates for 5.5 Andy Gross
2019-11-06 19:33 ` Andy Gross
2019-11-06 19:33 ` [GIT PULL] Qualcomm ARM64 DT " Andy Gross
2019-11-06 19:33   ` Andy Gross
2019-11-07 14:06   ` Amit Kucheria
2019-11-07 14:06     ` Amit Kucheria
2019-11-08  3:18     ` Andy Gross
2019-11-08  3:18       ` Andy Gross
2019-12-10 10:57       ` Stephan Gerhold
2019-12-10 10:57         ` Stephan Gerhold
2019-12-10 17:36         ` Amit Kucheria
2019-12-10 17:36           ` Amit Kucheria
2019-12-10 18:17           ` Bjorn Andersson [this message]
2019-12-10 18:17             ` Bjorn Andersson
2019-12-10 21:00             ` Olof Johansson
2019-12-10 21:00               ` Olof Johansson
2019-12-11  6:26               ` Bjorn Andersson
2019-12-11  6:26                 ` Bjorn Andersson
2019-12-11 10:00               ` Amit Kucheria
2019-12-11 10:00                 ` Amit Kucheria
2019-11-06 19:33 ` [GIT PULL] Qualcomm Defconfig " Andy Gross
2019-11-06 19:33   ` Andy Gross
2019-11-06 19:33 ` [GIT PULL] Qualcomm Driver " Andy Gross
2019-11-06 19:33   ` Andy Gross
2019-11-06 19:34 ` [GIT PULL] Qualcomm Device Tree " Andy Gross
2019-11-06 19:34   ` Andy Gross
2019-11-06 22:04 ` [GIT PULL] Qualcomm ARM64 Defconfig " Olof Johansson
2019-11-06 22:04   ` Olof Johansson
2019-11-06 23:18   ` Bjorn Andersson
2019-11-06 23:18     ` Bjorn Andersson
2019-12-06  5:02   ` Bjorn Andersson
2019-12-06  5:02     ` Bjorn Andersson
2019-12-06 16:32     ` Olof Johansson
2019-12-06 16:32       ` Olof Johansson
2019-12-06 17:28       ` Bjorn Andersson
2019-12-06 17:28         ` Bjorn Andersson
2019-12-06 17:57         ` Amit Kucheria
2019-12-06 17:57           ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210181725.GD314059@yoga \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@verdurent.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.