All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
	netdev@vger.kernel.org,
	Denis Odintsov <d.odintsov@traviangames.com>,
	Hubert Feurstein <h.feurstein@gmail.com>
Subject: Re: [BUG] mv88e6xxx: tx regression in v5.3
Date: Wed, 11 Dec 2019 18:49:38 +0100	[thread overview]
Message-ID: <20191211174938.GB30053@lunn.ch> (raw)
In-Reply-To: <87fthqu6y6.fsf@tarshish>

> Bisect points at 7fb5a711545d ("net: dsa: mv88e6xxx: drop adjust_link to
> enabled phylink"). Reverting this commit on top of v5.3.15 fixes the
> issue (and brings the warning back). As I understand, this basically
> reverts the driver migration to phylink. What might be the issue with
> phylink?

That suggests the MAC is wrongly running at 1G, and the PHY at 100M,
which is why it does not work.

You probably want to add #define DEBUG to the top of phylink.c, and
scatter some debug prints in mv88e6xxx_mac_config(). My guess would
be, either mv88e6xxx_mac_config() is existing before configuring the
MAC, or mv88e6xxx_port_setup_mac() has wrongly decided nothing has
changed and so has not configured the MAC.

	Andrew

  reply	other threads:[~2019-12-11 17:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  9:48 [BUG] mv88e6xxx: tx regression in v5.3 Baruch Siach
2019-12-11 13:11 ` Andrew Lunn
2019-12-11 17:07   ` Baruch Siach
2019-12-11 17:49     ` Andrew Lunn [this message]
2019-12-12  8:50       ` Baruch Siach
2019-12-12 13:14         ` Andrew Lunn
2019-12-12 14:19           ` Andreas Tobler
2019-12-12 15:08           ` Baruch Siach
2019-12-12 15:13             ` Andrew Lunn
2019-12-12 15:23               ` Baruch Siach
2019-12-12 18:17                 ` Baruch Siach
2019-12-12 18:32                   ` Marek Behun
2019-12-12 18:48                     ` Baruch Siach
2019-12-12 18:36                 ` Marek Behun
2019-12-12 19:06                   ` Baruch Siach
2019-12-12 19:31                     ` Andrew Lunn
2019-12-12 19:41                       ` Marek Behun
2019-12-12 20:49                         ` Andrew Lunn
2019-12-15 10:13                         ` Baruch Siach
2019-12-15 11:10                           ` Baruch Siach
2019-12-15 14:53                             ` Andrew Lunn
2019-12-15 15:08                               ` Baruch Siach
2019-12-15 16:14                                 ` Andrew Lunn
2019-12-17 18:26                                   ` Baruch Siach
2019-12-18 14:30                           ` Marek Behún
2019-12-18 16:04                             ` Baruch Siach
2019-12-19  9:04                             ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211174938.GB30053@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=baruch@tkos.co.il \
    --cc=d.odintsov@traviangames.com \
    --cc=h.feurstein@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.