[PATCH 0/1] tests/Makefile: Show check-report.tap in check-help

[PATCH 0/1] tests/Makefile: Show check-report.tap in check-help

[Wainer dos Santos Moschetta]

Simple fix to commit 9df43317b82 that didn't adjust check-help.

Wainer dos Santos Moschetta (1):
  tests/Makefile: Fix check-report.* targets shown in check-help

 tests/Makefile.include | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.21.0

[PATCH 1/1] tests/Makefile: Fix check-report.* targets shown in check-help

[Wainer dos Santos Moschetta]

The check-report.html and check-report.xml targets were replaced
with check-report.tap in commit 9df43317b82 but the check-help
text was not updated so it still lists check-report.html.

Fixes: 9df43317b82
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 tests/Makefile.include | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 8566f5f119..680bd8a669 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -16,12 +16,10 @@ check-help:
 	@echo " $(MAKE) check-softfloat      Run FPU emulation tests"
 	@echo " $(MAKE) check-acceptance     Run all acceptance (functional) tests"
 	@echo
-	@echo " $(MAKE) check-report.html    Generates an HTML test report"
+	@echo " $(MAKE) check-report.tap     Generates an aggregated TAP test report"
 	@echo " $(MAKE) check-venv           Creates a Python venv for tests"
 	@echo " $(MAKE) check-clean          Clean the tests and related data"
 	@echo
-	@echo "Please note that HTML reports do not regenerate if the unit tests"
-	@echo "have not changed."
 	@echo
 	@echo "The variable SPEED can be set to control the gtester speed setting."
 	@echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
-- 
2.21.0

Re: [PATCH 1/1] tests/Makefile: Fix check-report.* targets shown in check-help

[Paolo Bonzini]

On 11/12/19 21:44, Wainer dos Santos Moschetta wrote:
> The check-report.html and check-report.xml targets were replaced
> with check-report.tap in commit 9df43317b82 but the check-help
> text was not updated so it still lists check-report.html.
> 
> Fixes: 9df43317b82
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
>  tests/Makefile.include | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 8566f5f119..680bd8a669 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -16,12 +16,10 @@ check-help:
>  	@echo " $(MAKE) check-softfloat      Run FPU emulation tests"
>  	@echo " $(MAKE) check-acceptance     Run all acceptance (functional) tests"
>  	@echo
> -	@echo " $(MAKE) check-report.html    Generates an HTML test report"
> +	@echo " $(MAKE) check-report.tap     Generates an aggregated TAP test report"
>  	@echo " $(MAKE) check-venv           Creates a Python venv for tests"
>  	@echo " $(MAKE) check-clean          Clean the tests and related data"
>  	@echo
> -	@echo "Please note that HTML reports do not regenerate if the unit tests"
> -	@echo "have not changed."
>  	@echo
>  	@echo "The variable SPEED can be set to control the gtester speed setting."
>  	@echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
> 

Cc: qemu-trivial@nongnu.org

Re: [PATCH 1/1] tests/Makefile: Fix check-report.* targets shown in check-help

[Thomas Huth]

On 11/12/2019 21.44, Wainer dos Santos Moschetta wrote:
> The check-report.html and check-report.xml targets were replaced
> with check-report.tap in commit 9df43317b82 but the check-help
> text was not updated so it still lists check-report.html.
> 
> Fixes: 9df43317b82
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
>  tests/Makefile.include | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 8566f5f119..680bd8a669 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -16,12 +16,10 @@ check-help:
>  	@echo " $(MAKE) check-softfloat      Run FPU emulation tests"
>  	@echo " $(MAKE) check-acceptance     Run all acceptance (functional) tests"
>  	@echo
> -	@echo " $(MAKE) check-report.html    Generates an HTML test report"
> +	@echo " $(MAKE) check-report.tap     Generates an aggregated TAP test report"
>  	@echo " $(MAKE) check-venv           Creates a Python venv for tests"
>  	@echo " $(MAKE) check-clean          Clean the tests and related data"
>  	@echo
> -	@echo "Please note that HTML reports do not regenerate if the unit tests"
> -	@echo "have not changed."
>  	@echo
>  	@echo "The variable SPEED can be set to control the gtester speed setting."
>  	@echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>