All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: dwc3: pci: add ID for the Intel Comet Lake -H variant
@ 2019-12-12  9:37 Heikki Krogerus
  2019-12-12 11:16 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Heikki Krogerus @ 2019-12-12  9:37 UTC (permalink / raw)
  To: Felipe Balbi; +Cc: Greg Kroah-Hartman, linux-usb

The original ID that was added for Comet Lake PCH was
actually for the -LP (low power) variant even though the
constant for it said CMLH. Changing that while at it.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/usb/dwc3/dwc3-pci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 023f0357efd7..294276f7deb9 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -29,7 +29,8 @@
 #define PCI_DEVICE_ID_INTEL_BXT_M		0x1aaa
 #define PCI_DEVICE_ID_INTEL_APL			0x5aaa
 #define PCI_DEVICE_ID_INTEL_KBP			0xa2b0
-#define PCI_DEVICE_ID_INTEL_CMLH		0x02ee
+#define PCI_DEVICE_ID_INTEL_CMLLP		0x02ee
+#define PCI_DEVICE_ID_INTEL_CMLH		0x06ee
 #define PCI_DEVICE_ID_INTEL_GLK			0x31aa
 #define PCI_DEVICE_ID_INTEL_CNPLP		0x9dee
 #define PCI_DEVICE_ID_INTEL_CNPH		0xa36e
@@ -308,6 +309,9 @@ static const struct pci_device_id dwc3_pci_id_table[] = {
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_MRFLD),
 	  (kernel_ulong_t) &dwc3_pci_mrfld_properties, },
 
+	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_CMLLP),
+	  (kernel_ulong_t) &dwc3_pci_intel_properties, },
+
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_CMLH),
 	  (kernel_ulong_t) &dwc3_pci_intel_properties, },
 
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: dwc3: pci: add ID for the Intel Comet Lake -H variant
  2019-12-12  9:37 [PATCH] usb: dwc3: pci: add ID for the Intel Comet Lake -H variant Heikki Krogerus
@ 2019-12-12 11:16 ` Greg Kroah-Hartman
  2019-12-12 12:27   ` Felipe Balbi
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-12 11:16 UTC (permalink / raw)
  To: Heikki Krogerus; +Cc: Felipe Balbi, linux-usb

On Thu, Dec 12, 2019 at 12:37:13PM +0300, Heikki Krogerus wrote:
> The original ID that was added for Comet Lake PCH was
> actually for the -LP (low power) variant even though the
> constant for it said CMLH. Changing that while at it.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  drivers/usb/dwc3/dwc3-pci.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Felipe, any objection for me just taking this to my tree now?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: dwc3: pci: add ID for the Intel Comet Lake -H variant
  2019-12-12 11:16 ` Greg Kroah-Hartman
@ 2019-12-12 12:27   ` Felipe Balbi
  0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2019-12-12 12:27 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Heikki Krogerus; +Cc: linux-usb

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]


Hi,

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Thu, Dec 12, 2019 at 12:37:13PM +0300, Heikki Krogerus wrote:
>> The original ID that was added for Comet Lake PCH was
>> actually for the -LP (low power) variant even though the
>> constant for it said CMLH. Changing that while at it.
>> 
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> ---
>>  drivers/usb/dwc3/dwc3-pci.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> Felipe, any objection for me just taking this to my tree now?

none whatsoever :-)

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-12 12:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12  9:37 [PATCH] usb: dwc3: pci: add ID for the Intel Comet Lake -H variant Heikki Krogerus
2019-12-12 11:16 ` Greg Kroah-Hartman
2019-12-12 12:27   ` Felipe Balbi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.