From: Maxime Ripard <maxime@cerno.tech> To: Kevin Tang <kevin3.tang@gmail.com> Cc: airlied@linux.ie, daniel@ffwll.ch, orsonzhai@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhang.lyra@gmail.com, baolin.wang@linaro.org Subject: Re: [PATCH RFC 3/8] dt-bindings: display: add Unisoc's dpu bindings Date: Fri, 13 Dec 2019 10:44:09 +0100 [thread overview] Message-ID: <20191213094409.lvvhwtxl4vlkvi6b@gilmour.lan> (raw) In-Reply-To: <1575966995-13757-4-git-send-email-kevin3.tang@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2025 bytes --] Hi, On Tue, Dec 10, 2019 at 04:36:30PM +0800, Kevin Tang wrote: > From: Kevin Tang <kevin.tang@unisoc.com> > > DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs > which transfers the image data from a video memory buffer to an internal > LCD interface. > > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com> > --- > .../devicetree/bindings/display/sprd/dpu.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/dpu.txt > > diff --git a/Documentation/devicetree/bindings/display/sprd/dpu.txt b/Documentation/devicetree/bindings/display/sprd/dpu.txt > new file mode 100644 > index 0000000..25cbf8e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/dpu.txt > @@ -0,0 +1,55 @@ > +Unisoc SoC Display Processor Unit (DPU) > +============================================================================ > + > +DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs > +which transfers the image data from a video memory buffer to an internal > +LCD interface. > + > +Required properties: > + - compatible: value should be "sprd,display-processor"; > + - reg: physical base address and length of the DPU registers set. > + - interrupts: the interrupt signal from DPU. > + - clocks: must include clock specifiers corresponding to entries in the > + clock-names property. > + - clock-names: list of clock names sorted in the same order as the clocks > + property. Same story, this should be a YAML schemas, but here you should describe what the expected clock-names are, and what clock they represent. > + - dma-coherent: with this property, the dpu driver can allocate large and > + continuous memorys. > + - port: a port node with endpoint definitions as defined in document [1]. So only one? Connected to what? Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Kevin Tang <kevin3.tang@gmail.com> Cc: baolin.wang@linaro.org, airlied@linux.ie, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, orsonzhai@gmail.com Subject: Re: [PATCH RFC 3/8] dt-bindings: display: add Unisoc's dpu bindings Date: Fri, 13 Dec 2019 10:44:09 +0100 [thread overview] Message-ID: <20191213094409.lvvhwtxl4vlkvi6b@gilmour.lan> (raw) In-Reply-To: <1575966995-13757-4-git-send-email-kevin3.tang@gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 2025 bytes --] Hi, On Tue, Dec 10, 2019 at 04:36:30PM +0800, Kevin Tang wrote: > From: Kevin Tang <kevin.tang@unisoc.com> > > DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs > which transfers the image data from a video memory buffer to an internal > LCD interface. > > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com> > --- > .../devicetree/bindings/display/sprd/dpu.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/dpu.txt > > diff --git a/Documentation/devicetree/bindings/display/sprd/dpu.txt b/Documentation/devicetree/bindings/display/sprd/dpu.txt > new file mode 100644 > index 0000000..25cbf8e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/dpu.txt > @@ -0,0 +1,55 @@ > +Unisoc SoC Display Processor Unit (DPU) > +============================================================================ > + > +DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs > +which transfers the image data from a video memory buffer to an internal > +LCD interface. > + > +Required properties: > + - compatible: value should be "sprd,display-processor"; > + - reg: physical base address and length of the DPU registers set. > + - interrupts: the interrupt signal from DPU. > + - clocks: must include clock specifiers corresponding to entries in the > + clock-names property. > + - clock-names: list of clock names sorted in the same order as the clocks > + property. Same story, this should be a YAML schemas, but here you should describe what the expected clock-names are, and what clock they represent. > + - dma-coherent: with this property, the dpu driver can allocate large and > + continuous memorys. > + - port: a port node with endpoint definitions as defined in document [1]. So only one? Connected to what? Maxime [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-13 9:44 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-10 8:36 [PATCH RFC 0/8] Add Unisoc's drm kms module Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-10 8:36 ` [PATCH RFC 1/8] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-13 9:42 ` Maxime Ripard 2019-12-13 9:42 ` Maxime Ripard 2019-12-10 8:36 ` [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-10 10:32 ` Thomas Zimmermann 2019-12-10 10:32 ` Thomas Zimmermann 2019-12-10 12:38 ` tang pengchuan 2019-12-10 12:47 ` Thomas Zimmermann 2019-12-10 12:47 ` Thomas Zimmermann 2019-12-10 13:42 ` tang pengchuan 2019-12-11 3:00 ` tang pengchuan 2019-12-10 10:41 ` Daniel Vetter 2019-12-10 10:41 ` Daniel Vetter 2019-12-10 11:40 ` tang pengchuan 2019-12-10 16:06 ` Emil Velikov 2019-12-10 16:06 ` Emil Velikov 2019-12-10 22:01 ` Daniel Vetter 2019-12-10 22:01 ` Daniel Vetter 2019-12-10 8:36 ` [PATCH RFC 3/8] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-13 9:44 ` Maxime Ripard [this message] 2019-12-13 9:44 ` Maxime Ripard 2019-12-10 8:36 ` [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-10 10:44 ` Thomas Zimmermann 2019-12-10 10:44 ` Thomas Zimmermann 2019-12-10 11:29 ` tang pengchuan 2019-12-10 11:32 ` tang pengchuan 2019-12-10 17:13 ` Emil Velikov 2019-12-10 17:13 ` Emil Velikov 2019-12-11 1:18 ` tang pengchuan 2019-12-11 11:46 ` Emil Velikov 2019-12-11 11:46 ` Emil Velikov 2019-12-10 8:36 ` [PATCH RFC 5/8] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-13 9:46 ` Maxime Ripard 2019-12-13 9:46 ` Maxime Ripard 2019-12-10 8:36 ` [PATCH RFC 6/8] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-10 8:36 ` [PATCH RFC 7/8] dt-bindings: display: add Unisoc's generic mipi panel bindings Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-13 9:48 ` Maxime Ripard 2019-12-13 9:48 ` Maxime Ripard 2019-12-10 8:36 ` [PATCH RFC 8/8] drm/sprd: add Unisoc's drm generic mipi panel driver Kevin Tang 2019-12-10 8:36 ` Kevin Tang 2019-12-10 18:54 ` [PATCH RFC 0/8] Add Unisoc's drm kms module Sam Ravnborg 2019-12-10 18:54 ` Sam Ravnborg 2019-12-12 14:29 ` tang pengchuan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191213094409.lvvhwtxl4vlkvi6b@gilmour.lan \ --to=maxime@cerno.tech \ --cc=airlied@linux.ie \ --cc=baolin.wang@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kevin3.tang@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=orsonzhai@gmail.com \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.