* [PATCH liburing] spec: additional Fedora RPM cleanups
@ 2019-12-13 10:16 Stefan Hajnoczi
2019-12-13 15:59 ` Jeff Moyer
2019-12-18 4:13 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-12-13 10:16 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, Jeff Moyer, Stefan Hajnoczi
Cole Robinson made some more suggestions:
* Use %set_build_flags before ./configure to get the default compiler
flags.
* Use '%license COPYING' instead of %doc.
* Do not ship the static library. This is distro policy and Fedora
would ship a separate -static package if static libraries are
desired.
* Source: should be the URL to the sources. URL: should be the URL of
the website or git repo.
* The devel package needs
Requires: %{name}%{?_isa} = %{version}-%{release}
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
liburing.spec | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/liburing.spec b/liburing.spec
index e542771..87b16b1 100644
--- a/liburing.spec
+++ b/liburing.spec
@@ -3,8 +3,8 @@ Version: 0.2
Release: 1%{?dist}
Summary: Linux-native io_uring I/O access library
License: LGPLv2+
-Source: %{name}-%{version}.tar.gz
-URL: https://git.kernel.dk/cgit/liburing/snapshot/%{name}-%{version}.tar.gz
+Source: https://git.kernel.dk/cgit/liburing/snapshot/%{name}-%{version}.tar.gz
+URL: https://git.kernel.dk/cgit/liburing/
BuildRequires: gcc
%description
@@ -13,7 +13,7 @@ manner, for both buffered and O_DIRECT.
%package devel
Summary: Development files for Linux-native io_uring I/O access library
-Requires: %{name} = %{version}-%{release}
+Requires: %{name}%{_isa} = %{version}-%{release}
Requires: pkgconfig
%description devel
@@ -24,6 +24,7 @@ for the Linux-native io_uring.
%autosetup
%build
+%set_build_flags
./configure --prefix=%{_prefix} --libdir=/%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir}
%make_build
@@ -33,13 +34,13 @@ for the Linux-native io_uring.
%files
%attr(0755,root,root) %{_libdir}/liburing.so.*
-%doc COPYING
+%license COPYING
%files devel
%{_includedir}/liburing/
%{_includedir}/liburing.h
%{_libdir}/liburing.so
-%{_libdir}/liburing.a
+%exclude %{_libdir}/liburing.a
%{_libdir}/pkgconfig/*
%{_mandir}/man2/*
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH liburing] spec: additional Fedora RPM cleanups
2019-12-13 10:16 [PATCH liburing] spec: additional Fedora RPM cleanups Stefan Hajnoczi
@ 2019-12-13 15:59 ` Jeff Moyer
2019-12-18 4:13 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Moyer @ 2019-12-13 15:59 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Jens Axboe, linux-block
Stefan Hajnoczi <stefanha@redhat.com> writes:
> Cole Robinson made some more suggestions:
>
> * Use %set_build_flags before ./configure to get the default compiler
> flags.
>
> * Use '%license COPYING' instead of %doc.
>
> * Do not ship the static library. This is distro policy and Fedora
> would ship a separate -static package if static libraries are
> desired.
>
> * Source: should be the URL to the sources. URL: should be the URL of
> the website or git repo.
>
> * The devel package needs
> Requires: %{name}%{?_isa} = %{version}-%{release}
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
LGTM
Acked-by: Jeff Moyer <jmoyer@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH liburing] spec: additional Fedora RPM cleanups
2019-12-13 10:16 [PATCH liburing] spec: additional Fedora RPM cleanups Stefan Hajnoczi
2019-12-13 15:59 ` Jeff Moyer
@ 2019-12-18 4:13 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-12-18 4:13 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: linux-block, Jeff Moyer
On 12/13/19 3:16 AM, Stefan Hajnoczi wrote:
> Cole Robinson made some more suggestions:
>
> * Use %set_build_flags before ./configure to get the default compiler
> flags.
>
> * Use '%license COPYING' instead of %doc.
>
> * Do not ship the static library. This is distro policy and Fedora
> would ship a separate -static package if static libraries are
> desired.
>
> * Source: should be the URL to the sources. URL: should be the URL of
> the website or git repo.
>
> * The devel package needs
> Requires: %{name}%{?_isa} = %{version}-%{release}
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-18 4:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 10:16 [PATCH liburing] spec: additional Fedora RPM cleanups Stefan Hajnoczi
2019-12-13 15:59 ` Jeff Moyer
2019-12-18 4:13 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.