From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Boris Brezillon <boris.brezillon@collabora.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hans.verkuil@cisco.com>, Sakari Ailus <sakari.ailus@iki.fi>, linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>, Nicolas Dufresne <nicolas@ndufresne.ca>, kernel@collabora.com, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Ezequiel Garcia <ezequiel@collabora.com>, Jonas Karlman <jonas@kwiboo.se>, linux-rockchip@lists.infradead.org, Heiko Stuebner <heiko@sntech.de> Subject: Re: [PATCH v3 5/7] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Date: Fri, 13 Dec 2019 17:23:32 +0200 [thread overview] Message-ID: <20191213152332.GF4860@pendragon.ideasonboard.com> (raw) In-Reply-To: <20191213125414.90725-6-boris.brezillon@collabora.com> Hi Boris, Thank you for the patch. On Fri, Dec 13, 2019 at 01:54:12PM +0100, Boris Brezillon wrote: > Document the Rockchip RK3399 Video Decoder bindings. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > Changes in v3: > * Fix dtbs_check failures > --- > .../bindings/media/rockchip,vdec.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > new file mode 100644 > index 000000000000..7167c3d6a389 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip,vdec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip Video Decoder (VDec) Device Tree Bindings > + > +maintainers: > + - Heiko Stuebner <heiko@sntech.de> > + > +description: |- > + The Rockchip rk3399 has a stateless Video Decoder that can decodes H.264, > + HEVC an VP9 streams. > + > +properties: > + compatible: > + const: rockchip,rk3399-vdec > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: The Video Decoder AXI interface clock > + - description: The Video Decoder AHB interface clock > + - description: The Video Decoded CABAC clock > + - description: The Video Decoder core clock > + > + clock-names: > + items: > + - const: aclk How about calling it "axi" ? None of the other clock names have "clk". > + - const: iface And "ahb" here, as the AXI interface clock is also an interface clock ? > + - const: cabac > + - const: core > + > + power-domains: > + maxItems: 1 > + > + iommus: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + vdec: video-codec@ff660000 { > + compatible = "rockchip,rk3399-vdec"; > + reg = <0x0 0xff660000 0x0 0x400>; > + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&cru ACLK_VDU>, <&cru HCLK_VDU>, > + <&cru SCLK_VDU_CA>, <&cru SCLK_VDU_CORE>; > + clock-names = "aclk", "iface", "cabac", "core"; > + power-domains = <&power RK3399_PD_VDU>; > + iommus = <&vdec_mmu>; > + }; > + > +... -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> To: Boris Brezillon <boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>, Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>, Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org>, Nicolas Dufresne <nicolas-dDhyB4GVkw9AFePFGvp55w@public.gmane.org>, Hans Verkuil <hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>, Mauro Carvalho Chehab <mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Ezequiel Garcia <ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v3 5/7] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Date: Fri, 13 Dec 2019 17:23:32 +0200 [thread overview] Message-ID: <20191213152332.GF4860@pendragon.ideasonboard.com> (raw) In-Reply-To: <20191213125414.90725-6-boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Hi Boris, Thank you for the patch. On Fri, Dec 13, 2019 at 01:54:12PM +0100, Boris Brezillon wrote: > Document the Rockchip RK3399 Video Decoder bindings. > > Signed-off-by: Boris Brezillon <boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> > --- > Changes in v3: > * Fix dtbs_check failures > --- > .../bindings/media/rockchip,vdec.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > new file mode 100644 > index 000000000000..7167c3d6a389 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip,vdec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip Video Decoder (VDec) Device Tree Bindings > + > +maintainers: > + - Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> > + > +description: |- > + The Rockchip rk3399 has a stateless Video Decoder that can decodes H.264, > + HEVC an VP9 streams. > + > +properties: > + compatible: > + const: rockchip,rk3399-vdec > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: The Video Decoder AXI interface clock > + - description: The Video Decoder AHB interface clock > + - description: The Video Decoded CABAC clock > + - description: The Video Decoder core clock > + > + clock-names: > + items: > + - const: aclk How about calling it "axi" ? None of the other clock names have "clk". > + - const: iface And "ahb" here, as the AXI interface clock is also an interface clock ? > + - const: cabac > + - const: core > + > + power-domains: > + maxItems: 1 > + > + iommus: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + vdec: video-codec@ff660000 { > + compatible = "rockchip,rk3399-vdec"; > + reg = <0x0 0xff660000 0x0 0x400>; > + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&cru ACLK_VDU>, <&cru HCLK_VDU>, > + <&cru SCLK_VDU_CA>, <&cru SCLK_VDU_CORE>; > + clock-names = "aclk", "iface", "cabac", "core"; > + power-domains = <&power RK3399_PD_VDU>; > + iommus = <&vdec_mmu>; > + }; > + > +... -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2019-12-13 20:38 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-13 12:54 [PATCH v3 0/7] media: rockchip: Add the rkvdec driver Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon 2019-12-13 12:54 ` [PATCH v3 1/7] media: vb2: Add a helper to get the vb2 buffer attached to a request Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon 2019-12-13 15:09 ` Laurent Pinchart 2019-12-13 15:09 ` Laurent Pinchart 2019-12-13 15:21 ` Boris Brezillon 2019-12-13 15:21 ` Boris Brezillon 2019-12-13 12:54 ` [PATCH v3 2/7] media: uapi: h264: Add DPB entry field reference flags Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon 2019-12-13 12:54 ` [PATCH v3 3/7] media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon 2019-12-13 12:54 ` [PATCH v3 4/7] media: hantro: h264: Use the generic H264 reflist builder Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon 2019-12-14 15:46 ` Hugh Cole-Baker 2019-12-14 15:46 ` Hugh Cole-Baker 2019-12-16 8:54 ` Boris Brezillon 2019-12-16 8:54 ` Boris Brezillon 2019-12-13 12:54 ` [PATCH v3 5/7] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon 2019-12-13 15:23 ` Laurent Pinchart [this message] 2019-12-13 15:23 ` Laurent Pinchart 2019-12-13 15:25 ` Boris Brezillon 2019-12-13 15:25 ` Boris Brezillon 2019-12-14 2:32 ` Chen-Yu Tsai 2019-12-14 2:32 ` Chen-Yu Tsai 2019-12-18 22:03 ` Rob Herring 2019-12-18 22:03 ` Rob Herring 2019-12-13 12:54 ` [PATCH v3 6/7] media: rkvdec: Add the rkvdec driver Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon 2019-12-13 14:21 ` Hans Verkuil 2019-12-13 14:21 ` Hans Verkuil 2019-12-13 15:05 ` Boris Brezillon 2019-12-13 15:05 ` Boris Brezillon 2020-01-06 7:52 ` Boris Brezillon 2020-01-06 7:52 ` Boris Brezillon 2019-12-13 12:54 ` [PATCH v3 7/7] arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node Boris Brezillon 2019-12-13 12:54 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191213152332.GF4860@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=boris.brezillon@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=ezequiel@collabora.com \ --cc=hans.verkuil@cisco.com \ --cc=heiko@sntech.de \ --cc=jonas@kwiboo.se \ --cc=kernel@collabora.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=nicolas@ndufresne.ca \ --cc=paul.kocialkowski@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@iki.fi \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.