All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Engraf <david.engraf@sysgo.com>
Cc: richard.genoud@gmail.com, jslaby@suse.com,
	nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
	ludovic.desroches@microchip.com, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider handling
Date: Fri, 13 Dec 2019 17:07:26 +0100	[thread overview]
Message-ID: <20191213160726.GB2632926@kroah.com> (raw)
In-Reply-To: <20191213140301.16490-1-david.engraf@sysgo.com>

On Fri, Dec 13, 2019 at 03:03:01PM +0100, David Engraf wrote:
> Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode
> register was already written thus the clock selection is ignored.
> 
> Fix by doing the baud rate calulation before setting the mode.
> 
> Fixes: 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support")
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 43 ++++++++++++++++---------------
>  1 file changed, 22 insertions(+), 21 deletions(-)

What changed from v1?

Always put that below the --- line.

v3 please?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: David Engraf <david.engraf@sysgo.com>
Cc: alexandre.belloni@bootlin.com, richard.genoud@gmail.com,
	linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com,
	linux-serial@vger.kernel.org, jslaby@suse.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider handling
Date: Fri, 13 Dec 2019 17:07:26 +0100	[thread overview]
Message-ID: <20191213160726.GB2632926@kroah.com> (raw)
In-Reply-To: <20191213140301.16490-1-david.engraf@sysgo.com>

On Fri, Dec 13, 2019 at 03:03:01PM +0100, David Engraf wrote:
> Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode
> register was already written thus the clock selection is ignored.
> 
> Fix by doing the baud rate calulation before setting the mode.
> 
> Fixes: 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support")
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 43 ++++++++++++++++---------------
>  1 file changed, 22 insertions(+), 21 deletions(-)

What changed from v1?

Always put that below the --- line.

v3 please?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-13 21:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 16:29 [PATCH] tty/serial: atmel: fix out of range clock divider handling David Engraf
2019-12-11 16:29 ` David Engraf
2019-12-13  9:57 ` Richard Genoud
2019-12-13  9:57   ` Richard Genoud
2019-12-13 13:49   ` David Engraf
2019-12-13 13:49     ` David Engraf
2019-12-13 14:03     ` [PATCH v2] " David Engraf
2019-12-13 14:03       ` David Engraf
2019-12-13 16:07       ` Greg KH [this message]
2019-12-13 16:07         ` Greg KH
2019-12-16  8:34         ` David Engraf
2019-12-16  8:34           ` David Engraf
2019-12-16  8:54           ` [PATCH v3] " David Engraf
2019-12-16  8:54             ` David Engraf
2019-12-16 10:03             ` Richard Genoud
2019-12-16 10:03               ` Richard Genoud
2019-12-16 10:26             ` Ludovic Desroches
2019-12-16 10:26               ` Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191213160726.GB2632926@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=david.engraf@sysgo.com \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=richard.genoud@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.