* [PATCH] ARM: dts: sh73a0: Add missing clock-frequency for fixed clocks
@ 2019-12-13 16:27 Geert Uytterhoeven
2019-12-13 16:27 ` [PATCH] ARM: dts: r8a7778: " Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-13 16:27 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc, devicetree, Geert Uytterhoeven
"clock-frequency" is a required property for devices nodes compatible
with "fixed-clock", leading to warnings when running
$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/fixed-clock.yaml
arch/arm/boot/dts/sh73a0-kzm9g.dt.yaml: extcki: 'clock-frequency' is a required property
Fix this by adding the missing "clock-frequency" properties to the various
clocks, to be overridden by the board DTS files when populated.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/sh73a0.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sh73a0.dtsi b/arch/arm/boot/dts/sh73a0.dtsi
index 7efe33c4d041a524..7c67581f57422a26 100644
--- a/arch/arm/boot/dts/sh73a0.dtsi
+++ b/arch/arm/boot/dts/sh73a0.dtsi
@@ -624,19 +624,25 @@
extal2_clk: extal2 {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value must be overridden by the board. */
+ clock-frequency = <0>;
};
extcki_clk: extcki {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value can be overridden by the board. */
+ clock-frequency = <0>;
};
fsiack_clk: fsiack {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value can be overridden by the board. */
clock-frequency = <0>;
};
fsibck_clk: fsibck {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value can be overridden by the board. */
clock-frequency = <0>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: r8a7778: Add missing clock-frequency for fixed clocks
@ 2019-12-13 16:27 ` Geert Uytterhoeven
2019-12-13 16:26 ` [PATCH] ARM: dts: rcar-gen2: Add missing mmio-sram bus properties Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-13 16:27 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc, devicetree, Geert Uytterhoeven
"clock-frequency" is a required property for devices nodes compatible
with "fixed-clock", leading to warnings when running
$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/fixed-clock.yaml
arch/arm/boot/dts/r8a7778-bockw.dt.yaml: audio_clk_a: 'clock-frequency' is a required property
arch/arm/boot/dts/r8a7778-bockw.dt.yaml: audio_clk_b: 'clock-frequency' is a required property
arch/arm/boot/dts/r8a7778-bockw.dt.yaml: audio_clk_c: 'clock-frequency' is a required property
Fix this by adding the missing "clock-frequency" properties to the audio
clocks, to be overridden by board DTS files when populated.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7778.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
index 10d996d2941fe6ea..5628b8a3598f43c1 100644
--- a/arch/arm/boot/dts/r8a7778.dtsi
+++ b/arch/arm/boot/dts/r8a7778.dtsi
@@ -498,14 +498,17 @@
audio_clk_a: audio_clk_a {
compatible = "fixed-clock";
#clock-cells = <0>;
+ clock-frequency = <0>;
};
audio_clk_b: audio_clk_b {
compatible = "fixed-clock";
#clock-cells = <0>;
+ clock-frequency = <0>;
};
audio_clk_c: audio_clk_c {
compatible = "fixed-clock";
#clock-cells = <0>;
+ clock-frequency = <0>;
};
/* Fixed ratio clocks */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: rcar-gen2: Add missing mmio-sram bus properties
@ 2019-12-13 16:26 ` Geert Uytterhoeven
2019-12-31 10:00 ` Patchwork summary for: linux-renesas-soc patchwork-bot+linux-renesas-soc
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-13 16:26 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc, devicetree, Geert Uytterhoeven
"#address-cells", "#size-cells", and "ranges" are required properties
for devices nodes compatible with "mmio-sram", leading to warnings when
running "make dtbs_check":
$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sram/sram.yaml
arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: sram@e63a0000: '#address-cells' is a required property
arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: sram@e63a0000: '#size-cells' is a required property
arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: sram@e63a0000: 'ranges' is a required property
...
Fix this by adding the missing properties to the mmio-sram device nodes
in the DTS files for all affected R-Car Gen2 and RZ/G1 SoCs.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7743.dtsi | 6 ++++++
arch/arm/boot/dts/r8a7744.dtsi | 6 ++++++
arch/arm/boot/dts/r8a7745.dtsi | 6 ++++++
arch/arm/boot/dts/r8a77470.dtsi | 6 ++++++
arch/arm/boot/dts/r8a7790.dtsi | 3 +++
arch/arm/boot/dts/r8a7791.dtsi | 3 +++
arch/arm/boot/dts/r8a7792.dtsi | 3 +++
arch/arm/boot/dts/r8a7793.dtsi | 3 +++
arch/arm/boot/dts/r8a7794.dtsi | 3 +++
9 files changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 5f88d9f585988c0c..dcf09d9a1d76bb02 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -399,6 +399,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
@@ -417,6 +420,9 @@
icram2: sram@e6300000 {
compatible = "mmio-sram";
reg = <0 0xe6300000 0 0x40000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe6300000 0x40000>;
};
/* The memory map in the User's Manual maps the cores to
diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
index 446dbb5409e67aeb..357640e3693480f3 100644
--- a/arch/arm/boot/dts/r8a7744.dtsi
+++ b/arch/arm/boot/dts/r8a7744.dtsi
@@ -399,6 +399,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
@@ -417,6 +420,9 @@
icram2: sram@e6300000 {
compatible = "mmio-sram";
reg = <0 0xe6300000 0 0x40000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe6300000 0x40000>;
};
/* The memory map in the User's Manual maps the cores to
diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
index 04f1ca1828b15954..edcc74ff90865540 100644
--- a/arch/arm/boot/dts/r8a7745.dtsi
+++ b/arch/arm/boot/dts/r8a7745.dtsi
@@ -363,6 +363,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
@@ -381,6 +384,9 @@
icram2: sram@e6300000 {
compatible = "mmio-sram";
reg = <0 0xe6300000 0 0x40000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe6300000 0x40000>;
};
i2c0: i2c@e6508000 {
#address-cells = <1>;
diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 51806c7f486a3681..8b522ed4eb1ef815 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -242,6 +242,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
@@ -260,6 +263,9 @@
icram2: sram@e6300000 {
compatible = "mmio-sram";
reg = <0 0xe6300000 0 0x20000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe6300000 0x20000>;
};
i2c0: i2c@e6508000 {
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index cf7bf7d7caee1808..344519957916f473 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -487,6 +487,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index e5fa01034666616b..119e67b665392a5a 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -421,6 +421,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
diff --git a/arch/arm/boot/dts/r8a7792.dtsi b/arch/arm/boot/dts/r8a7792.dtsi
index c4ea2d6760301706..5956854e60d8d585 100644
--- a/arch/arm/boot/dts/r8a7792.dtsi
+++ b/arch/arm/boot/dts/r8a7792.dtsi
@@ -345,6 +345,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index bf05110fac4e23be..91c7c3cfe7476cbf 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -406,6 +406,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index 945b1378dc40d53a..7d4644fac3771798 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -351,6 +351,9 @@
icram0: sram@e63a0000 {
compatible = "mmio-sram";
reg = <0 0xe63a0000 0 0x12000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63a0000 0x12000>;
};
icram1: sram@e63c0000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 0/7] arm: dts: renesas: Group tuples in reg/ranges/dma-ranges/states properties
@ 2019-12-13 16:41 Geert Uytterhoeven
2019-12-13 16:41 ` [PATCH] ARM: dts: sh73a0: Add missing clock-frequency for fixed clocks Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-13 16:41 UTC (permalink / raw)
To: Magnus Damm
Cc: Rob Herring, Mark Rutland, linux-renesas-soc, devicetree,
Geert Uytterhoeven
Hi all,
To improve human readability and enable automatic validation, tuples
in various properties should be grouped. While "make dtbs_check" does
not impose this yet for all properties, it does for some, hence
triggering me to fix (I hope) all of them.
Unfortunately even after this, a few "... is too long" warnings are
still printed (e.g. for PCI "ranges"), which I believe are false
positives.
This series is against renesas-devel-2019-12-13-v5.5-rc1[*] with
"[PATCH] ARM: dts: rcar-gen2: Fix PCI high address in
interrupt-map-mask" applied on top.
Thanks for your comments!
[*] Will be pushed out when gitolite.kernel.org is back.
Geert Uytterhoeven (7):
ARM: dts: renesas: Group tuples in regulator-gpio states properties
ARM: dts: renesas: Group tuples in interrupt properties
ARM: dts: renesas: Group tuples in pci ranges and dma-ranges
properties
arm64: dts: renesas: Group tuples in regulator-gpio states properties
arm64: dts: renesas: Group tuples in interrupt properties
arm64: dts: renesas: Group tuples in pci ranges and dma-ranges
properties
arm64: dts: renesas: r8a77970: Group tuples in thermal reg property
arch/arm/boot/dts/iwg20d-q7-common.dtsi | 3 +-
arch/arm/boot/dts/r7s72100.dtsi | 18 +-
arch/arm/boot/dts/r8a73a4.dtsi | 42 ++--
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 3 +-
arch/arm/boot/dts/r8a7740.dtsi | 102 ++++-----
arch/arm/boot/dts/r8a7743.dtsi | 152 ++++++-------
arch/arm/boot/dts/r8a7744.dtsi | 152 ++++++-------
arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 3 +-
arch/arm/boot/dts/r8a7745.dtsi | 112 ++++-----
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 3 +-
arch/arm/boot/dts/r8a77470.dtsi | 80 +++----
arch/arm/boot/dts/r8a7778.dtsi | 8 +-
arch/arm/boot/dts/r8a7779-marzen.dts | 3 +-
arch/arm/boot/dts/r8a7779.dtsi | 8 +-
arch/arm/boot/dts/r8a7790-lager.dts | 6 +-
arch/arm/boot/dts/r8a7790.dtsi | 158 ++++++-------
arch/arm/boot/dts/r8a7791-koelsch.dts | 9 +-
arch/arm/boot/dts/r8a7791-porter.dts | 6 +-
arch/arm/boot/dts/r8a7791.dtsi | 152 ++++++-------
arch/arm/boot/dts/r8a7792.dtsi | 64 +++---
arch/arm/boot/dts/r8a7793-gose.dts | 9 +-
arch/arm/boot/dts/r8a7793.dtsi | 120 +++++-----
arch/arm/boot/dts/r8a7794-alt.dts | 6 +-
arch/arm/boot/dts/r8a7794-silk.dts | 3 +-
arch/arm/boot/dts/r8a7794.dtsi | 104 ++++-----
arch/arm/boot/dts/sh73a0.dtsi | 122 +++++-----
.../arm64/boot/dts/renesas/hihope-common.dtsi | 3 +-
arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 206 ++++++++---------
arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 206 ++++++++---------
.../boot/dts/renesas/r8a774c0-cat874.dts | 3 +-
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 164 +++++++-------
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 214 +++++++++---------
arch/arm64/boot/dts/renesas/r8a77960.dtsi | 206 ++++++++---------
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 206 ++++++++---------
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 52 ++---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 96 ++++----
.../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 6 +-
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 164 +++++++-------
arch/arm64/boot/dts/renesas/r8a77995.dtsi | 74 +++---
.../boot/dts/renesas/salvator-common.dtsi | 6 +-
arch/arm64/boot/dts/renesas/ulcb.dtsi | 3 +-
41 files changed, 1514 insertions(+), 1543 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: sh73a0: Add missing clock-frequency for fixed clocks
2019-12-13 16:41 [PATCH 0/7] arm: dts: renesas: Group tuples in reg/ranges/dma-ranges/states properties Geert Uytterhoeven
@ 2019-12-13 16:41 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-13 16:41 UTC (permalink / raw)
To: Magnus Damm
Cc: Rob Herring, Mark Rutland, linux-renesas-soc, devicetree,
Geert Uytterhoeven
"clock-frequency" is a required property for devices nodes compatible
with "fixed-clock", leading to warnings when running
$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/fixed-clock.yaml
arch/arm/boot/dts/sh73a0-kzm9g.dt.yaml: extcki: 'clock-frequency' is a required property
Fix this by adding the missing "clock-frequency" properties to the various
clocks, to be overridden by the board DTS files when populated.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/sh73a0.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sh73a0.dtsi b/arch/arm/boot/dts/sh73a0.dtsi
index 7efe33c4d041a524..7c67581f57422a26 100644
--- a/arch/arm/boot/dts/sh73a0.dtsi
+++ b/arch/arm/boot/dts/sh73a0.dtsi
@@ -624,19 +624,25 @@
extal2_clk: extal2 {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value must be overridden by the board. */
+ clock-frequency = <0>;
};
extcki_clk: extcki {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value can be overridden by the board. */
+ clock-frequency = <0>;
};
fsiack_clk: fsiack {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value can be overridden by the board. */
clock-frequency = <0>;
};
fsibck_clk: fsibck {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value can be overridden by the board. */
clock-frequency = <0>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-31 10:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 16:27 [PATCH] ARM: dts: sh73a0: Add missing clock-frequency for fixed clocks Geert Uytterhoeven
2019-12-13 16:27 ` [PATCH] ARM: dts: r8a7778: " Geert Uytterhoeven
2019-12-13 16:26 ` [PATCH] ARM: dts: rcar-gen2: Add missing mmio-sram bus properties Geert Uytterhoeven
2019-12-31 10:00 ` Patchwork summary for: linux-renesas-soc patchwork-bot+linux-renesas-soc
2019-12-13 16:41 [PATCH 0/7] arm: dts: renesas: Group tuples in reg/ranges/dma-ranges/states properties Geert Uytterhoeven
2019-12-13 16:41 ` [PATCH] ARM: dts: sh73a0: Add missing clock-frequency for fixed clocks Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.