All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Daniel Vetter <daniel@ffwll.ch>, Jyri Sarha <jsarha@ti.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	yamonkar@cadence.com, praneeth@ti.com, sjakhade@cadence.com,
	robh+dt@kernel.org, peter.ujfalusi@ti.com,
	laurent.pinchart@ideasonboard.com, subhajit_paul@ti.com,
	sam@ravnborg.org
Subject: Re: [PATCH v3 5/5] MAINTAINERS: add entry for tidss
Date: Fri, 13 Dec 2019 21:15:46 +0100	[thread overview]
Message-ID: <20191213201546.GN624164@phenom.ffwll.local> (raw)
In-Reply-To: <0acedebf-25d9-6ae2-1307-8f764af449af@ti.com>

On Fri, Dec 13, 2019 at 01:17:59PM +0200, Tomi Valkeinen wrote:
> Hi Daniel,
> 
> On 13/12/2019 12:30, Daniel Vetter wrote:
> 
> > > +DRM DRIVERS FOR TI KEYSTONE
> > > +M:	Jyri Sarha <jsarha@ti.com>
> > > +M:	Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > +L:	dri-devel@lists.freedesktop.org
> > > +S:	Maintained
> > > +F:	drivers/gpu/drm/tidss/
> > > +F:	Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml
> > > +F:	Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> > > +F:	Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
> > > +T:	git git://anongit.freedesktop.org/drm/drm-misc
> > 
> > Is the plan to also move other TI drivers over (like tilcdc) or just an
> > experiment to see what happens? Asking since if eventually omapdrm moves
> > that might be a bit much (or at least needs a discussion first).
> 
> Hmm, yes, I think we should have a plan for these.
> 
> tilcdc: small, old driver, and I don't see much changes for it. The HW is
> very different from the ones supported by omapdrm and tidss (the two of
> which have many commonalities). I think drm-misc is fine for tilcdc.
> 
> omapdrm: big changes going on for now, but after the rewrite to get rid of
> omapdrm specific drivers is done, I expect the patch count to drop, as the
> HW is "legacy".
> 
> tidss: the "new" driver, which should get most attention in the future (after omapdrm rewrite).
> 
> All in all, sometimes there have been very few patches for many months, and
> then sometimes there's a big series.

Yeah occasionally big series is totally fine for -misc. We're pulling in
pretty big amounts of refactoring all the time, so really doesn't make a
difference.

> I haven't seen a need to have a maintained branch for omapdrm, as multiple
> people working on conflicting items has been very rare (there aren't that
> many people working on omapdrm). So I've picked patches to my private
> branch, which I have rebased as needed. And then I've either pushed via
> drm-misc if there's just a few patches, or sent a pull request if there's a
> lot.
> 
> Is such a mixed model ok?
> 
> I'm not sure how much is too much for drm-misc, but probably omapdrm and
> tidss combined (if pushing everything always via drm-misc) is a bit too
> much. So perhaps a maintained TI tree would be an option too, and pushing
> everything for omapdrm and tidss via that tree.

tbh I dunno either when too much is too much for -misc. I think tilcdc and
omapdrm should both easily fit (maybe after the big rewrite). If the shiny
new one here becomes too big we can always reconsider.

I think the really big drivers like amdgpu or intel don't belong in -misc,
that one is clear. In between I guess we'll see.

> I'm fine with all options, so I think we can go with whatever is most
> acceptable from DRM maintainer point of view.

Whatever floats the boat, with a preference for not having tiny trees
(simply because those pull request tend to get lost in the noise).
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: devicetree@vger.kernel.org, yamonkar@cadence.com,
	praneeth@ti.com, subhajit_paul@ti.com,
	dri-devel@lists.freedesktop.org, peter.ujfalusi@ti.com,
	robh+dt@kernel.org, Jyri Sarha <jsarha@ti.com>,
	sjakhade@cadence.com, sam@ravnborg.org,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v3 5/5] MAINTAINERS: add entry for tidss
Date: Fri, 13 Dec 2019 21:15:46 +0100	[thread overview]
Message-ID: <20191213201546.GN624164@phenom.ffwll.local> (raw)
In-Reply-To: <0acedebf-25d9-6ae2-1307-8f764af449af@ti.com>

On Fri, Dec 13, 2019 at 01:17:59PM +0200, Tomi Valkeinen wrote:
> Hi Daniel,
> 
> On 13/12/2019 12:30, Daniel Vetter wrote:
> 
> > > +DRM DRIVERS FOR TI KEYSTONE
> > > +M:	Jyri Sarha <jsarha@ti.com>
> > > +M:	Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > +L:	dri-devel@lists.freedesktop.org
> > > +S:	Maintained
> > > +F:	drivers/gpu/drm/tidss/
> > > +F:	Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml
> > > +F:	Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> > > +F:	Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
> > > +T:	git git://anongit.freedesktop.org/drm/drm-misc
> > 
> > Is the plan to also move other TI drivers over (like tilcdc) or just an
> > experiment to see what happens? Asking since if eventually omapdrm moves
> > that might be a bit much (or at least needs a discussion first).
> 
> Hmm, yes, I think we should have a plan for these.
> 
> tilcdc: small, old driver, and I don't see much changes for it. The HW is
> very different from the ones supported by omapdrm and tidss (the two of
> which have many commonalities). I think drm-misc is fine for tilcdc.
> 
> omapdrm: big changes going on for now, but after the rewrite to get rid of
> omapdrm specific drivers is done, I expect the patch count to drop, as the
> HW is "legacy".
> 
> tidss: the "new" driver, which should get most attention in the future (after omapdrm rewrite).
> 
> All in all, sometimes there have been very few patches for many months, and
> then sometimes there's a big series.

Yeah occasionally big series is totally fine for -misc. We're pulling in
pretty big amounts of refactoring all the time, so really doesn't make a
difference.

> I haven't seen a need to have a maintained branch for omapdrm, as multiple
> people working on conflicting items has been very rare (there aren't that
> many people working on omapdrm). So I've picked patches to my private
> branch, which I have rebased as needed. And then I've either pushed via
> drm-misc if there's just a few patches, or sent a pull request if there's a
> lot.
> 
> Is such a mixed model ok?
> 
> I'm not sure how much is too much for drm-misc, but probably omapdrm and
> tidss combined (if pushing everything always via drm-misc) is a bit too
> much. So perhaps a maintained TI tree would be an option too, and pushing
> everything for omapdrm and tidss via that tree.

tbh I dunno either when too much is too much for -misc. I think tilcdc and
omapdrm should both easily fit (maybe after the big rewrite). If the shiny
new one here becomes too big we can always reconsider.

I think the really big drivers like amdgpu or intel don't belong in -misc,
that one is clear. In between I guess we'll see.

> I'm fine with all options, so I think we can go with whatever is most
> acceptable from DRM maintainer point of view.

Whatever floats the boat, with a preference for not having tiny trees
(simply because those pull request tend to get lost in the noise).
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-12-13 20:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 13:51 [PATCH v3 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2019-12-12 13:51 ` Jyri Sarha
2019-12-12 13:51 ` [PATCH v3 1/5] dt-bindings: display: ti,k2g-dss: Add dt-schema yaml binding Jyri Sarha
2019-12-12 13:51   ` [PATCH v3 1/5] dt-bindings: display: ti, k2g-dss: " Jyri Sarha
2019-12-13 10:42   ` Maxime Ripard
2019-12-13 10:42     ` Maxime Ripard
2019-12-12 13:51 ` [PATCH v3 2/5] dt-bindings: display: ti,am65x-dss: " Jyri Sarha
2019-12-12 13:51   ` [PATCH v3 2/5] dt-bindings: display: ti, am65x-dss: " Jyri Sarha
2019-12-12 13:51 ` [PATCH v3 3/5] dt-bindings: display: ti,j721e-dss: " Jyri Sarha
2019-12-12 13:51   ` [PATCH v3 3/5] dt-bindings: display: ti, j721e-dss: " Jyri Sarha
2019-12-12 13:52 ` [PATCH v3 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2019-12-12 13:52   ` Jyri Sarha
2019-12-12 13:52 ` [PATCH v3 5/5] MAINTAINERS: add entry for tidss Jyri Sarha
2019-12-12 13:52   ` Jyri Sarha
2019-12-13 10:30   ` Daniel Vetter
2019-12-13 10:30     ` Daniel Vetter
2019-12-13 11:17     ` Tomi Valkeinen
2019-12-13 11:17       ` Tomi Valkeinen
2019-12-13 20:15       ` Daniel Vetter [this message]
2019-12-13 20:15         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191213201546.GN624164@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=praneeth@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sjakhade@cadence.com \
    --cc=subhajit_paul@ti.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=yamonkar@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.