All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stefan Mavrodiev <stefan@olimex.com>
Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	"open list:DRM DRIVERS FOR ALLWINNER A10" 
	<dri-devel@lists.freedesktop.org>,
	"moderated list:ARM/Allwinner sunXi SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup
Date: Tue, 17 Dec 2019 08:26:25 +0100	[thread overview]
Message-ID: <20191217072625.rqzl2udojrxcxqd4@pengutronix.de> (raw)
In-Reply-To: <20191216144348.7540-1-stefan@olimex.com>

On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote:
> It's possible hdmi->connector and hdmi->encoder divices to be NULL.

The wording is broken and s/divices/devices/. I'd write:

	It's possible that the parent devices of the connector and/or
	encoder are NULL. This makes drm_connector_cleanup and
	drm_encoder_cleanup respectively trigger a NULL pointer
	exeception:

		<...log here...>

	This is reproducible by

		<...receipt here...>

	So add a check for NULL before calling these functions.

Of course this doesn't address the reservations by Maxime.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stefan Mavrodiev <stefan@olimex.com>
Cc: David Airlie <airlied@linux.ie>,
	linux-sunxi@googlegroups.com,
	open list <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVERS FOR ALLWINNER A10"
	<dri-devel@lists.freedesktop.org>, Chen-Yu Tsai <wens@csie.org>,
	Maxime Ripard <mripard@kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	"moderated list:ARM/Allwinner sunXi SoC support"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup
Date: Tue, 17 Dec 2019 08:26:25 +0100	[thread overview]
Message-ID: <20191217072625.rqzl2udojrxcxqd4@pengutronix.de> (raw)
In-Reply-To: <20191216144348.7540-1-stefan@olimex.com>

On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote:
> It's possible hdmi->connector and hdmi->encoder divices to be NULL.

The wording is broken and s/divices/devices/. I'd write:

	It's possible that the parent devices of the connector and/or
	encoder are NULL. This makes drm_connector_cleanup and
	drm_encoder_cleanup respectively trigger a NULL pointer
	exeception:

		<...log here...>

	This is reproducible by

		<...receipt here...>

	So add a check for NULL before calling these functions.

Of course this doesn't address the reservations by Maxime.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stefan Mavrodiev <stefan@olimex.com>
Cc: David Airlie <airlied@linux.ie>,
	linux-sunxi@googlegroups.com,
	open list <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVERS FOR ALLWINNER A10"
	<dri-devel@lists.freedesktop.org>, Chen-Yu Tsai <wens@csie.org>,
	"moderated list:ARM/Allwinner sunXi SoC support"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup
Date: Tue, 17 Dec 2019 08:26:25 +0100	[thread overview]
Message-ID: <20191217072625.rqzl2udojrxcxqd4@pengutronix.de> (raw)
In-Reply-To: <20191216144348.7540-1-stefan@olimex.com>

On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote:
> It's possible hdmi->connector and hdmi->encoder divices to be NULL.

The wording is broken and s/divices/devices/. I'd write:

	It's possible that the parent devices of the connector and/or
	encoder are NULL. This makes drm_connector_cleanup and
	drm_encoder_cleanup respectively trigger a NULL pointer
	exeception:

		<...log here...>

	This is reproducible by

		<...receipt here...>

	So add a check for NULL before calling these functions.

Of course this doesn't address the reservations by Maxime.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-12-17  7:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 14:43 [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup Stefan Mavrodiev
2019-12-16 14:43 ` Stefan Mavrodiev
2019-12-16 14:43 ` Stefan Mavrodiev
2019-12-16 16:12 ` Maxime Ripard
2019-12-16 16:12   ` Maxime Ripard
2019-12-16 16:12   ` Maxime Ripard
2019-12-17  6:45   ` Stefan Mavrodiev
2019-12-17  6:45     ` Stefan Mavrodiev
2019-12-17  6:45     ` Stefan Mavrodiev
2019-12-17 11:46     ` Maxime Ripard
2019-12-17 11:46       ` Maxime Ripard
2019-12-17 11:46       ` Maxime Ripard
2019-12-17 11:49       ` Maxime Ripard
2019-12-17 11:49         ` Maxime Ripard
2019-12-17 11:49         ` Maxime Ripard
2019-12-17 11:54         ` Stefan Mavrodiev
2019-12-17 11:54           ` Stefan Mavrodiev
2019-12-17 11:54           ` Stefan Mavrodiev
2019-12-17 11:57           ` Maxime Ripard
2019-12-17 11:57             ` Maxime Ripard
2019-12-17 11:57             ` Maxime Ripard
2019-12-17  7:26 ` Uwe Kleine-König [this message]
2019-12-17  7:26   ` Uwe Kleine-König
2019-12-17  7:26   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217072625.rqzl2udojrxcxqd4@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=stefan@olimex.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.