All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: sun4i-ss: make unexported sun4i_ss_pm_ops static
@ 2019-12-17 11:30 ` Ben Dooks (Codethink)
  0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks (Codethink) @ 2019-12-17 11:30 UTC (permalink / raw)
  To: ben.dooks
  Cc: Corentin Labbe, Herbert Xu, David S. Miller, Maxime Ripard,
	Chen-Yu Tsai, Allison Randal, Thomas Gleixner, YueHaibing,
	Mauro Carvalho Chehab, linux-crypto, linux-arm-kernel

The sun4i_ss_pm_ops is not referenced outside the driver
except via a pointer, so make it static to avoid the following
warning:

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c:276:25: warning: symbol 'sun4i_ss_pm_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Allison Randal <allison@lohutok.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: YueHaibing <yuehaibing@huawei.com>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: linux-crypto@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
index 814cd12149a9..52c8b7f680a7 100644
--- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
+++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
@@ -273,7 +273,7 @@ static int sun4i_ss_pm_resume(struct device *dev)
 	return err;
 }
 
-const struct dev_pm_ops sun4i_ss_pm_ops = {
+static const struct dev_pm_ops sun4i_ss_pm_ops = {
 	SET_RUNTIME_PM_OPS(sun4i_ss_pm_suspend, sun4i_ss_pm_resume, NULL)
 };
 
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] crypto: sun4i-ss: make unexported sun4i_ss_pm_ops static
@ 2019-12-17 11:30 ` Ben Dooks (Codethink)
  0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks (Codethink) @ 2019-12-17 11:30 UTC (permalink / raw)
  To: ben.dooks
  Cc: linux-arm-kernel, Herbert Xu, YueHaibing, Maxime Ripard,
	Chen-Yu Tsai, Corentin Labbe, linux-crypto,
	Mauro Carvalho Chehab, Thomas Gleixner, David S. Miller,
	Allison Randal

The sun4i_ss_pm_ops is not referenced outside the driver
except via a pointer, so make it static to avoid the following
warning:

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c:276:25: warning: symbol 'sun4i_ss_pm_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Allison Randal <allison@lohutok.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: YueHaibing <yuehaibing@huawei.com>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: linux-crypto@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
index 814cd12149a9..52c8b7f680a7 100644
--- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
+++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
@@ -273,7 +273,7 @@ static int sun4i_ss_pm_resume(struct device *dev)
 	return err;
 }
 
-const struct dev_pm_ops sun4i_ss_pm_ops = {
+static const struct dev_pm_ops sun4i_ss_pm_ops = {
 	SET_RUNTIME_PM_OPS(sun4i_ss_pm_suspend, sun4i_ss_pm_resume, NULL)
 };
 
-- 
2.24.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: sun4i-ss: make unexported sun4i_ss_pm_ops static
  2019-12-17 11:30 ` Ben Dooks (Codethink)
@ 2019-12-27 10:37   ` Herbert Xu
  -1 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2019-12-27 10:37 UTC (permalink / raw)
  To: Ben Dooks (Codethink)
  Cc: Corentin Labbe, David S. Miller, Maxime Ripard, Chen-Yu Tsai,
	Allison Randal, Thomas Gleixner, YueHaibing,
	Mauro Carvalho Chehab, linux-crypto, linux-arm-kernel

On Tue, Dec 17, 2019 at 11:30:24AM +0000, Ben Dooks (Codethink) wrote:
> The sun4i_ss_pm_ops is not referenced outside the driver
> except via a pointer, so make it static to avoid the following
> warning:
> 
> drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c:276:25: warning: symbol 'sun4i_ss_pm_ops' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Allison Randal <allison@lohutok.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: YueHaibing <yuehaibing@huawei.com>
> Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: sun4i-ss: make unexported sun4i_ss_pm_ops static
@ 2019-12-27 10:37   ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2019-12-27 10:37 UTC (permalink / raw)
  To: Ben Dooks (Codethink)
  Cc: linux-arm-kernel, YueHaibing, Maxime Ripard, Chen-Yu Tsai,
	Corentin Labbe, linux-crypto, Mauro Carvalho Chehab,
	Thomas Gleixner, David S. Miller, Allison Randal

On Tue, Dec 17, 2019 at 11:30:24AM +0000, Ben Dooks (Codethink) wrote:
> The sun4i_ss_pm_ops is not referenced outside the driver
> except via a pointer, so make it static to avoid the following
> warning:
> 
> drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c:276:25: warning: symbol 'sun4i_ss_pm_ops' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Allison Randal <allison@lohutok.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: YueHaibing <yuehaibing@huawei.com>
> Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-27 10:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 11:30 [PATCH] crypto: sun4i-ss: make unexported sun4i_ss_pm_ops static Ben Dooks (Codethink)
2019-12-17 11:30 ` Ben Dooks (Codethink)
2019-12-27 10:37 ` Herbert Xu
2019-12-27 10:37   ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.