All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath11k: set TxBf parameters after vdev start
@ 2019-12-17 16:49 ` John Crispin
  0 siblings, 0 replies; 4+ messages in thread
From: John Crispin @ 2019-12-17 16:49 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, ath11k, Bhagavathi Perumal S, John Crispin

From: Bhagavathi Perumal S <bperumal@codeaurora.org>

The channel info parameters are required by the firmware to process TxBf
parameters. Currently TxBf is passed prior to the channel info. This patch
moves TxBf setup after the channel setup.

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/mac.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 9d0fed4034dd..a8ccb00d6072 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4216,12 +4216,6 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw,
 			    arvif->vdev_id, ret);
 	}
 
-	ret = ath11k_mac_set_txbf_conf(arvif);
-	if (ret) {
-		ath11k_warn(ar->ab, "failed to set txbf conf for vdev %d: %d\n",
-			    arvif->vdev_id, ret);
-	}
-
 	ath11k_dp_vdev_tx_attach(ar, arvif);
 
 	mutex_unlock(&ar->conf_mutex);
@@ -4573,6 +4567,11 @@ ath11k_mac_vdev_start_restart(struct ath11k_vif *arvif,
 			   arg.channel.freq, arg.vdev_id);
 	}
 
+	ret = ath11k_mac_set_txbf_conf(arvif);
+	if (ret)
+		ath11k_warn(ab, "failed to set txbf conf for vdev %d: %d\n",
+			    arvif->vdev_id, ret);
+
 	return 0;
 }
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ath11k: set TxBf parameters after vdev start
@ 2019-12-17 16:49 ` John Crispin
  0 siblings, 0 replies; 4+ messages in thread
From: John Crispin @ 2019-12-17 16:49 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, ath11k, Bhagavathi Perumal S, John Crispin

From: Bhagavathi Perumal S <bperumal@codeaurora.org>

The channel info parameters are required by the firmware to process TxBf
parameters. Currently TxBf is passed prior to the channel info. This patch
moves TxBf setup after the channel setup.

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/mac.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 9d0fed4034dd..a8ccb00d6072 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4216,12 +4216,6 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw,
 			    arvif->vdev_id, ret);
 	}
 
-	ret = ath11k_mac_set_txbf_conf(arvif);
-	if (ret) {
-		ath11k_warn(ar->ab, "failed to set txbf conf for vdev %d: %d\n",
-			    arvif->vdev_id, ret);
-	}
-
 	ath11k_dp_vdev_tx_attach(ar, arvif);
 
 	mutex_unlock(&ar->conf_mutex);
@@ -4573,6 +4567,11 @@ ath11k_mac_vdev_start_restart(struct ath11k_vif *arvif,
 			   arg.channel.freq, arg.vdev_id);
 	}
 
+	ret = ath11k_mac_set_txbf_conf(arvif);
+	if (ret)
+		ath11k_warn(ab, "failed to set txbf conf for vdev %d: %d\n",
+			    arvif->vdev_id, ret);
+
 	return 0;
 }
 
-- 
2.20.1


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath11k: set TxBf parameters after vdev start
  2019-12-17 16:49 ` John Crispin
  (?)
@ 2020-01-26 10:40 ` Kalle Valo
  -1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-01-26 10:40 UTC (permalink / raw)
  To: John Crispin; +Cc: linux-wireless, ath11k, Bhagavathi Perumal S, John Crispin

John Crispin <john@phrozen.org> wrote:

> The channel info parameters are required by the firmware to process TxBf
> parameters. Currently TxBf is passed prior to the channel info. This patch
> moves TxBf setup after the channel setup.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

5815719dd271 ath11k: set TxBf parameters after vdev start

-- 
https://patchwork.kernel.org/patch/11298249/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath11k: set TxBf parameters after vdev start
  2019-12-17 16:49 ` John Crispin
  (?)
  (?)
@ 2020-01-26 10:40 ` Kalle Valo
  -1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-01-26 10:40 UTC (permalink / raw)
  To: John Crispin; +Cc: linux-wireless, ath11k, Bhagavathi Perumal S

John Crispin <john@phrozen.org> wrote:

> The channel info parameters are required by the firmware to process TxBf
> parameters. Currently TxBf is passed prior to the channel info. This patch
> moves TxBf setup after the channel setup.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

5815719dd271 ath11k: set TxBf parameters after vdev start

-- 
https://patchwork.kernel.org/patch/11298249/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-26 10:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 16:49 [PATCH] ath11k: set TxBf parameters after vdev start John Crispin
2019-12-17 16:49 ` John Crispin
2020-01-26 10:40 ` Kalle Valo
2020-01-26 10:40 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.