* [PATCH linux dev-5.4] ARM: dts: nuvoton: Update EVB for new PECI layout
@ 2019-12-18 4:22 Joel Stanley
2019-12-18 8:13 ` Jae Hyun Yoo
0 siblings, 1 reply; 2+ messages in thread
From: Joel Stanley @ 2019-12-18 4:22 UTC (permalink / raw)
To: Avi Fishman, Tomer Maimon, Jae Hyun Yoo; +Cc: openbmc
The PECI device tree layout changed, breaking the EVB.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 25 ++++++++++++-----------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
index de9c668c6e9a..e02c04910ef0 100644
--- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
@@ -492,18 +492,6 @@
};
};
- peci: peci-bus@100000 {
- cmd-timeout-ms = <1000>;
- pull-down = <0>;
- host-neg-bit-rate = <15>;
- status = "okay";
- intel-peci-dimmtemp@30 {
- compatible = "intel,peci-client";
- reg = <0x30>;
- status = "okay";
- };
- };
-
spi0: spi@200000 {
cs-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
status = "okay";
@@ -610,3 +598,16 @@
idle-states = <2>; /* Serial port mode 3 (takeover) */
};
};
+
+&peci0 {
+ cmd-timeout-ms = <1000>;
+ pull-down = <0>;
+ host-neg-bit-rate = <15>;
+ status = "okay";
+
+ intel-peci-dimmtemp@30 {
+ compatible = "intel,peci-client";
+ reg = <0x30>;
+ status = "okay";
+ };
+};
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux dev-5.4] ARM: dts: nuvoton: Update EVB for new PECI layout
2019-12-18 4:22 [PATCH linux dev-5.4] ARM: dts: nuvoton: Update EVB for new PECI layout Joel Stanley
@ 2019-12-18 8:13 ` Jae Hyun Yoo
0 siblings, 0 replies; 2+ messages in thread
From: Jae Hyun Yoo @ 2019-12-18 8:13 UTC (permalink / raw)
To: Joel Stanley, Avi Fishman, Tomer Maimon; +Cc: openbmc
On 12/17/2019 8:22 PM, Joel Stanley wrote:
> The PECI device tree layout changed, breaking the EVB.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 25 ++++++++++++-----------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> index de9c668c6e9a..e02c04910ef0 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> @@ -492,18 +492,6 @@
> };
> };
>
> - peci: peci-bus@100000 {
> - cmd-timeout-ms = <1000>;
> - pull-down = <0>;
> - host-neg-bit-rate = <15>;
> - status = "okay";
> - intel-peci-dimmtemp@30 {
> - compatible = "intel,peci-client";
> - reg = <0x30>;
> - status = "okay";
> - };
> - };
> -
> spi0: spi@200000 {
> cs-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
> status = "okay";
> @@ -610,3 +598,16 @@
> idle-states = <2>; /* Serial port mode 3 (takeover) */
> };
> };
> +
> +&peci0 {
> + cmd-timeout-ms = <1000>;
> + pull-down = <0>;
> + host-neg-bit-rate = <15>;
> + status = "okay";
> +
> + intel-peci-dimmtemp@30 {
> + compatible = "intel,peci-client";
> + reg = <0x30>;
> + status = "okay";
> + };
> +};
>
Yes, I fixed peci nodes in 'nuvoton-common-npcm7xx.dtsi' using the new
PECI patch set because previous node setting was incorrect. PECI node
shape should be like:
bus: {
controller: {
client: {
};
};
};
so this fix is needed for nuvoton EVB.
Acked-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-18 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 4:22 [PATCH linux dev-5.4] ARM: dts: nuvoton: Update EVB for new PECI layout Joel Stanley
2019-12-18 8:13 ` Jae Hyun Yoo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.