[PATCH v3] dbus: NULL check proxy on method calls

[PATCH v3] dbus: NULL check proxy on method calls

[Brian Gix]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

l_dbus_proxy_method_call() seg-faults when called with a NULL proxy
pointer.  This NULL check follows the pattern of NULL checks in the
other LIB_EXPORT methods in module.
---
 ell/dbus-client.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ell/dbus-client.c b/ell/dbus-client.c
index 541f3e8..2d8120e 100644
--- a/ell/dbus-client.c
+++ b/ell/dbus-client.c
@@ -301,6 +301,9 @@ LIB_EXPORT uint32_t l_dbus_proxy_method_call(struct l_dbus_proxy *proxy,
 {
 	struct method_call_request *req;
 
+	if (unlikely(!proxy))
+		return 0;
+
 	req = l_new(struct method_call_request, 1);
 	req->proxy = proxy;
 	req->setup = setup;
-- 
2.21.0

Re: [PATCH v3] dbus: NULL check proxy on method calls

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi Brian,

On 12/18/19 9:12 AM, Brian Gix wrote:
> l_dbus_proxy_method_call() seg-faults when called with a NULL proxy
> pointer.  This NULL check follows the pattern of NULL checks in the
> other LIB_EXPORT methods in module.
> ---
>   ell/dbus-client.c | 3 +++
>   1 file changed, 3 insertions(+)

Applied, thanks.

Regards,
-Denis