* [PATCH bpf-next] libbpf: fix another __u64 printf warning
@ 2019-12-19 5:21 Andrii Nakryiko
2019-12-19 16:02 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Andrii Nakryiko @ 2019-12-19 5:21 UTC (permalink / raw)
To: bpf, netdev, ast, daniel; +Cc: andrii.nakryiko, kernel-team, Andrii Nakryiko
Fix yet another printf warning for %llu specifier on ppc64le. This time size_t
casting won't work, so cast to verbose `unsigned long long`.
Fixes: 166750bc1dd2 ("libbpf: Support libbpf-provided extern variables")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
---
tools/lib/bpf/libbpf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 6340b81b555b..e5a6b07060fb 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -1129,12 +1129,12 @@ static int set_ext_value_num(struct extern_desc *ext, void *ext_val,
{
if (ext->type != EXT_INT && ext->type != EXT_CHAR) {
pr_warn("extern %s=%llu should be integer\n",
- ext->name, value);
+ ext->name, (unsigned long long)value);
return -EINVAL;
}
if (!is_ext_value_in_range(ext, value)) {
pr_warn("extern %s=%llu value doesn't fit in %d bytes\n",
- ext->name, value, ext->sz);
+ ext->name, (unsigned long long)value, ext->sz);
return -ERANGE;
}
switch (ext->sz) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] libbpf: fix another __u64 printf warning
2019-12-19 5:21 [PATCH bpf-next] libbpf: fix another __u64 printf warning Andrii Nakryiko
@ 2019-12-19 16:02 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2019-12-19 16:02 UTC (permalink / raw)
To: Andrii Nakryiko; +Cc: bpf, netdev, ast, andrii.nakryiko, kernel-team
On Wed, Dec 18, 2019 at 09:21:03PM -0800, Andrii Nakryiko wrote:
> Fix yet another printf warning for %llu specifier on ppc64le. This time size_t
> casting won't work, so cast to verbose `unsigned long long`.
>
> Fixes: 166750bc1dd2 ("libbpf: Support libbpf-provided extern variables")
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 5:21 [PATCH bpf-next] libbpf: fix another __u64 printf warning Andrii Nakryiko
2019-12-19 16:02 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.